From: Paul Cercueil <paul@crapouillou.net>
To: Zhou Yanjie <zhouyanjie@zoho.com>
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, robh+dt@kernel.org,
paul.burton@mips.com, paulburton@kernel.org, jhogan@kernel.org,
mripard@kernel.org, shawnguo@kernel.org, mark.rutland@arm.com,
syq@debian.org, ralf@linux-mips.org, heiko@sntech.de,
icenowy@aosc.io, laurent.pinchart@ideasonboard.com,
krzk@kernel.org, geert+renesas@glider.be,
prasannatsmkumar@gmail.com, sernia.zhou@foxmail.com,
zhenwenjin@gmail.com, 772753199@qq.com
Subject: Re: Add initial support for Ingenic X1000 SoC and Y&A CU Neo board v6.
Date: Fri, 29 Nov 2019 12:15:20 +0100 [thread overview]
Message-ID: <1575026120.3.1@crapouillou.net> (raw)
In-Reply-To: <1575017333-29020-1-git-send-email-zhouyanjie@zoho.com>
Hi Zhou,
This series need some reorder.
You introduce the defconfig in patch [03/12], then modify it in
[06/12], [08/12] and [10/12]. This just makes the patchset hard to
review and less likely to be merged.
Simply:
- Add missing X1000 nodes (pdma, mmc, rtc) in one patch,
- then add the CU Neo devicetree & config with PDMA, MMC and RTC
enabled.
And where are patches [11/12] and [12/12]? I didn't receive them.
Cheers,
-Paul
Le ven., nov. 29, 2019 at 16:48, Zhou Yanjie <zhouyanjie@zoho.com> a
écrit :
> v5->v6:
> 1.Use "stdout-path = "serial2:115200n8"" instead "stdout-path =
> &uart2" in DT.
> 2.Remove "console=ttyS2,115200n8" and "CONFIG_CMDLINE_OVERRIDE=y"
> from defconfg.
> 3.Add watchdog timer DT node, and update defconfig for watchdog timer.
>
>
prev parent reply other threads:[~2019-11-29 11:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-29 8:48 Add initial support for Ingenic X1000 SoC and Y&A CU Neo board v6 Zhou Yanjie
2019-11-29 8:48 ` [PATCH v6 01/12] MIPS: Ingenic: Initial X1000 support Zhou Yanjie
2019-11-29 8:48 ` [PATCH v6 02/12] dt-bindings: Document yna vendor-prefix Zhou Yanjie
2019-11-29 8:48 ` [PATCH v6 03/12] dt-bindings: MIPS: Add Ingenic XBurst based boards Zhou Yanjie
2019-11-29 8:48 ` [PATCH v6 04/12] MIPS: Ingenic: Initial YSH & ATIL CU Neo board support Zhou Yanjie
2019-11-29 8:48 ` [PATCH v6 05/12] MIPS: X1000: Add pdma controller DT node Zhou Yanjie
2019-11-29 8:48 ` [PATCH v6 06/12] MIPS: CU1000: Update defconfig for pdma controller Zhou Yanjie
2019-11-29 8:48 ` [PATCH v6 07/12] MIPS: X1000: Add msc controller DT node Zhou Yanjie
2019-11-29 8:48 ` [PATCH v6 08/12] MIPS: CU1000: Update defconfig for msc controller Zhou Yanjie
2019-11-29 8:48 ` [PATCH v6 09/12] MIPS: X1000: Add rtc DT node Zhou Yanjie
2019-11-29 8:48 ` [PATCH v6 10/12] MIPS: CU1000: Update defconfig for rtc Zhou Yanjie
2019-11-29 11:15 ` Paul Cercueil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1575026120.3.1@crapouillou.net \
--to=paul@crapouillou.net \
--cc=772753199@qq.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=heiko@sntech.de \
--cc=icenowy@aosc.io \
--cc=jhogan@kernel.org \
--cc=krzk@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mripard@kernel.org \
--cc=paul.burton@mips.com \
--cc=paulburton@kernel.org \
--cc=prasannatsmkumar@gmail.com \
--cc=ralf@linux-mips.org \
--cc=robh+dt@kernel.org \
--cc=sernia.zhou@foxmail.com \
--cc=shawnguo@kernel.org \
--cc=syq@debian.org \
--cc=zhenwenjin@gmail.com \
--cc=zhouyanjie@zoho.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).