From: Stephen Boyd <sboyd@kernel.org>
To: Michael Turquette <mturquette@baylibre.com>,
Paul Cercueil <paul@crapouillou.net>
Cc: linux-mips@vger.kernel.org, list@opendingux.net,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
Paul Cercueil <paul@crapouillou.net>,
Artur Rojek <contact@artur-rojek.eu>
Subject: Re: [PATCH] clk: ingenic: Fix bugs with divided dividers
Date: Tue, 02 Nov 2021 14:27:51 -0700 [thread overview]
Message-ID: <163588847120.2993099.5234069019391601753@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20211001172033.122329-1-paul@crapouillou.net>
Quoting Paul Cercueil (2021-10-01 10:20:33)
> Two fixes in one:
>
> - In the "impose hardware constraints" block, the "logical" divider
> value (aka. not translated to the hardware) was clamped to fit in the
> register area, but this totally ignored the fact that the divider
> value can itself have a fixed divider.
>
> - The code that made sure that the divider value returned by the
> function was a multiple of its own fixed divider could result in a
> wrong value being calculated, because it was rounded down instead of
> rounded up.
>
> Fixes: 4afe2d1a6ed5 ("clk: ingenic: Allow divider value to be divided")
> Co-developed-by: Artur Rojek <contact@artur-rojek.eu>
> Signed-off-by: Artur Rojek <contact@artur-rojek.eu>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
Applied to clk-next
prev parent reply other threads:[~2021-11-02 21:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 17:20 [PATCH] clk: ingenic: Fix bugs with divided dividers Paul Cercueil
2021-11-02 21:27 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163588847120.2993099.5234069019391601753@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=contact@artur-rojek.eu \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=list@opendingux.net \
--cc=mturquette@baylibre.com \
--cc=paul@crapouillou.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).