From: Jiaxun Yang <jiaxun.yang@flygoat.com>
To: Guenter Roeck <linux@roeck-us.net>, Paul Burton <paulburton@kernel.org>
Cc: Ralf Baechle <ralf@linux-mips.org>,
James Hogan <jhogan@kernel.org>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: Fix boot on Fuloong2 systems
Date: Thu, 28 Nov 2019 08:42:28 +0800 [thread overview]
Message-ID: <1F64121F-0A46-41C2-ABE0-917A1A968A3E@flygoat.com> (raw)
In-Reply-To: <20191127152612.21945-1-linux@roeck-us.net>
于 2019年11月27日 GMT+08:00 下午11:26:12, Guenter Roeck <linux@roeck-us.net> 写到:
>Commit 268a2d60013049 ("MIPS: Loongson64: Rename CPU TYPES") changed
>Kconfig symbols as follows:
> CPU_LOONGSON2 to CPU_LOONGSON2EF
> CPU_LOONGSON3 to CPU_LOONGSON64
> SYS_HAS_CPU_LOONGSON3 to SYS_HAS_CPU_LOONGSON64
>
>It did not touch SYS_HAS_CPU_LOONGSON2E or SYS_HAS_CPU_LOONGSON2F.
>However, the patch changed a conditional from
>
> #if defined(CONFIG_SYS_HAS_CPU_LOONGSON2E) || \
> defined(CONFIG_SYS_HAS_CPU_LOONGSON2F)
>
>to
>
> #if defined(CONFIG_SYS_HAS_CPU_LOONGSON2EF)
>
>SYS_HAS_CPU_LOONGSON2EF does not exist, resulting in boot failures
>with the qemu fulong2e emulation. Revert to the original code.
>
>Fixes: 268a2d60013049 ("MIPS: Loongson64: Rename CPU TYPES")
>Cc: Jiaxun Yang <jiaxun.yang@flygoat.com>
>Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
Apologies for the mistake. I ran some tests before sending the
patch but probably get this missed due to
difference between my local tree and next tree.
Thanks for catching that!
>---
--
Jiaxun Yang
prev parent reply other threads:[~2019-11-28 0:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 15:26 [PATCH] MIPS: Fix boot on Fuloong2 systems Guenter Roeck
2019-11-27 17:25 ` Philippe Mathieu-Daudé
2019-11-27 18:28 ` Paul Burton
2019-11-28 0:42 ` Jiaxun Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1F64121F-0A46-41C2-ABE0-917A1A968A3E@flygoat.com \
--to=jiaxun.yang@flygoat.com \
--cc=jhogan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=paulburton@kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).