From: Jussi Kivilinna <jussi.kivilinna@iki.fi> To: Nathan Chancellor <natechancellor@gmail.com> Cc: Ralf Baechle <ralf@linux-mips.org>, Paul Burton <paul.burton@mips.com>, James Hogan <jhogan@kernel.org>, Nick Desaulniers <ndesaulniers@google.com>, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, Vladimir Serbinenko <phcoder@gmail.com>, gcrypt-devel <gcrypt-devel@gnupg.org>, Herbert Xu <herbert@gondor.apana.org.au> Subject: Re: [PATCH 3/5] lib/mpi: Fix for building for MIPS32 with Clang Date: Mon, 12 Aug 2019 22:40:49 +0300 Message-ID: <1ba05172-500b-6b42-00ad-27fb33eff070@iki.fi> (raw) In-Reply-To: <20190812171448.GA10039@archlinux-threadripper> Hello, On 12.8.2019 20.14, Nathan Chancellor wrote: > On Mon, Aug 12, 2019 at 10:35:53AM +0300, Jussi Kivilinna wrote: >> Hello, >> >> On 12.8.2019 6.31, Nathan Chancellor wrote: >>> From: Vladimir Serbinenko <phcoder@gmail.com> >>> >>> clang doesn't recognise =l / =h assembly operand specifiers but apparently >>> handles C version well. >>> >>> lib/mpi/generic_mpih-mul1.c:37:24: error: invalid use of a cast in a >>> inline asm context requiring an l-value: remove the cast or build with >>> -fheinous-gnu-extensions >>> umul_ppmm(prod_high, prod_low, s1_ptr[j], s2_limb); >>> ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >>> lib/mpi/longlong.h:652:20: note: expanded from macro 'umul_ppmm' >>> : "=l" ((USItype)(w0)), \ >>> ~~~~~~~~~~^~~ >>> lib/mpi/generic_mpih-mul1.c:37:3: error: invalid output constraint '=h' >>> in asm >>> umul_ppmm(prod_high, prod_low, s1_ptr[j], s2_limb); >>> ^ >>> lib/mpi/longlong.h:653:7: note: expanded from macro 'umul_ppmm' >>> "=h" ((USItype)(w1)) \ >>> ^ >>> 2 errors generated. >>> >>> Fixes: 5ce3e312ec5c ("crypto: GnuPG based MPI lib - header files (part 2)") >>> Link: https://github.com/ClangBuiltLinux/linux/issues/605 >>> Link: https://github.com/gpg/libgcrypt/commit/1ecbd0bca31d462719a2a6590c1d03244e76ef89 >>> Signed-off-by: Vladimir Serbinenko <phcoder@gmail.com> >>> [jk: add changelog, rebase on libgcrypt repository, reformat changed >>> line so it does not go over 80 characters] >>> Signed-off-by: Jussi Kivilinna <jussi.kivilinna@iki.fi> >> >> This is my signed-off-by for libgcrypt project, not kernel. I do not think >> signed-offs can be passed from other projects in this way. >> >> -Jussi > > Hi Jussi, > > I am no signoff expert but if I am reading the developer certificate of > origin in the libgcrypt repo correctly [1], your signoff on this commit > falls under: > > (d) I understand and agree that this project and the contribution > are public and that a record of the contribution (including all > personal information I submit with it, including my sign-off) is > maintained indefinitely and may be redistributed consistent with > this project or the open source license(s) involved. There is nothing wrong with the commit in libgcrypt repo and/or my libgcrypt-DCO-sign-off. > > This file is maintained under the LGPL because it was taken straight > from the libgcrypr repo and per (b), I can submit this commit here > with everything intact. But you do not have my kernel-DCO-sign-off for this patch. I have not been involved with this kernel patch in anyway, have not integrated it to kernel, not testing it on kernel.. I do not own it. However, with this signed-off-by line you have involved me to kernel patch process in which for this patch I'm not interested. So to be clear, I retract my kernel-DCO-signed-off for this kernel patch: NOT-Signed-off-by: Jussi Kivilinna <jussi.kivilinna@iki.fi> Of course you can copy the original libgcrypt commit message to this patch, but I think it needs to be clearly quoted so that my libgcrypt-DCO-signed-off line wont be mixed with kernel-DOC-signed-off lines. > > However, I don't want to upset you in any way though so if you are not > comfortable with that, I suppose I can remove it as if Vladimir > submitted this fix to me directly (as I got permission for his signoff). > I need to resubmit this fix to an appropriate maintainer so let me know > what you think. That's quite complicated approach. Fast and easier process would be if you just own the patch yourself. Libgcrypt (and target file in libgcrypt) is LGPL v2.1+, so the license is compatible with kernel and you are good to go with just your own (kernel DCO) signed-off-by. -Jussi > > [1]: https://github.com/gpg/libgcrypt/blob/3bb858551cd5d84e43b800edfa2b07d1529718a9/doc/DCO > > Cheers, > Nathan >
next prev parent reply index Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-12 3:31 [PATCH 0/5] Clang build fixes for MIPS Nathan Chancellor 2019-08-12 3:31 ` [PATCH 1/5] MIPS: Don't use bc_false uninitialized in __mm_isBranchInstr Nathan Chancellor 2019-08-12 4:47 ` Paul Burton 2019-08-12 3:31 ` [PATCH 2/5] MIPS/ptrace: Update mips_get_syscall_arg's return type Nathan Chancellor 2019-08-12 4:47 ` Paul Burton 2019-08-12 3:31 ` [PATCH 3/5] lib/mpi: Fix for building for MIPS32 with Clang Nathan Chancellor 2019-08-12 5:23 ` Nathan Chancellor 2019-08-12 5:26 ` Nathan Chancellor 2019-08-12 12:28 ` Herbert Xu 2019-08-12 17:58 ` Paul Burton 2019-08-12 7:35 ` Jussi Kivilinna 2019-08-12 17:14 ` Nathan Chancellor 2019-08-12 19:40 ` Jussi Kivilinna [this message] 2019-08-12 19:45 ` Nathan Chancellor 2019-08-12 3:31 ` [PATCH 4/5] lib/mpi: Fix for building for MIPS64 " Nathan Chancellor 2019-08-12 5:25 ` Nathan Chancellor 2019-08-12 17:42 ` Nick Desaulniers 2019-08-12 17:45 ` Nathan Chancellor 2019-08-12 3:31 ` [PATCH 5/5] MIPS: tlbex: Explicitly cast _PAGE_NO_EXEC to a boolean Nathan Chancellor 2019-08-12 4:47 ` Paul Burton
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1ba05172-500b-6b42-00ad-27fb33eff070@iki.fi \ --to=jussi.kivilinna@iki.fi \ --cc=clang-built-linux@googlegroups.com \ --cc=gcrypt-devel@gnupg.org \ --cc=herbert@gondor.apana.org.au \ --cc=jhogan@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mips@vger.kernel.org \ --cc=natechancellor@gmail.com \ --cc=ndesaulniers@google.com \ --cc=paul.burton@mips.com \ --cc=phcoder@gmail.com \ --cc=ralf@linux-mips.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-MIPS Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-mips/0 linux-mips/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-mips linux-mips/ https://lore.kernel.org/linux-mips \ linux-mips@vger.kernel.org public-inbox-index linux-mips Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-mips AGPL code for this site: git clone https://public-inbox.org/public-inbox.git