From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 740DAC43217 for ; Wed, 16 Nov 2022 03:35:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231947AbiKPDe6 (ORCPT ); Tue, 15 Nov 2022 22:34:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229567AbiKPDez (ORCPT ); Tue, 15 Nov 2022 22:34:55 -0500 Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9C06623EA3; Tue, 15 Nov 2022 19:34:52 -0800 (PST) Received: from loongson.cn (unknown [10.180.13.64]) by gateway (Coremail) with SMTP id _____8AxDdlbWnRjV5YHAA--.22024S3; Wed, 16 Nov 2022 11:34:51 +0800 (CST) Received: from [10.180.13.64] (unknown [10.180.13.64]) by localhost.localdomain (Coremail) with SMTP id AQAAf8Dx9VZYWnRj314UAA--.35734S2; Wed, 16 Nov 2022 11:34:50 +0800 (CST) Subject: Re: [PATCH v2 1/2] gpio: loongson: add dts/acpi gpio support To: Thomas Bogendoerfer Cc: Bartosz Golaszewski , Linus Walleij , zhuyinbo@loongson.cn, Rob Herring , Krzysztof Kozlowski , WANG Xuerui , Jiaxun Yang , Juxin Gao , Bibo Mao , Yanteng Si , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, Arnaud Patard , Huacai Chen , lvjianmin , zhanghongchen , Liu Peibao References: <20221114095332.21079-1-zhuyinbo@loongson.cn> <8b24e3df-8c22-bd09-cfc1-b27e39a05c25@loongson.cn> <20221115102050.GA3167@alpha.franken.de> From: Yinbo Zhu Message-ID: <1bcc9fa5-c701-758d-c241-88c7b5d0216a@loongson.cn> Date: Wed, 16 Nov 2022 11:34:48 +0800 User-Agent: Mozilla/5.0 (X11; Linux loongarch64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20221115102050.GA3167@alpha.franken.de> Content-Type: text/plain; charset=gbk; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-CM-TRANSID: AQAAf8Dx9VZYWnRj314UAA--.35734S2 X-CM-SenderInfo: 52kx5xhqerqz5rrqw2lrqou0/ X-Coremail-Antispam: 1Uk129KBjvdXoWrZF43ZFy5ur4DZr4kArWDJwb_yoWfurb_u3 4I9FW8Jr48Zr1kJwn5try3Jasrtr98JF18ZrW0vr42qwsYya1SkryUCrySya1kWw1xKrn8 Zr4kWw1fA34fWjkaLaAFLSUrUUUUeb8apTn2vfkv8UJUUUU8wcxFpf9Il3svdxBIdaVrn0 xqx4xG64xvF2IEw4CE5I8CrVC2j2Jv73VFW2AGmfu7bjvjm3AaLaJ3UjIYCTnIWjp_UUUO 17CY07I20VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1Y6r17M28lY4IEw2 IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84AC jcxK6xIIjxv20xvEc7CjxVAFwI0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM2 8EF7xvwVC2z280aVCY1x0267AKxVW8Jr0_Cr1UM2kKe7AKxVWUAVWUtwAS0I0E0xvYzxvE 52x082IY62kv0487Mc804VCY07AIYIkI8VC2zVCFFI0UMc02F40EFcxC0VAKzVAqx4xG6I 80ewAv7VC0I7IYx2IY67AKxVWUtVWrXwAv7VC2z280aVAFwI0_Gr0_Cr1lOx8S6xCaFVCj c4AY6r1j6r4UM4x0Y48IcVAKI48JMxk0xIA0c2IEe2xFo4CEbIxvr21lc7CjxVAaw2AFwI 0_Jw0_GFyl42xK82IYc2Ij64vIr41l42xK82IY6x8ErcxFaVAv8VWrMxC20s026xCaFVCj c4AY6r1j6r4UMxCIbckI1I0E14v26r1q6r43MI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxV Cjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVW8ZVWrXwCIc40Y0x0EwIxGrwCI42IY 6xIIjxv20xvE14v26r4j6ryUMIIF0xvE2Ix0cI8IcVCY1x0267AKxVW8JVWxJwCI42IY6x AIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Gr0_Cr1lIxAIcVC2z280aVCY 1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7IU86yIUUUUUU== Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org ÔÚ 2022/11/15 ÏÂÎç6:20, Thomas Bogendoerfer дµÀ: > On Tue, Nov 15, 2022 at 05:53:26PM +0800, Yinbo Zhu wrote: >>>> +/* ============== Data structrues =============== */ >>>> + >>>> +/* gpio data */ >>>> +struct platform_gpio_data { >>>> + u32 gpio_conf; >>>> + u32 gpio_out; >>>> + u32 gpio_in; >>>> + u32 support_irq; >>>> + char *label; >>>> + int gpio_base; >>>> + int ngpio; >>>> +}; >>> >>> No idea why you would need to duplicate it like this either. And why >>> put it in arch/. >> because loongson platform include mips and loongarch, and the gpio device >> data was defined in arch/ in leagcy loongson gpio driver. so the >> latest loongson gpio drvier add platform_gpio_data in same dir. > > put the struct into a new file in include/linux/platform_data and > use that. > > Thomas. Hi Thomas, I think it is okay for me about your advice. I will move gpio platform data in include/linux/platform_data. Thanks Yinbo. >