linux-mips.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Matthew Fortune <Matthew.Fortune@imgtec.com>
Cc: Maciej Rozycki <Maciej.Rozycki@imgtec.com>,
	Ralf Baechle <ralf@linux-mips.org>,
	"linux-mips@linux-mips.org" <linux-mips@linux-mips.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	James Hogan <James.Hogan@imgtec.com>
Subject: Re: [PATCH] MIPS: VDSO: Always select -msoft-float
Date: Fri, 4 Nov 2016 11:33:54 -0700	[thread overview]
Message-ID: <20161104183354.GA16694@roeck-us.net> (raw)
In-Reply-To: <6D39441BF12EF246A7ABCE6654B0235380AB822B@HHMAIL01.hh.imgtec.org>

On Fri, Nov 04, 2016 at 04:55:05PM +0000, Matthew Fortune wrote:
> Maciej Rozycki <Maciej.Rozycki@imgtec.com> writes:
> > On Fri, 4 Nov 2016, Guenter Roeck wrote:
> > 
> > > > As above, unless absolutely critical to have floating point code
> > > > then the vDSO should just avoid all FP related issues and build
> > soft-float.
> ...
> > > Anyway, isn't the kernel supposed to not use floating point operations
> > > in the first place ? Is this different for vDSO ?
> > 
> >  This code is executed in the user mode so while floating-point code may
> > not be needed there, not at least right now, there's actually nothing
> > which should stop us from from adding some should such a need arise.
> 
> Indeed. For now though the switch to -msoft-float is the simplest solution
> isn't it?
> 
One should think so, especially since 1) the code has to be built as part of the
kernel build anyway, and 2) there would be other implications besides just
adding floating point operations into the kernel (see the other e-mail).
Overall I am glad that I don't have to maintain this code.

Either case, it would be great if we can come up with a solution to avoid build
failures due to toolchain configurations. If that means that vDSO won't be
compilable with debian toolchains, so be it. After all, that would not be
different to the current situation, only it would be official instead of causing
build failures.

Thanks,
Guenter

  reply	other threads:[~2016-11-04 18:34 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-30 16:05 [PATCH] MIPS: VDSO: Always select -msoft-float Guenter Roeck
2016-11-01 22:40 ` Maciej W. Rozycki
2016-11-01 22:40   ` Maciej W. Rozycki
2016-11-01 23:30   ` Guenter Roeck
2016-11-04 12:54     ` Maciej W. Rozycki
2016-11-04 12:54       ` Maciej W. Rozycki
2016-11-04 13:42       ` Matthew Fortune
2016-11-04 15:26         ` Guenter Roeck
2016-11-04 16:09           ` Maciej W. Rozycki
2016-11-04 16:50             ` Guenter Roeck
2016-11-04 18:06               ` Maciej W. Rozycki
2016-11-04 16:55             ` Matthew Fortune
2016-11-04 18:33               ` Guenter Roeck [this message]
2016-11-04 19:07               ` Maciej W. Rozycki
2016-11-23  0:08         ` Maciej W. Rozycki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161104183354.GA16694@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=James.Hogan@imgtec.com \
    --cc=Maciej.Rozycki@imgtec.com \
    --cc=Matthew.Fortune@imgtec.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).