From: James Hogan <james.hogan@imgtec.com>
To: Matt Redfearn <matt.redfearn@imgtec.com>
Cc: Ralf Baechle <ralf@linux-mips.org>,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: Fix distclean with Makefile.postlink
Date: Sat, 11 Feb 2017 21:27:45 +0000 [thread overview]
Message-ID: <20170211212745.GE24226@jhogan-linux.le.imgtec.org> (raw)
Message-ID: <20170211212745.M_uhbwDzaVaQ6_9UjBa24NA6N5lIb6lpCJhuQ-NCRwM@z> (raw)
In-Reply-To: <1485770314-29891-1-git-send-email-matt.redfearn@imgtec.com>
[-- Attachment #1: Type: text/plain, Size: 1321 bytes --]
On Mon, Jan 30, 2017 at 09:58:34AM +0000, Matt Redfearn wrote:
> The postlink Makefile must include include/config/auto.conf to get the
> kernel configuration variables. But in a clean kernel directory this
> file does not exist, causing make to bail with the error:
>
> arch/mips/Makefile.postlink:10:
> include/config/auto.conf: No such file or directory
> make[1]: *** No rule to make target
> 'include/config/auto.conf'. Stop.
> Makefile:1290: recipe for target 'vmlinuxclean' failed
>
> Fix this by using "-include" to not cause a Make error when the file
> does not exist.
>
> Fixes: 44079d3509ae ("MIPS: Use Makefile.postlink to insert relocations into vmlinux")
> Signed-off-by: Matt Redfearn <matt.redfearn@imgtec.com>
Applied
Thanks
James
> ---
>
> arch/mips/Makefile.postlink | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/Makefile.postlink b/arch/mips/Makefile.postlink
> index b0ddf0701a31..4b7f5a648c79 100644
> --- a/arch/mips/Makefile.postlink
> +++ b/arch/mips/Makefile.postlink
> @@ -7,7 +7,7 @@
> PHONY := __archpost
> __archpost:
>
> -include include/config/auto.conf
> +-include include/config/auto.conf
> include scripts/Kbuild.include
>
> CMD_RELOCS = arch/mips/boot/tools/relocs
> --
> 2.7.4
>
>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2017-02-11 21:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-30 9:58 [PATCH] MIPS: Fix distclean with Makefile.postlink Matt Redfearn
2017-01-30 9:58 ` Matt Redfearn
2017-02-11 21:27 ` James Hogan [this message]
2017-02-11 21:27 ` James Hogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170211212745.GE24226@jhogan-linux.le.imgtec.org \
--to=james.hogan@imgtec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=matt.redfearn@imgtec.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).