From: Jiri Slaby <jslaby@suse.cz>
To: stable@vger.kernel.org
Cc: John Crispin <john@phrozen.org>,
linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>,
Jiri Slaby <jslaby@suse.cz>
Subject: [patch added to 3.12-stable] MIPS: ralink: Cosmetic change to prom_init().
Date: Wed, 22 Mar 2017 16:57:41 +0100 [thread overview]
Message-ID: <20170322155753.23556-8-jslaby@suse.cz> (raw)
In-Reply-To: <20170322155753.23556-1-jslaby@suse.cz>
From: John Crispin <john@phrozen.org>
This patch has been added to the 3.12 stable tree. If you have any
objections, please let us know.
===============
commit 9c48568b3692f1a56cbf1935e4eea835e6b185b1 upstream.
Over the years the code has been changed various times leading to
argc/argv being defined in a different function to where we actually
use the variables. Clean this up by moving them to prom_init_cmdline().
Signed-off-by: John Crispin <john@phrozen.org>
Cc: linux-mips@linux-mips.org
Patchwork: https://patchwork.linux-mips.org/patch/14902/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
---
arch/mips/ralink/prom.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/arch/mips/ralink/prom.c b/arch/mips/ralink/prom.c
index 9c64f029d047..87312dfcee38 100644
--- a/arch/mips/ralink/prom.c
+++ b/arch/mips/ralink/prom.c
@@ -24,8 +24,10 @@ const char *get_system_type(void)
return soc_info.sys_type;
}
-static __init void prom_init_cmdline(int argc, char **argv)
+static __init void prom_init_cmdline(void)
{
+ int argc;
+ char **argv;
int i;
pr_debug("prom: fw_arg0=%08x fw_arg1=%08x fw_arg2=%08x fw_arg3=%08x\n",
@@ -54,14 +56,11 @@ static __init void prom_init_cmdline(int argc, char **argv)
void __init prom_init(void)
{
- int argc;
- char **argv;
-
prom_soc_init(&soc_info);
pr_info("SoC Type: %s\n", get_system_type());
- prom_init_cmdline(argc, argv);
+ prom_init_cmdline();
}
void __init prom_free_prom_memory(void)
--
2.12.0
prev parent reply other threads:[~2017-03-22 15:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170322155753.23556-1-jslaby@suse.cz>
2017-03-22 15:57 ` [patch added to 3.12-stable] MIPS: ip27: Disable qlge driver in defconfig Jiri Slaby
2017-03-22 15:57 ` [patch added to 3.12-stable] MIPS: ip22: Fix ip28 build for modern gcc Jiri Slaby
2017-03-22 15:57 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170322155753.23556-8-jslaby@suse.cz \
--to=jslaby@suse.cz \
--cc=john@phrozen.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).