linux-mips.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Burton <paul.burton@mips.com>
To: Tobias Wolf <dev-NTEO@vplace.de>
Cc: linux-mips@linux-mips.org, stable@vger.kernel.org
Subject: Re: [PATCH v3] MIPS: Fix memory reservation in bootmem_init for certain non-usermem setups
Date: Mon, 20 Aug 2018 16:31:11 -0700	[thread overview]
Message-ID: <20180820233111.xww5232dxbuouf4n@pburton-laptop> (raw)
In-Reply-To: <7994529.fS1YjVU6T6@loki>

Hi Tobias,

On Mon, Aug 20, 2018 at 01:10:38PM +0200, Tobias Wolf wrote:
> Commit 67a3ba25aa95 ("MIPS: Fix incorrect mem=X@Y handling") introduced a new
> issue for rt288x where "PHYS_OFFSET" is 0x0 but the calculated "ramstart" is
> not. As the prerequisite of custom memory map has been removed, this results
> in the full memory range of 0x0 - 0x8000000 to be marked as reserved for this
> platform.
> 
> This patch adds the originally intended prerequisite again.

Could you please give an example of a typical memory layout on your
platform, and what mem= arguments you're using? That would help a lot in
being able to understand what's going wrong with the existing code.

> Signed-off-by: Tobias Wolf <dev-NTEO@vplace.de>

You'd want to add at least a fixes tag here:

  Fixes: 67a3ba25aa95 ("MIPS: Fix incorrect mem=X@Y handling")

And ideally add the Cc: stable tag indicating the version the fix ought
to be backported to, something like:

  Cc: stable@vger.kernel.org # v4.16+

As an aside, if your system generally has a non-zero ramstart perhaps it
would be worth having it select MIPS_AUTO_PFN_OFFSET in Kconfig? (New in
the 4.19 merge window.) That would effectively adjust PHYS_OFFSET to
match ramstart, and not waste memory on struct page for the region below
ramstart.

Thanks,
    Paul

  parent reply	other threads:[~2018-08-20 23:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-20  9:27 [PATCH] MIPS: Fix memory reservation in bootmem_init for certain non-usermem setups Tobias Wolf
2018-08-20 10:06 ` [PATCH v2] " Tobias Wolf
2018-08-20 10:45   ` Mathieu Malaterre
2018-08-20 11:10 ` [PATCH v3] " Tobias Wolf
2018-08-20 11:51   ` Mathieu Malaterre
2018-08-20 17:14   ` Greg KH
2018-08-20 23:31   ` Paul Burton [this message]
2018-08-21  7:39     ` Tobias Wolf
2018-08-21  7:41 ` [PATCH v4] " Tobias Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180820233111.xww5232dxbuouf4n@pburton-laptop \
    --to=paul.burton@mips.com \
    --cc=dev-NTEO@vplace.de \
    --cc=linux-mips@linux-mips.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).