linux-mips.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Burton <paul.burton@mips.com>
To: Yunqiang Su <ysu@wavecomp.com>
Cc: Paul Burton <pburton@wavecomp.com>, YunQiang Su <syq@debian.org>,
	"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
	"aaro.koskinen@iki.fi" <aaro.koskinen@iki.fi>
Subject: Re: [PATCH v2] Disable MSI also when pcie-octeon.pcie_disable on
Date: Thu, 10 Jan 2019 18:45:31 +0000	[thread overview]
Message-ID: <20190110184530.7odyys2qyrmfcjkk@pburton-laptop> (raw)
In-Reply-To: <D0125B24-7506-48D0-B2A8-D1D1AC75ECC1@wavecomp.com>

Hi Yunqiang,

On Thu, Jan 10, 2019 at 10:35:13AM -0800, Yunqiang Su wrote:
> > 在 2019年1月11日，上午2:24，Paul Burton <pburton@wavecomp.com> 写道：
> > Hi YunQiang,
> > 
> > On Tue, Jan 08, 2019 at 01:45:10PM +0800, YunQiang Su wrote:
> >> From: YunQiang Su <ysu@wavecomp.com>
> >> 
> >> Octeon has an boot-time option to disable pcie.
> >> 
> >> Since MSI depends on PCI-E, we should also disable MSI also with
> >> this options is on.
> > 
> > Does this fix a bug you're seeing? Or is it just intended to avoid
> > redundant work?
> 
> I have no idea whether this is a bug or new feathers.
> I get an Cavium machine, which has no PCI at all, and so I have to disable the PCI totally.
> 
> For me there are 2 ways: disable on build-time or disable on runtime.
> Since Debian prefer to use a single kernel image.
> So I need to disable it on runtime.

Let me phrase this another way - if you boot with PCIe disabled, but
without your patch applied, what happens? Does the system work or does
it break?

You must have written the patch for a reason, I just want to know what
that reason is.

> > If it fixes a bug then I'll apply it to mips-fixes & copy stable,
> > otherwise I'll apply it to mips-next & not copy stable.
> 
> I prefer it to be backported.

Only if it fixes a bug.

Thanks,
    Paul

  reply	other threads:[~2019-01-10 18:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-08  5:45 [PATCH v2] Disable MSI also when pcie-octeon.pcie_disable on YunQiang Su
2019-01-08  7:41 ` YunQiang Su
2019-01-10 18:24 ` Paul Burton
2019-01-10 18:35   ` Yunqiang Su
2019-01-10 18:45     ` Paul Burton [this message]
2019-01-10 18:49       ` YunQiang Su
2019-01-10 18:55       ` YunQiang Su
2019-01-10 18:58 ` Paul Burton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190110184530.7odyys2qyrmfcjkk@pburton-laptop \
    --to=paul.burton@mips.com \
    --cc=aaro.koskinen@iki.fi \
    --cc=linux-mips@vger.kernel.org \
    --cc=pburton@wavecomp.com \
    --cc=syq@debian.org \
    --cc=ysu@wavecomp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).