From: Paul Burton <paul.burton@mips.com>
To: Oleksij Rempel <linux@rempel-privat.de>
Cc: "linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>, John Crispin <john@phrozen.org>,
"antonynpavlov@gmail.com" <antonynpavlov@gmail.com>
Subject: Re: MIPS: ath79: regressions after dma-mapping changes
Date: Thu, 10 Jan 2019 19:56:51 +0000 [thread overview]
Message-ID: <20190110195650.ped5tqsgkedrnn3d@pburton-laptop> (raw)
In-Reply-To: <6fcd16d9-84fc-891e-a295-9146c8071900@rempel-privat.de>
Hi Oleksij,
On Sat, Jan 05, 2019 at 05:39:06PM +0100, Oleksij Rempel wrote:
> Hi all,
>
> I'm working on Atheros ar9331 related patches for upstream. Suddenly
> this architecture is not working with latest mips_4.21 tag. Bisecting is
> pointing to dma-mapping-4.20 merge.
>
> The symptoms are following:
> - networking is broken, getting tx timouts from atheros network driver.
> - depending on configuration boot will stall even before UART is enabled
> - after reverting some of dma-mapping patches, network seems to work but
> init will trigger segfault. It is running from nfs-root.
Could you please try with v5.0-rc1 & let us know how that goes?
The mips_4.21 tag was based upon v4.20-rc1 which had a bug in
dma_alloc_coherent. That was fixed for v4.20-rc2 by commit d01501f85249
("MIPS: Fix `dma_alloc_coherent' returning a non-coherent allocation").
In general if you're planning to use the mips-next branch or a tag from
it then I'd suggest always merging it with the latest -rc or the release
of the appropriate kernel version, and possibly also the mips-fixes
branch. Or just use linux-next instead of mips-next.
> First patch where regressions started is this:
> commit dc3c05504d38849f77149cb962caeaedd1efa127
> Author: Christoph Hellwig <hch@lst.de>
> Date: Fri Aug 24 10:28:18 2018 +0200
>
> dma-mapping: remove dma_deconfigure
>
> This goes through a lot of hooks just to call arch_teardown_dma_ops.
> Replace it with a direct call instead.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Robin Murphy <robin.murphy@arm.com>
Having said that, I'm not sure the dma_alloc_coherent issue we had would
have led to this patch being pinpointed by a bisect, so let's see.
Thanks,
Paul
next prev parent reply other threads:[~2019-01-10 19:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-05 16:39 MIPS: ath79: regressions after dma-mapping changes Oleksij Rempel
2019-01-08 18:02 ` MIPS: ath79: net boot related regressions Oleksij Rempel
2019-01-08 18:19 ` Trond Myklebust
2019-01-08 19:55 ` Oleksij Rempel
2019-01-10 19:56 ` Paul Burton [this message]
2019-01-11 13:53 ` MIPS: ath79: regressions after dma-mapping changes Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190110195650.ped5tqsgkedrnn3d@pburton-laptop \
--to=paul.burton@mips.com \
--cc=antonynpavlov@gmail.com \
--cc=hch@lst.de \
--cc=john@phrozen.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux@rempel-privat.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).