Linux-MIPS Archive on lore.kernel.org
 help / Atom feed
* [PATCH] MIPS: Select PINCTRL_RT2880 when RALINK is enabled
@ 2019-01-29 15:25 Nishad Kamdar
  2019-01-29 20:09 ` Paul Burton
  0 siblings, 1 reply; 3+ messages in thread
From: Nishad Kamdar @ 2019-01-29 15:25 UTC (permalink / raw)
  To: Greg Kroah-Hartman, NeilBrown
  Cc: Ralf Baechle, Paul Burton, James Hogan, Joe Perches,
	Matthias Brugger, Sergio Paracuellos, Kees Cook, devel,
	Nishad Kamdar, linux-arm-kernel, linux-mediatek, linux-mips,
	linux-kernel

This patch selects config PINCTRL_RT2880 when config RALINK is
enabled as per drivers/staging/mt7621-pinctrl/TODO list. PINCTRL
is also selected when RALINK is enabled to avoid config dependency
warnings.

Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com>
---
 arch/mips/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index e2fc88da0223..cea529cf6284 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -623,6 +623,8 @@ config RALINK
 	select CLKDEV_LOOKUP
 	select ARCH_HAS_RESET_CONTROLLER
 	select RESET_CONTROLLER
+	select PINCTRL
+	select PINCTRL_RT2880
 
 config SGI_IP22
 	bool "SGI IP22 (Indy/Indigo2)"
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] MIPS: Select PINCTRL_RT2880 when RALINK is enabled
  2019-01-29 15:25 [PATCH] MIPS: Select PINCTRL_RT2880 when RALINK is enabled Nishad Kamdar
@ 2019-01-29 20:09 ` Paul Burton
  2019-01-30 14:26   ` Nishad Kamdar
  0 siblings, 1 reply; 3+ messages in thread
From: Paul Burton @ 2019-01-29 20:09 UTC (permalink / raw)
  To: Nishad Kamdar
  Cc: Greg Kroah-Hartman, NeilBrown, Ralf Baechle, James Hogan,
	Joe Perches, Matthias Brugger, Sergio Paracuellos, Kees Cook,
	devel, linux-arm-kernel, linux-mediatek, linux-mips,
	linux-kernel

Hi Nishad,

On Tue, Jan 29, 2019 at 08:55:27PM +0530, Nishad Kamdar wrote:
> This patch selects config PINCTRL_RT2880 when config RALINK is
> enabled as per drivers/staging/mt7621-pinctrl/TODO list. PINCTRL
> is also selected when RALINK is enabled to avoid config dependency
> warnings.
> 
> Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com>
> ---
>  arch/mips/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index e2fc88da0223..cea529cf6284 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -623,6 +623,8 @@ config RALINK
>  	select CLKDEV_LOOKUP
>  	select ARCH_HAS_RESET_CONTROLLER
>  	select RESET_CONTROLLER
> +	select PINCTRL
> +	select PINCTRL_RT2880
>  
>  config SGI_IP22
>  	bool "SGI IP22 (Indy/Indigo2)"

Wouldn't this also require selecting STAGING? Perhaps that's why it
wasn't done in the first place?

Thanks,
    Paul

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] MIPS: Select PINCTRL_RT2880 when RALINK is enabled
  2019-01-29 20:09 ` Paul Burton
@ 2019-01-30 14:26   ` Nishad Kamdar
  0 siblings, 0 replies; 3+ messages in thread
From: Nishad Kamdar @ 2019-01-30 14:26 UTC (permalink / raw)
  To: Paul Burton
  Cc: Greg Kroah-Hartman, NeilBrown, Ralf Baechle, James Hogan,
	Joe Perches, Matthias Brugger, Sergio Paracuellos, Kees Cook,
	devel, linux-arm-kernel, linux-mediatek, linux-mips,
	linux-kernel

On Tue, Jan 29, 2019 at 08:09:07PM +0000, Paul Burton wrote:
> Hi Nishad,
> 
> On Tue, Jan 29, 2019 at 08:55:27PM +0530, Nishad Kamdar wrote:
> > This patch selects config PINCTRL_RT2880 when config RALINK is
> > enabled as per drivers/staging/mt7621-pinctrl/TODO list. PINCTRL
> > is also selected when RALINK is enabled to avoid config dependency
> > warnings.
> > 
> > Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com>
> > ---
> >  arch/mips/Kconfig | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> > index e2fc88da0223..cea529cf6284 100644
> > --- a/arch/mips/Kconfig
> > +++ b/arch/mips/Kconfig
> > @@ -623,6 +623,8 @@ config RALINK
> >  	select CLKDEV_LOOKUP
> >  	select ARCH_HAS_RESET_CONTROLLER
> >  	select RESET_CONTROLLER
> > +	select PINCTRL
> > +	select PINCTRL_RT2880
> >  
> >  config SGI_IP22
> >  	bool "SGI IP22 (Indy/Indigo2)"
> 
> Wouldn't this also require selecting STAGING? Perhaps that's why it
> wasn't done in the first place?
> 
> Thanks,
>     Paul
Ok, got it.

Thanks for the review.

Regards,
Nishad

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-29 15:25 [PATCH] MIPS: Select PINCTRL_RT2880 when RALINK is enabled Nishad Kamdar
2019-01-29 20:09 ` Paul Burton
2019-01-30 14:26   ` Nishad Kamdar

Linux-MIPS Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-mips/0 linux-mips/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mips linux-mips/ https://lore.kernel.org/linux-mips \
		linux-mips@vger.kernel.org linux-mips@archiver.kernel.org
	public-inbox-index linux-mips


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-mips


AGPL code for this site: git clone https://public-inbox.org/ public-inbox