From: Rob Herring <robh@kernel.org>
To: Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc: linux-mips@vger.kernel.org, mturquette@baylibre.com,
sboyd@kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, mark.rutland@arm.com,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 3/3] dt-bindings: clock: Add loongson-1 clock bindings
Date: Wed, 30 Jan 2019 13:47:31 -0600 [thread overview]
Message-ID: <20190130194731.GA25716@bogus> (raw)
In-Reply-To: <20190128152052.3047-4-jiaxun.yang@flygoat.com>
On Mon, Jan 28, 2019 at 11:20:52PM +0800, Jiaxun Yang wrote:
> Loongson-1 is a series of MIPS MCUs.
> This patch add the clock bindings for loongson-1b and
> loongson-1c clock subsystem.
>
> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> ---
> .../bindings/clock/loongson1-clock.txt | 11 ++++++++++
> include/dt-bindings/clock/ls1b-clock.h | 20 +++++++++++++++++++
> include/dt-bindings/clock/ls1c-clock.h | 17 ++++++++++++++++
> 3 files changed, 48 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/clock/loongson1-clock.txt
> create mode 100644 include/dt-bindings/clock/ls1b-clock.h
> create mode 100644 include/dt-bindings/clock/ls1c-clock.h
>
> diff --git a/Documentation/devicetree/bindings/clock/loongson1-clock.txt b/Documentation/devicetree/bindings/clock/loongson1-clock.txt
> new file mode 100644
> index 000000000000..f0119fbd0851
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/loongson1-clock.txt
> @@ -0,0 +1,11 @@
> +* Clock bindings for Loongson-1 MCUs
> +
> +Required properties:
> +- compatible: Should be "loongson,ls1c-clock" or "loongson,ls1b-clock"
List one per line please.
> +- reg: Address and length of the register set
> +- #clock-cells: Should be <1>
> +- clocks: list of input clocks
> +
> +The clock consumer should specify the desired clock by having the clock
> +ID in its "clocks" phandle cell. See include/dt-bindings/clock/ls1c-clock.h
> +or include/dt-bindings/clock/ls1b-clock.h for the full list of clocks.
> diff --git a/include/dt-bindings/clock/ls1b-clock.h b/include/dt-bindings/clock/ls1b-clock.h
> new file mode 100644
> index 000000000000..814227842ae0
> --- /dev/null
> +++ b/include/dt-bindings/clock/ls1b-clock.h
> @@ -0,0 +1,20 @@
> +// SPDX-License-Identifier: GPL-2.0
Headers should be /* */ style comments.
> +/*
> + * Copyright (C) 2019 Jiaxun Yang <jiaxun.yang@flygoat.com>
> + *
> + */
> +
> +#ifndef __DT_BINDINGS_CLOCK_LS1B_CLOCK_H__
> +#define __DT_BINDINGS_CLOCK_LS1B_CLOCK_H__
> +
> +#define LS1B_CLK_PLL 0
> +#define LS1B_CLK_CPU_DIV 1
> +#define LS1B_CLK_CPU 2
> +#define LS1B_CLK_DC_DIV 3
> +#define LS1B_CLK_DC 4
> +#define LS1B_CLK_DDR_DIV 5
> +#define LS1B_CLK_DDR 6
> +#define LS1B_CLK_AHB 7
> +#define LS1B_CLK_APB 8
> +
> +#endif /* __DT_BINDINGS_CLOCK_LS1B_CLOCK_H__ */
> diff --git a/include/dt-bindings/clock/ls1c-clock.h b/include/dt-bindings/clock/ls1c-clock.h
> new file mode 100644
> index 000000000000..40f386cb92ce
> --- /dev/null
> +++ b/include/dt-bindings/clock/ls1c-clock.h
> @@ -0,0 +1,17 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (C) 2019 Jiaxun Yang <jiaxun.yang@flygoat.com>
> + *
> + */
> +
> +#ifndef __DT_BINDINGS_CLOCK_LS1C_CLOCK_H__
> +#define __DT_BINDINGS_CLOCK_LS1C_CLOCK_H__
> +
> +#define LS1C_CLK_PLL 0
> +#define LS1C_CLK_CPU 1
> +#define LS1C_CLK_DC 2
> +#define LS1C_CLK_DDR 3
> +#define LS1C_CLK_AHB 4
> +#define LS1C_CLK_APB 5
> +
> +#endif /* __DT_BINDINGS_CLOCK_LS1C_CLOCK_H__ */
> --
> 2.20.1
>
next prev parent reply other threads:[~2019-01-30 19:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 13:34 [PATCH 0/3] Enhance loongson-1 clock driver Jiaxun Yang
2019-01-25 13:34 ` [PATCH 1/3] clk: loongson1: add configuration option for loongson1 clks Jiaxun Yang
2019-01-25 13:34 ` [PATCH 2/3] clk: loongson1: add of support Jiaxun Yang
2019-01-25 13:34 ` [PATCH 3/3] dt-bindings: clock: Add loongson-1 clock bindings Jiaxun Yang
2019-01-28 15:20 ` [PATCH 0/3] Enhance loongson-1 clock driver Jiaxun Yang
2019-01-28 15:20 ` [PATCH v2 1/3] clk: loongson1: add configuration option for loongson1 clks Jiaxun Yang
2019-01-28 15:20 ` [PATCH v2 2/3] clk: loongson1: add of support Jiaxun Yang
2019-01-28 15:20 ` [PATCH v2 3/3] dt-bindings: clock: Add loongson-1 clock bindings Jiaxun Yang
2019-01-30 19:47 ` Rob Herring [this message]
2019-02-01 6:35 ` [PATCH v3 0/3] Enhance loongson-1 clock driver Jiaxun Yang
2019-02-01 6:35 ` [PATCH v3 1/3] clk: loongson1: add configuration option for loongson1 clks Jiaxun Yang
2019-02-06 19:18 ` Stephen Boyd
2019-02-01 6:35 ` [PATCH v3 2/3] clk: loongson1: add of support Jiaxun Yang
2019-02-06 19:16 ` Stephen Boyd
2019-02-01 6:35 ` [PATCH v3 3/3] dt-bindings: clock: Add loongson-1 clock bindings Jiaxun Yang
2019-02-13 22:56 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190130194731.GA25716@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).