From: Paul Burton <paul.burton@mips.com>
To: "akpm@linux-foundation.org" <akpm@linux-foundation.org>
Cc: "dave@stgolabs.net" <dave@stgolabs.net>,
"dbueso@suse.de" <dbueso@suse.de>,
"jhogan@kernel.org" <jhogan@kernel.org>,
"mm-commits@vger.kernel.org" <mm-commits@vger.kernel.org>,
"ralf@linux-mips.org" <ralf@linux-mips.org>,
"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>
Subject: Re: + mips-c-r4k-do-no-use-mmap_sem-for-gup_fast.patch added to -mm tree
Date: Fri, 8 Feb 2019 05:57:10 +0000 [thread overview]
Message-ID: <20190208055708.sxlvcfyjayiwrozc@pburton-laptop> (raw)
In-Reply-To: <20190208054407.gjyKBBYUS%akpm@linux-foundation.org>
Hi Andrew,
On Thu, Feb 07, 2019 at 09:44:07PM -0800, akpm@linux-foundation.org wrote:
>
> The patch titled
> Subject: arch/mips/mm/c-r4k.c: do not use mmap_sem for gup_fast()
> has been added to the -mm tree. Its filename is
> mips-c-r4k-do-no-use-mmap_sem-for-gup_fast.patch
>
> This patch should soon appear at
> http://ozlabs.org/~akpm/mmots/broken-out/mips-c-r4k-do-no-use-mmap_sem-for-gup_fast.patch
> and later at
> http://ozlabs.org/~akpm/mmotm/broken-out/mips-c-r4k-do-no-use-mmap_sem-for-gup_fast.patch
>
> Before you just go and hit "reply", please:
> a) Consider who else should be cc'ed
> b) Prefer to cc a suitable mailing list as well
> c) Ideally: find the original patch on the mailing list and do a
> reply-to-all to that, adding suitable additional cc's
>
> *** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
>
> The -mm tree is included into linux-next and is updated
> there every 3-4 working days
>
> ------------------------------------------------------
> From: Davidlohr Bueso <dave@stgolabs.net>
> Subject: arch/mips/mm/c-r4k.c: do not use mmap_sem for gup_fast()
>
> It is well known that because the mm can internally call the regular
> gup_unlocked if the lockless approach fails and take the sem there, the
> caller must not hold the mmap_sem already.
>
> Link: http://lkml.kernel.org/r/20190207053740.26915-3-dave@stgolabs.net
> Fixes: e523f289fe4d ("MIPS: c-r4k: Fix sigtramp SMP call to use kmap")
> Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: Paul Burton <paul.burton@mips.com>
> Cc: James Hogan <jhogan@kernel.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Whilst I don't object to you merging this too strongly, I thought I'd
point out again that as I already replied to Davidlohr [1] the code
being changed here is unused in mainline & all affected stable branches.
In mips-next it's entirely removed. As such this patch will have no
effect on the kernel's behaviour & cause a minor conflict with
mips-next.
Thanks,
Paul
[1] https://lore.kernel.org/linux-mips/20190207190007.jz4rz6e6qxwazxm7@pburton-laptop/
next parent reply other threads:[~2019-02-08 5:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190208054407.gjyKBBYUS%akpm@linux-foundation.org>
2019-02-08 5:57 ` Paul Burton [this message]
2019-02-08 22:57 ` + mips-c-r4k-do-no-use-mmap_sem-for-gup_fast.patch added to -mm tree Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190208055708.sxlvcfyjayiwrozc@pburton-laptop \
--to=paul.burton@mips.com \
--cc=akpm@linux-foundation.org \
--cc=dave@stgolabs.net \
--cc=dbueso@suse.de \
--cc=jhogan@kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).