From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F149C43219 for ; Fri, 3 May 2019 11:11:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5347D206C3 for ; Fri, 3 May 2019 11:11:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727469AbfECLL7 convert rfc822-to-8bit (ORCPT ); Fri, 3 May 2019 07:11:59 -0400 Received: from relay11.mail.gandi.net ([217.70.178.231]:50555 "EHLO relay11.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726396AbfECLL6 (ORCPT ); Fri, 3 May 2019 07:11:58 -0400 Received: from xps13 (aaubervilliers-681-1-29-145.w90-88.abo.wanadoo.fr [90.88.149.145]) (Authenticated sender: miquel.raynal@bootlin.com) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 9D4FF100005; Fri, 3 May 2019 11:11:53 +0000 (UTC) Date: Fri, 3 May 2019 13:11:52 +0200 From: Miquel Raynal To: Masahiro Yamada Cc: linux-arch , Christophe Leroy , Arnd Bergmann , linux-s390 , Mathieu Malaterre , X86 ML , Heiko Carstens , linux-mips@vger.kernel.org, Linux Kernel Mailing List , Ingo Molnar , linux-mtd , Andrew Morton , linuxppc-dev , linux-arm-kernel Subject: Re: [RESEND PATCH v3 05/11] mtd: rawnand: vf610_nfc: add initializer to avoid -Wmaybe-uninitialized Message-ID: <20190503131152.57b4ce25@xps13> In-Reply-To: References: <20190423034959.13525-1-yamada.masahiro@socionext.com> <20190423034959.13525-6-yamada.masahiro@socionext.com> <20190502161346.07c15187@xps13> Organization: Bootlin X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org Hi Masahiro, Masahiro Yamada wrote on Fri, 3 May 2019 19:36:35 +0900: > Hi Miquel, > > On Thu, May 2, 2019 at 11:14 PM Miquel Raynal wrote: > > > > Hi Masahiro, > > > > Masahiro Yamada wrote on Tue, 23 Apr > > 2019 12:49:53 +0900: > > > > > This prepares to move CONFIG_OPTIMIZE_INLINING from x86 to a common > > > place. We need to eliminate potential issues beforehand. > > > > > > Kbuild test robot has never reported -Wmaybe-uninitialized warning > > > for this probably because vf610_nfc_run() is inlined by the x86 > > > compiler's inlining heuristic. > > > > > > If CONFIG_OPTIMIZE_INLINING is enabled for a different architecture > > > and vf610_nfc_run() is not inlined, the following warning is reported: > > > > > > drivers/mtd/nand/raw/vf610_nfc.c: In function ‘vf610_nfc_cmd’: > > > drivers/mtd/nand/raw/vf610_nfc.c:455:3: warning: ‘offset’ may be used uninitialized in this function [-Wmaybe-uninitialized] > > > vf610_nfc_rd_from_sram(instr->ctx.data.buf.in + offset, > > > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > nfc->regs + NFC_MAIN_AREA(0) + offset, > > > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > trfr_sz, !nfc->data_access); > > > ~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > > IMHO this patch has no dependencies with this series. > > > This patch is the prerequisite for 11/11. > https://lore.kernel.org/patchwork/patch/1064959/ > > > Without the correct patch order, > the kbuild test robot reports the warning. > > > > Would you mind sending it alone with the proper Fixes tag? > > > I do not think Fixes is necessary. IMHO it is. Even if today the warning does not spawn, there is a real C error which might already be an issue. > > Nobody has noticed this potential issue before. > Without 11/11, probably we cannot reproduce this warning. > > > BTW, this series has been for a while in linux-next. Missed that. Ok, nevermind. Thanks, Miquèl