Linux-MIPS Archive on lore.kernel.org
 help / Atom feed
* [PATCH] MIPS: remove a space after -I to cope with header search paths for VDSO
@ 2019-05-21  4:03 Masahiro Yamada
  2019-05-23  1:56 ` Paul Burton
  0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2019-05-21  4:03 UTC (permalink / raw)
  To: Ralf Baechle, Paul Burton, James Hogan, linux-mips
  Cc: Masahiro Yamada, linux-kernel

Commit 9cc342f6c4a0 ("treewide: prefix header search paths with
$(srctree)/") caused a build error for MIPS VDSO.

  CC      arch/mips/vdso/gettimeofday.o
In file included from ../arch/mips/vdso/vdso.h:26,
                 from ../arch/mips/vdso/gettimeofday.c:11:
../arch/mips/include/asm/page.h:12:10: fatal error: spaces.h: No such file or directory
 #include <spaces.h>
          ^~~~~~~~~~

The cause of the error is a missing space after the compiler flag -I .

Kbuild used to have a global restriction "no space after -I", but
commit 48f6e3cf5bc6 ("kbuild: do not drop -I without parameter") got
rid of it. Having a space after -I is no longer a big deal as far as
Kbuild is concerned.

It is still a big deal for MIPS because arch/mips/vdso/Makefile
filters the header search paths, like this:

  ccflags-vdso := \
          $(filter -I%,$(KBUILD_CFLAGS)) \

..., which relies on the assumption that there is no space after -I .

Fixes: 9cc342f6c4a0 ("treewide: prefix header search paths with $(srctree)/")
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 arch/mips/pnx833x/Platform | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/pnx833x/Platform b/arch/mips/pnx833x/Platform
index 6b1a847d593f..287260669551 100644
--- a/arch/mips/pnx833x/Platform
+++ b/arch/mips/pnx833x/Platform
@@ -1,5 +1,5 @@
 # NXP STB225
 platform-$(CONFIG_SOC_PNX833X)	+= pnx833x/
-cflags-$(CONFIG_SOC_PNX833X)	+= -I $(srctree)/arch/mips/include/asm/mach-pnx833x
+cflags-$(CONFIG_SOC_PNX833X)	+= -I$(srctree)/arch/mips/include/asm/mach-pnx833x
 load-$(CONFIG_NXP_STB220)	+= 0xffffffff80001000
 load-$(CONFIG_NXP_STB225)	+= 0xffffffff80001000
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] MIPS: remove a space after -I to cope with header search paths for VDSO
  2019-05-21  4:03 [PATCH] MIPS: remove a space after -I to cope with header search paths for VDSO Masahiro Yamada
@ 2019-05-23  1:56 ` Paul Burton
  0 siblings, 0 replies; 2+ messages in thread
From: Paul Burton @ 2019-05-23  1:56 UTC (permalink / raw)
  To: Masahiro Yamada
  Cc: Ralf Baechle, Paul Burton, James Hogan, linux-mips,
	Masahiro Yamada, linux-kernel, linux-mips

Hello,

Masahiro Yamada wrote:
> Commit 9cc342f6c4a0 ("treewide: prefix header search paths with
> $(srctree)/") caused a build error for MIPS VDSO.
> 
> CC      arch/mips/vdso/gettimeofday.o
> In file included from ../arch/mips/vdso/vdso.h:26,
> from ../arch/mips/vdso/gettimeofday.c:11:
> ../arch/mips/include/asm/page.h:12:10: fatal error: spaces.h: No such file or directory
> #include <spaces.h>
> ^~~~~~~~~~
> 
> The cause of the error is a missing space after the compiler flag -I .
> 
> Kbuild used to have a global restriction "no space after -I", but
> commit 48f6e3cf5bc6 ("kbuild: do not drop -I without parameter") got
> rid of it. Having a space after -I is no longer a big deal as far as
> Kbuild is concerned.
> 
> It is still a big deal for MIPS because arch/mips/vdso/Makefile
> filters the header search paths, like this:
> 
> ccflags-vdso :=           $(filter -I%,$(KBUILD_CFLAGS))
> ..., which relies on the assumption that there is no space after -I .
> 
> Fixes: 9cc342f6c4a0 ("treewide: prefix header search paths with $(srctree)/")
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Applied to mips-fixes.

Thanks,
    Paul

[ This message was auto-generated; if you believe anything is incorrect
  then please email paul.burton@mips.com to report it. ]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-21  4:03 [PATCH] MIPS: remove a space after -I to cope with header search paths for VDSO Masahiro Yamada
2019-05-23  1:56 ` Paul Burton

Linux-MIPS Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-mips/0 linux-mips/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mips linux-mips/ https://lore.kernel.org/linux-mips \
		linux-mips@vger.kernel.org linux-mips@archiver.kernel.org
	public-inbox-index linux-mips


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-mips


AGPL code for this site: git clone https://public-inbox.org/ public-inbox