From: David Miller <davem@davemloft.net>
To: horatiu.vultur@microchip.com
Cc: alexandre.belloni@bootlin.com, UNGLinuxDriver@microchip.com,
robh+dt@kernel.org, mark.rutland@arm.com, ralf@linux-mips.org,
paul.burton@mips.com, jhogan@kernel.org,
linux-mips@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] net: mscc: ocelot: Add support for tcam
Date: Tue, 28 May 2019 10:59:05 -0700 (PDT) [thread overview]
Message-ID: <20190528.105905.1984032479752781822.davem@davemloft.net> (raw)
In-Reply-To: <1558944996-23069-2-git-send-email-horatiu.vultur@microchip.com>
From: Horatiu Vultur <horatiu.vultur@microchip.com>
Date: Mon, 27 May 2019 10:16:35 +0200
> +/* Calculate offsets for entry */
> +static void is2_data_get(struct vcap_data *data, int ix)
> +{
> + const struct vcap_props *vcap = &vcap_is2;
> + u32 i, col, offset, count, cnt, base, width = vcap->tg_width;
Reverse christmas tree please.
> +static void is2_entry_set(struct ocelot *ocelot, int ix,
> + struct ocelot_ace_rule *ace)
> +{
> + u32 val, msk, type, type_mask = 0xf, i, count;
> + struct ocelot_vcap_u64 payload = { 0 };
> + struct ocelot_ace_vlan *tag = &ace->vlan;
> + struct vcap_data data = { 0 };
> + int row = (ix / 2);
Likewise.
> +static void is2_entry_get(struct ocelot_ace_rule *rule, int ix)
> +{
> + struct vcap_data data;
> + struct ocelot *op = rule->port->ocelot;
> + int row = (ix / 2);
> + u32 cnt;
Likewise.
> +static void ocelot_ace_rule_add(struct ocelot_acl_block *block,
> + struct ocelot_ace_rule *rule)
> +{
> + struct list_head *pos, *n;
> + struct ocelot_ace_rule *tmp;
Likewise.
And so on and so forth for your entire submission.
Thank you.
next prev parent reply other threads:[~2019-05-28 17:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-27 8:16 [PATCH net-next 0/2] Add hw offload of TC flower on MSCC Ocelot Horatiu Vultur
2019-05-27 8:16 ` [PATCH net-next 1/2] net: mscc: ocelot: Add support for tcam Horatiu Vultur
2019-05-28 17:59 ` David Miller [this message]
2019-05-27 8:16 ` [PATCH net-next 2/2] net: mscc: ocelot: Hardware ofload for tc flower filter Horatiu Vultur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190528.105905.1984032479752781822.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=horatiu.vultur@microchip.com \
--cc=jhogan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=paul.burton@mips.com \
--cc=ralf@linux-mips.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).