From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Horatiu Vultur <horatiu.vultur@microchip.com>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
Rob Herring <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
Ralf Baechle <ralf@linux-mips.org>,
"Paul Burton" <paul.burton@mips.com>,
James Hogan <jhogan@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
<linux-mips@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next v2 2/2] net: mscc: ocelot: Hardware ofload for tc flower filter
Date: Wed, 29 May 2019 15:18:44 -0700 [thread overview]
Message-ID: <20190529151802.19aa82a2@cakuba.netronome.com> (raw)
In-Reply-To: <1559125580-6375-3-git-send-email-horatiu.vultur@microchip.com>
On Wed, 29 May 2019 12:26:20 +0200, Horatiu Vultur wrote:
> +static int ocelot_flower_replace(struct tc_cls_flower_offload *f,
> + struct ocelot_port_block *port_block)
> +{
> + struct ocelot_ace_rule *rule;
> + int ret;
> +
> + if (port_block->port->tc.block_shared)
> + return -EOPNOTSUPP;
FWIW since you only support TRAP and DROP actions here (AFAICT) you
should actually be okay with shared blocks. The problems with shared
blocks start when the action is stateful (like act_police), because we
can't share that state between devices. But for most actions which just
maintain statistics, it's fine to allow shared blocks. HTH
next prev parent reply other threads:[~2019-05-29 22:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 10:26 [PATCH net-next v2 0/2] Add hw offload of TC flower on MSCC Ocelot Horatiu Vultur
2019-05-29 10:26 ` [PATCH net-next v2 1/2] net: mscc: ocelot: Add support for tcam Horatiu Vultur
2019-05-29 10:26 ` [PATCH net-next v2 2/2] net: mscc: ocelot: Hardware ofload for tc flower filter Horatiu Vultur
2019-05-29 22:18 ` Jakub Kicinski [this message]
2019-05-30 19:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190529151802.19aa82a2@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=horatiu.vultur@microchip.com \
--cc=jhogan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=paul.burton@mips.com \
--cc=ralf@linux-mips.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).