From: Sasha Levin <sashal@kernel.org> To: Thomas Gleixner <tglx@linutronix.de> Cc: Michael Kelley <mikelley@microsoft.com>, Vincenzo Frascino <vincenzo.frascino@arm.com>, "linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>, "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will.deacon@arm.com>, Arnd Bergmann <arnd@arndb.de>, Russell King <linux@armlinux.org.uk>, Ralf Baechle <ralf@linux-mips.org>, Paul Burton <paul.burton@mips.com>, Daniel Lezcano <daniel.lezcano@linaro.org>, Mark Salyzyn <salyzyn@android.com>, Peter Collingbourne <pcc@google.com>, Shuah Khan <shuah@kernel.org>, Dmitry Safonov <0x7f454c46@gmail.com>, Rasmus Villemoes <linux@rasmusvillemoes.dk>, Huw Davies <huw@codeweavers.com>, linux-hyperv@vger.kernel.org, Greg KH <gregkh@linuxfoundation.org>, Stephen Rothwell <sfr@canb.auug.org.au> Subject: Re: [PATCH v6 18/19] x86: Add support for generic vDSO Date: Sun, 23 Jun 2019 15:09:29 -0400 Message-ID: <20190623190929.GL2226@sasha-vm> (raw) In-Reply-To: <alpine.DEB.2.21.1906221542270.5503@nanos.tec.linutronix.de> On Sat, Jun 22, 2019 at 04:46:28PM +0200, Thomas Gleixner wrote: >On Fri, 14 Jun 2019, Sasha Levin wrote: >> On Fri, Jun 14, 2019 at 01:15:23PM +0200, Thomas Gleixner wrote: >> > On Thu, 30 May 2019, Michael Kelley wrote: >> > > Vincenzo -- these changes for Hyper-V are a subset of a larger patch set >> > > I have that moves all of the Hyper-V clock/timer code into a separate >> > > clocksource driver in drivers/clocksource, with an include file in >> > > includes/clocksource. That new include file should be able to work >> > > instead of your new mshyperv-tsc.h. It also has the benefit of being >> > > ISA neutral, so it will work with my in-progress patch set to support >> > > Linux on Hyper-V on ARM64. See https://lkml.org/lkml/2019/5/27/231 >> > > for the new clocksource driver patch set. >> > >> > Grrr. That's queued in hyperv-next for whatever reasons. >> >> I queue up our future pull requests there to give them some soaking in >> -next. > >What? You queue completely unreviewed stuff which touches two other >subsystems to let it soak in next? It was out on LKML for 2+ weeks before I've pulled it in. As it mostly touches hyperv bits I felt comfortable to give it time in -next (but not actually to try and merge it until it gets a few acks). >> > Sasha, can you please provide me the branch to pull from so I can have a >> > common base for all the various changes floating around? >> >> I'll send you a unified pull request for these changes. > >Which has not materialized yet. Appologies about this. I ended up with way more travel than I would have liked (writing this from an airport). I've reset our hyperv-next branch to remove these 3 commits until we figure this out. >TBH, I'm pretty grumpy about those clocksource changes. Here is the >diffstat: > > MAINTAINERS | 2 > arch/x86/entry/vdso/vclock_gettime.c | 1 > arch/x86/entry/vdso/vma.c | 2 > arch/x86/hyperv/hv_init.c | 91 --------- > arch/x86/include/asm/hyperv-tlfs.h | 6 > arch/x86/include/asm/mshyperv.h | 81 +------- > arch/x86/kernel/cpu/mshyperv.c | 2 > arch/x86/kvm/x86.c | 1 > drivers/clocksource/Makefile | 1 > drivers/clocksource/hyperv_timer.c | 322 +++++++++++++++++++++++++++++++++++ > drivers/hv/Kconfig | 3 > drivers/hv/hv.c | 156 ---------------- > drivers/hv/hv_util.c | 1 > drivers/hv/hyperv_vmbus.h | 3 > drivers/hv/vmbus_drv.c | 42 ++-- > include/clocksource/hyperv_timer.h | 105 +++++++++++ > >While the world and some more people have been CC'ed on those patches, >neither the clocksource nor the x86 maintainer have been. > >When I gave Vincenzo the advise to base his code on that hyper-v branch, I >expected that I find the related patches in my mail backlog. No, they have >not been there because I was not on CC. > >Folks, please stop chosing Cc lists as you like. We have well established >rules for that. And please stop queueing random unreviewed patches in >next. Next is not a playground for not ready and unreviewed stuff. No, the >hyper-v inbreed Reviewed-by is not sufficient for anything x86 and >clocksource related. I'm sorry for this, you were supposed to be Cc'ed on these patches and I see that you were not. >After chasing and looking at those patches, which have horrible subject >lines and changelogs btw, I was not able to judge quickly whether that >stuff is self contained or not. So no, I fixed up the fallout and rebased >Vincenzos VDSO stuff on mainline w/o those hyperv changes simply because if >they are not self contained they will break bisection badly. > >I'm going to push out the VDSO series later today. That will nicely break >in combination with the hyper-next branch. Stephen, please drop that and do >not try to handle the fallout. That stuff needs to go through the proper >channels or at least be acked/reviewed by the relevant maintainers. So the >hyper-v folks can rebase themself and post it proper. Okay, thank you. We'll rebase and resend. -- Thanks, Sasha
next prev parent reply index Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-30 14:15 [PATCH v6 00/19] Unify vDSOs across more architectures Vincenzo Frascino 2019-05-30 14:15 ` [PATCH v6 01/19] kernel: Standardize vdso_datapage Vincenzo Frascino 2019-05-31 8:16 ` Arnd Bergmann 2019-06-04 12:05 ` Vincenzo Frascino 2019-06-10 17:47 ` Huw Davies 2019-06-10 9:27 ` Huw Davies 2019-06-10 10:17 ` Vincenzo Frascino 2019-06-10 10:31 ` Huw Davies 2019-06-10 11:07 ` Vincenzo Frascino 2019-06-10 11:37 ` Huw Davies 2019-05-30 14:15 ` [PATCH v6 02/19] kernel: Define gettimeofday vdso common code Vincenzo Frascino 2019-05-31 8:19 ` Arnd Bergmann 2019-06-04 12:08 ` Vincenzo Frascino 2019-06-10 9:31 ` Huw Davies 2019-06-10 10:18 ` Vincenzo Frascino 2019-05-30 14:15 ` [PATCH v6 03/19] kernel: Unify update_vsyscall implementation Vincenzo Frascino 2019-06-10 9:34 ` Huw Davies 2019-06-10 10:19 ` Vincenzo Frascino 2019-06-14 11:10 ` Thomas Gleixner 2019-06-14 12:15 ` Vincenzo Frascino 2019-06-14 12:19 ` Thomas Gleixner 2019-06-14 12:25 ` Vincenzo Frascino 2019-06-14 13:07 ` Thomas Gleixner 2019-05-30 14:15 ` [PATCH v6 04/19] arm64: Substitute gettimeofday with C implementation Vincenzo Frascino 2019-05-30 14:15 ` [PATCH v6 05/19] arm64: Build vDSO with -ffixed-x18 Vincenzo Frascino 2019-05-30 14:15 ` [PATCH v6 06/19] arm64: compat: Add missing syscall numbers Vincenzo Frascino 2019-05-30 14:15 ` [PATCH v6 07/19] arm64: compat: Expose signal related structures Vincenzo Frascino 2019-05-30 14:15 ` [PATCH v6 08/19] arm64: compat: Generate asm offsets for signals Vincenzo Frascino 2019-05-30 14:15 ` [PATCH v6 09/19] lib: vdso: Add compat support Vincenzo Frascino 2019-05-30 14:15 ` [PATCH v6 10/19] arm64: compat: Add vDSO Vincenzo Frascino 2019-05-30 14:15 ` [PATCH v6 11/19] arm64: Refactor vDSO code Vincenzo Frascino 2019-05-30 14:15 ` [PATCH v6 12/19] arm64: compat: vDSO setup for compat layer Vincenzo Frascino 2019-05-30 14:15 ` [PATCH v6 13/19] arm64: elf: vDSO code page discovery Vincenzo Frascino 2019-05-30 14:15 ` [PATCH v6 14/19] arm64: compat: Get sigreturn trampolines from vDSO Vincenzo Frascino 2019-05-30 14:15 ` [PATCH v6 15/19] arm64: Add vDSO compat support Vincenzo Frascino 2019-06-01 9:38 ` Catalin Marinas 2019-06-04 12:10 ` Vincenzo Frascino 2019-05-30 14:15 ` [PATCH v6 16/19] arm: Add support for generic vDSO Vincenzo Frascino 2019-05-31 8:32 ` Arnd Bergmann 2019-05-30 14:15 ` [PATCH v6 17/19] mips: " Vincenzo Frascino 2019-05-31 8:34 ` Arnd Bergmann 2019-06-03 14:54 ` Mark Salyzyn 2019-06-03 17:07 ` Arnd Bergmann 2019-05-30 14:15 ` [PATCH v6 18/19] x86: " Vincenzo Frascino 2019-05-30 15:41 ` Michael Kelley 2019-06-04 12:13 ` Vincenzo Frascino 2019-06-14 11:15 ` Thomas Gleixner 2019-06-14 21:17 ` Sasha Levin 2019-06-22 14:46 ` Thomas Gleixner 2019-06-23 19:09 ` Sasha Levin [this message] 2019-06-23 21:58 ` Stephen Rothwell 2019-06-24 0:24 ` Sasha Levin 2019-06-24 1:20 ` Stephen Rothwell 2019-06-23 22:12 ` Thomas Gleixner 2019-06-24 0:04 ` Michael Kelley 2019-06-24 0:25 ` Thomas Gleixner 2019-06-28 18:40 ` Michael Kelley 2019-05-30 14:15 ` [PATCH v6 19/19] kselftest: Extend vDSO selftest Vincenzo Frascino 2019-05-31 8:53 ` Arnd Bergmann 2019-05-31 8:46 ` [PATCH v6 00/19] Unify vDSOs across more architectures Arnd Bergmann 2019-06-04 12:04 ` Vincenzo Frascino 2019-06-04 12:12 ` Arnd Bergmann 2019-06-05 14:32 ` Vincenzo Frascino 2019-06-14 12:16 ` Thomas Gleixner 2019-06-14 12:19 ` Vincenzo Frascino 2019-06-20 6:17 ` Shijith Thotton 2019-06-20 8:55 ` Vincenzo Frascino 2019-06-20 16:27 ` Andre Przywara 2019-06-21 9:11 ` Vincenzo Frascino
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190623190929.GL2226@sasha-vm \ --to=sashal@kernel.org \ --cc=0x7f454c46@gmail.com \ --cc=arnd@arndb.de \ --cc=catalin.marinas@arm.com \ --cc=daniel.lezcano@linaro.org \ --cc=gregkh@linuxfoundation.org \ --cc=huw@codeweavers.com \ --cc=linux-arch@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-hyperv@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-kselftest@vger.kernel.org \ --cc=linux-mips@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=linux@rasmusvillemoes.dk \ --cc=mikelley@microsoft.com \ --cc=paul.burton@mips.com \ --cc=pcc@google.com \ --cc=ralf@linux-mips.org \ --cc=salyzyn@android.com \ --cc=sfr@canb.auug.org.au \ --cc=shuah@kernel.org \ --cc=tglx@linutronix.de \ --cc=vincenzo.frascino@arm.com \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-MIPS Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-mips/0 linux-mips/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-mips linux-mips/ https://lore.kernel.org/linux-mips \ linux-mips@vger.kernel.org public-inbox-index linux-mips Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-mips AGPL code for this site: git clone https://public-inbox.org/public-inbox.git