From: Stephen Boyd <sboyd@kernel.org>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>,
James Hogan <jhogan@kernel.org>,
Jason Cooper <jason@lakedaemon.net>,
Jonathan Corbet <corbet@lwn.net>,
Lee Jones <lee.jones@linaro.org>,
Marc Zyngier <marc.zyngier@arm.com>,
Michael Turquette <mturquette@baylibre.com>,
Paul Burton <paul.burton@mips.com>,
Ralf Baechle <ralf@linux-mips.org>,
Thomas Gleixner <tglx@linutronix.de>,
Mathieu Malaterre <malat@debian.org>,
od@zcrc.me, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org,
linux-doc@vger.kernel.org, linux-clk@vger.kernel.org,
Artur Rojek <contact@artur-rojek.eu>
Subject: Re: [PATCH v13 05/13] clk: ingenic: Add driver for the TCU clocks
Date: Tue, 25 Jun 2019 16:28:20 -0700 [thread overview]
Message-ID: <20190625232820.D1D4A20645@mail.kernel.org> (raw)
In-Reply-To: <1561502227.10069.1@crapouillou.net>
Quoting Paul Cercueil (2019-06-25 15:37:07)
> >
> > Do you need to get the clk by name? Or can that clk be "known" to the
> > TCU somehow so we can already have a direct clk pointer?
>
> This clock is provided by a separate driver, so I have to obtain the
> clock pointer from devicetree.
Ok.
> >> +}
> >> +
> >> +static int __maybe_unused tcu_pm_suspend(void)
> >> +{
> >> + struct ingenic_tcu *tcu = ingenic_tcu;
> >> +
> >> + if (tcu->clk)
> >> + clk_disable(tcu->clk);
> >
> > Do you need to unprepare? Or it just isn't possible because this is
> > called from syscore and thus we can't sleep?
>
> I thought that clk_disable() was enough. We don't actually need to
> unprepare, do we? And yes, as you pointed out, this call cannot sleep.
Yeah unprepare isn't necessary, but it will be different on different
platforms. This is a highly platform specific driver though so I suspect
this is all fine.
next prev parent reply other threads:[~2019-06-25 23:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-24 22:57 [PATCH v13 00/13] Ingenic Timer/Counter Unit patchset v13 Paul Cercueil
2019-06-24 22:57 ` [PATCH v13 01/13] dt-bindings: ingenic: Add DT bindings for TCU clocks Paul Cercueil
2019-06-24 22:57 ` [PATCH v13 02/13] doc: Add doc for the Ingenic TCU hardware Paul Cercueil
2019-06-25 6:44 ` Thomas Gleixner
2019-06-24 22:57 ` [PATCH v13 03/13] dt-bindings: Add doc for the Ingenic TCU drivers Paul Cercueil
2019-06-24 22:57 ` [PATCH v13 04/13] mfd: Add Ingenic TCU driver Paul Cercueil
2019-06-25 17:30 ` Paul Burton
2019-06-25 17:47 ` Paul Cercueil
2019-06-24 22:57 ` [PATCH v13 05/13] clk: ingenic: Add driver for the TCU clocks Paul Cercueil
2019-06-25 22:09 ` Stephen Boyd
2019-06-25 22:37 ` Paul Cercueil
2019-06-25 23:28 ` Stephen Boyd [this message]
2019-06-24 22:57 ` [PATCH v13 06/13] irqchip: Add irq-ingenic-tcu driver Paul Cercueil
2019-06-25 6:51 ` Thomas Gleixner
2019-06-24 22:57 ` [PATCH v13 07/13] clocksource: Add a new timer-ingenic driver Paul Cercueil
2019-06-25 6:53 ` Thomas Gleixner
2019-06-24 22:57 ` [PATCH v13 08/13] clk: jz4740: Add TCU clock Paul Cercueil
2019-06-24 22:57 ` [PATCH v13 09/13] MIPS: jz4740: Add DTS nodes for the TCU drivers Paul Cercueil
2019-06-24 22:57 ` [PATCH v13 10/13] MIPS: qi_lb60: Reduce system timer and clocksource to 750 kHz Paul Cercueil
2019-06-24 22:57 ` [PATCH v13 11/13] MIPS: CI20: Reduce system timer and clocksource to 3 MHz Paul Cercueil
2019-06-24 22:57 ` [PATCH v13 12/13] MIPS: GCW0: Reduce system timer and clocksource to 750 kHz Paul Cercueil
2019-06-24 22:57 ` [PATCH v13 13/13] MIPS: jz4740: Drop obsolete code Paul Cercueil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190625232820.D1D4A20645@mail.kernel.org \
--to=sboyd@kernel.org \
--cc=contact@artur-rojek.eu \
--cc=corbet@lwn.net \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jason@lakedaemon.net \
--cc=jhogan@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=malat@debian.org \
--cc=marc.zyngier@arm.com \
--cc=mturquette@baylibre.com \
--cc=od@zcrc.me \
--cc=paul.burton@mips.com \
--cc=paul@crapouillou.net \
--cc=ralf@linux-mips.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).