From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D1D8C7618B for ; Fri, 26 Jul 2019 13:45:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F34FC22CBF for ; Fri, 26 Jul 2019 13:45:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564148734; bh=wwV7PLvh/xNrnph6E42cP4uISJHCMYeOAQ0JA0g11bA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=wvlueIOpR3g4xtaQuCkDy0xhJFW/dms8DGwcN0mAt7TSK8DByXxinElq4aasxLXbl YPJiqoFOsMyMC7c5/5GUVg0+NLnJmhvYIZ5gKoUPDGmaeXfU5yrdVFVX6iUG3AhIoY TDkLu0jghyIb7APeETJnwVrgmWHiUwcDALKGWQMY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728150AbfGZNpd (ORCPT ); Fri, 26 Jul 2019 09:45:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:54460 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388180AbfGZNp2 (ORCPT ); Fri, 26 Jul 2019 09:45:28 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E16A422CEC; Fri, 26 Jul 2019 13:45:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564148727; bh=wwV7PLvh/xNrnph6E42cP4uISJHCMYeOAQ0JA0g11bA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Hz5tEiR6VndKF1BvkE13IC4q1cuDGKtkzoYyyd/LD+io7J4fq8JOU4oqk3QPnp23e FsKltSXNgATwqpyvqDgFniYXaogCv5pBNN4PkBBH4mRLK1inIme7eZDSvsuEurkwWL GNRTxMTa8qrk2HOmmflHkZwLo9F21NkbYxMw7vSs= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Petr Cvek , Paul Burton , hauke@hauke-m.de, john@phrozen.org, linux-mips@vger.kernel.org, openwrt-devel@lists.openwrt.org, pakahmar@hotmail.com, Sasha Levin Subject: [PATCH AUTOSEL 4.4 04/23] MIPS: lantiq: Fix bitfield masking Date: Fri, 26 Jul 2019 09:45:03 -0400 Message-Id: <20190726134522.13308-4-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190726134522.13308-1-sashal@kernel.org> References: <20190726134522.13308-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org From: Petr Cvek [ Upstream commit ba1bc0fcdeaf3bf583c1517bd2e3e29cf223c969 ] The modification of EXIN register doesn't clean the bitfield before the writing of a new value. After a few modifications the bitfield would accumulate only '1's. Signed-off-by: Petr Cvek Signed-off-by: Paul Burton Cc: hauke@hauke-m.de Cc: john@phrozen.org Cc: linux-mips@vger.kernel.org Cc: openwrt-devel@lists.openwrt.org Cc: pakahmar@hotmail.com Signed-off-by: Sasha Levin --- arch/mips/lantiq/irq.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/mips/lantiq/irq.c b/arch/mips/lantiq/irq.c index 2e7f60c9fc5d..a7057a06c096 100644 --- a/arch/mips/lantiq/irq.c +++ b/arch/mips/lantiq/irq.c @@ -160,8 +160,9 @@ static int ltq_eiu_settype(struct irq_data *d, unsigned int type) if (edge) irq_set_handler(d->hwirq, handle_edge_irq); - ltq_eiu_w32(ltq_eiu_r32(LTQ_EIU_EXIN_C) | - (val << (i * 4)), LTQ_EIU_EXIN_C); + ltq_eiu_w32((ltq_eiu_r32(LTQ_EIU_EXIN_C) & + (~(7 << (i * 4)))) | (val << (i * 4)), + LTQ_EIU_EXIN_C); } } -- 2.20.1