* [PATCH] irqchip/irq-ingenic-tcu: Fix COMPILE_TEST building
@ 2019-08-13 1:56 YueHaibing
2019-08-16 12:28 ` Thomas Gleixner
2019-08-19 21:17 ` Paul Burton
0 siblings, 2 replies; 5+ messages in thread
From: YueHaibing @ 2019-08-13 1:56 UTC (permalink / raw)
To: tglx, jason, maz, paul, malat, paul.burton
Cc: linux-kernel, linux-mips, linux-clk, YueHaibing
While do COMPILE_TEST building, if GENERIC_IRQ_CHIP is
not selected, it fails:
drivers/irqchip/irq-ingenic-tcu.o: In function `ingenic_tcu_intc_cascade':
irq-ingenic-tcu.c:(.text+0x13f): undefined reference to `irq_get_domain_generic_chip'
drivers/irqchip/irq-ingenic-tcu.o: In function `ingenic_tcu_irq_init':
irq-ingenic-tcu.c:(.init.text+0x97): undefined reference to `irq_generic_chip_ops'
irq-ingenic-tcu.c:(.init.text+0xdd): undefined reference to `__irq_alloc_domain_generic_chips'
irq-ingenic-tcu.c:(.init.text+0x10b): undefined reference to `irq_get_domain_generic_chip'
select GENERIC_IRQ_CHIP to fix this.
Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: 9536eba03ec7 ("irqchip: Add irq-ingenic-tcu driver")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/irqchip/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index 3c8308e..ccbb897 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -320,6 +320,7 @@ config INGENIC_TCU_IRQ
default MACH_INGENIC
depends on MIPS || COMPILE_TEST
select MFD_SYSCON
+ select GENERIC_IRQ_CHIP
help
Support for interrupts in the Timer/Counter Unit (TCU) of the Ingenic
JZ47xx SoCs.
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] irqchip/irq-ingenic-tcu: Fix COMPILE_TEST building
2019-08-13 1:56 [PATCH] irqchip/irq-ingenic-tcu: Fix COMPILE_TEST building YueHaibing
@ 2019-08-16 12:28 ` Thomas Gleixner
2019-08-16 20:19 ` Paul Burton
2019-08-19 21:17 ` Paul Burton
1 sibling, 1 reply; 5+ messages in thread
From: Thomas Gleixner @ 2019-08-16 12:28 UTC (permalink / raw)
To: YueHaibing
Cc: jason, maz, paul, malat, paul.burton, linux-kernel, linux-mips,
linux-clk
On Tue, 13 Aug 2019, YueHaibing wrote:
> While do COMPILE_TEST building, if GENERIC_IRQ_CHIP is
> not selected, it fails:
>
> drivers/irqchip/irq-ingenic-tcu.o: In function `ingenic_tcu_intc_cascade':
> irq-ingenic-tcu.c:(.text+0x13f): undefined reference to `irq_get_domain_generic_chip'
> drivers/irqchip/irq-ingenic-tcu.o: In function `ingenic_tcu_irq_init':
> irq-ingenic-tcu.c:(.init.text+0x97): undefined reference to `irq_generic_chip_ops'
> irq-ingenic-tcu.c:(.init.text+0xdd): undefined reference to `__irq_alloc_domain_generic_chips'
> irq-ingenic-tcu.c:(.init.text+0x10b): undefined reference to `irq_get_domain_generic_chip'
>
> select GENERIC_IRQ_CHIP to fix this.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 9536eba03ec7 ("irqchip: Add irq-ingenic-tcu driver")
git show 9536eba03ec7
fatal: ambiguous argument '9536eba03ec7': unknown revision or path not in
the working tree.
Thanks,
tglx
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] irqchip/irq-ingenic-tcu: Fix COMPILE_TEST building
2019-08-16 12:28 ` Thomas Gleixner
@ 2019-08-16 20:19 ` Paul Burton
2019-08-16 20:41 ` Thomas Gleixner
0 siblings, 1 reply; 5+ messages in thread
From: Paul Burton @ 2019-08-16 20:19 UTC (permalink / raw)
To: Thomas Gleixner
Cc: YueHaibing, jason, maz, paul, malat, linux-kernel, linux-mips, linux-clk
Hi Thomas,
On Fri, Aug 16, 2019 at 02:28:42PM +0200, Thomas Gleixner wrote:
> On Tue, 13 Aug 2019, YueHaibing wrote:
>
> > While do COMPILE_TEST building, if GENERIC_IRQ_CHIP is
> > not selected, it fails:
> >
> > drivers/irqchip/irq-ingenic-tcu.o: In function `ingenic_tcu_intc_cascade':
> > irq-ingenic-tcu.c:(.text+0x13f): undefined reference to `irq_get_domain_generic_chip'
> > drivers/irqchip/irq-ingenic-tcu.o: In function `ingenic_tcu_irq_init':
> > irq-ingenic-tcu.c:(.init.text+0x97): undefined reference to `irq_generic_chip_ops'
> > irq-ingenic-tcu.c:(.init.text+0xdd): undefined reference to `__irq_alloc_domain_generic_chips'
> > irq-ingenic-tcu.c:(.init.text+0x10b): undefined reference to `irq_get_domain_generic_chip'
> >
> > select GENERIC_IRQ_CHIP to fix this.
> >
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Fixes: 9536eba03ec7 ("irqchip: Add irq-ingenic-tcu driver")
>
> git show 9536eba03ec7
>
> fatal: ambiguous argument '9536eba03ec7': unknown revision or path not in
> the working tree.
The referenced patch is in mips-next - can I get your Ack to apply this
there too?
Thanks,
Paul
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] irqchip/irq-ingenic-tcu: Fix COMPILE_TEST building
2019-08-16 20:19 ` Paul Burton
@ 2019-08-16 20:41 ` Thomas Gleixner
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Gleixner @ 2019-08-16 20:41 UTC (permalink / raw)
To: Paul Burton
Cc: YueHaibing, jason, maz, paul, malat, linux-kernel, linux-mips, linux-clk
On Fri, 16 Aug 2019, Paul Burton wrote:
> On Fri, Aug 16, 2019 at 02:28:42PM +0200, Thomas Gleixner wrote:
> > On Tue, 13 Aug 2019, YueHaibing wrote:
> >
> > > While do COMPILE_TEST building, if GENERIC_IRQ_CHIP is
> > > not selected, it fails:
> > >
> > > drivers/irqchip/irq-ingenic-tcu.o: In function `ingenic_tcu_intc_cascade':
> > > irq-ingenic-tcu.c:(.text+0x13f): undefined reference to `irq_get_domain_generic_chip'
> > > drivers/irqchip/irq-ingenic-tcu.o: In function `ingenic_tcu_irq_init':
> > > irq-ingenic-tcu.c:(.init.text+0x97): undefined reference to `irq_generic_chip_ops'
> > > irq-ingenic-tcu.c:(.init.text+0xdd): undefined reference to `__irq_alloc_domain_generic_chips'
> > > irq-ingenic-tcu.c:(.init.text+0x10b): undefined reference to `irq_get_domain_generic_chip'
> > >
> > > select GENERIC_IRQ_CHIP to fix this.
> > >
> > > Reported-by: Hulk Robot <hulkci@huawei.com>
> > > Fixes: 9536eba03ec7 ("irqchip: Add irq-ingenic-tcu driver")
> >
> > git show 9536eba03ec7
> >
> > fatal: ambiguous argument '9536eba03ec7': unknown revision or path not in
> > the working tree.
>
> The referenced patch is in mips-next - can I get your Ack to apply this
> there too?
Sure. Acked-by-me :)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] irqchip/irq-ingenic-tcu: Fix COMPILE_TEST building
2019-08-13 1:56 [PATCH] irqchip/irq-ingenic-tcu: Fix COMPILE_TEST building YueHaibing
2019-08-16 12:28 ` Thomas Gleixner
@ 2019-08-19 21:17 ` Paul Burton
1 sibling, 0 replies; 5+ messages in thread
From: Paul Burton @ 2019-08-19 21:17 UTC (permalink / raw)
To: YueHaibing
Cc: tglx, jason, maz, paul, malat, Paul Burton, linux-kernel,
linux-mips, linux-clk, YueHaibing, linux-mips
Hello,
YueHaibing wrote:
> While do COMPILE_TEST building, if GENERIC_IRQ_CHIP is
> not selected, it fails:
>
> drivers/irqchip/irq-ingenic-tcu.o: In function `ingenic_tcu_intc_cascade':
> irq-ingenic-tcu.c:(.text+0x13f): undefined reference to `irq_get_domain_generic_chip'
> drivers/irqchip/irq-ingenic-tcu.o: In function `ingenic_tcu_irq_init':
> irq-ingenic-tcu.c:(.init.text+0x97): undefined reference to `irq_generic_chip_ops'
> irq-ingenic-tcu.c:(.init.text+0xdd): undefined reference to `__irq_alloc_domain_generic_chips'
> irq-ingenic-tcu.c:(.init.text+0x10b): undefined reference to `irq_get_domain_generic_chip'
>
> select GENERIC_IRQ_CHIP to fix this.
Applied to mips-next.
> commit 8084499bd7d4
> https://git.kernel.org/mips/c/8084499bd7d4
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 9536eba03ec7 ("irqchip: Add irq-ingenic-tcu driver")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> Acked-by: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Paul Burton <paul.burton@mips.com>
Thanks,
Paul
[ This message was auto-generated; if you believe anything is incorrect
then please email paul.burton@mips.com to report it. ]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-08-19 21:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-13 1:56 [PATCH] irqchip/irq-ingenic-tcu: Fix COMPILE_TEST building YueHaibing
2019-08-16 12:28 ` Thomas Gleixner
2019-08-16 20:19 ` Paul Burton
2019-08-16 20:41 ` Thomas Gleixner
2019-08-19 21:17 ` Paul Burton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).