From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C67C9C3A5A1 for ; Wed, 28 Aug 2019 22:58:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9C68E2339E for ; Wed, 28 Aug 2019 22:58:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="rczdY01A" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726941AbfH1W6j (ORCPT ); Wed, 28 Aug 2019 18:58:39 -0400 Received: from mail-ed1-f67.google.com ([209.85.208.67]:37793 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726844AbfH1W6e (ORCPT ); Wed, 28 Aug 2019 18:58:34 -0400 Received: by mail-ed1-f67.google.com with SMTP id f22so1821868edt.4 for ; Wed, 28 Aug 2019 15:58:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=MWIFKIzouiKNiGjOqNU3Lg2whivTBv+XNz2yxpVpVdk=; b=rczdY01AKrKa0uF52azBBxJb1SYipY6u79S6FnAjJZbqKBaWR4bEt5Q1F/z+gPOmV8 2LgNnTLUtcsNPBxAimDjDrKhK0XRpX2UbKs39RWkqXGG9vFmXddS5Chm8nmO/ctPLS/W 7Q3E4uzkWIt60Md8eSjv8qlbJC/ug1geug3/TgIL/4PFwjIPXZfAbBt8c5t0Zy4vZbJE zAOpSAmCM9V6Pw/rW6+TDwunxdFqfAuY2uHJ24RM3iuy1UP6oeVKO7wlEexYBwI5EEZG aCfhrSzLY3b5JnFMCUmlK4fswrNsctSFSCY1XQ93oEnydxJoaICx83awfv8BwNZUXeMX 4aag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=MWIFKIzouiKNiGjOqNU3Lg2whivTBv+XNz2yxpVpVdk=; b=pcm2CI4S1EdLOvw1D1ArMUCe5m4f2dqG/F8n8yJkwjN+7kCMIZ0Hyk8hN6NvM66+wU VAZiccwFSKUoykKSaSVGZJsBU+GgIK35cuLdszrBAgtcopKcAnu/HcTBHjWV1AnqD4A6 17NpoKehzSa5BYq81kzZ+zm7+WH44W6bQb5TG5WlPBNkOfMRZXrMOO92A5szSYEFbTpl bb+GXQ57E+gN2LpMhWqr9bVC6EwwiUJlz6/O0zj+iDGKEcfVq3EyXi5oSq+lkP8FcLx0 utF7SmhPpupz6bMApzUcSvxkaYWFfbjuyHxIkw4x5w92sZtyr7qmkV1q1DNx3VTtYM7j Tu1A== X-Gm-Message-State: APjAAAXc1HVl87ToaUWTqw5f1QDiX63qGv3EM5oV4NGzrP2pmyeZzz7J tE/1hpACwgz2BVHk1RJFoZCfNw== X-Google-Smtp-Source: APXvYqzlwrSyUeO/iZbE6dDzW6rjW3NYftlJjlyPkx6b8TsSKh+G73SS2+o4rdG+5KdBZyEOmHOotw== X-Received: by 2002:aa7:da4d:: with SMTP id w13mr6716505eds.224.1567033112940; Wed, 28 Aug 2019 15:58:32 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id k15sm101111ejk.46.2019.08.28.15.58.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Aug 2019 15:58:32 -0700 (PDT) Date: Wed, 28 Aug 2019 15:58:09 -0700 From: Jakub Kicinski To: Thomas Bogendoerfer Cc: Ralf Baechle , Paul Burton , James Hogan , "David S. Miller" , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next 05/15] net: sgi: ioc3-eth: allocate space for desc rings only once Message-ID: <20190828155809.5c155bee@cakuba.netronome.com> In-Reply-To: <20190828140315.17048-6-tbogendoerfer@suse.de> References: <20190828140315.17048-1-tbogendoerfer@suse.de> <20190828140315.17048-6-tbogendoerfer@suse.de> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Wed, 28 Aug 2019 16:03:04 +0200, Thomas Bogendoerfer wrote: > Memory for descriptor rings are allocated/freed, when interface is > brought up/down. Since the size of the rings is not changeable by > hardware, we now allocate rings now during probe and free it, when > device is removed. > > Signed-off-by: Thomas Bogendoerfer So the rings still get freed and allocated from ioc3_init() but there's a set allocated from the start? I guess that makes some sense.. Most drivers will allocate rings in open() and free them in close().