* [PATCH] mips: Loongson: Fix the link time qualifier of 'serial_exit()'
@ 2019-09-10 3:59 Christophe JAILLET
2019-10-02 22:54 ` Paul Burton
0 siblings, 1 reply; 2+ messages in thread
From: Christophe JAILLET @ 2019-09-10 3:59 UTC (permalink / raw)
To: chenhc, ralf, paul.burton, jhogan
Cc: linux-mips, linux-kernel, kernel-janitors, Christophe JAILLET
'exit' functions should be marked as __exit, not __init.
Fixes: 85cc028817ef ("mips: make loongsoon serial driver explicitly modular")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
arch/mips/loongson64/common/serial.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/loongson64/common/serial.c b/arch/mips/loongson64/common/serial.c
index ffefc1cb2612..98c3a7feb10f 100644
--- a/arch/mips/loongson64/common/serial.c
+++ b/arch/mips/loongson64/common/serial.c
@@ -110,7 +110,7 @@ static int __init serial_init(void)
}
module_init(serial_init);
-static void __init serial_exit(void)
+static void __exit serial_exit(void)
{
platform_device_unregister(&uart8250_device);
}
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mips: Loongson: Fix the link time qualifier of 'serial_exit()'
2019-09-10 3:59 [PATCH] mips: Loongson: Fix the link time qualifier of 'serial_exit()' Christophe JAILLET
@ 2019-10-02 22:54 ` Paul Burton
0 siblings, 0 replies; 2+ messages in thread
From: Paul Burton @ 2019-10-02 22:54 UTC (permalink / raw)
To: Christophe JAILLET
Cc: chenhc, ralf, Paul Burton, jhogan, linux-mips, linux-kernel,
kernel-janitors, Christophe JAILLET, linux-mips
Hello,
Christophe JAILLET wrote:
> 'exit' functions should be marked as __exit, not __init.
Applied to mips-fixes.
> commit 25b69a889b63
> https://git.kernel.org/mips/c/25b69a889b63
>
> Fixes: 85cc028817ef ("mips: make loongsoon serial driver explicitly modular")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Signed-off-by: Paul Burton <paul.burton@mips.com>
Thanks,
Paul
[ This message was auto-generated; if you believe anything is incorrect
then please email paul.burton@mips.com to report it. ]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-02 22:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-10 3:59 [PATCH] mips: Loongson: Fix the link time qualifier of 'serial_exit()' Christophe JAILLET
2019-10-02 22:54 ` Paul Burton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).