From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B261ECE599 for ; Wed, 16 Oct 2019 06:19:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0CE1720873 for ; Wed, 16 Oct 2019 06:19:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gffNxPX5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728515AbfJPGTB (ORCPT ); Wed, 16 Oct 2019 02:19:01 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:46374 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728091AbfJPGTB (ORCPT ); Wed, 16 Oct 2019 02:19:01 -0400 Received: by mail-wr1-f66.google.com with SMTP id o18so26446653wrv.13 for ; Tue, 15 Oct 2019 23:18:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=YRhrTB62D4V/UFoC3f7Dy9VxNzwea0kYw4JJIDyNnSU=; b=gffNxPX59uLp8d/gUW5M7E6+ht3fLmLfSJgrgYUe1tI7Afeyq6CzJQ+74I6+AmU/z/ LCxua/tgSJOllX2PjdMVZeJvnP0ag9dr/fxDqwqp/VddGOOGCVTOTcUt0EU2EnzWOTqU RxXnz4wgoSk81+fFaU14kCZSCs3zePHw0unCHMU0JPUBY5lIPVNvqiZnZ04YBtvQKgDQ HpdVT8WRcKE9oDhNiAVcKWTT0LS3Yqc1Ultg55vUfNYknQMR/m9KWI0GKJlDKkLdc9rj OdjIf4UnX2hBqQMJACFydhYY7OgZIs841Bu3TJXMwsNzfUGHuD6/H97Ls+FNG+P7MyTQ zYKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=YRhrTB62D4V/UFoC3f7Dy9VxNzwea0kYw4JJIDyNnSU=; b=E4a9VzNGVSrZZsa7EpDO/3Gb49Zp+Qg26dGTJh8q8MGoTTKZGY6sPYCKGPtFiYZZO1 8bzClkhl+FkBZoIpdcHliniPFwuFltUBvl1szZL7VWH9V7ZAn/XBZBJ0ydRwYqeyLsxD uYs1cpiKe21oO2PkwIWIdwmZec1TtZRdRldMGpQ65rlWg0LxdN0kgeDHjlXnWO1atTem Wx2IQPVmd1LOndj2/4ftWnfpTXgygCTQtrg/xKCePzGwTT1FwCGcDCOd8prFnixqFwvO xvIV0sBVbRi1xcwj+OE8FjQufspqIudPBRqmqglV0/vNvrihwQjxInJkjIIovieaHqsS QGCw== X-Gm-Message-State: APjAAAV4r1Yhpp8/Nnzy94n8ee2vpc9Sg25ponvlf0jJ4bRCpH1N5oD/ Phudf8AGraE9FKGYTx+8V/0fhQ== X-Google-Smtp-Source: APXvYqyKm24zfNyAXdbf8pS+DsTWKRvLuNz2vGQv6C7u2rAu4IGWRBvmbdVbgFvVvDmpGDOwl7yD5w== X-Received: by 2002:adf:c98b:: with SMTP id f11mr1155362wrh.274.1571206738605; Tue, 15 Oct 2019 23:18:58 -0700 (PDT) Received: from dell ([95.149.164.86]) by smtp.gmail.com with ESMTPSA id a3sm3004392wmc.3.2019.10.15.23.18.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 15 Oct 2019 23:18:57 -0700 (PDT) Date: Wed, 16 Oct 2019 07:18:56 +0100 From: Lee Jones To: Jakub Kicinski Cc: Thomas Bogendoerfer , Jonathan Corbet , Ralf Baechle , Paul Burton , James Hogan , "David S. Miller" , Srinivas Kandagatla , Alessandro Zummo , Alexandre Belloni , Greg Kroah-Hartman , Jiri Slaby , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, netdev@vger.kernel.org, linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH v10 4/6] mfd: ioc3: Add driver for SGI IOC3 chip Message-ID: <20191016061856.GA4365@dell> References: <20191015120953.2597-1-tbogendoerfer@suse.de> <20191015120953.2597-5-tbogendoerfer@suse.de> <20191015122349.612a230b@cakuba.netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20191015122349.612a230b@cakuba.netronome.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Tue, 15 Oct 2019, Jakub Kicinski wrote: > On Tue, 15 Oct 2019 14:09:49 +0200, Thomas Bogendoerfer wrote: > > SGI IOC3 chip has integrated ethernet, keyboard and mouse interface. > > It also supports connecting a SuperIO chip for serial and parallel > > interfaces. IOC3 is used inside various SGI systemboards and add-on > > cards with different equipped external interfaces. > > > > Support for ethernet and serial interfaces were implemented inside > > the network driver. This patchset moves out the not network related > > parts to a new MFD driver, which takes care of card detection, > > setup of platform devices and interrupt distribution for the subdevices. > > > > Serial portion: Acked-by: Greg Kroah-Hartman > > Acked-for-MFD-by: Lee Jones > > > > Signed-off-by: Thomas Bogendoerfer > > Looks good, I think. Is that a Reviewed-by? If so, it doesn't sound like a very convincing one? If not, it's probably not worth replying at all. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog