From: Paul Burton <paulburton@kernel.org>
To: Sergio Paracuellos <sergio.paracuellos@gmail.com>,
Hauke Mehrtens <hauke@hauke-m.de>
Cc: Paul Burton <paul.burton@mips.com>,
ralf@linux-mips.org, jhogan@kernel.org, john@phrozen.org,
NeilBrown <neil@brown.name>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-mips@vger.kernel.org
Subject: Re: [PATCH RESEND] MIPS: ralink: enable PCI support only if driver for mt7621 SoC is selected
Date: Thu, 31 Oct 2019 14:36:56 -0700 [thread overview]
Message-ID: <20191031213656.iycqiijz3nd5xtkr@lantea.localdomain> (raw)
In-Reply-To: <20191031071124.22102-1-sergio.paracuellos@gmail.com>
Hi Sergio,
On Thu, Oct 31, 2019 at 08:11:24AM +0100, Sergio Paracuellos wrote:
> diff --git a/arch/mips/ralink/Kconfig b/arch/mips/ralink/Kconfig
> index 1434fa60f3db..94e9ce994494 100644
> --- a/arch/mips/ralink/Kconfig
> +++ b/arch/mips/ralink/Kconfig
> @@ -51,6 +51,7 @@ choice
> select MIPS_GIC
> select COMMON_CLK
> select CLKSRC_MIPS_GIC
> + select HAVE_PCI if PCI_MT7621
> endchoice
>
> choice
> diff --git a/drivers/staging/mt7621-pci/Kconfig b/drivers/staging/mt7621-pci/Kconfig
> index af928b75a940..ce58042f2f21 100644
> --- a/drivers/staging/mt7621-pci/Kconfig
> +++ b/drivers/staging/mt7621-pci/Kconfig
> @@ -2,7 +2,6 @@
> config PCI_MT7621
> tristate "MediaTek MT7621 PCI Controller"
> depends on RALINK
> - depends on PCI
> select PCI_DRIVERS_GENERIC
> help
> This selects a driver for the MediaTek MT7621 PCI Controller.
This doesn't seem right to me - doesn't this now allow the PCI
controller driver to build without PCI support enabled? Are you sure
that won't allow more build failures?
How does enabling the driver change whether or not the SoC has PCI
support? The SoC is always the same hardware regardless of whether you
enable the driver for it, so this doesn't seem right to me.
Hauke - do you recall what the build failure you mentioned in commit
c4d48cf5e2f0 ("MIPS: ralink: deactivate PCI support for SOC_MT7621")
was?
Thanks,
Paul
next prev parent reply other threads:[~2019-10-31 21:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-31 7:11 [PATCH RESEND] MIPS: ralink: enable PCI support only if driver for mt7621 SoC is selected Sergio Paracuellos
2019-10-31 21:36 ` Paul Burton [this message]
2019-11-01 5:08 ` Sergio Paracuellos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191031213656.iycqiijz3nd5xtkr@lantea.localdomain \
--to=paulburton@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hauke@hauke-m.de \
--cc=jhogan@kernel.org \
--cc=john@phrozen.org \
--cc=linux-mips@vger.kernel.org \
--cc=neil@brown.name \
--cc=paul.burton@mips.com \
--cc=ralf@linux-mips.org \
--cc=sergio.paracuellos@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).