From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DB59C432C3 for ; Mon, 25 Nov 2019 15:46:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6F36820866 for ; Mon, 25 Nov 2019 15:46:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728565AbfKYPq1 (ORCPT ); Mon, 25 Nov 2019 10:46:27 -0500 Received: from muru.com ([72.249.23.125]:43484 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728554AbfKYPq1 (ORCPT ); Mon, 25 Nov 2019 10:46:27 -0500 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 3A89A80EA; Mon, 25 Nov 2019 15:47:02 +0000 (UTC) Date: Mon, 25 Nov 2019 07:46:21 -0800 From: Tony Lindgren To: "H. Nikolaus Schaller" Cc: Paul Cercueil , David Airlie , Daniel Vetter , Rob Herring , Mark Rutland , =?utf-8?Q?Beno=C3=AEt?= Cousson , Ralf Baechle , Paul Burton , James Hogan , dri-devel , devicetree , Linux Kernel Mailing List , Linux-OMAP , OpenPVRSGX Linux Driver Group , Discussions about the Letux Kernel , kernel@pyra-handheld.com, linux-mips@vger.kernel.org, Paul Boddie Subject: Re: [PATCH v3 8/8] MIPS: DTS: jz4780: add sgx gpu node Message-ID: <20191125154621.GY35479@atomide.com> References: <1574600246.3.0@crapouillou.net> <20191124174837.GX35479@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org * H. Nikolaus Schaller [191124 18:00]: > Hi Paul, Tony, > > > Am 24.11.2019 um 18:48 schrieb Tony Lindgren : > > > > * Paul Cercueil [191124 12:58]: > >> Le dim., nov. 24, 2019 at 12:40, H. Nikolaus Schaller a > >> écrit : > >>> and add interrupt and clocks. > > ... > >>> --- a/arch/mips/boot/dts/ingenic/jz4780.dtsi > >>> +++ b/arch/mips/boot/dts/ingenic/jz4780.dtsi > >>> @@ -46,6 +46,17 @@ > >>> #clock-cells = <1>; > >>> }; > >>> > >>> + gpu: gpu@13040000 { > >> > >> We try to keep the nodes ordered by address, could you move this node where > >> it belongs? > > ... > > Yes, I have noted. > > > > >>> + compatible = "ingenic,jz4780-sgx540-120", "img,sgx540-120", > >>> "img,sgx540", "img,sgx5"; > >>> + reg = <0x13040000 0x4000>; > >>> + > >>> + clocks = <&cgu JZ4780_CLK_GPU>; > >>> + clock-names = "gpu"; > > > > Just checking.. Is there something else to configure here > > potentially in addition to the clocks? > > It doesn't look so. Unfortuantely there isn't much information > except a v3.18 kernel supported by the vendor and that one also > just has a gpu node with clock control. > > > That is, do we need to do some interconnect specific > > configuration etc in addition to the clocks to have > > runtime PM work for enabling and disabling sgx on > > jz4780? > > I think we have to leave that open for further study. OK for now, let's assume we just need to call clk_enable/disable from the PM runtime functions if a clock exists. Regards, Tony