From: Daniel Borkmann <daniel@iogearbox.net>
To: Alexander Lobakin <alobakin@dlink.ru>
Cc: Paul Burton <paul.burton@mips.com>,
Hassan Naveed <hnaveed@wavecomp.com>,
Ralf Baechle <ralf@linux-mips.org>,
James Hogan <jhogan@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>, Andrii Nakryiko <andriin@fb.com>,
netdev@vger.kernel.org, bpf@vger.kernel.org,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: MIPS eBPF JIT support on pre-32R2
Date: Thu, 5 Dec 2019 14:04:09 +0100 [thread overview]
Message-ID: <20191205130409.GC29780@localhost.localdomain> (raw)
In-Reply-To: <09d713a59665d745e21d021deeaebe0a@dlink.ru>
On Thu, Dec 05, 2019 at 03:45:27PM +0300, Alexander Lobakin wrote:
> Hey all,
>
> I'm writing about lines arch/mips/net/ebpf_jit.c:1806-1807:
>
> if (!prog->jit_requested || MIPS_ISA_REV < 2)
> return prog;
>
> Do pre-32R2 architectures (32R1, maybe even R3000-like) actually support
> this eBPF JIT code? If they do, then the condition 'MIPS_ISA_REV < 2'
> should be removed as it is always true for them and tells CC to remove
> JIT completely.
>
> If they don't support instructions from this JIT, then the line
> arch/mips/Kconfig:50:
>
> select HAVE_EBPF_JIT if (!CPU_MICROMIPS)
>
> should be changed to something like:
>
> select HAVE_EBPF_JIT if !CPU_MICROMIPS && TARGET_ISA_REV >= 2
>
> (and then the mentioned 'if' condition would become redundant)
>
> At the moment it is possible to build a kernel without both JIT and
> interpreter, but with CONFIG_BPF_SYSCALL=y (what should not be allowed
> I suppose?) within the following configuration:
Cannot comment on the MIPS ISA question above, but it would definiely be
a bug to build a kernel with neither JIT nor interpreter. If a JIT is not
available, then there /must/ be the interpreter as fallback to be able to
run BPF programs.
> - select any pre-32R2 CPU (e.g. CONFIG_CPU_MIPS32_R1);
> - enable CONFIG_BPF_JIT (CONFIG_MIPS_EBPF_JIT will be autoselected);
> - enable CONFIG_BPF_JIT_ALWAYS_ON (this removes BPF interpreter from
> the system).
>
> I may prepare a proper patch by myself if needed (after clarification).
> Thanks.
>
> Regards,
> ᚷ ᛖ ᚢ ᚦ ᚠ ᚱ
next prev parent reply other threads:[~2019-12-05 13:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-05 12:45 Alexander Lobakin
2019-12-05 13:04 ` Daniel Borkmann [this message]
2019-12-05 18:44 ` Paul Burton
2019-12-06 7:20 ` Alexander Lobakin
2019-12-06 8:11 ` Alexander Lobakin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191205130409.GC29780@localhost.localdomain \
--to=daniel@iogearbox.net \
--cc=alobakin@dlink.ru \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=hnaveed@wavecomp.com \
--cc=jhogan@kernel.org \
--cc=kafai@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paul.burton@mips.com \
--cc=ralf@linux-mips.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
--subject='Re: MIPS eBPF JIT support on pre-32R2' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).