linux-mips.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: jouni.hogander@unikie.com
To: linux-mips@vger.kernel.org
Cc: Jouni Hogander <jouni.hogander@unikie.com>,
	Paul Burton <paulburton@kernel.org>,
	Lukas Bulwahn <lukas.bulwahn@gmail.com>
Subject: [PATCH] MIPS: Prevent link failure with kcov instrumentation
Date: Mon,  9 Dec 2019 14:37:07 +0200	[thread overview]
Message-ID: <20191209123707.19693-1-jouni.hogander@unikie.com> (raw)

From: Jouni Hogander <jouni.hogander@unikie.com>

__sanitizer_cov_trace_pc() is not linked in and causing link
failure if KCOV_INSTRUMENT is enabled. Fix this by disabling
instrumentation for compressed image.

Cc: Paul Burton <paulburton@kernel.org>
Cc: Lukas Bulwahn <lukas.bulwahn@gmail.com>

Signed-off-by: Jouni Hogander <jouni.hogander@unikie.com>
---
 arch/mips/boot/compressed/Makefile | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/mips/boot/compressed/Makefile b/arch/mips/boot/compressed/Makefile
index 172801ed35b8..d859f079b771 100644
--- a/arch/mips/boot/compressed/Makefile
+++ b/arch/mips/boot/compressed/Makefile
@@ -29,6 +29,9 @@ KBUILD_AFLAGS := $(KBUILD_AFLAGS) -D__ASSEMBLY__ \
 	-DBOOT_HEAP_SIZE=$(BOOT_HEAP_SIZE) \
 	-DKERNEL_ENTRY=$(VMLINUX_ENTRY_ADDRESS)
 
+# Prevents link failures: __sanitizer_cov_trace_pc() is not linked in.
+KCOV_INSTRUMENT		:= n
+
 # decompressor objects (linked with vmlinuz)
 vmlinuzobjs-y := $(obj)/head.o $(obj)/decompress.o $(obj)/string.o
 
-- 
2.17.1


             reply	other threads:[~2019-12-09 12:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-09 12:37 jouni.hogander [this message]
2019-12-09 18:48 ` Paul Burton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191209123707.19693-1-jouni.hogander@unikie.com \
    --to=jouni.hogander@unikie.com \
    --cc=linux-mips@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    --cc=paulburton@kernel.org \
    --subject='Re: [PATCH] MIPS: Prevent link failure with kcov instrumentation' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).