From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 562CAC3F68F for ; Wed, 18 Dec 2019 16:40:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2B54D2146E for ; Wed, 18 Dec 2019 16:40:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727381AbfLRQkA (ORCPT ); Wed, 18 Dec 2019 11:40:00 -0500 Received: from mga07.intel.com ([134.134.136.100]:30982 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727124AbfLRQkA (ORCPT ); Wed, 18 Dec 2019 11:40:00 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Dec 2019 08:39:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,330,1571727600"; d="scan'208";a="205898318" Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.202]) by orsmga007.jf.intel.com with ESMTP; 18 Dec 2019 08:39:59 -0800 Date: Wed, 18 Dec 2019 08:39:59 -0800 From: Sean Christopherson To: Christian Borntraeger Cc: James Hogan , Paul Mackerras , Janosch Frank , Paolo Bonzini , Marc Zyngier , David Hildenbrand , Cornelia Huck , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , James Morse , Julien Thierry , Suzuki K Poulose , linux-mips@vger.kernel.org, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, Christoffer Dall , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Subject: Re: [PATCH v4 19/19] KVM: selftests: Add test for KVM_SET_USER_MEMORY_REGION Message-ID: <20191218163958.GC25201@linux.intel.com> References: <20191217204041.10815-1-sean.j.christopherson@intel.com> <20191217204041.10815-20-sean.j.christopherson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Wed, Dec 18, 2019 at 12:39:43PM +0100, Christian Borntraeger wrote: > > On 17.12.19 21:40, Sean Christopherson wrote: > > Add a KVM selftest to test moving the base gfn of a userspace memory > > region. The test is primarily targeted at x86 to verify its memslot > > metadata is correctly updated, but also provides basic functionality > > coverage on other architectures. > > +static void *vcpu_worker(void *data) > > +{ > > + struct kvm_vm *vm = data; > > + struct kvm_run *run; > > + struct ucall uc; > > + uint64_t cmd; > > + > > + /* > > + * Loop until the guest is done. Re-enter the guest on all MMIO exits, > > + * which will occur if the guest attempts to access a memslot while it > > + * is being moved. > > + */ > > + run = vcpu_state(vm, VCPU_ID); > > + do { > > + vcpu_run(vm, VCPU_ID); > > + } while (run->exit_reason == KVM_EXIT_MMIO); > > + > > + TEST_ASSERT(run->exit_reason == KVM_EXIT_IO, > > + "Unexpected exit reason = %d", run->exit_reason); > > > This will also not work for s390. Maybe just make this test x86 specific for now? Doh, that's obvious in hindsight. I think the basic premise is also broken on arm64 as it returns -EFAULT on is_error_noslot_pfn(pfn). So yeah, x86 only for now :-(