From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3473C33C9A for ; Mon, 13 Jan 2020 10:13:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 755F82084D for ; Mon, 13 Jan 2020 10:13:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=flygoat.com header.i=@flygoat.com header.b="K4EqHH7F" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726001AbgAMKNR (ORCPT ); Mon, 13 Jan 2020 05:13:17 -0500 Received: from forward103j.mail.yandex.net ([5.45.198.246]:42177 "EHLO forward103j.mail.yandex.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725978AbgAMKNR (ORCPT ); Mon, 13 Jan 2020 05:13:17 -0500 Received: from forward102q.mail.yandex.net (forward102q.mail.yandex.net [IPv6:2a02:6b8:c0e:1ba:0:640:516:4e7d]) by forward103j.mail.yandex.net (Yandex) with ESMTP id D3D456741291; Mon, 13 Jan 2020 13:13:13 +0300 (MSK) Received: from mxback3q.mail.yandex.net (mxback3q.mail.yandex.net [IPv6:2a02:6b8:c0e:39:0:640:4545:437c]) by forward102q.mail.yandex.net (Yandex) with ESMTP id CF6D97F2001F; Mon, 13 Jan 2020 13:13:13 +0300 (MSK) Received: from vla3-4c649d03f525.qloud-c.yandex.net (vla3-4c649d03f525.qloud-c.yandex.net [2a02:6b8:c15:2584:0:640:4c64:9d03]) by mxback3q.mail.yandex.net (mxback/Yandex) with ESMTP id MlyymQRMBT-DDkChGdu; Mon, 13 Jan 2020 13:13:13 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flygoat.com; s=mail; t=1578910393; bh=W0LouJHxhJ8X0NqqqQzaJDVH6qHFyXTB5zG8KPXgID4=; h=Subject:To:From:Cc:Date:Message-Id; b=K4EqHH7FRdthdu1mQFTuNH0tqlMArF4/YrXBetuY56mT5APBCkP3cufdKPCDNUDE5 ttURaS/F0BmJC1ZKF40w5QlJVfDL18FRuLLHHiWDepTdga0CSp/77C0mf8licrE8vy OUSrbrYe1g62TO0yyBxjRBaVrR7ataPr7/wPHeSw= Authentication-Results: mxback3q.mail.yandex.net; dkim=pass header.i=@flygoat.com Received: by vla3-4c649d03f525.qloud-c.yandex.net (smtp/Yandex) with ESMTPSA id ATtQsIjGG0-D4VCMcx1; Mon, 13 Jan 2020 13:13:11 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) From: Jiaxun Yang To: linux-mips@vger.kernel.org Cc: chenhc@lemote.com, paul.burton@mips.com, tglx@linutronix.de, jason@lakedaemon.net, maz@kernel.org, linux-kernel@vger.kernel.org, Jiaxun Yang Subject: [PATCH] irqchip: mips-cpu: Remove eoi operation Date: Mon, 13 Jan 2020 18:12:51 +0800 Message-Id: <20200113101251.37471-1-jiaxun.yang@flygoat.com> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org The eoi opreation in mips_cpu_irq_controller caused chained_irq_enter falsely consider CPU IP interrupt as a FastEOI type IRQ. So the interrupt won't be masked during in handler. Which might lead to spurious interrupt. Thus we simply remove eoi operation for mips_cpu_irq_controller, Signed-off-by: Jiaxun Yang --- drivers/irqchip/irq-mips-cpu.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/irqchip/irq-mips-cpu.c b/drivers/irqchip/irq-mips-cpu.c index 95d4fd8f7a96..0ad7f1f9a58b 100644 --- a/drivers/irqchip/irq-mips-cpu.c +++ b/drivers/irqchip/irq-mips-cpu.c @@ -55,7 +55,6 @@ static struct irq_chip mips_cpu_irq_controller = { .irq_mask = mask_mips_irq, .irq_mask_ack = mask_mips_irq, .irq_unmask = unmask_mips_irq, - .irq_eoi = unmask_mips_irq, .irq_disable = mask_mips_irq, .irq_enable = unmask_mips_irq, }; -- 2.24.1