From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7418C33CAF for ; Thu, 16 Jan 2020 20:11:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B83A520663 for ; Thu, 16 Jan 2020 20:11:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579205477; bh=ksnhhuSQ1QJCKWVbxycdJPPdnNpLHb7Tfyo71D6g6mc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=YvMcjp+cCzR8zN01aJa3mXW7+nHw3OBTDcTadPl9DMeTfVfoLnK6YmiN3En65fqSI P6D78gHcsq6e0nTsVi/K01gQnkAaHDrRGMPc39Ef2JwDvZMhhClBriNIUo6I+W1/Zo +rAmqwKqH0MeEQY9zsqw7p2nnl1eZp6To5wceLSU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387443AbgAPULR (ORCPT ); Thu, 16 Jan 2020 15:11:17 -0500 Received: from mail-pl1-f193.google.com ([209.85.214.193]:46450 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387437AbgAPULR (ORCPT ); Thu, 16 Jan 2020 15:11:17 -0500 Received: by mail-pl1-f193.google.com with SMTP id y8so8794791pll.13; Thu, 16 Jan 2020 12:11:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=Tm23PxhXo55Di3dhtZ2C51EXGzICtg127cF/oILr50A=; b=rz3lxLhxXoqePSgakl8djESfGyMpk1CkyVl/OVsGJEw9UDKuIRgQAe+fDaB46He53C +G74+Gy1dXYXyHSWIabHMvFH8bugWoOC4neIc/CjSC3VFxOmhC81YWM8ZSb7JHq1eRXd K9dWa19NRYx2/sz67IytkCUSiv1nQL1+BhRPPURbrujEFH2WD7GZRu+IByQ249lCBFiH ZbBttFBfjOwPbxEdc8Ht5d5cZF8N3YL42lLbivqA2nBjceHvNIywMOiMDIY6BM7cfWo0 gr1QYjXPpqoj8+zYOMI/kvdu6r10RGFa5X0WLEPEFUBG1sltcIH3xJpLLZvKrUI7rQdZ 2eZg== X-Gm-Message-State: APjAAAWRHNSIyMSgYXVhL2bkrQfGa+RT32UaDTldC7qItZMjAbI/j9cM HgSU/Jx+a/WsHmMWojvbGGs= X-Google-Smtp-Source: APXvYqxALxH6RE6QR8Q0mmczdgGt4YUBXj86LMzvHDaKHxeqPk5YH8lJTwPvLsDAldKhkyPFv9VgzQ== X-Received: by 2002:a17:90a:21a7:: with SMTP id q36mr1112343pjc.140.1579205476399; Thu, 16 Jan 2020 12:11:16 -0800 (PST) Received: from localhost (MIPS-TECHNO.ear1.SanJose1.Level3.net. [4.15.122.74]) by smtp.gmail.com with ESMTPSA id r66sm27423056pfc.74.2020.01.16.12.11.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jan 2020 12:11:15 -0800 (PST) Date: Thu, 16 Jan 2020 12:11:14 -0800 From: Paul Burton To: Thomas Gleixner Cc: Vincenzo Frascino , linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, paul.burton@mips.com, luto@kernel.org, kbuild test robot Subject: Re: [PATCH] MIPS: vdso: Define BUILD_VDSO32 when building a 32bit kernel Message-ID: <20200116201114.44l7ou24ppz2jjjt@pburton-laptop> References: <20190830135902.20861-1-vincenzo.frascino@arm.com> <20190830135902.20861-3-vincenzo.frascino@arm.com> <87d0bjfaqa.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87d0bjfaqa.fsf@nanos.tec.linutronix.de> Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org Hi Thomas, On Thu, Jan 16, 2020 at 08:43:41PM +0100, Thomas Gleixner wrote: > The confinement of the 32bit specific VDSO functions missed to define > BUILD_VDSO32 when building a 32bit MIPS kernel: > > arch/mips/vdso/vgettimeofday.c: In function ‘__vdso_clock_gettime’: > arch/mips/vdso/vgettimeofday.c:17:9: error: implicit declaration of function ‘__cvdso_clock_gettime32’ > > arch/mips/vdso/vgettimeofday.c: In function ‘__vdso_clock_getres’: > arch/mips/vdso/vgettimeofday.c:39:9: error: implicit declaration of function ‘__cvdso_clock_getres_time32’ > > Force the define for 32bit builds in the VDSO Makefile. > > Fixes: bf279849ad59 ("lib/vdso: Build 32 bit specific functions in the right context") > Reported-by: kbuild test robot > Signed-off-by: Thomas Gleixner Presuming you want to take this through timers/core along with the patch it fixes: Acked-by: Paul Burton Thanks, Paul > --- > arch/mips/vdso/Makefile | 4 ++++ > 1 file changed, 4 insertions(+) > > --- a/arch/mips/vdso/Makefile > +++ b/arch/mips/vdso/Makefile > @@ -18,6 +18,10 @@ ccflags-vdso := \ > $(filter -mno-loongson-%,$(KBUILD_CFLAGS)) \ > -D__VDSO__ > > +ifndef CONFIG_64BIT > +ccflags-vdso += -DBUILD_VDSO32 > +endif > + > ifdef CONFIG_CC_IS_CLANG > ccflags-vdso += $(filter --target=%,$(KBUILD_CFLAGS)) > endif