linux-mips.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [bug report] MIPS: add support for SGI Octane (IP30)
@ 2020-01-22 10:03 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2020-01-22 10:03 UTC (permalink / raw)
  To: tbogendoerfer; +Cc: linux-mips

Hello Thomas Bogendoerfer,

This is a semi-automatic email about new static checker warnings.

The patch 7505576d1c1a: "MIPS: add support for SGI Octane (IP30)"
from Oct 24, 2019, leads to the following Smatch complaint:

    ./arch/mips/sgi-ip30/ip30-irq.c:236 heart_domain_free()
     warn: variable dereferenced before check 'irqd' (see line 235)

./arch/mips/sgi-ip30/ip30-irq.c
   234		irqd = irq_domain_get_irq_data(domain, virq);
   235		clear_bit(irqd->hwirq, heart_irq_map);
                          ^^^^^^^^^^^
Dereference

   236		if (irqd && irqd->chip_data)
                    ^^^^
Check too late.

   237			kfree(irqd->chip_data);
   238	}

regards,
dan carpenter

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-01-22 10:04 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-22 10:03 [bug report] MIPS: add support for SGI Octane (IP30) Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).