* [PATCH] MIPS: VPE: Fix a double free and a memory leak in 'release_vpe()'
@ 2020-02-02 20:19 Christophe JAILLET
2020-02-15 22:56 ` Paul Burton
0 siblings, 1 reply; 2+ messages in thread
From: Christophe JAILLET @ 2020-02-02 20:19 UTC (permalink / raw)
To: ralf, paulburton
Cc: linux-mips, linux-kernel, kernel-janitors, Christophe JAILLET
Pointer on the memory allocated by 'alloc_progmem()' is stored in
'v->load_addr'. So this is this memory that should be freed by
'release_progmem()'.
'release_progmem()' is only a call to 'kfree()'.
With the current code, there is both a double free and a memory leak.
Fix it by passing the correct pointer to 'release_progmem()'.
Fixes: e01402b115ccc ("More AP / SP bits for the 34K, the Malta bits and things. Still wants")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
Un-tested
The 'if (v->load_addr)' looks also redundant, but, well, the code is old
and I feel lazy tonight to send another patch for only that.
---
arch/mips/kernel/vpe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/kernel/vpe.c b/arch/mips/kernel/vpe.c
index 6176b9acba95..d0d832ab3d3b 100644
--- a/arch/mips/kernel/vpe.c
+++ b/arch/mips/kernel/vpe.c
@@ -134,7 +134,7 @@ void release_vpe(struct vpe *v)
{
list_del(&v->list);
if (v->load_addr)
- release_progmem(v);
+ release_progmem(v->load_addr);
kfree(v);
}
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] MIPS: VPE: Fix a double free and a memory leak in 'release_vpe()'
2020-02-02 20:19 [PATCH] MIPS: VPE: Fix a double free and a memory leak in 'release_vpe()' Christophe JAILLET
@ 2020-02-15 22:56 ` Paul Burton
0 siblings, 0 replies; 2+ messages in thread
From: Paul Burton @ 2020-02-15 22:56 UTC (permalink / raw)
To: Christophe JAILLET
Cc: ralf, paulburton, linux-mips, linux-kernel, kernel-janitors,
Christophe JAILLET, linux-mips
Hello,
Christophe JAILLET wrote:
> Pointer on the memory allocated by 'alloc_progmem()' is stored in
> 'v->load_addr'. So this is this memory that should be freed by
> 'release_progmem()'.
>
> 'release_progmem()' is only a call to 'kfree()'.
>
> With the current code, there is both a double free and a memory leak.
> Fix it by passing the correct pointer to 'release_progmem()'.
Applied to mips-fixes.
> commit bef8e2dfceed
> https://git.kernel.org/mips/c/bef8e2dfceed
>
> Fixes: e01402b115ccc ("More AP / SP bits for the 34K, the Malta bits and things. Still wants")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Signed-off-by: Paul Burton <paulburton@kernel.org>
Thanks,
Paul
[ This message was auto-generated; if you believe anything is incorrect
then please email paulburton@kernel.org to report it. ]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-15 22:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-02 20:19 [PATCH] MIPS: VPE: Fix a double free and a memory leak in 'release_vpe()' Christophe JAILLET
2020-02-15 22:56 ` Paul Burton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).