From: Nathan Chancellor <natechancellor@gmail.com>
To: afzal mohammed <afzal.mohd.ma@gmail.com>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Ralf Baechle <ralf@linux-mips.org>,
Paul Burton <paulburton@kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
bcm-kernel-feedback-list@broadcom.com,
"Maciej W. Rozycki" <macro@linux-mips.org>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Keguang Zhang <keguang.zhang@gmail.com>,
Huacai Chen <chenhc@lemote.com>, John Crispin <john@phrozen.org>
Subject: Re: [PATCH v2] MIPS: pass non-NULL dev_id on shared request_irq()
Date: Sun, 15 Mar 2020 00:11:54 -0700 [thread overview]
Message-ID: <20200315071154.GA31696@ubuntu-m2-xlarge-x86> (raw)
In-Reply-To: <20200314081312.GA4948@afzalpc>
On Sat, Mar 14, 2020 at 01:43:12PM +0530, afzal mohammed wrote:
> Recently all usages of setup_irq() was replaced by request_irq().
> request_irq() does a few sanity checks that were not done in
> setup_irq(), if they fail irq registration will fail. One of the check
> is to ensure that non-NULL dev_id is passed in the case of shared irq.
> This caused malta on qemu to hang.
>
> Fix it by passing handler as dev_id to all request_irq()'s that are
> shared. For sni, instead of passing non-NULL dev_id, remove shared irq
> flags.
>
> Fixes: ac8fd122e070 ("MIPS: Replace setup_irq() by request_irq()")
> Reported-by: Nathan Chancellor <natechancellor@gmail.com>
> Suggested-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> Signed-off-by: afzal mohammed <afzal.mohd.ma@gmail.com>
Tested-by: Nathan Chancellor <natechancellor@gmail.com>
next prev parent reply other threads:[~2020-03-15 7:11 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 0:55 [PATCH v3] MIPS: Replace setup_irq() by request_irq() afzal mohammed
2020-03-04 20:31 ` Thomas Bogendoerfer
2020-03-05 11:57 ` [PATCH v4] " afzal mohammed
2020-03-06 12:47 ` Thomas Bogendoerfer
2020-03-11 5:31 ` Nathan Chancellor
2020-03-11 7:56 ` afzal mohammed
2020-03-11 9:03 ` afzal mohammed
2020-03-11 10:42 ` Thomas Bogendoerfer
2020-03-11 13:12 ` afzal mohammed
[not found] ` <20200311160307.GA15464@alpha.franken.de>
[not found] ` <20200311163249.GA4984@afzalpc>
2020-03-13 12:11 ` afzal mohammed
2020-03-14 8:13 ` [PATCH v2] MIPS: pass non-NULL dev_id on shared request_irq() afzal mohammed
2020-03-14 17:19 ` Guenter Roeck
2020-03-15 7:11 ` Nathan Chancellor [this message]
2020-03-16 15:32 ` Thomas Bogendoerfer
2020-03-14 6:55 ` [PATCH v4] MIPS: Replace setup_irq() by request_irq() afzal mohammed
2020-03-13 16:47 ` Guenter Roeck
2020-03-14 1:07 ` afzal mohammed
[not found] ` <0b41aa60-9869-ab62-4c8e-cbf7c62cdb7e@loongson.cn>
2020-03-14 6:49 ` afzal mohammed
2020-03-14 10:28 ` Guenter Roeck
2020-03-14 11:42 ` afzal mohammed
2020-03-05 12:29 ` [PATCH v3] " afzal mohammed
2020-03-05 12:42 ` afzal mohammed
2020-03-04 20:38 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200315071154.GA31696@ubuntu-m2-xlarge-x86 \
--to=natechancellor@gmail.com \
--cc=afzal.mohd.ma@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=chenhc@lemote.com \
--cc=f.fainelli@gmail.com \
--cc=jiaxun.yang@flygoat.com \
--cc=john@phrozen.org \
--cc=keguang.zhang@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=macro@linux-mips.org \
--cc=paulburton@kernel.org \
--cc=ralf@linux-mips.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).