Linux-MIPS Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v2 01/10] dt-bindings: display: Convert ingenic,lcd.txt to YAML
@ 2020-06-29 23:52 Paul Cercueil
  2020-06-29 23:52 ` [PATCH v2 02/10] dt-bindings: display: Add ingenic,ipu.yaml Paul Cercueil
                   ` (8 more replies)
  0 siblings, 9 replies; 22+ messages in thread
From: Paul Cercueil @ 2020-06-29 23:52 UTC (permalink / raw)
  To: David Airlie, Daniel Vetter, Rob Herring
  Cc: od, dri-devel, devicetree, linux-mips, linux-kernel,
	Paul Cercueil, Rob Herring, Sam Ravnborg

Convert the ingenic,lcd.txt to a new ingenic,lcd.yaml file.

In the process, the new ingenic,jz4780-lcd compatible string has been
added.

Reviewed-by: Rob Herring <robh@kernel.org>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---

Notes:
    v2: Add info about IPU at port@8

 .../bindings/display/ingenic,lcd.txt          |  45 -------
 .../bindings/display/ingenic,lcd.yaml         | 126 ++++++++++++++++++
 2 files changed, 126 insertions(+), 45 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/display/ingenic,lcd.txt
 create mode 100644 Documentation/devicetree/bindings/display/ingenic,lcd.yaml

diff --git a/Documentation/devicetree/bindings/display/ingenic,lcd.txt b/Documentation/devicetree/bindings/display/ingenic,lcd.txt
deleted file mode 100644
index 01e3261defb6..000000000000
--- a/Documentation/devicetree/bindings/display/ingenic,lcd.txt
+++ /dev/null
@@ -1,45 +0,0 @@
-Ingenic JZ47xx LCD driver
-
-Required properties:
-- compatible: one of:
-  * ingenic,jz4740-lcd
-  * ingenic,jz4725b-lcd
-  * ingenic,jz4770-lcd
-- reg: LCD registers location and length
-- clocks: LCD pixclock and device clock specifiers.
-	   The device clock is only required on the JZ4740.
-- clock-names: "lcd_pclk" and "lcd"
-- interrupts: Specifies the interrupt line the LCD controller is connected to.
-
-Example:
-
-panel {
-	compatible = "sharp,ls020b1dd01d";
-
-	backlight = <&backlight>;
-	power-supply = <&vcc>;
-
-	port {
-		panel_input: endpoint {
-			remote-endpoint = <&panel_output>;
-		};
-	};
-};
-
-
-lcd: lcd-controller@13050000 {
-	compatible = "ingenic,jz4725b-lcd";
-	reg = <0x13050000 0x1000>;
-
-	interrupt-parent = <&intc>;
-	interrupts = <31>;
-
-	clocks = <&cgu JZ4725B_CLK_LCD>;
-	clock-names = "lcd";
-
-	port {
-		panel_output: endpoint {
-			remote-endpoint = <&panel_input>;
-		};
-	};
-};
diff --git a/Documentation/devicetree/bindings/display/ingenic,lcd.yaml b/Documentation/devicetree/bindings/display/ingenic,lcd.yaml
new file mode 100644
index 000000000000..d56db1802fad
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/ingenic,lcd.yaml
@@ -0,0 +1,126 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/ingenic,lcd.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Ingenic SoCs LCD controller devicetree bindings
+
+maintainers:
+  - Paul Cercueil <paul@crapouillou.net>
+
+properties:
+  $nodename:
+    pattern: "^lcd-controller@[0-9a-f]+$"
+
+  compatible:
+    enum:
+      - ingenic,jz4740-lcd
+      - ingenic,jz4725b-lcd
+      - ingenic,jz4770-lcd
+      - ingenic,jz4780-lcd
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  clocks:
+    items:
+      - description: Pixel clock
+      - description: Module clock
+    minItems: 1
+
+  clock-names:
+    items:
+      - const: lcd_pclk
+      - const: lcd
+    minItems: 1
+
+  port:
+    description: OF graph bindings (specified in bindings/graph.txt).
+
+  ports:
+    description: OF graph bindings (specified in bindings/graph.txt).
+    type: object
+    properties:
+      port@0:
+        type: object
+        description: DPI output, to interface with TFT panels.
+
+      port@8:
+        type: object
+        description: Link to the Image Processing Unit (IPU).
+          (See ingenic,ipu.yaml).
+
+    required:
+      - port@0
+
+required:
+    - compatible
+    - reg
+    - interrupts
+    - clocks
+    - clock-names
+
+if:
+  properties:
+    compatible:
+      contains:
+        enum:
+          - ingenic,jz4740-lcd
+          - ingenic,jz4780-lcd
+then:
+  properties:
+    clocks:
+      minItems: 2
+    clock-names:
+      minItems: 2
+else:
+  properties:
+    clocks:
+      maxItems: 1
+    clock-names:
+      maxItems: 1
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/clock/jz4740-cgu.h>
+    lcd-controller@13050000 {
+      compatible = "ingenic,jz4740-lcd";
+      reg = <0x13050000 0x1000>;
+
+      interrupt-parent = <&intc>;
+      interrupts = <30>;
+
+      clocks = <&cgu JZ4740_CLK_LCD_PCLK>, <&cgu JZ4740_CLK_LCD>;
+      clock-names = "lcd_pclk", "lcd";
+
+      port {
+        endpoint {
+          remote-endpoint = <&panel_input>;
+        };
+      };
+    };
+
+  - |
+    #include <dt-bindings/clock/jz4725b-cgu.h>
+    lcd-controller@13050000 {
+      compatible = "ingenic,jz4725b-lcd";
+      reg = <0x13050000 0x1000>;
+
+      interrupt-parent = <&intc>;
+      interrupts = <31>;
+
+      clocks = <&cgu JZ4725B_CLK_LCD>;
+      clock-names = "lcd_pclk";
+
+      port {
+        endpoint {
+          remote-endpoint = <&panel_input>;
+        };
+      };
+    };
-- 
2.27.0


^ permalink raw reply	[flat|nested] 22+ messages in thread

* [PATCH v2 02/10] dt-bindings: display: Add ingenic,ipu.yaml
  2020-06-29 23:52 [PATCH v2 01/10] dt-bindings: display: Convert ingenic,lcd.txt to YAML Paul Cercueil
@ 2020-06-29 23:52 ` Paul Cercueil
  2020-06-30 10:08   ` Sam Ravnborg
  2020-07-14  2:38   ` Rob Herring
  2020-06-29 23:52 ` [PATCH v2 03/10] drm/ingenic: Rename ingenic-drm.c to ingenic-drm-drv.c Paul Cercueil
                   ` (7 subsequent siblings)
  8 siblings, 2 replies; 22+ messages in thread
From: Paul Cercueil @ 2020-06-29 23:52 UTC (permalink / raw)
  To: David Airlie, Daniel Vetter, Rob Herring
  Cc: od, dri-devel, devicetree, linux-mips, linux-kernel, Paul Cercueil

Add documentation of the Device Tree bindings for the Image Processing
Unit (IPU) found in most Ingenic SoCs.

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---

Notes:
    v2: Add missing 'const' in items list

 .../bindings/display/ingenic,ipu.yaml         | 65 +++++++++++++++++++
 1 file changed, 65 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/ingenic,ipu.yaml

diff --git a/Documentation/devicetree/bindings/display/ingenic,ipu.yaml b/Documentation/devicetree/bindings/display/ingenic,ipu.yaml
new file mode 100644
index 000000000000..5bfc33eb32c9
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/ingenic,ipu.yaml
@@ -0,0 +1,65 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/ingenic,ipu.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Ingenic SoCs Image Processing Unit (IPU) devicetree bindings
+
+maintainers:
+  - Paul Cercueil <paul@crapouillou.net>
+
+properties:
+  compatible:
+    oneOf:
+      - enum:
+        - ingenic,jz4725b-ipu
+        - ingenic,jz4760-ipu
+      - items:
+        - const: ingenic,jz4770-ipu
+        - const: ingenic,jz4760-ipu
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  clock-names:
+    const: ipu
+
+patternProperties:
+  "^ports?$":
+    description: OF graph bindings (specified in bindings/graph.txt).
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - clocks
+  - clock-names
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/clock/jz4770-cgu.h>
+    ipu@13080000 {
+      compatible = "ingenic,jz4770-ipu", "ingenic,jz4760-ipu";
+      reg = <0x13080000 0x800>;
+
+      interrupt-parent = <&intc>;
+      interrupts = <29>;
+
+      clocks = <&cgu JZ4770_CLK_IPU>;
+      clock-names = "ipu";
+
+      port {
+        ipu_ep: endpoint {
+          remote-endpoint = <&lcdc_ep>;
+        };
+      };
+    };
-- 
2.27.0


^ permalink raw reply	[flat|nested] 22+ messages in thread

* [PATCH v2 03/10] drm/ingenic: Rename ingenic-drm.c to ingenic-drm-drv.c
  2020-06-29 23:52 [PATCH v2 01/10] dt-bindings: display: Convert ingenic,lcd.txt to YAML Paul Cercueil
  2020-06-29 23:52 ` [PATCH v2 02/10] dt-bindings: display: Add ingenic,ipu.yaml Paul Cercueil
@ 2020-06-29 23:52 ` Paul Cercueil
  2020-06-30 10:09   ` Sam Ravnborg
  2020-06-29 23:52 ` [PATCH v2 04/10] drm/ingenic: Add missing CR in debug strings Paul Cercueil
                   ` (6 subsequent siblings)
  8 siblings, 1 reply; 22+ messages in thread
From: Paul Cercueil @ 2020-06-29 23:52 UTC (permalink / raw)
  To: David Airlie, Daniel Vetter, Rob Herring
  Cc: od, dri-devel, devicetree, linux-mips, linux-kernel, Paul Cercueil

Full rename without any modification, except to the Makefile.

Renaming ingenic-drm.c to ingenic-drm-drv.c allow to decouple the module
name from the source file name in the Makefile. This will be useful
later when more source files are added.

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---

Notes:
    v2: New patch

 drivers/gpu/drm/ingenic/Makefile                             | 1 +
 drivers/gpu/drm/ingenic/{ingenic-drm.c => ingenic-drm-drv.c} | 0
 2 files changed, 1 insertion(+)
 rename drivers/gpu/drm/ingenic/{ingenic-drm.c => ingenic-drm-drv.c} (100%)

diff --git a/drivers/gpu/drm/ingenic/Makefile b/drivers/gpu/drm/ingenic/Makefile
index 11cac42ce0bb..9875628dd8bc 100644
--- a/drivers/gpu/drm/ingenic/Makefile
+++ b/drivers/gpu/drm/ingenic/Makefile
@@ -1 +1,2 @@
 obj-$(CONFIG_DRM_INGENIC) += ingenic-drm.o
+ingenic-drm-y += ingenic-drm-drv.o
diff --git a/drivers/gpu/drm/ingenic/ingenic-drm.c b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
similarity index 100%
rename from drivers/gpu/drm/ingenic/ingenic-drm.c
rename to drivers/gpu/drm/ingenic/ingenic-drm-drv.c
-- 
2.27.0


^ permalink raw reply	[flat|nested] 22+ messages in thread

* [PATCH v2 04/10] drm/ingenic: Add missing CR in debug strings
  2020-06-29 23:52 [PATCH v2 01/10] dt-bindings: display: Convert ingenic,lcd.txt to YAML Paul Cercueil
  2020-06-29 23:52 ` [PATCH v2 02/10] dt-bindings: display: Add ingenic,ipu.yaml Paul Cercueil
  2020-06-29 23:52 ` [PATCH v2 03/10] drm/ingenic: Rename ingenic-drm.c to ingenic-drm-drv.c Paul Cercueil
@ 2020-06-29 23:52 ` Paul Cercueil
  2020-06-30 10:10   ` Sam Ravnborg
  2020-06-29 23:52 ` [PATCH v2 05/10] drm/ingenic: Fix incorrect assumption about plane->index Paul Cercueil
                   ` (5 subsequent siblings)
  8 siblings, 1 reply; 22+ messages in thread
From: Paul Cercueil @ 2020-06-29 23:52 UTC (permalink / raw)
  To: David Airlie, Daniel Vetter, Rob Herring
  Cc: od, dri-devel, devicetree, linux-mips, linux-kernel, Paul Cercueil

If you pass a string that is not terminated with a carriage return to
dev_err(), it will eventually be printed with a carriage return, but
not right away, since the kernel will wait for a pr_cont().

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---

Notes:
    v2: New patch

 drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 30 +++++++++++------------
 1 file changed, 15 insertions(+), 15 deletions(-)

diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
index 16f0740df507..a15f9a1940c6 100644
--- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
+++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
@@ -623,14 +623,14 @@ static int ingenic_drm_probe(struct platform_device *pdev)
 
 	base = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(base)) {
-		dev_err(dev, "Failed to get memory resource");
+		dev_err(dev, "Failed to get memory resource\n");
 		return PTR_ERR(base);
 	}
 
 	priv->map = devm_regmap_init_mmio(dev, base,
 					  &ingenic_drm_regmap_config);
 	if (IS_ERR(priv->map)) {
-		dev_err(dev, "Failed to create regmap");
+		dev_err(dev, "Failed to create regmap\n");
 		return PTR_ERR(priv->map);
 	}
 
@@ -641,21 +641,21 @@ static int ingenic_drm_probe(struct platform_device *pdev)
 	if (soc_info->needs_dev_clk) {
 		priv->lcd_clk = devm_clk_get(dev, "lcd");
 		if (IS_ERR(priv->lcd_clk)) {
-			dev_err(dev, "Failed to get lcd clock");
+			dev_err(dev, "Failed to get lcd clock\n");
 			return PTR_ERR(priv->lcd_clk);
 		}
 	}
 
 	priv->pix_clk = devm_clk_get(dev, "lcd_pclk");
 	if (IS_ERR(priv->pix_clk)) {
-		dev_err(dev, "Failed to get pixel clock");
+		dev_err(dev, "Failed to get pixel clock\n");
 		return PTR_ERR(priv->pix_clk);
 	}
 
 	ret = drm_of_find_panel_or_bridge(dev->of_node, 0, 0, &panel, &bridge);
 	if (ret) {
 		if (ret != -EPROBE_DEFER)
-			dev_err(dev, "Failed to get panel handle");
+			dev_err(dev, "Failed to get panel handle\n");
 		return ret;
 	}
 
@@ -684,7 +684,7 @@ static int ingenic_drm_probe(struct platform_device *pdev)
 				       ARRAY_SIZE(ingenic_drm_primary_formats),
 				       NULL, DRM_PLANE_TYPE_PRIMARY, NULL);
 	if (ret) {
-		dev_err(dev, "Failed to register primary plane: %i", ret);
+		dev_err(dev, "Failed to register primary plane: %i\n", ret);
 		return ret;
 	}
 
@@ -693,7 +693,7 @@ static int ingenic_drm_probe(struct platform_device *pdev)
 	ret = drm_crtc_init_with_planes(drm, &priv->crtc, &priv->primary,
 					NULL, &ingenic_drm_crtc_funcs, NULL);
 	if (ret) {
-		dev_err(dev, "Failed to init CRTC: %i", ret);
+		dev_err(dev, "Failed to init CRTC: %i\n", ret);
 		return ret;
 	}
 
@@ -705,25 +705,25 @@ static int ingenic_drm_probe(struct platform_device *pdev)
 	ret = drm_simple_encoder_init(drm, &priv->encoder,
 				      DRM_MODE_ENCODER_DPI);
 	if (ret) {
-		dev_err(dev, "Failed to init encoder: %i", ret);
+		dev_err(dev, "Failed to init encoder: %i\n", ret);
 		return ret;
 	}
 
 	ret = drm_bridge_attach(&priv->encoder, bridge, NULL, 0);
 	if (ret) {
-		dev_err(dev, "Unable to attach bridge");
+		dev_err(dev, "Unable to attach bridge\n");
 		return ret;
 	}
 
 	ret = drm_irq_install(drm, irq);
 	if (ret) {
-		dev_err(dev, "Unable to install IRQ handler");
+		dev_err(dev, "Unable to install IRQ handler\n");
 		return ret;
 	}
 
 	ret = drm_vblank_init(drm, 1);
 	if (ret) {
-		dev_err(dev, "Failed calling drm_vblank_init()");
+		dev_err(dev, "Failed calling drm_vblank_init()\n");
 		return ret;
 	}
 
@@ -731,7 +731,7 @@ static int ingenic_drm_probe(struct platform_device *pdev)
 
 	ret = clk_prepare_enable(priv->pix_clk);
 	if (ret) {
-		dev_err(dev, "Unable to start pixel clock");
+		dev_err(dev, "Unable to start pixel clock\n");
 		return ret;
 	}
 
@@ -746,20 +746,20 @@ static int ingenic_drm_probe(struct platform_device *pdev)
 		 */
 		ret = clk_set_rate(priv->lcd_clk, parent_rate);
 		if (ret) {
-			dev_err(dev, "Unable to set LCD clock rate");
+			dev_err(dev, "Unable to set LCD clock rate\n");
 			goto err_pixclk_disable;
 		}
 
 		ret = clk_prepare_enable(priv->lcd_clk);
 		if (ret) {
-			dev_err(dev, "Unable to start lcd clock");
+			dev_err(dev, "Unable to start lcd clock\n");
 			goto err_pixclk_disable;
 		}
 	}
 
 	ret = drm_dev_register(drm, 0);
 	if (ret) {
-		dev_err(dev, "Failed to register DRM driver");
+		dev_err(dev, "Failed to register DRM driver\n");
 		goto err_devclk_disable;
 	}
 
-- 
2.27.0


^ permalink raw reply	[flat|nested] 22+ messages in thread

* [PATCH v2 05/10] drm/ingenic: Fix incorrect assumption about plane->index
  2020-06-29 23:52 [PATCH v2 01/10] dt-bindings: display: Convert ingenic,lcd.txt to YAML Paul Cercueil
                   ` (2 preceding siblings ...)
  2020-06-29 23:52 ` [PATCH v2 04/10] drm/ingenic: Add missing CR in debug strings Paul Cercueil
@ 2020-06-29 23:52 ` Paul Cercueil
  2020-06-30 11:35   ` Sam Ravnborg
  2020-06-29 23:52 ` [PATCH v2 06/10] drm/ingenic: Set DMA descriptor chain address in probe Paul Cercueil
                   ` (4 subsequent siblings)
  8 siblings, 1 reply; 22+ messages in thread
From: Paul Cercueil @ 2020-06-29 23:52 UTC (permalink / raw)
  To: David Airlie, Daniel Vetter, Rob Herring
  Cc: od, dri-devel, devicetree, linux-mips, linux-kernel,
	Paul Cercueil, stable

plane->index is NOT the index of the color plane in a YUV frame.
Actually, a YUV frame is represented by a single drm_plane, even though
it contains three Y, U, V planes.

Cc: stable@vger.kernel.org # v5.3
Fixes: 90b86fcc47b4 ("DRM: Add KMS driver for the Ingenic JZ47xx SoCs")
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---

Notes:
    v2: No change

 drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
index a15f9a1940c6..924c8daf071a 100644
--- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
+++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
@@ -386,7 +386,7 @@ static void ingenic_drm_plane_atomic_update(struct drm_plane *plane,
 		addr = drm_fb_cma_get_gem_addr(state->fb, state, 0);
 		width = state->src_w >> 16;
 		height = state->src_h >> 16;
-		cpp = state->fb->format->cpp[plane->index];
+		cpp = state->fb->format->cpp[0];
 
 		priv->dma_hwdesc->addr = addr;
 		priv->dma_hwdesc->cmd = width * height * cpp / 4;
-- 
2.27.0


^ permalink raw reply	[flat|nested] 22+ messages in thread

* [PATCH v2 06/10] drm/ingenic: Set DMA descriptor chain address in probe
  2020-06-29 23:52 [PATCH v2 01/10] dt-bindings: display: Convert ingenic,lcd.txt to YAML Paul Cercueil
                   ` (3 preceding siblings ...)
  2020-06-29 23:52 ` [PATCH v2 05/10] drm/ingenic: Fix incorrect assumption about plane->index Paul Cercueil
@ 2020-06-29 23:52 ` Paul Cercueil
  2020-06-30 11:44   ` Sam Ravnborg
  2020-06-29 23:52 ` [PATCH v2 07/10] drm/ingenic: Move register definitions to ingenic-drm.h Paul Cercueil
                   ` (3 subsequent siblings)
  8 siblings, 1 reply; 22+ messages in thread
From: Paul Cercueil @ 2020-06-29 23:52 UTC (permalink / raw)
  To: David Airlie, Daniel Vetter, Rob Herring
  Cc: od, dri-devel, devicetree, linux-mips, linux-kernel, Paul Cercueil

The address of the DMA descriptor never changes. It can therefore be set
in the probe function.

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---

Notes:
    v2: No change

 drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
index 924c8daf071a..f7b0c5dc8cd8 100644
--- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
+++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
@@ -358,8 +358,6 @@ static void ingenic_drm_crtc_atomic_flush(struct drm_crtc *crtc,
 		ingenic_drm_crtc_update_ctrl(priv, finfo);
 
 		clk_set_rate(priv->pix_clk, state->adjusted_mode.clock * 1000);
-
-		regmap_write(priv->map, JZ_REG_LCD_DA0, priv->dma_hwdesc->next);
 	}
 
 	if (event) {
@@ -757,6 +755,9 @@ static int ingenic_drm_probe(struct platform_device *pdev)
 		}
 	}
 
+	/* Set address of our DMA descriptor chain */
+	regmap_write(priv->map, JZ_REG_LCD_DA0, priv->dma_hwdesc_phys);
+
 	ret = drm_dev_register(drm, 0);
 	if (ret) {
 		dev_err(dev, "Failed to register DRM driver\n");
-- 
2.27.0


^ permalink raw reply	[flat|nested] 22+ messages in thread

* [PATCH v2 07/10] drm/ingenic: Move register definitions to ingenic-drm.h
  2020-06-29 23:52 [PATCH v2 01/10] dt-bindings: display: Convert ingenic,lcd.txt to YAML Paul Cercueil
                   ` (4 preceding siblings ...)
  2020-06-29 23:52 ` [PATCH v2 06/10] drm/ingenic: Set DMA descriptor chain address in probe Paul Cercueil
@ 2020-06-29 23:52 ` Paul Cercueil
  2020-06-30 11:46   ` Sam Ravnborg
  2020-06-29 23:52 ` [PATCH v2 08/10] drm/ingenic: Add support for OSD mode Paul Cercueil
                   ` (2 subsequent siblings)
  8 siblings, 1 reply; 22+ messages in thread
From: Paul Cercueil @ 2020-06-29 23:52 UTC (permalink / raw)
  To: David Airlie, Daniel Vetter, Rob Herring
  Cc: od, dri-devel, devicetree, linux-mips, linux-kernel, Paul Cercueil

Move the register definitions to ingenic-drm.h, to keep
ingenic-drm-drv.c tidy.

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---

Notes:
    v2: Fix SPDX license tag

 drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 116 +-------------------
 drivers/gpu/drm/ingenic/ingenic-drm.h     | 126 ++++++++++++++++++++++
 2 files changed, 128 insertions(+), 114 deletions(-)
 create mode 100644 drivers/gpu/drm/ingenic/ingenic-drm.h

diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
index f7b0c5dc8cd8..6590b61cb915 100644
--- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
+++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
@@ -4,6 +4,8 @@
 //
 // Copyright (C) 2019, Paul Cercueil <paul@crapouillou.net>
 
+#include "ingenic-drm.h"
+
 #include <linux/clk.h>
 #include <linux/dma-mapping.h>
 #include <linux/module.h>
@@ -32,120 +34,6 @@
 #include <drm/drm_simple_kms_helper.h>
 #include <drm/drm_vblank.h>
 
-#define JZ_REG_LCD_CFG				0x00
-#define JZ_REG_LCD_VSYNC			0x04
-#define JZ_REG_LCD_HSYNC			0x08
-#define JZ_REG_LCD_VAT				0x0C
-#define JZ_REG_LCD_DAH				0x10
-#define JZ_REG_LCD_DAV				0x14
-#define JZ_REG_LCD_PS				0x18
-#define JZ_REG_LCD_CLS				0x1C
-#define JZ_REG_LCD_SPL				0x20
-#define JZ_REG_LCD_REV				0x24
-#define JZ_REG_LCD_CTRL				0x30
-#define JZ_REG_LCD_STATE			0x34
-#define JZ_REG_LCD_IID				0x38
-#define JZ_REG_LCD_DA0				0x40
-#define JZ_REG_LCD_SA0				0x44
-#define JZ_REG_LCD_FID0				0x48
-#define JZ_REG_LCD_CMD0				0x4C
-#define JZ_REG_LCD_DA1				0x50
-#define JZ_REG_LCD_SA1				0x54
-#define JZ_REG_LCD_FID1				0x58
-#define JZ_REG_LCD_CMD1				0x5C
-
-#define JZ_LCD_CFG_SLCD				BIT(31)
-#define JZ_LCD_CFG_PS_DISABLE			BIT(23)
-#define JZ_LCD_CFG_CLS_DISABLE			BIT(22)
-#define JZ_LCD_CFG_SPL_DISABLE			BIT(21)
-#define JZ_LCD_CFG_REV_DISABLE			BIT(20)
-#define JZ_LCD_CFG_HSYNCM			BIT(19)
-#define JZ_LCD_CFG_PCLKM			BIT(18)
-#define JZ_LCD_CFG_INV				BIT(17)
-#define JZ_LCD_CFG_SYNC_DIR			BIT(16)
-#define JZ_LCD_CFG_PS_POLARITY			BIT(15)
-#define JZ_LCD_CFG_CLS_POLARITY			BIT(14)
-#define JZ_LCD_CFG_SPL_POLARITY			BIT(13)
-#define JZ_LCD_CFG_REV_POLARITY			BIT(12)
-#define JZ_LCD_CFG_HSYNC_ACTIVE_LOW		BIT(11)
-#define JZ_LCD_CFG_PCLK_FALLING_EDGE		BIT(10)
-#define JZ_LCD_CFG_DE_ACTIVE_LOW		BIT(9)
-#define JZ_LCD_CFG_VSYNC_ACTIVE_LOW		BIT(8)
-#define JZ_LCD_CFG_18_BIT			BIT(7)
-#define JZ_LCD_CFG_PDW				(BIT(5) | BIT(4))
-
-#define JZ_LCD_CFG_MODE_GENERIC_16BIT		0
-#define JZ_LCD_CFG_MODE_GENERIC_18BIT		BIT(7)
-#define JZ_LCD_CFG_MODE_GENERIC_24BIT		BIT(6)
-
-#define JZ_LCD_CFG_MODE_SPECIAL_TFT_1		1
-#define JZ_LCD_CFG_MODE_SPECIAL_TFT_2		2
-#define JZ_LCD_CFG_MODE_SPECIAL_TFT_3		3
-
-#define JZ_LCD_CFG_MODE_TV_OUT_P		4
-#define JZ_LCD_CFG_MODE_TV_OUT_I		6
-
-#define JZ_LCD_CFG_MODE_SINGLE_COLOR_STN	8
-#define JZ_LCD_CFG_MODE_SINGLE_MONOCHROME_STN	9
-#define JZ_LCD_CFG_MODE_DUAL_COLOR_STN		10
-#define JZ_LCD_CFG_MODE_DUAL_MONOCHROME_STN	11
-
-#define JZ_LCD_CFG_MODE_8BIT_SERIAL		12
-#define JZ_LCD_CFG_MODE_LCM			13
-
-#define JZ_LCD_VSYNC_VPS_OFFSET			16
-#define JZ_LCD_VSYNC_VPE_OFFSET			0
-
-#define JZ_LCD_HSYNC_HPS_OFFSET			16
-#define JZ_LCD_HSYNC_HPE_OFFSET			0
-
-#define JZ_LCD_VAT_HT_OFFSET			16
-#define JZ_LCD_VAT_VT_OFFSET			0
-
-#define JZ_LCD_DAH_HDS_OFFSET			16
-#define JZ_LCD_DAH_HDE_OFFSET			0
-
-#define JZ_LCD_DAV_VDS_OFFSET			16
-#define JZ_LCD_DAV_VDE_OFFSET			0
-
-#define JZ_LCD_CTRL_BURST_4			(0x0 << 28)
-#define JZ_LCD_CTRL_BURST_8			(0x1 << 28)
-#define JZ_LCD_CTRL_BURST_16			(0x2 << 28)
-#define JZ_LCD_CTRL_RGB555			BIT(27)
-#define JZ_LCD_CTRL_OFUP			BIT(26)
-#define JZ_LCD_CTRL_FRC_GRAYSCALE_16		(0x0 << 24)
-#define JZ_LCD_CTRL_FRC_GRAYSCALE_4		(0x1 << 24)
-#define JZ_LCD_CTRL_FRC_GRAYSCALE_2		(0x2 << 24)
-#define JZ_LCD_CTRL_PDD_MASK			(0xff << 16)
-#define JZ_LCD_CTRL_EOF_IRQ			BIT(13)
-#define JZ_LCD_CTRL_SOF_IRQ			BIT(12)
-#define JZ_LCD_CTRL_OFU_IRQ			BIT(11)
-#define JZ_LCD_CTRL_IFU0_IRQ			BIT(10)
-#define JZ_LCD_CTRL_IFU1_IRQ			BIT(9)
-#define JZ_LCD_CTRL_DD_IRQ			BIT(8)
-#define JZ_LCD_CTRL_QDD_IRQ			BIT(7)
-#define JZ_LCD_CTRL_REVERSE_ENDIAN		BIT(6)
-#define JZ_LCD_CTRL_LSB_FISRT			BIT(5)
-#define JZ_LCD_CTRL_DISABLE			BIT(4)
-#define JZ_LCD_CTRL_ENABLE			BIT(3)
-#define JZ_LCD_CTRL_BPP_1			0x0
-#define JZ_LCD_CTRL_BPP_2			0x1
-#define JZ_LCD_CTRL_BPP_4			0x2
-#define JZ_LCD_CTRL_BPP_8			0x3
-#define JZ_LCD_CTRL_BPP_15_16			0x4
-#define JZ_LCD_CTRL_BPP_18_24			0x5
-#define JZ_LCD_CTRL_BPP_MASK			(JZ_LCD_CTRL_RGB555 | (0x7 << 0))
-
-#define JZ_LCD_CMD_SOF_IRQ			BIT(31)
-#define JZ_LCD_CMD_EOF_IRQ			BIT(30)
-#define JZ_LCD_CMD_ENABLE_PAL			BIT(28)
-
-#define JZ_LCD_SYNC_MASK			0x3ff
-
-#define JZ_LCD_STATE_EOF_IRQ			BIT(5)
-#define JZ_LCD_STATE_SOF_IRQ			BIT(4)
-#define JZ_LCD_STATE_DISABLED			BIT(0)
-
 struct ingenic_dma_hwdesc {
 	u32 next;
 	u32 addr;
diff --git a/drivers/gpu/drm/ingenic/ingenic-drm.h b/drivers/gpu/drm/ingenic/ingenic-drm.h
new file mode 100644
index 000000000000..cb578cff7bb1
--- /dev/null
+++ b/drivers/gpu/drm/ingenic/ingenic-drm.h
@@ -0,0 +1,126 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+//
+// Ingenic JZ47xx KMS driver - Register definitions and private API
+//
+// Copyright (C) 2020, Paul Cercueil <paul@crapouillou.net>
+
+#ifndef DRIVERS_GPU_DRM_INGENIC_INGENIC_DRM_H
+#define DRIVERS_GPU_DRM_INGENIC_INGENIC_DRM_H
+
+#include <linux/bitops.h>
+
+#define JZ_REG_LCD_CFG				0x00
+#define JZ_REG_LCD_VSYNC			0x04
+#define JZ_REG_LCD_HSYNC			0x08
+#define JZ_REG_LCD_VAT				0x0C
+#define JZ_REG_LCD_DAH				0x10
+#define JZ_REG_LCD_DAV				0x14
+#define JZ_REG_LCD_PS				0x18
+#define JZ_REG_LCD_CLS				0x1C
+#define JZ_REG_LCD_SPL				0x20
+#define JZ_REG_LCD_REV				0x24
+#define JZ_REG_LCD_CTRL				0x30
+#define JZ_REG_LCD_STATE			0x34
+#define JZ_REG_LCD_IID				0x38
+#define JZ_REG_LCD_DA0				0x40
+#define JZ_REG_LCD_SA0				0x44
+#define JZ_REG_LCD_FID0				0x48
+#define JZ_REG_LCD_CMD0				0x4C
+#define JZ_REG_LCD_DA1				0x50
+#define JZ_REG_LCD_SA1				0x54
+#define JZ_REG_LCD_FID1				0x58
+#define JZ_REG_LCD_CMD1				0x5C
+
+#define JZ_LCD_CFG_SLCD				BIT(31)
+#define JZ_LCD_CFG_PS_DISABLE			BIT(23)
+#define JZ_LCD_CFG_CLS_DISABLE			BIT(22)
+#define JZ_LCD_CFG_SPL_DISABLE			BIT(21)
+#define JZ_LCD_CFG_REV_DISABLE			BIT(20)
+#define JZ_LCD_CFG_HSYNCM			BIT(19)
+#define JZ_LCD_CFG_PCLKM			BIT(18)
+#define JZ_LCD_CFG_INV				BIT(17)
+#define JZ_LCD_CFG_SYNC_DIR			BIT(16)
+#define JZ_LCD_CFG_PS_POLARITY			BIT(15)
+#define JZ_LCD_CFG_CLS_POLARITY			BIT(14)
+#define JZ_LCD_CFG_SPL_POLARITY			BIT(13)
+#define JZ_LCD_CFG_REV_POLARITY			BIT(12)
+#define JZ_LCD_CFG_HSYNC_ACTIVE_LOW		BIT(11)
+#define JZ_LCD_CFG_PCLK_FALLING_EDGE		BIT(10)
+#define JZ_LCD_CFG_DE_ACTIVE_LOW		BIT(9)
+#define JZ_LCD_CFG_VSYNC_ACTIVE_LOW		BIT(8)
+#define JZ_LCD_CFG_18_BIT			BIT(7)
+#define JZ_LCD_CFG_PDW				(BIT(5) | BIT(4))
+
+#define JZ_LCD_CFG_MODE_GENERIC_16BIT		0
+#define JZ_LCD_CFG_MODE_GENERIC_18BIT		BIT(7)
+#define JZ_LCD_CFG_MODE_GENERIC_24BIT		BIT(6)
+
+#define JZ_LCD_CFG_MODE_SPECIAL_TFT_1		1
+#define JZ_LCD_CFG_MODE_SPECIAL_TFT_2		2
+#define JZ_LCD_CFG_MODE_SPECIAL_TFT_3		3
+
+#define JZ_LCD_CFG_MODE_TV_OUT_P		4
+#define JZ_LCD_CFG_MODE_TV_OUT_I		6
+
+#define JZ_LCD_CFG_MODE_SINGLE_COLOR_STN	8
+#define JZ_LCD_CFG_MODE_SINGLE_MONOCHROME_STN	9
+#define JZ_LCD_CFG_MODE_DUAL_COLOR_STN		10
+#define JZ_LCD_CFG_MODE_DUAL_MONOCHROME_STN	11
+
+#define JZ_LCD_CFG_MODE_8BIT_SERIAL		12
+#define JZ_LCD_CFG_MODE_LCM			13
+
+#define JZ_LCD_VSYNC_VPS_OFFSET			16
+#define JZ_LCD_VSYNC_VPE_OFFSET			0
+
+#define JZ_LCD_HSYNC_HPS_OFFSET			16
+#define JZ_LCD_HSYNC_HPE_OFFSET			0
+
+#define JZ_LCD_VAT_HT_OFFSET			16
+#define JZ_LCD_VAT_VT_OFFSET			0
+
+#define JZ_LCD_DAH_HDS_OFFSET			16
+#define JZ_LCD_DAH_HDE_OFFSET			0
+
+#define JZ_LCD_DAV_VDS_OFFSET			16
+#define JZ_LCD_DAV_VDE_OFFSET			0
+
+#define JZ_LCD_CTRL_BURST_4			(0x0 << 28)
+#define JZ_LCD_CTRL_BURST_8			(0x1 << 28)
+#define JZ_LCD_CTRL_BURST_16			(0x2 << 28)
+#define JZ_LCD_CTRL_RGB555			BIT(27)
+#define JZ_LCD_CTRL_OFUP			BIT(26)
+#define JZ_LCD_CTRL_FRC_GRAYSCALE_16		(0x0 << 24)
+#define JZ_LCD_CTRL_FRC_GRAYSCALE_4		(0x1 << 24)
+#define JZ_LCD_CTRL_FRC_GRAYSCALE_2		(0x2 << 24)
+#define JZ_LCD_CTRL_PDD_MASK			(0xff << 16)
+#define JZ_LCD_CTRL_EOF_IRQ			BIT(13)
+#define JZ_LCD_CTRL_SOF_IRQ			BIT(12)
+#define JZ_LCD_CTRL_OFU_IRQ			BIT(11)
+#define JZ_LCD_CTRL_IFU0_IRQ			BIT(10)
+#define JZ_LCD_CTRL_IFU1_IRQ			BIT(9)
+#define JZ_LCD_CTRL_DD_IRQ			BIT(8)
+#define JZ_LCD_CTRL_QDD_IRQ			BIT(7)
+#define JZ_LCD_CTRL_REVERSE_ENDIAN		BIT(6)
+#define JZ_LCD_CTRL_LSB_FISRT			BIT(5)
+#define JZ_LCD_CTRL_DISABLE			BIT(4)
+#define JZ_LCD_CTRL_ENABLE			BIT(3)
+#define JZ_LCD_CTRL_BPP_1			0x0
+#define JZ_LCD_CTRL_BPP_2			0x1
+#define JZ_LCD_CTRL_BPP_4			0x2
+#define JZ_LCD_CTRL_BPP_8			0x3
+#define JZ_LCD_CTRL_BPP_15_16			0x4
+#define JZ_LCD_CTRL_BPP_18_24			0x5
+#define JZ_LCD_CTRL_BPP_MASK			(JZ_LCD_CTRL_RGB555 | 0x7)
+
+#define JZ_LCD_CMD_SOF_IRQ			BIT(31)
+#define JZ_LCD_CMD_EOF_IRQ			BIT(30)
+#define JZ_LCD_CMD_ENABLE_PAL			BIT(28)
+
+#define JZ_LCD_SYNC_MASK			0x3ff
+
+#define JZ_LCD_STATE_EOF_IRQ			BIT(5)
+#define JZ_LCD_STATE_SOF_IRQ			BIT(4)
+#define JZ_LCD_STATE_DISABLED			BIT(0)
+
+#endif /* DRIVERS_GPU_DRM_INGENIC_INGENIC_DRM_H */
-- 
2.27.0


^ permalink raw reply	[flat|nested] 22+ messages in thread

* [PATCH v2 08/10] drm/ingenic: Add support for OSD mode
  2020-06-29 23:52 [PATCH v2 01/10] dt-bindings: display: Convert ingenic,lcd.txt to YAML Paul Cercueil
                   ` (5 preceding siblings ...)
  2020-06-29 23:52 ` [PATCH v2 07/10] drm/ingenic: Move register definitions to ingenic-drm.h Paul Cercueil
@ 2020-06-29 23:52 ` Paul Cercueil
  2020-06-30 12:05   ` Sam Ravnborg
  2020-06-29 23:52 ` [PATCH v2 09/10] drm/ingenic: Add support for the IPU Paul Cercueil
  2020-06-29 23:52 ` [PATCH v2 10/10] drm/ingenic: Support multiple panels/bridges Paul Cercueil
  8 siblings, 1 reply; 22+ messages in thread
From: Paul Cercueil @ 2020-06-29 23:52 UTC (permalink / raw)
  To: David Airlie, Daniel Vetter, Rob Herring
  Cc: od, dri-devel, devicetree, linux-mips, linux-kernel, Paul Cercueil

All Ingenic SoCs starting from the JZ4725B support OSD mode.

In this mode, two separate planes can be used. They can have different
positions and sizes, and one can be overlayed on top of the other.

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---

Notes:
    v2: Use fallthrough; instead of /* fall-through */

 drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 271 +++++++++++++++++-----
 drivers/gpu/drm/ingenic/ingenic-drm.h     |  35 +++
 2 files changed, 254 insertions(+), 52 deletions(-)

diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
index 6590b61cb915..a8573da1d577 100644
--- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
+++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
@@ -43,12 +43,13 @@ struct ingenic_dma_hwdesc {
 
 struct jz_soc_info {
 	bool needs_dev_clk;
+	bool has_osd;
 	unsigned int max_width, max_height;
 };
 
 struct ingenic_drm {
 	struct drm_device drm;
-	struct drm_plane primary;
+	struct drm_plane f0, f1;
 	struct drm_crtc crtc;
 	struct drm_encoder encoder;
 
@@ -57,8 +58,8 @@ struct ingenic_drm {
 	struct clk *lcd_clk, *pix_clk;
 	const struct jz_soc_info *soc_info;
 
-	struct ingenic_dma_hwdesc *dma_hwdesc;
-	dma_addr_t dma_hwdesc_phys;
+	struct ingenic_dma_hwdesc *dma_hwdesc[2];
+	dma_addr_t dma_hwdesc_phys[2];
 
 	bool panel_is_sharp;
 };
@@ -90,7 +91,7 @@ static const struct regmap_config ingenic_drm_regmap_config = {
 	.val_bits = 32,
 	.reg_stride = 4,
 
-	.max_register = JZ_REG_LCD_CMD1,
+	.max_register = JZ_REG_LCD_SIZE1,
 	.writeable_reg = ingenic_drm_writeable_reg,
 };
 
@@ -110,11 +111,6 @@ drm_encoder_get_priv(struct drm_encoder *encoder)
 	return container_of(encoder, struct ingenic_drm, encoder);
 }
 
-static inline struct ingenic_drm *drm_plane_get_priv(struct drm_plane *plane)
-{
-	return container_of(plane, struct ingenic_drm, primary);
-}
-
 static void ingenic_drm_crtc_atomic_enable(struct drm_crtc *crtc,
 					   struct drm_crtc_state *state)
 {
@@ -185,34 +181,17 @@ static void ingenic_drm_crtc_update_timings(struct ingenic_drm *priv,
 		regmap_write(priv->map, JZ_REG_LCD_SPL, hpe << 16 | (hpe + 1));
 		regmap_write(priv->map, JZ_REG_LCD_REV, mode->htotal << 16);
 	}
-}
-
-static void ingenic_drm_crtc_update_ctrl(struct ingenic_drm *priv,
-					 const struct drm_format_info *finfo)
-{
-	unsigned int ctrl = JZ_LCD_CTRL_OFUP | JZ_LCD_CTRL_BURST_16;
-
-	switch (finfo->format) {
-	case DRM_FORMAT_XRGB1555:
-		ctrl |= JZ_LCD_CTRL_RGB555;
-		/* fall-through */
-	case DRM_FORMAT_RGB565:
-		ctrl |= JZ_LCD_CTRL_BPP_15_16;
-		break;
-	case DRM_FORMAT_XRGB8888:
-		ctrl |= JZ_LCD_CTRL_BPP_18_24;
-		break;
-	}
 
 	regmap_update_bits(priv->map, JZ_REG_LCD_CTRL,
-			   JZ_LCD_CTRL_OFUP | JZ_LCD_CTRL_BURST_16 |
-			   JZ_LCD_CTRL_BPP_MASK, ctrl);
+			   JZ_LCD_CTRL_OFUP | JZ_LCD_CTRL_BURST_16,
+			   JZ_LCD_CTRL_OFUP | JZ_LCD_CTRL_BURST_16);
 }
 
 static int ingenic_drm_crtc_atomic_check(struct drm_crtc *crtc,
 					 struct drm_crtc_state *state)
 {
 	struct ingenic_drm *priv = drm_crtc_get_priv(crtc);
+	struct drm_plane_state *f1_state, *f0_state;
 	long rate;
 
 	if (!drm_atomic_crtc_needs_modeset(state))
@@ -227,6 +206,15 @@ static int ingenic_drm_crtc_atomic_check(struct drm_crtc *crtc,
 	if (rate < 0)
 		return rate;
 
+	if (priv->soc_info->has_osd) {
+		f1_state = drm_atomic_get_plane_state(state->state, &priv->f1);
+		f0_state = drm_atomic_get_plane_state(state->state, &priv->f0);
+
+		/* If all the planes are disabled, we won't get a VBLANK IRQ */
+		if (!f1_state->fb && !f0_state->fb)
+			state->no_vblank = true;
+	}
+
 	return 0;
 }
 
@@ -236,14 +224,9 @@ static void ingenic_drm_crtc_atomic_flush(struct drm_crtc *crtc,
 	struct ingenic_drm *priv = drm_crtc_get_priv(crtc);
 	struct drm_crtc_state *state = crtc->state;
 	struct drm_pending_vblank_event *event = state->event;
-	struct drm_framebuffer *drm_fb = crtc->primary->state->fb;
-	const struct drm_format_info *finfo;
 
 	if (drm_atomic_crtc_needs_modeset(state)) {
-		finfo = drm_format_info(drm_fb->format->format);
-
 		ingenic_drm_crtc_update_timings(priv, &state->mode);
-		ingenic_drm_crtc_update_ctrl(priv, finfo);
 
 		clk_set_rate(priv->pix_clk, state->adjusted_mode.clock * 1000);
 	}
@@ -260,12 +243,149 @@ static void ingenic_drm_crtc_atomic_flush(struct drm_crtc *crtc,
 	}
 }
 
+static int ingenic_drm_plane_atomic_check(struct drm_plane *plane,
+					  struct drm_plane_state *state)
+{
+	struct ingenic_drm *priv = drm_device_get_priv(plane->dev);
+	struct drm_crtc_state *crtc_state;
+	struct drm_crtc *crtc = state->crtc ?: plane->state->crtc;
+	int ret;
+
+	if (!crtc)
+		return 0;
+
+	crtc_state = drm_atomic_get_existing_crtc_state(state->state, crtc);
+	if (WARN_ON(!crtc_state))
+		return -EINVAL;
+
+	ret = drm_atomic_helper_check_plane_state(state, crtc_state,
+						  DRM_PLANE_HELPER_NO_SCALING,
+						  DRM_PLANE_HELPER_NO_SCALING,
+						  priv->soc_info->has_osd,
+						  true);
+	if (ret)
+		return ret;
+
+	if (!priv->soc_info->has_osd &&
+	    (state->src_x != 0 ||
+	     (state->src_w >> 16) != state->crtc_w ||
+	     (state->src_h >> 16) != state->crtc_h))
+		return -EINVAL;
+
+	/*
+	 * Require full modeset if if enabling or disabling a plane, or changing
+	 * its position, size or depth.
+	 */
+	if (priv->soc_info->has_osd &&
+	    (!plane->state->fb || !state->fb ||
+	     plane->state->crtc_x != state->crtc_x ||
+	     plane->state->crtc_y != state->crtc_y ||
+	     plane->state->crtc_w != state->crtc_w ||
+	     plane->state->crtc_h != state->crtc_h ||
+	     plane->state->fb->format->format != state->fb->format->format))
+		crtc_state->mode_changed = true;
+
+	return 0;
+}
+
+static void ingenic_drm_plane_enable(struct ingenic_drm *priv,
+				      struct drm_plane *plane)
+{
+	unsigned int en_bit;
+
+	if (priv->soc_info->has_osd) {
+		if (plane->type == DRM_PLANE_TYPE_PRIMARY)
+			en_bit = JZ_LCD_OSDC_F1EN;
+		else
+			en_bit = JZ_LCD_OSDC_F0EN;
+
+		regmap_update_bits(priv->map, JZ_REG_LCD_OSDC, en_bit, en_bit);
+	}
+}
+
+static void ingenic_drm_plane_atomic_disable(struct drm_plane *plane,
+					     struct drm_plane_state *old_state)
+{
+	struct ingenic_drm *priv = drm_device_get_priv(plane->dev);
+	unsigned int en_bit;
+
+	if (priv->soc_info->has_osd) {
+		if (plane->type == DRM_PLANE_TYPE_PRIMARY)
+			en_bit = JZ_LCD_OSDC_F1EN;
+		else
+			en_bit = JZ_LCD_OSDC_F0EN;
+
+		regmap_update_bits(priv->map, JZ_REG_LCD_OSDC, en_bit, 0);
+	}
+}
+
+static void ingenic_drm_plane_config(struct ingenic_drm *priv,
+				     struct drm_plane *plane, u32 fourcc)
+{
+	struct drm_plane_state *state = plane->state;
+	unsigned int xy_reg, size_reg;
+	unsigned int ctrl = 0;
+
+	ingenic_drm_plane_enable(priv, plane);
+
+	if (priv->soc_info->has_osd &&
+	    plane->type == DRM_PLANE_TYPE_PRIMARY) {
+		switch (fourcc) {
+		case DRM_FORMAT_XRGB1555:
+			ctrl |= JZ_LCD_OSDCTRL_RGB555;
+			fallthrough;
+		case DRM_FORMAT_RGB565:
+			ctrl |= JZ_LCD_OSDCTRL_BPP_15_16;
+			break;
+		case DRM_FORMAT_XRGB8888:
+			ctrl |= JZ_LCD_OSDCTRL_BPP_18_24;
+			break;
+		}
+
+		regmap_update_bits(priv->map, JZ_REG_LCD_OSDCTRL,
+				   JZ_LCD_OSDCTRL_BPP_MASK, ctrl);
+	} else {
+		switch (fourcc) {
+		case DRM_FORMAT_XRGB1555:
+			ctrl |= JZ_LCD_CTRL_RGB555;
+			fallthrough;
+		case DRM_FORMAT_RGB565:
+			ctrl |= JZ_LCD_CTRL_BPP_15_16;
+			break;
+		case DRM_FORMAT_XRGB8888:
+			ctrl |= JZ_LCD_CTRL_BPP_18_24;
+			break;
+		}
+
+		regmap_update_bits(priv->map, JZ_REG_LCD_CTRL,
+				   JZ_LCD_CTRL_BPP_MASK, ctrl);
+	}
+
+	if (priv->soc_info->has_osd) {
+		if (plane->type == DRM_PLANE_TYPE_PRIMARY) {
+			xy_reg = JZ_REG_LCD_XYP1;
+			size_reg = JZ_REG_LCD_SIZE1;
+		} else {
+			xy_reg = JZ_REG_LCD_XYP0;
+			size_reg = JZ_REG_LCD_SIZE0;
+		}
+
+		regmap_write(priv->map, xy_reg,
+			     state->crtc_x << JZ_LCD_XYP01_XPOS_LSB |
+			     state->crtc_y << JZ_LCD_XYP01_YPOS_LSB);
+		regmap_write(priv->map, size_reg,
+			     state->crtc_w << JZ_LCD_SIZE01_WIDTH_LSB |
+			     state->crtc_h << JZ_LCD_SIZE01_HEIGHT_LSB);
+	}
+}
+
 static void ingenic_drm_plane_atomic_update(struct drm_plane *plane,
 					    struct drm_plane_state *oldstate)
 {
-	struct ingenic_drm *priv = drm_plane_get_priv(plane);
+	struct ingenic_drm *priv = drm_device_get_priv(plane->dev);
 	struct drm_plane_state *state = plane->state;
 	unsigned int width, height, cpp;
+	unsigned int hwdesc_idx;
 	dma_addr_t addr;
 
 	if (state && state->fb) {
@@ -274,9 +394,18 @@ static void ingenic_drm_plane_atomic_update(struct drm_plane *plane,
 		height = state->src_h >> 16;
 		cpp = state->fb->format->cpp[0];
 
-		priv->dma_hwdesc->addr = addr;
-		priv->dma_hwdesc->cmd = width * height * cpp / 4;
-		priv->dma_hwdesc->cmd |= JZ_LCD_CMD_EOF_IRQ;
+		if (!priv->soc_info->has_osd)
+			hwdesc_idx = 0;
+		else
+			hwdesc_idx = plane->type == DRM_PLANE_TYPE_PRIMARY;
+
+		priv->dma_hwdesc[hwdesc_idx]->addr = addr;
+		priv->dma_hwdesc[hwdesc_idx]->cmd = width * height * cpp / 4;
+		priv->dma_hwdesc[hwdesc_idx]->cmd |= JZ_LCD_CMD_EOF_IRQ;
+
+		if (drm_atomic_crtc_needs_modeset(state->crtc->state))
+			ingenic_drm_plane_config(priv, plane,
+						 state->fb->format->format);
 	}
 }
 
@@ -437,6 +566,8 @@ static const struct drm_crtc_funcs ingenic_drm_crtc_funcs = {
 
 static const struct drm_plane_helper_funcs ingenic_drm_plane_helper_funcs = {
 	.atomic_update		= ingenic_drm_plane_atomic_update,
+	.atomic_check		= ingenic_drm_plane_atomic_check,
+	.atomic_disable		= ingenic_drm_plane_atomic_disable,
 	.prepare_fb		= drm_gem_fb_prepare_fb,
 };
 
@@ -463,8 +594,10 @@ static void ingenic_drm_free_dma_hwdesc(void *d)
 {
 	struct ingenic_drm *priv = d;
 
-	dma_free_coherent(priv->dev, sizeof(*priv->dma_hwdesc),
-			  priv->dma_hwdesc, priv->dma_hwdesc_phys);
+	dma_free_coherent(priv->dev, sizeof(*priv->dma_hwdesc[0]),
+			  priv->dma_hwdesc[0], priv->dma_hwdesc_phys[0]);
+	dma_free_coherent(priv->dev, sizeof(*priv->dma_hwdesc[1]),
+			  priv->dma_hwdesc[1], priv->dma_hwdesc_phys[1]);
 }
 
 static int ingenic_drm_probe(struct platform_device *pdev)
@@ -549,23 +682,32 @@ static int ingenic_drm_probe(struct platform_device *pdev)
 		bridge = devm_drm_panel_bridge_add_typed(dev, panel,
 							 DRM_MODE_CONNECTOR_DPI);
 
-	priv->dma_hwdesc = dma_alloc_coherent(dev, sizeof(*priv->dma_hwdesc),
-					      &priv->dma_hwdesc_phys,
-					      GFP_KERNEL);
-	if (!priv->dma_hwdesc)
+	priv->dma_hwdesc[0] = dma_alloc_coherent(dev, sizeof(*priv->dma_hwdesc[0]),
+						 &priv->dma_hwdesc_phys[0],
+						 GFP_KERNEL);
+	if (!priv->dma_hwdesc[0])
+		return -ENOMEM;
+
+	priv->dma_hwdesc[0]->next = priv->dma_hwdesc_phys[0];
+	priv->dma_hwdesc[0]->id = 0xdeafbead;
+
+	priv->dma_hwdesc[1] = dma_alloc_coherent(dev, sizeof(*priv->dma_hwdesc[1]),
+						 &priv->dma_hwdesc_phys[1],
+						 GFP_KERNEL);
+	if (!priv->dma_hwdesc[1])
 		return -ENOMEM;
 
+	priv->dma_hwdesc[1]->next = priv->dma_hwdesc_phys[1];
+	priv->dma_hwdesc[1]->id = 0xdeadbabe;
+
 	ret = devm_add_action_or_reset(dev, ingenic_drm_free_dma_hwdesc, priv);
 	if (ret)
 		return ret;
 
-	priv->dma_hwdesc->next = priv->dma_hwdesc_phys;
-	priv->dma_hwdesc->id = 0xdeafbead;
-
-	drm_plane_helper_add(&priv->primary, &ingenic_drm_plane_helper_funcs);
+	drm_plane_helper_add(&priv->f1, &ingenic_drm_plane_helper_funcs);
 
-	ret = drm_universal_plane_init(drm, &priv->primary,
-				       0, &ingenic_drm_primary_plane_funcs,
+	ret = drm_universal_plane_init(drm, &priv->f1, 1,
+				       &ingenic_drm_primary_plane_funcs,
 				       ingenic_drm_primary_formats,
 				       ARRAY_SIZE(ingenic_drm_primary_formats),
 				       NULL, DRM_PLANE_TYPE_PRIMARY, NULL);
@@ -576,13 +718,30 @@ static int ingenic_drm_probe(struct platform_device *pdev)
 
 	drm_crtc_helper_add(&priv->crtc, &ingenic_drm_crtc_helper_funcs);
 
-	ret = drm_crtc_init_with_planes(drm, &priv->crtc, &priv->primary,
+	ret = drm_crtc_init_with_planes(drm, &priv->crtc, &priv->f1,
 					NULL, &ingenic_drm_crtc_funcs, NULL);
 	if (ret) {
 		dev_err(dev, "Failed to init CRTC: %i\n", ret);
 		return ret;
 	}
 
+	if (soc_info->has_osd) {
+		drm_plane_helper_add(&priv->f0,
+				     &ingenic_drm_plane_helper_funcs);
+
+		ret = drm_universal_plane_init(drm, &priv->f0, 1,
+					       &ingenic_drm_primary_plane_funcs,
+					       ingenic_drm_primary_formats,
+					       ARRAY_SIZE(ingenic_drm_primary_formats),
+					       NULL, DRM_PLANE_TYPE_OVERLAY,
+					       NULL);
+		if (ret) {
+			dev_err(dev, "Failed to register overlay plane: %i\n",
+				ret);
+			return ret;
+		}
+	}
+
 	priv->encoder.possible_crtcs = 1;
 
 	drm_encoder_helper_add(&priv->encoder,
@@ -644,7 +803,12 @@ static int ingenic_drm_probe(struct platform_device *pdev)
 	}
 
 	/* Set address of our DMA descriptor chain */
-	regmap_write(priv->map, JZ_REG_LCD_DA0, priv->dma_hwdesc_phys);
+	regmap_write(priv->map, JZ_REG_LCD_DA0, priv->dma_hwdesc_phys[0]);
+	regmap_write(priv->map, JZ_REG_LCD_DA1, priv->dma_hwdesc_phys[1]);
+
+	/* Enable OSD if available */
+	if (soc_info->has_osd)
+		regmap_write(priv->map, JZ_REG_LCD_OSDC, JZ_LCD_OSDC_OSDEN);
 
 	ret = drm_dev_register(drm, 0);
 	if (ret) {
@@ -680,18 +844,21 @@ static int ingenic_drm_remove(struct platform_device *pdev)
 
 static const struct jz_soc_info jz4740_soc_info = {
 	.needs_dev_clk = true,
+	.has_osd = false,
 	.max_width = 800,
 	.max_height = 600,
 };
 
 static const struct jz_soc_info jz4725b_soc_info = {
 	.needs_dev_clk = false,
+	.has_osd = true,
 	.max_width = 800,
 	.max_height = 600,
 };
 
 static const struct jz_soc_info jz4770_soc_info = {
 	.needs_dev_clk = false,
+	.has_osd = true,
 	.max_width = 1280,
 	.max_height = 720,
 };
diff --git a/drivers/gpu/drm/ingenic/ingenic-drm.h b/drivers/gpu/drm/ingenic/ingenic-drm.h
index cb578cff7bb1..d0b827a9fe83 100644
--- a/drivers/gpu/drm/ingenic/ingenic-drm.h
+++ b/drivers/gpu/drm/ingenic/ingenic-drm.h
@@ -30,6 +30,18 @@
 #define JZ_REG_LCD_SA1				0x54
 #define JZ_REG_LCD_FID1				0x58
 #define JZ_REG_LCD_CMD1				0x5C
+#define JZ_REG_LCD_OSDC				0x100
+#define JZ_REG_LCD_OSDCTRL			0x104
+#define JZ_REG_LCD_OSDS				0x108
+#define JZ_REG_LCD_BGC				0x10c
+#define JZ_REG_LCD_KEY0				0x110
+#define JZ_REG_LCD_KEY1				0x114
+#define JZ_REG_LCD_ALPHA			0x118
+#define JZ_REG_LCD_IPUR				0x11c
+#define JZ_REG_LCD_XYP0				0x120
+#define JZ_REG_LCD_XYP1				0x124
+#define JZ_REG_LCD_SIZE0			0x128
+#define JZ_REG_LCD_SIZE1			0x12c
 
 #define JZ_LCD_CFG_SLCD				BIT(31)
 #define JZ_LCD_CFG_PS_DISABLE			BIT(23)
@@ -123,4 +135,27 @@
 #define JZ_LCD_STATE_SOF_IRQ			BIT(4)
 #define JZ_LCD_STATE_DISABLED			BIT(0)
 
+#define JZ_LCD_OSDC_OSDEN			BIT(0)
+#define JZ_LCD_OSDC_F0EN			BIT(3)
+#define JZ_LCD_OSDC_F1EN			BIT(4)
+
+#define JZ_LCD_OSDCTRL_IPU			BIT(15)
+#define JZ_LCD_OSDCTRL_RGB555			BIT(4)
+#define JZ_LCD_OSDCTRL_CHANGE			BIT(3)
+#define JZ_LCD_OSDCTRL_BPP_15_16		0x4
+#define JZ_LCD_OSDCTRL_BPP_18_24		0x5
+#define JZ_LCD_OSDCTRL_BPP_30			0x7
+#define JZ_LCD_OSDCTRL_BPP_MASK			(JZ_LCD_OSDCTRL_RGB555 | 0x7)
+
+#define JZ_LCD_OSDS_READY			BIT(0)
+
+#define JZ_LCD_IPUR_IPUREN			BIT(31)
+#define JZ_LCD_IPUR_IPUR_LSB			0
+
+#define JZ_LCD_XYP01_XPOS_LSB			0
+#define JZ_LCD_XYP01_YPOS_LSB			16
+
+#define JZ_LCD_SIZE01_WIDTH_LSB			0
+#define JZ_LCD_SIZE01_HEIGHT_LSB		16
+
 #endif /* DRIVERS_GPU_DRM_INGENIC_INGENIC_DRM_H */
-- 
2.27.0


^ permalink raw reply	[flat|nested] 22+ messages in thread

* [PATCH v2 09/10] drm/ingenic: Add support for the IPU
  2020-06-29 23:52 [PATCH v2 01/10] dt-bindings: display: Convert ingenic,lcd.txt to YAML Paul Cercueil
                   ` (6 preceding siblings ...)
  2020-06-29 23:52 ` [PATCH v2 08/10] drm/ingenic: Add support for OSD mode Paul Cercueil
@ 2020-06-29 23:52 ` Paul Cercueil
  2020-06-30 12:16   ` Sam Ravnborg
  2020-06-29 23:52 ` [PATCH v2 10/10] drm/ingenic: Support multiple panels/bridges Paul Cercueil
  8 siblings, 1 reply; 22+ messages in thread
From: Paul Cercueil @ 2020-06-29 23:52 UTC (permalink / raw)
  To: David Airlie, Daniel Vetter, Rob Herring
  Cc: od, dri-devel, devicetree, linux-mips, linux-kernel, Paul Cercueil

Add support for the Image Processing Unit (IPU) found in all Ingenic
SoCs.

The IPU can upscale and downscale a source frame of arbitrary size
ranging from 4x4 to 4096x4096 on newer SoCs, with bicubic filtering
on newer SoCs, bilinear filtering on older SoCs. Nearest-neighbour can
also be obtained with proper coefficients.

Starting from the JZ4725B, the IPU supports a mode where its output is
sent directly to the LCDC, without having to be written to RAM first.
This makes it possible to use the IPU as a DRM plane on the compatible
SoCs, and have it convert and scale anything the userspace asks for to
what's available for the display.

Regarding pixel formats, older SoCs support packed YUV 4:2:2 and various
planar YUV formats. Newer SoCs introduced support for RGB.

Since the IPU is a separate hardware block, to make it work properly the
Ingenic DRM driver will now register itself as a component master in
case the IPU driver has been enabled in the config.

When enabled in the config, the CRTC will see the IPU as a second primary
plane. It cannot be enabled at the same time as the regular primary
plane. It has the same priority, which means that it will also display
below the overlay plane.

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---

Notes:
    v2: - ingenic-ipu is no longer its own module. It will be built
    	  into the ingenic-drm module.
    	- If enabled in the config, both the core driver and the IPU
    	  driver will register as components; otherwise the core
    	  driver will bypass that and call the ingenic_drm_bind()
    	  function directly.
    	- Since both files now build into the same module, the
    	  symbols previously exported as GPL are not exported anymore,
    	  since they are only used internally.
    	- Fix SPDX license header in ingenic-ipu.h
    	- Avoid using 'for(;;);' loops without trailing statement(s)

 drivers/gpu/drm/ingenic/Kconfig           |  11 +
 drivers/gpu/drm/ingenic/Makefile          |   3 +-
 drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 155 +++-
 drivers/gpu/drm/ingenic/ingenic-drm.h     |  12 +
 drivers/gpu/drm/ingenic/ingenic-ipu.c     | 848 ++++++++++++++++++++++
 drivers/gpu/drm/ingenic/ingenic-ipu.h     | 109 +++
 6 files changed, 1122 insertions(+), 16 deletions(-)
 create mode 100644 drivers/gpu/drm/ingenic/ingenic-ipu.c
 create mode 100644 drivers/gpu/drm/ingenic/ingenic-ipu.h

diff --git a/drivers/gpu/drm/ingenic/Kconfig b/drivers/gpu/drm/ingenic/Kconfig
index d82c3d37ec9c..477d5387e43e 100644
--- a/drivers/gpu/drm/ingenic/Kconfig
+++ b/drivers/gpu/drm/ingenic/Kconfig
@@ -14,3 +14,14 @@ config DRM_INGENIC
 	  Choose this option for DRM support for the Ingenic SoCs.
 
 	  If M is selected the module will be called ingenic-drm.
+
+if DRM_INGENIC
+
+config DRM_INGENIC_IPU
+	bool "IPU support for Ingenic SoCs"
+	help
+	  Choose this option to enable support for the IPU found in Ingenic SoCs.
+
+	  The Image Processing Unit (IPU) will appear as a second primary plane.
+
+endif
diff --git a/drivers/gpu/drm/ingenic/Makefile b/drivers/gpu/drm/ingenic/Makefile
index 9875628dd8bc..d313326bdddb 100644
--- a/drivers/gpu/drm/ingenic/Makefile
+++ b/drivers/gpu/drm/ingenic/Makefile
@@ -1,2 +1,3 @@
 obj-$(CONFIG_DRM_INGENIC) += ingenic-drm.o
-ingenic-drm-y += ingenic-drm-drv.o
+ingenic-drm-y = ingenic-drm-drv.o
+ingenic-drm-$(CONFIG_DRM_INGENIC_IPU) += ingenic-ipu.o
diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
index a8573da1d577..36440acd23de 100644
--- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
+++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
@@ -6,6 +6,7 @@
 
 #include "ingenic-drm.h"
 
+#include <linux/component.h>
 #include <linux/clk.h>
 #include <linux/dma-mapping.h>
 #include <linux/module.h>
@@ -49,7 +50,7 @@ struct jz_soc_info {
 
 struct ingenic_drm {
 	struct drm_device drm;
-	struct drm_plane f0, f1;
+	struct drm_plane f0, f1, *ipu_plane;
 	struct drm_crtc crtc;
 	struct drm_encoder encoder;
 
@@ -185,13 +186,16 @@ static void ingenic_drm_crtc_update_timings(struct ingenic_drm *priv,
 	regmap_update_bits(priv->map, JZ_REG_LCD_CTRL,
 			   JZ_LCD_CTRL_OFUP | JZ_LCD_CTRL_BURST_16,
 			   JZ_LCD_CTRL_OFUP | JZ_LCD_CTRL_BURST_16);
+
+	regmap_write(priv->map, JZ_REG_LCD_IPUR, JZ_LCD_IPUR_IPUREN |
+		     (ht * vpe / 3) << JZ_LCD_IPUR_IPUR_LSB);
 }
 
 static int ingenic_drm_crtc_atomic_check(struct drm_crtc *crtc,
 					 struct drm_crtc_state *state)
 {
 	struct ingenic_drm *priv = drm_crtc_get_priv(crtc);
-	struct drm_plane_state *f1_state, *f0_state;
+	struct drm_plane_state *f1_state, *f0_state, *ipu_state;
 	long rate;
 
 	if (!drm_atomic_crtc_needs_modeset(state))
@@ -210,14 +214,40 @@ static int ingenic_drm_crtc_atomic_check(struct drm_crtc *crtc,
 		f1_state = drm_atomic_get_plane_state(state->state, &priv->f1);
 		f0_state = drm_atomic_get_plane_state(state->state, &priv->f0);
 
+		if (priv->ipu_plane)
+			ipu_state = drm_atomic_get_plane_state(state->state, priv->ipu_plane);
+
+		/* IPU and F1 planes cannot be enabled at the same time. */
+		if (priv->ipu_plane && f1_state->fb && ipu_state->fb) {
+			dev_dbg(priv->dev, "Cannot enable both F1 and IPU\n");
+			return -EINVAL;
+		}
+
 		/* If all the planes are disabled, we won't get a VBLANK IRQ */
-		if (!f1_state->fb && !f0_state->fb)
+		if (!f1_state->fb && !f0_state->fb &&
+		    !(priv->ipu_plane && ipu_state->fb))
 			state->no_vblank = true;
 	}
 
 	return 0;
 }
 
+static void ingenic_drm_crtc_atomic_begin(struct drm_crtc *crtc,
+					  struct drm_crtc_state *oldstate)
+{
+	struct ingenic_drm *priv = drm_crtc_get_priv(crtc);
+	u32 ctrl = 0;
+
+	if (priv->soc_info->has_osd &&
+	    drm_atomic_crtc_needs_modeset(crtc->state)) {
+		if (priv->ipu_plane && priv->ipu_plane->state->fb)
+			ctrl |= JZ_LCD_OSDCTRL_IPU;
+
+		regmap_update_bits(priv->map, JZ_REG_LCD_OSDCTRL,
+				   JZ_LCD_OSDCTRL_IPU, ctrl);
+	}
+}
+
 static void ingenic_drm_crtc_atomic_flush(struct drm_crtc *crtc,
 					  struct drm_crtc_state *oldstate)
 {
@@ -303,10 +333,9 @@ static void ingenic_drm_plane_enable(struct ingenic_drm *priv,
 	}
 }
 
-static void ingenic_drm_plane_atomic_disable(struct drm_plane *plane,
-					     struct drm_plane_state *old_state)
+void ingenic_drm_plane_disable(struct device *dev, struct drm_plane *plane)
 {
-	struct ingenic_drm *priv = drm_device_get_priv(plane->dev);
+	struct ingenic_drm *priv = dev_get_drvdata(dev);
 	unsigned int en_bit;
 
 	if (priv->soc_info->has_osd) {
@@ -319,9 +348,18 @@ static void ingenic_drm_plane_atomic_disable(struct drm_plane *plane,
 	}
 }
 
-static void ingenic_drm_plane_config(struct ingenic_drm *priv,
-				     struct drm_plane *plane, u32 fourcc)
+static void ingenic_drm_plane_atomic_disable(struct drm_plane *plane,
+					     struct drm_plane_state *old_state)
 {
+	struct ingenic_drm *priv = drm_device_get_priv(plane->dev);
+
+	ingenic_drm_plane_disable(priv->dev, plane);
+}
+
+void ingenic_drm_plane_config(struct device *dev,
+			      struct drm_plane *plane, u32 fourcc)
+{
+	struct ingenic_drm *priv = dev_get_drvdata(dev);
 	struct drm_plane_state *state = plane->state;
 	unsigned int xy_reg, size_reg;
 	unsigned int ctrl = 0;
@@ -404,7 +442,7 @@ static void ingenic_drm_plane_atomic_update(struct drm_plane *plane,
 		priv->dma_hwdesc[hwdesc_idx]->cmd |= JZ_LCD_CMD_EOF_IRQ;
 
 		if (drm_atomic_crtc_needs_modeset(state->crtc->state))
-			ingenic_drm_plane_config(priv, plane,
+			ingenic_drm_plane_config(priv->dev, plane,
 						 state->fb->format->format);
 	}
 }
@@ -574,6 +612,7 @@ static const struct drm_plane_helper_funcs ingenic_drm_plane_helper_funcs = {
 static const struct drm_crtc_helper_funcs ingenic_drm_crtc_helper_funcs = {
 	.atomic_enable		= ingenic_drm_crtc_atomic_enable,
 	.atomic_disable		= ingenic_drm_crtc_atomic_disable,
+	.atomic_begin		= ingenic_drm_crtc_atomic_begin,
 	.atomic_flush		= ingenic_drm_crtc_atomic_flush,
 	.atomic_check		= ingenic_drm_crtc_atomic_check,
 };
@@ -600,10 +639,17 @@ static void ingenic_drm_free_dma_hwdesc(void *d)
 			  priv->dma_hwdesc[1], priv->dma_hwdesc_phys[1]);
 }
 
-static int ingenic_drm_probe(struct platform_device *pdev)
+static void ingenic_drm_unbind_all(void *d)
+{
+	struct ingenic_drm *priv = d;
+
+	component_unbind_all(priv->dev, &priv->drm);
+}
+
+static int ingenic_drm_bind(struct device *dev)
 {
+	struct platform_device *pdev = to_platform_device(dev);
 	const struct jz_soc_info *soc_info;
-	struct device *dev = &pdev->dev;
 	struct ingenic_drm *priv;
 	struct clk *parent_clk;
 	struct drm_bridge *bridge;
@@ -640,6 +686,19 @@ static int ingenic_drm_probe(struct platform_device *pdev)
 	drm->mode_config.max_height = 4095;
 	drm->mode_config.funcs = &ingenic_drm_mode_config_funcs;
 
+	if (IS_ENABLED(CONFIG_DRM_INGENIC_IPU)) {
+		ret = component_bind_all(dev, drm);
+		if (ret) {
+			if (ret != -EPROBE_DEFER)
+				dev_err(dev, "Failed to bind components: %i\n", ret);
+			return ret;
+		}
+
+		ret = devm_add_action_or_reset(dev, ingenic_drm_unbind_all, priv);
+		if (ret)
+			return ret;
+	}
+
 	base = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(base)) {
 		dev_err(dev, "Failed to get memory resource\n");
@@ -704,6 +763,9 @@ static int ingenic_drm_probe(struct platform_device *pdev)
 	if (ret)
 		return ret;
 
+	if (soc_info->has_osd)
+		priv->ipu_plane = drm_plane_from_index(drm, 0);
+
 	drm_plane_helper_add(&priv->f1, &ingenic_drm_plane_helper_funcs);
 
 	ret = drm_universal_plane_init(drm, &priv->f1, 1,
@@ -712,7 +774,7 @@ static int ingenic_drm_probe(struct platform_device *pdev)
 				       ARRAY_SIZE(ingenic_drm_primary_formats),
 				       NULL, DRM_PLANE_TYPE_PRIMARY, NULL);
 	if (ret) {
-		dev_err(dev, "Failed to register primary plane: %i\n", ret);
+		dev_err(dev, "Failed to register plane: %i\n", ret);
 		return ret;
 	}
 
@@ -828,9 +890,14 @@ static int ingenic_drm_probe(struct platform_device *pdev)
 	return ret;
 }
 
-static int ingenic_drm_remove(struct platform_device *pdev)
+static int compare_of(struct device *dev, void *data)
 {
-	struct ingenic_drm *priv = platform_get_drvdata(pdev);
+	return dev->of_node == data;
+}
+
+static void ingenic_drm_unbind(struct device *dev)
+{
+	struct ingenic_drm *priv = dev_get_drvdata(dev);
 
 	if (priv->lcd_clk)
 		clk_disable_unprepare(priv->lcd_clk);
@@ -838,6 +905,42 @@ static int ingenic_drm_remove(struct platform_device *pdev)
 
 	drm_dev_unregister(&priv->drm);
 	drm_atomic_helper_shutdown(&priv->drm);
+}
+
+static const struct component_master_ops ingenic_master_ops = {
+	.bind = ingenic_drm_bind,
+	.unbind = ingenic_drm_unbind,
+};
+
+static int ingenic_drm_probe(struct platform_device *pdev)
+{
+	struct device *dev = &pdev->dev;
+	struct component_match *match = NULL;
+	struct device_node *np;
+
+	if (!IS_ENABLED(CONFIG_DRM_INGENIC_IPU))
+		return ingenic_drm_bind(dev);
+
+	/* IPU is at port address 8 */
+	np = of_graph_get_remote_node(dev->of_node, 8, 0);
+	if (!np) {
+		dev_err(dev, "Unable to get IPU node\n");
+		return -EINVAL;
+	}
+
+	drm_of_component_match_add(dev, &match, compare_of, np);
+
+	return component_master_add_with_match(dev, &ingenic_master_ops, match);
+}
+
+static int ingenic_drm_remove(struct platform_device *pdev)
+{
+	struct device *dev = &pdev->dev;
+
+	if (!IS_ENABLED(CONFIG_DRM_INGENIC_IPU))
+		ingenic_drm_unbind(dev);
+	else
+		component_master_del(dev, &ingenic_master_ops);
 
 	return 0;
 }
@@ -879,7 +982,29 @@ static struct platform_driver ingenic_drm_driver = {
 	.probe = ingenic_drm_probe,
 	.remove = ingenic_drm_remove,
 };
-module_platform_driver(ingenic_drm_driver);
+
+static int ingenic_drm_init(void)
+{
+	int err;
+
+	if (IS_ENABLED(CONFIG_DRM_INGENIC_IPU)) {
+		err = platform_driver_register(ingenic_ipu_driver_ptr);
+		if (err)
+			return err;
+	}
+
+	return platform_driver_register(&ingenic_drm_driver);
+}
+module_init(ingenic_drm_init);
+
+static void ingenic_drm_exit(void)
+{
+	platform_driver_unregister(&ingenic_drm_driver);
+
+	if (IS_ENABLED(CONFIG_DRM_INGENIC_IPU))
+		platform_driver_unregister(ingenic_ipu_driver_ptr);
+}
+module_exit(ingenic_drm_exit);
 
 MODULE_AUTHOR("Paul Cercueil <paul@crapouillou.net>");
 MODULE_DESCRIPTION("DRM driver for the Ingenic SoCs\n");
diff --git a/drivers/gpu/drm/ingenic/ingenic-drm.h b/drivers/gpu/drm/ingenic/ingenic-drm.h
index d0b827a9fe83..43f7d959cff7 100644
--- a/drivers/gpu/drm/ingenic/ingenic-drm.h
+++ b/drivers/gpu/drm/ingenic/ingenic-drm.h
@@ -8,6 +8,7 @@
 #define DRIVERS_GPU_DRM_INGENIC_INGENIC_DRM_H
 
 #include <linux/bitops.h>
+#include <linux/types.h>
 
 #define JZ_REG_LCD_CFG				0x00
 #define JZ_REG_LCD_VSYNC			0x04
@@ -158,4 +159,15 @@
 #define JZ_LCD_SIZE01_WIDTH_LSB			0
 #define JZ_LCD_SIZE01_HEIGHT_LSB		16
 
+struct device;
+struct drm_plane;
+struct drm_plane_state;
+struct platform_driver;
+
+void ingenic_drm_plane_config(struct device *dev,
+			      struct drm_plane *plane, u32 fourcc);
+void ingenic_drm_plane_disable(struct device *dev, struct drm_plane *plane);
+
+extern struct platform_driver *ingenic_ipu_driver_ptr;
+
 #endif /* DRIVERS_GPU_DRM_INGENIC_INGENIC_DRM_H */
diff --git a/drivers/gpu/drm/ingenic/ingenic-ipu.c b/drivers/gpu/drm/ingenic/ingenic-ipu.c
new file mode 100644
index 000000000000..df7eb72df887
--- /dev/null
+++ b/drivers/gpu/drm/ingenic/ingenic-ipu.c
@@ -0,0 +1,848 @@
+// SPDX-License-Identifier: GPL-2.0
+//
+// Ingenic JZ47xx IPU driver
+//
+// Copyright (C) 2020, Paul Cercueil <paul@crapouillou.net>
+
+#include "ingenic-drm.h"
+#include "ingenic-ipu.h"
+
+#include <linux/clk.h>
+#include <linux/component.h>
+#include <linux/gcd.h>
+#include <linux/interrupt.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/of_device.h>
+#include <linux/regmap.h>
+#include <linux/time.h>
+
+#include <drm/drm_atomic.h>
+#include <drm/drm_atomic_helper.h>
+#include <drm/drm_drv.h>
+#include <drm/drm_fb_cma_helper.h>
+#include <drm/drm_fourcc.h>
+#include <drm/drm_gem_framebuffer_helper.h>
+#include <drm/drm_plane.h>
+#include <drm/drm_plane_helper.h>
+#include <drm/drm_property.h>
+#include <drm/drm_vblank.h>
+
+struct ingenic_ipu;
+
+struct soc_info {
+	const u32 *formats;
+	size_t num_formats;
+	bool has_bicubic;
+
+	void (*set_coefs)(struct ingenic_ipu *ipu, unsigned int reg,
+			  unsigned int sharpness, bool downscale,
+			  unsigned int weight, unsigned int offset);
+};
+
+struct ingenic_ipu {
+	struct drm_plane plane;
+	struct device *dev, *master;
+	struct regmap *map;
+	struct clk *clk;
+	const struct soc_info *soc_info;
+
+	unsigned int numW, numH, denomW, denomH;
+
+	struct drm_property *sharpness_prop;
+	unsigned int sharpness;
+};
+
+/* Signed 15.16 fixed-point math (for bicubic scaling coefficients) */
+#define I2F(i) ((s32)(i) * 65536)
+#define F2I(f) ((f) / 65536)
+#define FMUL(fa, fb) ((s32)(((s64)(fa) * (s64)(fb)) / 65536))
+#define SHARPNESS_INCR (I2F(-1) / 8)
+
+static inline struct ingenic_ipu *plane_to_ingenic_ipu(struct drm_plane *plane)
+{
+	return container_of(plane, struct ingenic_ipu, plane);
+}
+
+/*
+ * Apply conventional cubic convolution kernel. Both parameters
+ *  and return value are 15.16 signed fixed-point.
+ *
+ *  @f_a: Sharpness factor, typically in range [-4.0, -0.25].
+ *        A larger magnitude increases perceived sharpness, but going past
+ *        -2.0 might cause ringing artifacts to outweigh any improvement.
+ *        Nice values on a 320x240 LCD are between -0.75 and -2.0.
+ *
+ *  @f_x: Absolute distance in pixels from 'pixel 0' sample position
+ *        along horizontal (or vertical) source axis. Range is [0, +2.0].
+ *
+ *  returns: Weight of this pixel within 4-pixel sample group. Range is
+ *           [-2.0, +2.0]. For moderate (i.e. > -3.0) sharpness factors,
+ *           range is within [-1.0, +1.0].
+ */
+static inline s32 cubic_conv(s32 f_a, s32 f_x)
+{
+	const s32 f_1 = I2F(1);
+	const s32 f_2 = I2F(2);
+	const s32 f_3 = I2F(3);
+	const s32 f_4 = I2F(4);
+	const s32 f_x2 = FMUL(f_x, f_x);
+	const s32 f_x3 = FMUL(f_x, f_x2);
+
+	if (f_x <= f_1)
+		return FMUL((f_a + f_2), f_x3) - FMUL((f_a + f_3), f_x2) + f_1;
+	else if (f_x <= f_2)
+		return FMUL(f_a, (f_x3 - 5 * f_x2 + 8 * f_x - f_4));
+	else
+		return 0;
+}
+
+/*
+ * On entry, "weight" is a coefficient suitable for bilinear mode,
+ *  which is converted to a set of four suitable for bicubic mode.
+ *
+ * "weight 512" means all of pixel 0;
+ * "weight 256" means half of pixel 0 and half of pixel 1;
+ * "weight 0" means all of pixel 1;
+ *
+ * "offset" is increment to next source pixel sample location.
+ */
+static void jz4760_set_coefs(struct ingenic_ipu *ipu, unsigned int reg,
+			     unsigned int sharpness, bool downscale,
+			     unsigned int weight, unsigned int offset)
+{
+	u32 val;
+	s32 w0, w1, w2, w3; /* Pixel weights at X (or Y) offsets -1,0,1,2 */
+
+	weight = clamp_val(weight, 0, 512);
+
+	if (sharpness < 2) {
+		/*
+		 *  When sharpness setting is 0, emulate nearest-neighbor.
+		 *  When sharpness setting is 1, emulate bilinear.
+		 */
+
+		if (sharpness == 0)
+			weight = weight >= 256 ? 512 : 0;
+		w0 = 0;
+		w1 = weight;
+		w2 = 512 - weight;
+		w3 = 0;
+	} else {
+		const s32 f_a = SHARPNESS_INCR * sharpness;
+		const s32 f_h = I2F(1) / 2; /* Round up 0.5 */
+
+		/*
+		 * Note that always rounding towards +infinity here is intended.
+		 * The resulting coefficients match a round-to-nearest-int
+		 * double floating-point implementation.
+		 */
+
+		weight = 512 - weight;
+		w0 = F2I(f_h + 512 * cubic_conv(f_a, I2F(512  + weight) / 512));
+		w1 = F2I(f_h + 512 * cubic_conv(f_a, I2F(0    + weight) / 512));
+		w2 = F2I(f_h + 512 * cubic_conv(f_a, I2F(512  - weight) / 512));
+		w3 = F2I(f_h + 512 * cubic_conv(f_a, I2F(1024 - weight) / 512));
+		w0 = clamp_val(w0, -1024, 1023);
+		w1 = clamp_val(w1, -1024, 1023);
+		w2 = clamp_val(w2, -1024, 1023);
+		w3 = clamp_val(w3, -1024, 1023);
+	}
+
+	val = ((w1 & JZ4760_IPU_RSZ_COEF_MASK) << JZ4760_IPU_RSZ_COEF31_LSB) |
+		((w0 & JZ4760_IPU_RSZ_COEF_MASK) << JZ4760_IPU_RSZ_COEF20_LSB);
+	regmap_write(ipu->map, reg, val);
+
+	val = ((w3 & JZ4760_IPU_RSZ_COEF_MASK) << JZ4760_IPU_RSZ_COEF31_LSB) |
+		((w2 & JZ4760_IPU_RSZ_COEF_MASK) << JZ4760_IPU_RSZ_COEF20_LSB) |
+		((offset & JZ4760_IPU_RSZ_OFFSET_MASK) << JZ4760_IPU_RSZ_OFFSET_LSB);
+	regmap_write(ipu->map, reg, val);
+}
+
+static void jz4725b_set_coefs(struct ingenic_ipu *ipu, unsigned int reg,
+			      unsigned int sharpness, bool downscale,
+			      unsigned int weight, unsigned int offset)
+{
+	u32 val = JZ4725B_IPU_RSZ_LUT_OUT_EN;
+	unsigned int i;
+
+	weight = clamp_val(weight, 0, 512);
+
+	if (sharpness == 0)
+		weight = weight >= 256 ? 512 : 0;
+
+	val |= (weight & JZ4725B_IPU_RSZ_LUT_COEF_MASK) << JZ4725B_IPU_RSZ_LUT_COEF_LSB;
+	if (downscale || !!offset)
+		val |= JZ4725B_IPU_RSZ_LUT_IN_EN;
+
+	regmap_write(ipu->map, reg, val);
+
+	if (downscale) {
+		for (i = 1; i < offset; i++)
+			regmap_write(ipu->map, reg, JZ4725B_IPU_RSZ_LUT_IN_EN);
+	}
+}
+
+static void ingenic_ipu_set_downscale_coefs(struct ingenic_ipu *ipu,
+					    unsigned int reg,
+					    unsigned int num,
+					    unsigned int denom)
+{
+	unsigned int i, offset, weight, weight_num = denom;
+
+	for (i = 0; i < num; i++) {
+		weight_num = num + (weight_num - num) % (num * 2);
+		weight = 512 - 512 * (weight_num - num) / (num * 2);
+		weight_num += denom * 2;
+		offset = (weight_num - num) / (num * 2);
+
+		ipu->soc_info->set_coefs(ipu, reg, ipu->sharpness,
+					 true, weight, offset);
+	}
+}
+
+static void ingenic_ipu_set_integer_upscale_coefs(struct ingenic_ipu *ipu,
+						  unsigned int reg,
+						  unsigned int num)
+{
+	/*
+	 * Force nearest-neighbor scaling and use simple math when upscaling
+	 * by an integer ratio. It looks better, and fixes a few problem cases.
+	 */
+	unsigned int i;
+
+	for (i = 0; i < num; i++)
+		ipu->soc_info->set_coefs(ipu, reg, 0, false, 512, i == num - 1);
+}
+
+static void ingenic_ipu_set_upscale_coefs(struct ingenic_ipu *ipu,
+					  unsigned int reg,
+					  unsigned int num,
+					  unsigned int denom)
+{
+	unsigned int i, offset, weight, weight_num = 0;
+
+	for (i = 0; i < num; i++) {
+		weight = 512 - 512 * weight_num / num;
+		weight_num += denom;
+		offset = weight_num >= num;
+
+		if (offset)
+			weight_num -= num;
+
+		ipu->soc_info->set_coefs(ipu, reg, ipu->sharpness,
+					 false, weight, offset);
+	}
+}
+
+static void ingenic_ipu_set_coefs(struct ingenic_ipu *ipu, unsigned int reg,
+				  unsigned int num, unsigned int denom)
+{
+	/* Begin programming the LUT */
+	regmap_write(ipu->map, reg, -1);
+
+	if (denom > num)
+		ingenic_ipu_set_downscale_coefs(ipu, reg, num, denom);
+	else if (denom == 1)
+		ingenic_ipu_set_integer_upscale_coefs(ipu, reg, num);
+	else
+		ingenic_ipu_set_upscale_coefs(ipu, reg, num, denom);
+}
+
+static int reduce_fraction(unsigned int *num, unsigned int *denom)
+{
+	unsigned long d = gcd(*num, *denom);
+
+	/* The scaling table has only 31 entries */
+	if (*num > 31 * d)
+		return -EINVAL;
+
+	*num /= d;
+	*denom /= d;
+	return 0;
+}
+
+static inline bool scaling_required(struct drm_plane_state *state)
+{
+	return (state->src_w >> 16) != state->crtc_w &&
+		(state->src_h >> 16) != state->crtc_h;
+}
+
+static inline bool osd_changed(struct drm_plane_state *state,
+			       struct drm_plane_state *oldstate)
+{
+	return state->crtc_x != oldstate->crtc_x ||
+		state->crtc_y != oldstate->crtc_y ||
+		state->crtc_w != oldstate->crtc_w ||
+		state->crtc_h != oldstate->crtc_h;
+}
+
+static void ingenic_ipu_plane_atomic_update(struct drm_plane *plane,
+					    struct drm_plane_state *oldstate)
+{
+	struct ingenic_ipu *ipu = plane_to_ingenic_ipu(plane);
+	struct drm_plane_state *state = plane->state;
+	const struct drm_format_info *finfo;
+	u32 ctrl, stride = 0, coef_index = 0, format = 0;
+	bool needs_modeset, upscaling_w, upscaling_h;
+	dma_addr_t addr;
+
+	if (!state || !state->fb)
+		return;
+
+	finfo = drm_format_info(state->fb->format->format);
+
+	/* Reset all the registers if needed */
+	needs_modeset = drm_atomic_crtc_needs_modeset(state->crtc->state);
+	if (needs_modeset)
+		regmap_set_bits(ipu->map, JZ_REG_IPU_CTRL, JZ_IPU_CTRL_RST);
+
+	/* Enable the chip */
+	regmap_set_bits(ipu->map, JZ_REG_IPU_CTRL, JZ_IPU_CTRL_CHIP_EN);
+
+	/* Set addresses */
+	if (finfo->num_planes > 2) {
+		addr = drm_fb_cma_get_gem_addr(state->fb, state, 2);
+		regmap_write(ipu->map, JZ_REG_IPU_V_ADDR, addr);
+	}
+
+	if (finfo->num_planes > 1) {
+		addr = drm_fb_cma_get_gem_addr(state->fb, state, 1);
+		regmap_write(ipu->map, JZ_REG_IPU_U_ADDR, addr);
+	}
+
+	addr = drm_fb_cma_get_gem_addr(state->fb, state, 0);
+	regmap_write(ipu->map, JZ_REG_IPU_Y_ADDR, addr);
+
+	if (!needs_modeset)
+		return;
+
+	ingenic_drm_plane_config(ipu->master, plane, DRM_FORMAT_XRGB8888);
+
+	/* Set the input height/width/strides */
+	if (finfo->num_planes > 2)
+		stride = ((state->src_w >> 16) * finfo->cpp[2] / finfo->hsub)
+			<< JZ_IPU_UV_STRIDE_V_LSB;
+
+	if (finfo->num_planes > 1)
+		stride |= ((state->src_w >> 16) * finfo->cpp[1] / finfo->hsub)
+			<< JZ_IPU_UV_STRIDE_U_LSB;
+
+	regmap_write(ipu->map, JZ_REG_IPU_UV_STRIDE, stride);
+
+	stride = ((state->src_w >> 16) * finfo->cpp[0])
+		<< JZ_IPU_Y_STRIDE_Y_LSB;
+	regmap_write(ipu->map, JZ_REG_IPU_Y_STRIDE, stride);
+
+	regmap_write(ipu->map, JZ_REG_IPU_IN_GS,
+		     (stride << JZ_IPU_IN_GS_W_LSB) |
+		     ((state->src_h >> 16) << JZ_IPU_IN_GS_H_LSB));
+
+	switch (finfo->format) {
+	case DRM_FORMAT_XRGB1555:
+		format = JZ_IPU_D_FMT_IN_FMT_RGB555 |
+			JZ_IPU_D_FMT_RGB_OUT_OFT_RGB;
+		break;
+	case DRM_FORMAT_XBGR1555:
+		format = JZ_IPU_D_FMT_IN_FMT_RGB555 |
+			JZ_IPU_D_FMT_RGB_OUT_OFT_BGR;
+		break;
+	case DRM_FORMAT_RGB565:
+		format = JZ_IPU_D_FMT_IN_FMT_RGB565 |
+			JZ_IPU_D_FMT_RGB_OUT_OFT_RGB;
+		break;
+	case DRM_FORMAT_BGR565:
+		format = JZ_IPU_D_FMT_IN_FMT_RGB565 |
+			JZ_IPU_D_FMT_RGB_OUT_OFT_BGR;
+		break;
+	case DRM_FORMAT_XRGB8888:
+		format = JZ_IPU_D_FMT_IN_FMT_RGB888 |
+			JZ_IPU_D_FMT_RGB_OUT_OFT_RGB;
+		break;
+	case DRM_FORMAT_XBGR8888:
+		format = JZ_IPU_D_FMT_IN_FMT_RGB888 |
+			JZ_IPU_D_FMT_RGB_OUT_OFT_BGR;
+		break;
+	case DRM_FORMAT_YUYV:
+		format = JZ_IPU_D_FMT_IN_FMT_YUV422 |
+			JZ_IPU_D_FMT_YUV_VY1UY0;
+		break;
+	case DRM_FORMAT_YVYU:
+		format = JZ_IPU_D_FMT_IN_FMT_YUV422 |
+			JZ_IPU_D_FMT_YUV_UY1VY0;
+		break;
+	case DRM_FORMAT_UYVY:
+		format = JZ_IPU_D_FMT_IN_FMT_YUV422 |
+			JZ_IPU_D_FMT_YUV_Y1VY0U;
+		break;
+	case DRM_FORMAT_VYUY:
+		format = JZ_IPU_D_FMT_IN_FMT_YUV422 |
+			JZ_IPU_D_FMT_YUV_Y1UY0V;
+		break;
+	case DRM_FORMAT_YUV411:
+		format = JZ_IPU_D_FMT_IN_FMT_YUV411;
+		break;
+	case DRM_FORMAT_YUV420:
+		format = JZ_IPU_D_FMT_IN_FMT_YUV420;
+		break;
+	case DRM_FORMAT_YUV422:
+		format = JZ_IPU_D_FMT_IN_FMT_YUV422;
+		break;
+	case DRM_FORMAT_YUV444:
+		format = JZ_IPU_D_FMT_IN_FMT_YUV444;
+		break;
+	default:
+		WARN_ONCE(1, "Unsupported format");
+		break;
+	}
+
+	/* Fix output to RGB888 */
+	format |= JZ_IPU_D_FMT_OUT_FMT_RGB888;
+
+	/* Set pixel format */
+	regmap_write(ipu->map, JZ_REG_IPU_D_FMT, format);
+
+	/* Set the output height/width/stride */
+	regmap_write(ipu->map, JZ_REG_IPU_OUT_GS,
+		     ((state->crtc_w * 4) << JZ_IPU_OUT_GS_W_LSB)
+		     | state->crtc_h << JZ_IPU_OUT_GS_H_LSB);
+	regmap_write(ipu->map, JZ_REG_IPU_OUT_STRIDE, state->crtc_w * 4);
+
+	ctrl = JZ_IPU_CTRL_LCDC_SEL | JZ_IPU_CTRL_FM_IRQ_EN;
+
+	if (finfo->num_planes == 1)
+		ctrl |= JZ_IPU_CTRL_SPKG_SEL;
+	if (finfo->is_yuv)
+		ctrl |= JZ_IPU_CTRL_CSC_EN;
+
+	regmap_update_bits(ipu->map, JZ_REG_IPU_CTRL,
+			   JZ_IPU_CTRL_LCDC_SEL | JZ_IPU_CTRL_FM_IRQ_EN |
+			   JZ_IPU_CTRL_SPKG_SEL | JZ_IPU_CTRL_CSC_EN, ctrl);
+
+	if (finfo->is_yuv) {
+		/*
+		 * Offsets for Chroma/Luma.
+		 * y = source Y - LUMA,
+		 * u = source Cb - CHROMA,
+		 * v = source Cr - CHROMA
+		 */
+		regmap_write(ipu->map, JZ_REG_IPU_CSC_OFFSET,
+			     128 << JZ_IPU_CSC_OFFSET_CHROMA_LSB |
+			     0 << JZ_IPU_CSC_OFFSET_LUMA_LSB);
+
+		/*
+		 * YUV422 to RGB conversion table.
+		 * R = C0 / 0x400 * y + C1 / 0x400 * v
+		 * G = C0 / 0x400 * y - C2 / 0x400 * u - C3 / 0x400 * v
+		 * B = C0 / 0x400 * y + C4 / 0x400 * u
+		 */
+		regmap_write(ipu->map, JZ_REG_IPU_CSC_C0_COEF, 0x4a8);
+		regmap_write(ipu->map, JZ_REG_IPU_CSC_C1_COEF, 0x662);
+		regmap_write(ipu->map, JZ_REG_IPU_CSC_C2_COEF, 0x191);
+		regmap_write(ipu->map, JZ_REG_IPU_CSC_C3_COEF, 0x341);
+		regmap_write(ipu->map, JZ_REG_IPU_CSC_C4_COEF, 0x811);
+	}
+
+	ctrl = 0;
+
+	/*
+	 * Must set ZOOM_SEL before programming bicubic LUTs.
+	 * If the IPU supports bicubic, we enable it unconditionally, since it
+	 * can do anything bilinear can and more.
+	 */
+	if (ipu->soc_info->has_bicubic)
+		ctrl |= JZ_IPU_CTRL_ZOOM_SEL;
+
+	upscaling_w = ipu->numW > ipu->denomW;
+	if (upscaling_w)
+		ctrl |= JZ_IPU_CTRL_HSCALE;
+
+	if (ipu->numW != 1 || ipu->denomW != 1) {
+		if (!ipu->soc_info->has_bicubic && !upscaling_w)
+			coef_index |= (ipu->denomW - 1) << 16;
+		else
+			coef_index |= (ipu->numW - 1) << 16;
+		ctrl |= JZ_IPU_CTRL_HRSZ_EN;
+	}
+
+	upscaling_h = ipu->numH > ipu->denomH;
+	if (upscaling_h)
+		ctrl |= JZ_IPU_CTRL_VSCALE;
+
+	if (ipu->numH != 1 || ipu->denomH != 1) {
+		if (!ipu->soc_info->has_bicubic && !upscaling_h)
+			coef_index |= ipu->denomH - 1;
+		else
+			coef_index |= ipu->numH - 1;
+		ctrl |= JZ_IPU_CTRL_VRSZ_EN;
+	}
+
+	regmap_update_bits(ipu->map, JZ_REG_IPU_CTRL, JZ_IPU_CTRL_ZOOM_SEL |
+			   JZ_IPU_CTRL_HRSZ_EN | JZ_IPU_CTRL_VRSZ_EN |
+			   JZ_IPU_CTRL_HSCALE | JZ_IPU_CTRL_VSCALE, ctrl);
+
+	/* Set the LUT index register */
+	regmap_write(ipu->map, JZ_REG_IPU_RSZ_COEF_INDEX, coef_index);
+
+	if (ipu->numW != 1 || ipu->denomW != 1)
+		ingenic_ipu_set_coefs(ipu, JZ_REG_IPU_HRSZ_COEF_LUT,
+				      ipu->numW, ipu->denomW);
+
+	if (ipu->numH != 1 || ipu->denomH != 1)
+		ingenic_ipu_set_coefs(ipu, JZ_REG_IPU_VRSZ_COEF_LUT,
+				      ipu->numH, ipu->denomH);
+
+	/* Clear STATUS register */
+	regmap_write(ipu->map, JZ_REG_IPU_STATUS, 0);
+
+	/* Start IPU */
+	regmap_set_bits(ipu->map, JZ_REG_IPU_CTRL, JZ_IPU_CTRL_RUN);
+
+	dev_dbg(ipu->dev, "Scaling %ux%u to %ux%u (%u:%u horiz, %u:%u vert)\n",
+		state->src_w >> 16, state->src_h >> 16,
+		state->crtc_w, state->crtc_h,
+		ipu->numW, ipu->denomW, ipu->numH, ipu->denomH);
+}
+
+static int ingenic_ipu_plane_atomic_check(struct drm_plane *plane,
+					  struct drm_plane_state *state)
+{
+	unsigned int numW, denomW, numH, denomH, xres, yres;
+	struct ingenic_ipu *ipu = plane_to_ingenic_ipu(plane);
+	struct drm_crtc *crtc = state->crtc ?: plane->state->crtc;
+	struct drm_crtc_state *crtc_state;
+
+	if (!crtc)
+		return 0;
+
+	crtc_state = drm_atomic_get_existing_crtc_state(state->state, crtc);
+	if (WARN_ON(!crtc_state))
+		return -EINVAL;
+
+	/* Request a full modeset if we are enabling or disabling the IPU. */
+	if (!plane->state->crtc ^ !state->crtc)
+		crtc_state->mode_changed = true;
+
+	if (!state->crtc ||
+	    !crtc_state->mode.hdisplay || !crtc_state->mode.vdisplay)
+		return 0;
+
+	/* Plane must be fully visible */
+	if (state->crtc_x < 0 || state->crtc_y < 0 ||
+	    state->crtc_x + state->crtc_w > crtc_state->mode.hdisplay ||
+	    state->crtc_y + state->crtc_h > crtc_state->mode.vdisplay)
+		return -EINVAL;
+
+	/* Minimum size is 4x4 */
+	if ((state->src_w >> 16) < 4 || (state->src_h >> 16) < 4)
+		return -EINVAL;
+
+	/* Input and output lines must have an even number of pixels. */
+	if (((state->src_w >> 16) & 1) || (state->crtc_w & 1))
+		return -EINVAL;
+
+	if (!scaling_required(state)) {
+		if (plane->state && osd_changed(state, plane->state))
+			crtc_state->mode_changed = true;
+
+		ipu->numW = ipu->numH = ipu->denomW = ipu->denomH = 1;
+		return 0;
+	}
+
+	crtc_state->mode_changed = true;
+
+	xres = state->src_w >> 16;
+	yres = state->src_h >> 16;
+
+	/* Adjust the coefficients until we find a valid configuration */
+	for (denomW = xres, numW = state->crtc_w;
+	     numW <= crtc_state->mode.hdisplay; numW++)
+		if (!reduce_fraction(&numW, &denomW))
+			break;
+	if (numW > crtc_state->mode.hdisplay)
+		return -EINVAL;
+
+	for (denomH = yres, numH = state->crtc_h;
+	     numH <= crtc_state->mode.vdisplay; numH++)
+		if (!reduce_fraction(&numH, &denomH))
+			break;
+	if (numH > crtc_state->mode.vdisplay)
+		return -EINVAL;
+
+	ipu->numW = numW;
+	ipu->numH = numH;
+	ipu->denomW = denomW;
+	ipu->denomH = denomH;
+
+	return 0;
+}
+
+static void ingenic_ipu_plane_atomic_disable(struct drm_plane *plane,
+					     struct drm_plane_state *old_state)
+{
+	struct ingenic_ipu *ipu = plane_to_ingenic_ipu(plane);
+
+	regmap_set_bits(ipu->map, JZ_REG_IPU_CTRL, JZ_IPU_CTRL_STOP);
+	regmap_clear_bits(ipu->map, JZ_REG_IPU_CTRL, JZ_IPU_CTRL_CHIP_EN);
+
+	ingenic_drm_plane_disable(ipu->master, plane);
+}
+
+static const struct drm_plane_helper_funcs ingenic_ipu_plane_helper_funcs = {
+	.atomic_update		= ingenic_ipu_plane_atomic_update,
+	.atomic_check		= ingenic_ipu_plane_atomic_check,
+	.atomic_disable		= ingenic_ipu_plane_atomic_disable,
+	.prepare_fb		= drm_gem_fb_prepare_fb,
+};
+
+static int
+ingenic_ipu_plane_atomic_get_property(struct drm_plane *plane,
+				      const struct drm_plane_state *state,
+				      struct drm_property *property, u64 *val)
+{
+	struct ingenic_ipu *ipu = plane_to_ingenic_ipu(plane);
+
+	if (property != ipu->sharpness_prop)
+		return -EINVAL;
+
+	*val = ipu->sharpness;
+
+	return 0;
+}
+
+static int
+ingenic_ipu_plane_atomic_set_property(struct drm_plane *plane,
+				      struct drm_plane_state *state,
+				      struct drm_property *property, u64 val)
+{
+	struct ingenic_ipu *ipu = plane_to_ingenic_ipu(plane);
+	struct drm_crtc_state *crtc_state;
+
+	if (property != ipu->sharpness_prop)
+		return -EINVAL;
+
+	ipu->sharpness = val;
+
+	if (state->crtc) {
+		crtc_state = drm_atomic_get_existing_crtc_state(state->state, state->crtc);
+		if (WARN_ON(!crtc_state))
+			return -EINVAL;
+
+		crtc_state->mode_changed = true;
+	}
+
+	return 0;
+}
+
+static const struct drm_plane_funcs ingenic_ipu_plane_funcs = {
+	.update_plane		= drm_atomic_helper_update_plane,
+	.disable_plane		= drm_atomic_helper_disable_plane,
+	.reset			= drm_atomic_helper_plane_reset,
+	.destroy		= drm_plane_cleanup,
+
+	.atomic_duplicate_state	= drm_atomic_helper_plane_duplicate_state,
+	.atomic_destroy_state	= drm_atomic_helper_plane_destroy_state,
+
+	.atomic_get_property	= ingenic_ipu_plane_atomic_get_property,
+	.atomic_set_property	= ingenic_ipu_plane_atomic_set_property,
+};
+
+static irqreturn_t ingenic_ipu_irq_handler(int irq, void *arg)
+{
+	struct drm_plane *plane = drm_plane_from_index(arg, 0);
+	struct ingenic_ipu *ipu = plane_to_ingenic_ipu(plane);
+	struct drm_crtc *crtc = drm_crtc_from_index(arg, 0);
+
+	regmap_write(ipu->map, JZ_REG_IPU_STATUS, 0);
+
+	drm_crtc_handle_vblank(crtc);
+
+	return IRQ_HANDLED;
+}
+
+static const struct regmap_config ingenic_ipu_regmap_config = {
+	.reg_bits = 32,
+	.val_bits = 32,
+	.reg_stride = 4,
+
+	.max_register = JZ_REG_IPU_OUT_PHY_T_ADDR,
+};
+
+static int ingenic_ipu_bind(struct device *dev, struct device *master, void *d)
+{
+	struct platform_device *pdev = to_platform_device(dev);
+	const struct soc_info *soc_info;
+	struct drm_device *drm = d;
+	struct drm_plane *plane;
+	struct ingenic_ipu *ipu;
+	void __iomem *base;
+	unsigned int sharpness_max;
+	int err, irq;
+
+	ipu = devm_kzalloc(dev, sizeof(*ipu), GFP_KERNEL);
+	if (!ipu)
+		return -ENOMEM;
+
+	soc_info = of_device_get_match_data(dev);
+	if (!soc_info) {
+		dev_err(dev, "Missing platform data\n");
+		return -EINVAL;
+	}
+
+	ipu->dev = dev;
+	ipu->master = master;
+	ipu->soc_info = soc_info;
+
+	base = devm_platform_ioremap_resource(pdev, 0);
+	if (IS_ERR(base)) {
+		dev_err(dev, "Failed to get memory resource\n");
+		return PTR_ERR(base);
+	}
+
+	ipu->map = devm_regmap_init_mmio(dev, base, &ingenic_ipu_regmap_config);
+	if (IS_ERR(ipu->map)) {
+		dev_err(dev, "Failed to create regmap\n");
+		return PTR_ERR(ipu->map);
+	}
+
+	irq = platform_get_irq(pdev, 0);
+	if (irq < 0)
+		return irq;
+
+	ipu->clk = devm_clk_get(dev, "ipu");
+	if (IS_ERR(ipu->clk)) {
+		dev_err(dev, "Failed to get pixel clock\n");
+		return PTR_ERR(ipu->clk);
+	}
+
+	err = devm_request_irq(dev, irq, ingenic_ipu_irq_handler, 0,
+			       drm->driver->name, drm);
+	if (err) {
+		dev_err(dev, "Unable to request IRQ\n");
+		return err;
+	}
+
+	plane = &ipu->plane;
+	dev_set_drvdata(dev, plane);
+
+	drm_plane_helper_add(plane, &ingenic_ipu_plane_helper_funcs);
+
+	err = drm_universal_plane_init(drm, plane, 1, &ingenic_ipu_plane_funcs,
+				       soc_info->formats, soc_info->num_formats,
+				       NULL, DRM_PLANE_TYPE_PRIMARY, NULL);
+	if (err) {
+		dev_err(dev, "Failed to init plane: %i\n", err);
+		return err;
+	}
+
+	/*
+	 * Sharpness settings range is [0,32]
+	 * 0       : nearest-neighbor
+	 * 1       : bilinear
+	 * 2 .. 32 : bicubic (translated to sharpness factor -0.25 .. -4.0)
+	 */
+	sharpness_max = soc_info->has_bicubic ? 32 : 1;
+	ipu->sharpness_prop = drm_property_create_range(drm, 0, "sharpness",
+							0, sharpness_max);
+	if (!ipu->sharpness_prop) {
+		dev_err(dev, "Unable to create sharpness property\n");
+		return -ENOMEM;
+	}
+
+	/* Default sharpness factor: -0.125 * 8 = -1.0 */
+	ipu->sharpness = soc_info->has_bicubic ? 8 : 1;
+	drm_object_attach_property(&plane->base, ipu->sharpness_prop,
+				   ipu->sharpness);
+
+	err = clk_prepare_enable(ipu->clk);
+	if (err) {
+		dev_err(dev, "Unable to enable clock\n");
+		return err;
+	}
+
+	return 0;
+}
+
+static void ingenic_ipu_unbind(struct device *dev,
+			       struct device *master, void *d)
+{
+	struct ingenic_ipu *ipu = dev_get_drvdata(dev);
+
+	clk_disable_unprepare(ipu->clk);
+}
+
+static const struct component_ops ingenic_ipu_ops = {
+	.bind = ingenic_ipu_bind,
+	.unbind = ingenic_ipu_unbind,
+};
+
+static int ingenic_ipu_probe(struct platform_device *pdev)
+{
+	return component_add(&pdev->dev, &ingenic_ipu_ops);
+}
+
+static int ingenic_ipu_remove(struct platform_device *pdev)
+{
+	component_del(&pdev->dev, &ingenic_ipu_ops);
+	return 0;
+}
+
+static const u32 jz4725b_ipu_formats[] = {
+	DRM_FORMAT_YUYV,
+	DRM_FORMAT_YVYU,
+	DRM_FORMAT_UYVY,
+	DRM_FORMAT_VYUY,
+	DRM_FORMAT_YUV411,
+	DRM_FORMAT_YUV420,
+	DRM_FORMAT_YUV422,
+	DRM_FORMAT_YUV444,
+};
+
+static const struct soc_info jz4725b_soc_info = {
+	.formats	= jz4725b_ipu_formats,
+	.num_formats	= ARRAY_SIZE(jz4725b_ipu_formats),
+	.has_bicubic	= false,
+	.set_coefs	= jz4725b_set_coefs,
+};
+
+static const u32 jz4760_ipu_formats[] = {
+	DRM_FORMAT_XRGB1555,
+	DRM_FORMAT_XBGR1555,
+	DRM_FORMAT_RGB565,
+	DRM_FORMAT_BGR565,
+	DRM_FORMAT_XRGB8888,
+	DRM_FORMAT_XBGR8888,
+	DRM_FORMAT_YUYV,
+	DRM_FORMAT_YVYU,
+	DRM_FORMAT_UYVY,
+	DRM_FORMAT_VYUY,
+	DRM_FORMAT_YUV411,
+	DRM_FORMAT_YUV420,
+	DRM_FORMAT_YUV422,
+	DRM_FORMAT_YUV444,
+};
+
+static const struct soc_info jz4760_soc_info = {
+	.formats	= jz4760_ipu_formats,
+	.num_formats	= ARRAY_SIZE(jz4760_ipu_formats),
+	.has_bicubic	= true,
+	.set_coefs	= jz4760_set_coefs,
+};
+
+static const struct of_device_id ingenic_ipu_of_match[] = {
+	{ .compatible = "ingenic,jz4725b-ipu", .data = &jz4725b_soc_info },
+	{ .compatible = "ingenic,jz4760-ipu", .data = &jz4760_soc_info },
+	{ /* sentinel */ },
+};
+MODULE_DEVICE_TABLE(of, ingenic_ipu_of_match);
+
+static struct platform_driver ingenic_ipu_driver = {
+	.driver = {
+		.name = "ingenic-ipu",
+		.of_match_table = ingenic_ipu_of_match,
+	},
+	.probe = ingenic_ipu_probe,
+	.remove = ingenic_ipu_remove,
+};
+
+struct platform_driver *ingenic_ipu_driver_ptr = &ingenic_ipu_driver;
diff --git a/drivers/gpu/drm/ingenic/ingenic-ipu.h b/drivers/gpu/drm/ingenic/ingenic-ipu.h
new file mode 100644
index 000000000000..eab6fab8c7f6
--- /dev/null
+++ b/drivers/gpu/drm/ingenic/ingenic-ipu.h
@@ -0,0 +1,109 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+//
+// Ingenic JZ47xx IPU - Register definitions and private API
+//
+// Copyright (C) 2020, Paul Cercueil <paul@crapouillou.net>
+
+#ifndef DRIVERS_GPU_DRM_INGENIC_INGENIC_IPU_H
+#define DRIVERS_GPU_DRM_INGENIC_INGENIC_IPU_H
+
+#include <linux/bitops.h>
+
+#define JZ_REG_IPU_CTRL			0x00
+#define JZ_REG_IPU_STATUS		0x04
+#define JZ_REG_IPU_D_FMT		0x08
+#define JZ_REG_IPU_Y_ADDR		0x0c
+#define JZ_REG_IPU_U_ADDR		0x10
+#define JZ_REG_IPU_V_ADDR		0x14
+#define JZ_REG_IPU_IN_GS		0x18
+#define JZ_REG_IPU_Y_STRIDE		0x1c
+#define JZ_REG_IPU_UV_STRIDE		0x20
+#define JZ_REG_IPU_OUT_ADDR		0x24
+#define JZ_REG_IPU_OUT_GS		0x28
+#define JZ_REG_IPU_OUT_STRIDE		0x2c
+#define JZ_REG_IPU_RSZ_COEF_INDEX	0x30
+#define JZ_REG_IPU_CSC_C0_COEF		0x34
+#define JZ_REG_IPU_CSC_C1_COEF		0x38
+#define JZ_REG_IPU_CSC_C2_COEF		0x3c
+#define JZ_REG_IPU_CSC_C3_COEF		0x40
+#define JZ_REG_IPU_CSC_C4_COEF		0x44
+#define JZ_REG_IPU_HRSZ_COEF_LUT	0x48
+#define JZ_REG_IPU_VRSZ_COEF_LUT	0x4c
+#define JZ_REG_IPU_CSC_OFFSET		0x50
+#define JZ_REG_IPU_Y_PHY_T_ADDR		0x54
+#define JZ_REG_IPU_U_PHY_T_ADDR		0x58
+#define JZ_REG_IPU_V_PHY_T_ADDR		0x5c
+#define JZ_REG_IPU_OUT_PHY_T_ADDR	0x60
+
+#define JZ_IPU_CTRL_ADDR_SEL		BIT(20)
+#define JZ_IPU_CTRL_ZOOM_SEL		BIT(18)
+#define JZ_IPU_CTRL_DFIX_SEL		BIT(17)
+#define JZ_IPU_CTRL_LCDC_SEL		BIT(11)
+#define JZ_IPU_CTRL_SPKG_SEL		BIT(10)
+#define JZ_IPU_CTRL_VSCALE		BIT(9)
+#define JZ_IPU_CTRL_HSCALE		BIT(8)
+#define JZ_IPU_CTRL_STOP		BIT(7)
+#define JZ_IPU_CTRL_RST			BIT(6)
+#define JZ_IPU_CTRL_FM_IRQ_EN		BIT(5)
+#define JZ_IPU_CTRL_CSC_EN		BIT(4)
+#define JZ_IPU_CTRL_VRSZ_EN		BIT(3)
+#define JZ_IPU_CTRL_HRSZ_EN		BIT(2)
+#define JZ_IPU_CTRL_RUN			BIT(1)
+#define JZ_IPU_CTRL_CHIP_EN		BIT(0)
+
+#define JZ_IPU_STATUS_OUT_END		BIT(0)
+
+#define JZ_IPU_IN_GS_H_LSB		0x0
+#define JZ_IPU_IN_GS_W_LSB		0x10
+#define JZ_IPU_OUT_GS_H_LSB		0x0
+#define JZ_IPU_OUT_GS_W_LSB		0x10
+
+#define JZ_IPU_Y_STRIDE_Y_LSB		0
+#define JZ_IPU_UV_STRIDE_U_LSB		16
+#define JZ_IPU_UV_STRIDE_V_LSB		0
+
+#define JZ_IPU_D_FMT_IN_FMT_LSB		0
+#define JZ_IPU_D_FMT_IN_FMT_RGB555	(0x0 << JZ_IPU_D_FMT_IN_FMT_LSB)
+#define JZ_IPU_D_FMT_IN_FMT_YUV420	(0x0 << JZ_IPU_D_FMT_IN_FMT_LSB)
+#define JZ_IPU_D_FMT_IN_FMT_YUV422	(0x1 << JZ_IPU_D_FMT_IN_FMT_LSB)
+#define JZ_IPU_D_FMT_IN_FMT_RGB888	(0x2 << JZ_IPU_D_FMT_IN_FMT_LSB)
+#define JZ_IPU_D_FMT_IN_FMT_YUV444	(0x2 << JZ_IPU_D_FMT_IN_FMT_LSB)
+#define JZ_IPU_D_FMT_IN_FMT_RGB565	(0x3 << JZ_IPU_D_FMT_IN_FMT_LSB)
+
+#define JZ_IPU_D_FMT_YUV_FMT_LSB	2
+#define JZ_IPU_D_FMT_YUV_Y1UY0V		(0x0 << JZ_IPU_D_FMT_YUV_FMT_LSB)
+#define JZ_IPU_D_FMT_YUV_Y1VY0U		(0x1 << JZ_IPU_D_FMT_YUV_FMT_LSB)
+#define JZ_IPU_D_FMT_YUV_UY1VY0		(0x2 << JZ_IPU_D_FMT_YUV_FMT_LSB)
+#define JZ_IPU_D_FMT_YUV_VY1UY0		(0x3 << JZ_IPU_D_FMT_YUV_FMT_LSB)
+#define JZ_IPU_D_FMT_IN_FMT_YUV411	(0x3 << JZ_IPU_D_FMT_IN_FMT_LSB)
+
+#define JZ_IPU_D_FMT_OUT_FMT_LSB	19
+#define JZ_IPU_D_FMT_OUT_FMT_RGB555	(0x0 << JZ_IPU_D_FMT_OUT_FMT_LSB)
+#define JZ_IPU_D_FMT_OUT_FMT_RGB565	(0x1 << JZ_IPU_D_FMT_OUT_FMT_LSB)
+#define JZ_IPU_D_FMT_OUT_FMT_RGB888	(0x2 << JZ_IPU_D_FMT_OUT_FMT_LSB)
+#define JZ_IPU_D_FMT_OUT_FMT_YUV422	(0x3 << JZ_IPU_D_FMT_OUT_FMT_LSB)
+#define JZ_IPU_D_FMT_OUT_FMT_RGBAAA	(0x4 << JZ_IPU_D_FMT_OUT_FMT_LSB)
+
+#define JZ_IPU_D_FMT_RGB_OUT_OFT_LSB	22
+#define JZ_IPU_D_FMT_RGB_OUT_OFT_RGB	(0x0 << JZ_IPU_D_FMT_RGB_OUT_OFT_LSB)
+#define JZ_IPU_D_FMT_RGB_OUT_OFT_RBG	(0x1 << JZ_IPU_D_FMT_RGB_OUT_OFT_LSB)
+#define JZ_IPU_D_FMT_RGB_OUT_OFT_GBR	(0x2 << JZ_IPU_D_FMT_RGB_OUT_OFT_LSB)
+#define JZ_IPU_D_FMT_RGB_OUT_OFT_GRB	(0x3 << JZ_IPU_D_FMT_RGB_OUT_OFT_LSB)
+#define JZ_IPU_D_FMT_RGB_OUT_OFT_BRG	(0x4 << JZ_IPU_D_FMT_RGB_OUT_OFT_LSB)
+#define JZ_IPU_D_FMT_RGB_OUT_OFT_BGR	(0x5 << JZ_IPU_D_FMT_RGB_OUT_OFT_LSB)
+
+#define JZ4725B_IPU_RSZ_LUT_COEF_LSB	2
+#define JZ4725B_IPU_RSZ_LUT_COEF_MASK	0x7ff
+#define JZ4725B_IPU_RSZ_LUT_IN_EN	BIT(1)
+#define JZ4725B_IPU_RSZ_LUT_OUT_EN	BIT(0)
+
+#define JZ4760_IPU_RSZ_COEF20_LSB	6
+#define JZ4760_IPU_RSZ_COEF31_LSB	17
+#define JZ4760_IPU_RSZ_COEF_MASK	0x7ff
+#define JZ4760_IPU_RSZ_OFFSET_LSB	1
+#define JZ4760_IPU_RSZ_OFFSET_MASK	0x1f
+
+#define JZ_IPU_CSC_OFFSET_CHROMA_LSB	16
+#define JZ_IPU_CSC_OFFSET_LUMA_LSB	16
+
+#endif /* DRIVERS_GPU_DRM_INGENIC_INGENIC_IPU_H */
-- 
2.27.0


^ permalink raw reply	[flat|nested] 22+ messages in thread

* [PATCH v2 10/10] drm/ingenic: Support multiple panels/bridges
  2020-06-29 23:52 [PATCH v2 01/10] dt-bindings: display: Convert ingenic,lcd.txt to YAML Paul Cercueil
                   ` (7 preceding siblings ...)
  2020-06-29 23:52 ` [PATCH v2 09/10] drm/ingenic: Add support for the IPU Paul Cercueil
@ 2020-06-29 23:52 ` Paul Cercueil
  8 siblings, 0 replies; 22+ messages in thread
From: Paul Cercueil @ 2020-06-29 23:52 UTC (permalink / raw)
  To: David Airlie, Daniel Vetter, Rob Herring
  Cc: od, dri-devel, devicetree, linux-mips, linux-kernel, Paul Cercueil

Support multiple panels or bridges connected to the same DPI output of
the SoC. This setup can be found for instance on the GCW Zero, where the
same DPI output interfaces the internal 320x240 TFT panel, and the ITE
IT6610 HDMI chip.

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---

Notes:
    v2: No change

 drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 74 +++++++++++++----------
 1 file changed, 43 insertions(+), 31 deletions(-)

diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
index 36440acd23de..18f7a9eccfc0 100644
--- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
+++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
@@ -52,7 +52,6 @@ struct ingenic_drm {
 	struct drm_device drm;
 	struct drm_plane f0, f1, *ipu_plane;
 	struct drm_crtc crtc;
-	struct drm_encoder encoder;
 
 	struct device *dev;
 	struct regmap *map;
@@ -106,12 +105,6 @@ static inline struct ingenic_drm *drm_crtc_get_priv(struct drm_crtc *crtc)
 	return container_of(crtc, struct ingenic_drm, crtc);
 }
 
-static inline struct ingenic_drm *
-drm_encoder_get_priv(struct drm_encoder *encoder)
-{
-	return container_of(encoder, struct ingenic_drm, encoder);
-}
-
 static void ingenic_drm_crtc_atomic_enable(struct drm_crtc *crtc,
 					   struct drm_crtc_state *state)
 {
@@ -451,7 +444,7 @@ static void ingenic_drm_encoder_atomic_mode_set(struct drm_encoder *encoder,
 						struct drm_crtc_state *crtc_state,
 						struct drm_connector_state *conn_state)
 {
-	struct ingenic_drm *priv = drm_encoder_get_priv(encoder);
+	struct ingenic_drm *priv = drm_device_get_priv(encoder->dev);
 	struct drm_display_mode *mode = &crtc_state->adjusted_mode;
 	struct drm_connector *conn = conn_state->connector;
 	struct drm_display_info *info = &conn->display_info;
@@ -654,9 +647,11 @@ static int ingenic_drm_bind(struct device *dev)
 	struct clk *parent_clk;
 	struct drm_bridge *bridge;
 	struct drm_panel *panel;
+	struct drm_encoder *encoder;
 	struct drm_device *drm;
 	void __iomem *base;
 	long parent_rate;
+	unsigned int i, clone_mask = 0;
 	int ret, irq;
 
 	soc_info = of_device_get_match_data(dev);
@@ -730,17 +725,6 @@ static int ingenic_drm_bind(struct device *dev)
 		return PTR_ERR(priv->pix_clk);
 	}
 
-	ret = drm_of_find_panel_or_bridge(dev->of_node, 0, 0, &panel, &bridge);
-	if (ret) {
-		if (ret != -EPROBE_DEFER)
-			dev_err(dev, "Failed to get panel handle\n");
-		return ret;
-	}
-
-	if (panel)
-		bridge = devm_drm_panel_bridge_add_typed(dev, panel,
-							 DRM_MODE_CONNECTOR_DPI);
-
 	priv->dma_hwdesc[0] = dma_alloc_coherent(dev, sizeof(*priv->dma_hwdesc[0]),
 						 &priv->dma_hwdesc_phys[0],
 						 GFP_KERNEL);
@@ -804,22 +788,50 @@ static int ingenic_drm_bind(struct device *dev)
 		}
 	}
 
-	priv->encoder.possible_crtcs = 1;
+	for (i = 0; ; i++) {
+		ret = drm_of_find_panel_or_bridge(dev->of_node, 0, i,
+						  &panel, &bridge);
+		if (ret) {
+			if (ret == -ENODEV)
+				break; /* we're done */
+			if (ret != -EPROBE_DEFER)
+				dev_err(dev, "Failed to get bridge handle\n");
+			return ret;
+		}
 
-	drm_encoder_helper_add(&priv->encoder,
-			       &ingenic_drm_encoder_helper_funcs);
+		if (panel)
+			bridge = devm_drm_panel_bridge_add_typed(dev, panel,
+								 DRM_MODE_CONNECTOR_DPI);
 
-	ret = drm_simple_encoder_init(drm, &priv->encoder,
-				      DRM_MODE_ENCODER_DPI);
-	if (ret) {
-		dev_err(dev, "Failed to init encoder: %i\n", ret);
-		return ret;
+		encoder = devm_kzalloc(dev, sizeof(*encoder), GFP_KERNEL);
+		if (!encoder)
+			return -ENOMEM;
+
+		encoder->possible_crtcs = 1;
+
+		drm_encoder_helper_add(encoder,
+				       &ingenic_drm_encoder_helper_funcs);
+
+		ret = drm_simple_encoder_init(drm, encoder,
+					      DRM_MODE_ENCODER_DPI);
+		if (ret) {
+			dev_err(dev, "Failed to init encoder: %d\n", ret);
+			return ret;
+		}
+
+		ret = drm_bridge_attach(encoder, bridge, NULL, 0);
+		if (ret) {
+			dev_err(dev, "Unable to attach bridge\n");
+			return ret;
+		}
 	}
 
-	ret = drm_bridge_attach(&priv->encoder, bridge, NULL, 0);
-	if (ret) {
-		dev_err(dev, "Unable to attach bridge\n");
-		return ret;
+	drm_for_each_encoder(encoder, drm) {
+		clone_mask |= BIT(drm_encoder_index(encoder));
+	}
+
+	drm_for_each_encoder(encoder, drm) {
+		encoder->possible_clones = clone_mask;
 	}
 
 	ret = drm_irq_install(drm, irq);
-- 
2.27.0


^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH v2 02/10] dt-bindings: display: Add ingenic,ipu.yaml
  2020-06-29 23:52 ` [PATCH v2 02/10] dt-bindings: display: Add ingenic,ipu.yaml Paul Cercueil
@ 2020-06-30 10:08   ` Sam Ravnborg
  2020-07-14  2:38   ` Rob Herring
  1 sibling, 0 replies; 22+ messages in thread
From: Sam Ravnborg @ 2020-06-30 10:08 UTC (permalink / raw)
  To: Paul Cercueil
  Cc: David Airlie, Daniel Vetter, Rob Herring, devicetree, linux-mips,
	dri-devel, linux-kernel, od

On Tue, Jun 30, 2020 at 01:52:02AM +0200, Paul Cercueil wrote:
> Add documentation of the Device Tree bindings for the Image Processing
> Unit (IPU) found in most Ingenic SoCs.
> 
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Do not know the IPU but looks correct.
Acked-by: Sam Ravnborg <sam@ravnborg.org>
> ---
> 
> Notes:
>     v2: Add missing 'const' in items list
> 
>  .../bindings/display/ingenic,ipu.yaml         | 65 +++++++++++++++++++
>  1 file changed, 65 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/ingenic,ipu.yaml
> 
> diff --git a/Documentation/devicetree/bindings/display/ingenic,ipu.yaml b/Documentation/devicetree/bindings/display/ingenic,ipu.yaml
> new file mode 100644
> index 000000000000..5bfc33eb32c9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/ingenic,ipu.yaml
> @@ -0,0 +1,65 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/ingenic,ipu.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Ingenic SoCs Image Processing Unit (IPU) devicetree bindings
> +
> +maintainers:
> +  - Paul Cercueil <paul@crapouillou.net>
> +
> +properties:
> +  compatible:
> +    oneOf:
> +      - enum:
> +        - ingenic,jz4725b-ipu
> +        - ingenic,jz4760-ipu
> +      - items:
> +        - const: ingenic,jz4770-ipu
> +        - const: ingenic,jz4760-ipu
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  clock-names:
> +    const: ipu
> +
> +patternProperties:
> +  "^ports?$":
> +    description: OF graph bindings (specified in bindings/graph.txt).
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - clocks
> +  - clock-names
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/clock/jz4770-cgu.h>
> +    ipu@13080000 {
> +      compatible = "ingenic,jz4770-ipu", "ingenic,jz4760-ipu";
> +      reg = <0x13080000 0x800>;
> +
> +      interrupt-parent = <&intc>;
> +      interrupts = <29>;
> +
> +      clocks = <&cgu JZ4770_CLK_IPU>;
> +      clock-names = "ipu";
> +
> +      port {
> +        ipu_ep: endpoint {
> +          remote-endpoint = <&lcdc_ep>;
> +        };
> +      };
> +    };
> -- 
> 2.27.0
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH v2 03/10] drm/ingenic: Rename ingenic-drm.c to ingenic-drm-drv.c
  2020-06-29 23:52 ` [PATCH v2 03/10] drm/ingenic: Rename ingenic-drm.c to ingenic-drm-drv.c Paul Cercueil
@ 2020-06-30 10:09   ` Sam Ravnborg
  0 siblings, 0 replies; 22+ messages in thread
From: Sam Ravnborg @ 2020-06-30 10:09 UTC (permalink / raw)
  To: Paul Cercueil
  Cc: David Airlie, Daniel Vetter, Rob Herring, devicetree, linux-mips,
	dri-devel, linux-kernel, od

On Tue, Jun 30, 2020 at 01:52:03AM +0200, Paul Cercueil wrote:
> Full rename without any modification, except to the Makefile.
> 
> Renaming ingenic-drm.c to ingenic-drm-drv.c allow to decouple the module
> name from the source file name in the Makefile. This will be useful
> later when more source files are added.
> 
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
> ---
> 
> Notes:
>     v2: New patch
> 
>  drivers/gpu/drm/ingenic/Makefile                             | 1 +
>  drivers/gpu/drm/ingenic/{ingenic-drm.c => ingenic-drm-drv.c} | 0
>  2 files changed, 1 insertion(+)
>  rename drivers/gpu/drm/ingenic/{ingenic-drm.c => ingenic-drm-drv.c} (100%)
> 
> diff --git a/drivers/gpu/drm/ingenic/Makefile b/drivers/gpu/drm/ingenic/Makefile
> index 11cac42ce0bb..9875628dd8bc 100644
> --- a/drivers/gpu/drm/ingenic/Makefile
> +++ b/drivers/gpu/drm/ingenic/Makefile
> @@ -1 +1,2 @@
>  obj-$(CONFIG_DRM_INGENIC) += ingenic-drm.o
> +ingenic-drm-y += ingenic-drm-drv.o
> diff --git a/drivers/gpu/drm/ingenic/ingenic-drm.c b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
> similarity index 100%
> rename from drivers/gpu/drm/ingenic/ingenic-drm.c
> rename to drivers/gpu/drm/ingenic/ingenic-drm-drv.c
> -- 
> 2.27.0
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH v2 04/10] drm/ingenic: Add missing CR in debug strings
  2020-06-29 23:52 ` [PATCH v2 04/10] drm/ingenic: Add missing CR in debug strings Paul Cercueil
@ 2020-06-30 10:10   ` Sam Ravnborg
  0 siblings, 0 replies; 22+ messages in thread
From: Sam Ravnborg @ 2020-06-30 10:10 UTC (permalink / raw)
  To: Paul Cercueil
  Cc: David Airlie, Daniel Vetter, Rob Herring, devicetree, linux-mips,
	dri-devel, linux-kernel, od

On Tue, Jun 30, 2020 at 01:52:04AM +0200, Paul Cercueil wrote:
> If you pass a string that is not terminated with a carriage return to
> dev_err(), it will eventually be printed with a carriage return, but
> not right away, since the kernel will wait for a pr_cont().
> 
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>

It would have been nice if most was converted to drm_err() and friends
when touching these.
That may come later..
Acked-by: Sam Ravnborg <sam@ravnborg.org>

> ---
> 
> Notes:
>     v2: New patch
> 
>  drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 30 +++++++++++------------
>  1 file changed, 15 insertions(+), 15 deletions(-)
> 
> diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
> index 16f0740df507..a15f9a1940c6 100644
> --- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
> +++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
> @@ -623,14 +623,14 @@ static int ingenic_drm_probe(struct platform_device *pdev)
>  
>  	base = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(base)) {
> -		dev_err(dev, "Failed to get memory resource");
> +		dev_err(dev, "Failed to get memory resource\n");
>  		return PTR_ERR(base);
>  	}
>  
>  	priv->map = devm_regmap_init_mmio(dev, base,
>  					  &ingenic_drm_regmap_config);
>  	if (IS_ERR(priv->map)) {
> -		dev_err(dev, "Failed to create regmap");
> +		dev_err(dev, "Failed to create regmap\n");
>  		return PTR_ERR(priv->map);
>  	}
>  
> @@ -641,21 +641,21 @@ static int ingenic_drm_probe(struct platform_device *pdev)
>  	if (soc_info->needs_dev_clk) {
>  		priv->lcd_clk = devm_clk_get(dev, "lcd");
>  		if (IS_ERR(priv->lcd_clk)) {
> -			dev_err(dev, "Failed to get lcd clock");
> +			dev_err(dev, "Failed to get lcd clock\n");
>  			return PTR_ERR(priv->lcd_clk);
>  		}
>  	}
>  
>  	priv->pix_clk = devm_clk_get(dev, "lcd_pclk");
>  	if (IS_ERR(priv->pix_clk)) {
> -		dev_err(dev, "Failed to get pixel clock");
> +		dev_err(dev, "Failed to get pixel clock\n");
>  		return PTR_ERR(priv->pix_clk);
>  	}
>  
>  	ret = drm_of_find_panel_or_bridge(dev->of_node, 0, 0, &panel, &bridge);
>  	if (ret) {
>  		if (ret != -EPROBE_DEFER)
> -			dev_err(dev, "Failed to get panel handle");
> +			dev_err(dev, "Failed to get panel handle\n");
>  		return ret;
>  	}
>  
> @@ -684,7 +684,7 @@ static int ingenic_drm_probe(struct platform_device *pdev)
>  				       ARRAY_SIZE(ingenic_drm_primary_formats),
>  				       NULL, DRM_PLANE_TYPE_PRIMARY, NULL);
>  	if (ret) {
> -		dev_err(dev, "Failed to register primary plane: %i", ret);
> +		dev_err(dev, "Failed to register primary plane: %i\n", ret);
>  		return ret;
>  	}
>  
> @@ -693,7 +693,7 @@ static int ingenic_drm_probe(struct platform_device *pdev)
>  	ret = drm_crtc_init_with_planes(drm, &priv->crtc, &priv->primary,
>  					NULL, &ingenic_drm_crtc_funcs, NULL);
>  	if (ret) {
> -		dev_err(dev, "Failed to init CRTC: %i", ret);
> +		dev_err(dev, "Failed to init CRTC: %i\n", ret);
>  		return ret;
>  	}
>  
> @@ -705,25 +705,25 @@ static int ingenic_drm_probe(struct platform_device *pdev)
>  	ret = drm_simple_encoder_init(drm, &priv->encoder,
>  				      DRM_MODE_ENCODER_DPI);
>  	if (ret) {
> -		dev_err(dev, "Failed to init encoder: %i", ret);
> +		dev_err(dev, "Failed to init encoder: %i\n", ret);
>  		return ret;
>  	}
>  
>  	ret = drm_bridge_attach(&priv->encoder, bridge, NULL, 0);
>  	if (ret) {
> -		dev_err(dev, "Unable to attach bridge");
> +		dev_err(dev, "Unable to attach bridge\n");
>  		return ret;
>  	}
>  
>  	ret = drm_irq_install(drm, irq);
>  	if (ret) {
> -		dev_err(dev, "Unable to install IRQ handler");
> +		dev_err(dev, "Unable to install IRQ handler\n");
>  		return ret;
>  	}
>  
>  	ret = drm_vblank_init(drm, 1);
>  	if (ret) {
> -		dev_err(dev, "Failed calling drm_vblank_init()");
> +		dev_err(dev, "Failed calling drm_vblank_init()\n");
>  		return ret;
>  	}
>  
> @@ -731,7 +731,7 @@ static int ingenic_drm_probe(struct platform_device *pdev)
>  
>  	ret = clk_prepare_enable(priv->pix_clk);
>  	if (ret) {
> -		dev_err(dev, "Unable to start pixel clock");
> +		dev_err(dev, "Unable to start pixel clock\n");
>  		return ret;
>  	}
>  
> @@ -746,20 +746,20 @@ static int ingenic_drm_probe(struct platform_device *pdev)
>  		 */
>  		ret = clk_set_rate(priv->lcd_clk, parent_rate);
>  		if (ret) {
> -			dev_err(dev, "Unable to set LCD clock rate");
> +			dev_err(dev, "Unable to set LCD clock rate\n");
>  			goto err_pixclk_disable;
>  		}
>  
>  		ret = clk_prepare_enable(priv->lcd_clk);
>  		if (ret) {
> -			dev_err(dev, "Unable to start lcd clock");
> +			dev_err(dev, "Unable to start lcd clock\n");
>  			goto err_pixclk_disable;
>  		}
>  	}
>  
>  	ret = drm_dev_register(drm, 0);
>  	if (ret) {
> -		dev_err(dev, "Failed to register DRM driver");
> +		dev_err(dev, "Failed to register DRM driver\n");
>  		goto err_devclk_disable;
>  	}
>  
> -- 
> 2.27.0
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH v2 05/10] drm/ingenic: Fix incorrect assumption about plane->index
  2020-06-29 23:52 ` [PATCH v2 05/10] drm/ingenic: Fix incorrect assumption about plane->index Paul Cercueil
@ 2020-06-30 11:35   ` Sam Ravnborg
  0 siblings, 0 replies; 22+ messages in thread
From: Sam Ravnborg @ 2020-06-30 11:35 UTC (permalink / raw)
  To: Paul Cercueil
  Cc: David Airlie, Daniel Vetter, Rob Herring, devicetree, linux-mips,
	dri-devel, linux-kernel, od, stable

On Tue, Jun 30, 2020 at 01:52:05AM +0200, Paul Cercueil wrote:
> plane->index is NOT the index of the color plane in a YUV frame.
> Actually, a YUV frame is represented by a single drm_plane, even though
> it contains three Y, U, V planes.
> 
> Cc: stable@vger.kernel.org # v5.3
> Fixes: 90b86fcc47b4 ("DRM: Add KMS driver for the Ingenic JZ47xx SoCs")
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>

Look correct to me.

Acked-by: Sam Ravnborg <sam@ravnborg.org>
As this is tagged fixes: I assume this is for drm-misc-fixes and
not for drm-misc-next.
If you resend could you move it as patch 1/10 so this is more obvious.

	Sam
> ---
> 
> Notes:
>     v2: No change
> 
>  drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
> index a15f9a1940c6..924c8daf071a 100644
> --- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
> +++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
> @@ -386,7 +386,7 @@ static void ingenic_drm_plane_atomic_update(struct drm_plane *plane,
>  		addr = drm_fb_cma_get_gem_addr(state->fb, state, 0);
>  		width = state->src_w >> 16;
>  		height = state->src_h >> 16;
> -		cpp = state->fb->format->cpp[plane->index];
> +		cpp = state->fb->format->cpp[0];
>  
>  		priv->dma_hwdesc->addr = addr;
>  		priv->dma_hwdesc->cmd = width * height * cpp / 4;
> -- 
> 2.27.0
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH v2 06/10] drm/ingenic: Set DMA descriptor chain address in probe
  2020-06-29 23:52 ` [PATCH v2 06/10] drm/ingenic: Set DMA descriptor chain address in probe Paul Cercueil
@ 2020-06-30 11:44   ` Sam Ravnborg
  2020-06-30 11:54     ` Paul Cercueil
  0 siblings, 1 reply; 22+ messages in thread
From: Sam Ravnborg @ 2020-06-30 11:44 UTC (permalink / raw)
  To: Paul Cercueil
  Cc: David Airlie, Daniel Vetter, Rob Herring, devicetree, linux-mips,
	dri-devel, linux-kernel, od

Hi Paul.

On Tue, Jun 30, 2020 at 01:52:06AM +0200, Paul Cercueil wrote:
> The address of the DMA descriptor never changes. It can therefore be set
> in the probe function.
> 
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
> 
> Notes:
>     v2: No change
> 
>  drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
> index 924c8daf071a..f7b0c5dc8cd8 100644
> --- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
> +++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
> @@ -358,8 +358,6 @@ static void ingenic_drm_crtc_atomic_flush(struct drm_crtc *crtc,
>  		ingenic_drm_crtc_update_ctrl(priv, finfo);
>  
>  		clk_set_rate(priv->pix_clk, state->adjusted_mode.clock * 1000);
> -
> -		regmap_write(priv->map, JZ_REG_LCD_DA0, priv->dma_hwdesc->next);
>  	}
>  
>  	if (event) {
> @@ -757,6 +755,9 @@ static int ingenic_drm_probe(struct platform_device *pdev)
>  		}
>  	}
>  
> +	/* Set address of our DMA descriptor chain */
> +	regmap_write(priv->map, JZ_REG_LCD_DA0, priv->dma_hwdesc_phys);
> +


What is the purpose of this code after the assignment was moved:

static int ingenic_drm_probe(struct platform_device *pdev)
{
...
	priv->dma_hwdesc->next = priv->dma_hwdesc_phys;

I do not see ->next used anymore.
Could this assignment be dropped?


And the following line:
	priv->dma_hwdesc->id = 0xdeafbead;

I can only see ->id be assingned, it is never referenced??

Maybe this is all related to the structure assumed by the data pointed
to by JZ_REG_LCD_DA0?

	Sam

>  	ret = drm_dev_register(drm, 0);
>  	if (ret) {
>  		dev_err(dev, "Failed to register DRM driver\n");
> -- 
> 2.27.0
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH v2 07/10] drm/ingenic: Move register definitions to ingenic-drm.h
  2020-06-29 23:52 ` [PATCH v2 07/10] drm/ingenic: Move register definitions to ingenic-drm.h Paul Cercueil
@ 2020-06-30 11:46   ` Sam Ravnborg
  0 siblings, 0 replies; 22+ messages in thread
From: Sam Ravnborg @ 2020-06-30 11:46 UTC (permalink / raw)
  To: Paul Cercueil
  Cc: David Airlie, Daniel Vetter, Rob Herring, devicetree, linux-mips,
	dri-devel, linux-kernel, od

On Tue, Jun 30, 2020 at 01:52:07AM +0200, Paul Cercueil wrote:
> Move the register definitions to ingenic-drm.h, to keep
> ingenic-drm-drv.c tidy.
> 
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
> ---
> 
> Notes:
>     v2: Fix SPDX license tag
> 
>  drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 116 +-------------------
>  drivers/gpu/drm/ingenic/ingenic-drm.h     | 126 ++++++++++++++++++++++
>  2 files changed, 128 insertions(+), 114 deletions(-)
>  create mode 100644 drivers/gpu/drm/ingenic/ingenic-drm.h
> 
> diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
> index f7b0c5dc8cd8..6590b61cb915 100644
> --- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
> +++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
> @@ -4,6 +4,8 @@
>  //
>  // Copyright (C) 2019, Paul Cercueil <paul@crapouillou.net>
>  
> +#include "ingenic-drm.h"
> +
>  #include <linux/clk.h>
>  #include <linux/dma-mapping.h>
>  #include <linux/module.h>
> @@ -32,120 +34,6 @@
>  #include <drm/drm_simple_kms_helper.h>
>  #include <drm/drm_vblank.h>
>  
> -#define JZ_REG_LCD_CFG				0x00
> -#define JZ_REG_LCD_VSYNC			0x04
> -#define JZ_REG_LCD_HSYNC			0x08
> -#define JZ_REG_LCD_VAT				0x0C
> -#define JZ_REG_LCD_DAH				0x10
> -#define JZ_REG_LCD_DAV				0x14
> -#define JZ_REG_LCD_PS				0x18
> -#define JZ_REG_LCD_CLS				0x1C
> -#define JZ_REG_LCD_SPL				0x20
> -#define JZ_REG_LCD_REV				0x24
> -#define JZ_REG_LCD_CTRL				0x30
> -#define JZ_REG_LCD_STATE			0x34
> -#define JZ_REG_LCD_IID				0x38
> -#define JZ_REG_LCD_DA0				0x40
> -#define JZ_REG_LCD_SA0				0x44
> -#define JZ_REG_LCD_FID0				0x48
> -#define JZ_REG_LCD_CMD0				0x4C
> -#define JZ_REG_LCD_DA1				0x50
> -#define JZ_REG_LCD_SA1				0x54
> -#define JZ_REG_LCD_FID1				0x58
> -#define JZ_REG_LCD_CMD1				0x5C
> -
> -#define JZ_LCD_CFG_SLCD				BIT(31)
> -#define JZ_LCD_CFG_PS_DISABLE			BIT(23)
> -#define JZ_LCD_CFG_CLS_DISABLE			BIT(22)
> -#define JZ_LCD_CFG_SPL_DISABLE			BIT(21)
> -#define JZ_LCD_CFG_REV_DISABLE			BIT(20)
> -#define JZ_LCD_CFG_HSYNCM			BIT(19)
> -#define JZ_LCD_CFG_PCLKM			BIT(18)
> -#define JZ_LCD_CFG_INV				BIT(17)
> -#define JZ_LCD_CFG_SYNC_DIR			BIT(16)
> -#define JZ_LCD_CFG_PS_POLARITY			BIT(15)
> -#define JZ_LCD_CFG_CLS_POLARITY			BIT(14)
> -#define JZ_LCD_CFG_SPL_POLARITY			BIT(13)
> -#define JZ_LCD_CFG_REV_POLARITY			BIT(12)
> -#define JZ_LCD_CFG_HSYNC_ACTIVE_LOW		BIT(11)
> -#define JZ_LCD_CFG_PCLK_FALLING_EDGE		BIT(10)
> -#define JZ_LCD_CFG_DE_ACTIVE_LOW		BIT(9)
> -#define JZ_LCD_CFG_VSYNC_ACTIVE_LOW		BIT(8)
> -#define JZ_LCD_CFG_18_BIT			BIT(7)
> -#define JZ_LCD_CFG_PDW				(BIT(5) | BIT(4))
> -
> -#define JZ_LCD_CFG_MODE_GENERIC_16BIT		0
> -#define JZ_LCD_CFG_MODE_GENERIC_18BIT		BIT(7)
> -#define JZ_LCD_CFG_MODE_GENERIC_24BIT		BIT(6)
> -
> -#define JZ_LCD_CFG_MODE_SPECIAL_TFT_1		1
> -#define JZ_LCD_CFG_MODE_SPECIAL_TFT_2		2
> -#define JZ_LCD_CFG_MODE_SPECIAL_TFT_3		3
> -
> -#define JZ_LCD_CFG_MODE_TV_OUT_P		4
> -#define JZ_LCD_CFG_MODE_TV_OUT_I		6
> -
> -#define JZ_LCD_CFG_MODE_SINGLE_COLOR_STN	8
> -#define JZ_LCD_CFG_MODE_SINGLE_MONOCHROME_STN	9
> -#define JZ_LCD_CFG_MODE_DUAL_COLOR_STN		10
> -#define JZ_LCD_CFG_MODE_DUAL_MONOCHROME_STN	11
> -
> -#define JZ_LCD_CFG_MODE_8BIT_SERIAL		12
> -#define JZ_LCD_CFG_MODE_LCM			13
> -
> -#define JZ_LCD_VSYNC_VPS_OFFSET			16
> -#define JZ_LCD_VSYNC_VPE_OFFSET			0
> -
> -#define JZ_LCD_HSYNC_HPS_OFFSET			16
> -#define JZ_LCD_HSYNC_HPE_OFFSET			0
> -
> -#define JZ_LCD_VAT_HT_OFFSET			16
> -#define JZ_LCD_VAT_VT_OFFSET			0
> -
> -#define JZ_LCD_DAH_HDS_OFFSET			16
> -#define JZ_LCD_DAH_HDE_OFFSET			0
> -
> -#define JZ_LCD_DAV_VDS_OFFSET			16
> -#define JZ_LCD_DAV_VDE_OFFSET			0
> -
> -#define JZ_LCD_CTRL_BURST_4			(0x0 << 28)
> -#define JZ_LCD_CTRL_BURST_8			(0x1 << 28)
> -#define JZ_LCD_CTRL_BURST_16			(0x2 << 28)
> -#define JZ_LCD_CTRL_RGB555			BIT(27)
> -#define JZ_LCD_CTRL_OFUP			BIT(26)
> -#define JZ_LCD_CTRL_FRC_GRAYSCALE_16		(0x0 << 24)
> -#define JZ_LCD_CTRL_FRC_GRAYSCALE_4		(0x1 << 24)
> -#define JZ_LCD_CTRL_FRC_GRAYSCALE_2		(0x2 << 24)
> -#define JZ_LCD_CTRL_PDD_MASK			(0xff << 16)
> -#define JZ_LCD_CTRL_EOF_IRQ			BIT(13)
> -#define JZ_LCD_CTRL_SOF_IRQ			BIT(12)
> -#define JZ_LCD_CTRL_OFU_IRQ			BIT(11)
> -#define JZ_LCD_CTRL_IFU0_IRQ			BIT(10)
> -#define JZ_LCD_CTRL_IFU1_IRQ			BIT(9)
> -#define JZ_LCD_CTRL_DD_IRQ			BIT(8)
> -#define JZ_LCD_CTRL_QDD_IRQ			BIT(7)
> -#define JZ_LCD_CTRL_REVERSE_ENDIAN		BIT(6)
> -#define JZ_LCD_CTRL_LSB_FISRT			BIT(5)
> -#define JZ_LCD_CTRL_DISABLE			BIT(4)
> -#define JZ_LCD_CTRL_ENABLE			BIT(3)
> -#define JZ_LCD_CTRL_BPP_1			0x0
> -#define JZ_LCD_CTRL_BPP_2			0x1
> -#define JZ_LCD_CTRL_BPP_4			0x2
> -#define JZ_LCD_CTRL_BPP_8			0x3
> -#define JZ_LCD_CTRL_BPP_15_16			0x4
> -#define JZ_LCD_CTRL_BPP_18_24			0x5
> -#define JZ_LCD_CTRL_BPP_MASK			(JZ_LCD_CTRL_RGB555 | (0x7 << 0))
> -
> -#define JZ_LCD_CMD_SOF_IRQ			BIT(31)
> -#define JZ_LCD_CMD_EOF_IRQ			BIT(30)
> -#define JZ_LCD_CMD_ENABLE_PAL			BIT(28)
> -
> -#define JZ_LCD_SYNC_MASK			0x3ff
> -
> -#define JZ_LCD_STATE_EOF_IRQ			BIT(5)
> -#define JZ_LCD_STATE_SOF_IRQ			BIT(4)
> -#define JZ_LCD_STATE_DISABLED			BIT(0)
> -
>  struct ingenic_dma_hwdesc {
>  	u32 next;
>  	u32 addr;
> diff --git a/drivers/gpu/drm/ingenic/ingenic-drm.h b/drivers/gpu/drm/ingenic/ingenic-drm.h
> new file mode 100644
> index 000000000000..cb578cff7bb1
> --- /dev/null
> +++ b/drivers/gpu/drm/ingenic/ingenic-drm.h
> @@ -0,0 +1,126 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +//
> +// Ingenic JZ47xx KMS driver - Register definitions and private API
> +//
> +// Copyright (C) 2020, Paul Cercueil <paul@crapouillou.net>
> +
> +#ifndef DRIVERS_GPU_DRM_INGENIC_INGENIC_DRM_H
> +#define DRIVERS_GPU_DRM_INGENIC_INGENIC_DRM_H
> +
> +#include <linux/bitops.h>
> +
> +#define JZ_REG_LCD_CFG				0x00
> +#define JZ_REG_LCD_VSYNC			0x04
> +#define JZ_REG_LCD_HSYNC			0x08
> +#define JZ_REG_LCD_VAT				0x0C
> +#define JZ_REG_LCD_DAH				0x10
> +#define JZ_REG_LCD_DAV				0x14
> +#define JZ_REG_LCD_PS				0x18
> +#define JZ_REG_LCD_CLS				0x1C
> +#define JZ_REG_LCD_SPL				0x20
> +#define JZ_REG_LCD_REV				0x24
> +#define JZ_REG_LCD_CTRL				0x30
> +#define JZ_REG_LCD_STATE			0x34
> +#define JZ_REG_LCD_IID				0x38
> +#define JZ_REG_LCD_DA0				0x40
> +#define JZ_REG_LCD_SA0				0x44
> +#define JZ_REG_LCD_FID0				0x48
> +#define JZ_REG_LCD_CMD0				0x4C
> +#define JZ_REG_LCD_DA1				0x50
> +#define JZ_REG_LCD_SA1				0x54
> +#define JZ_REG_LCD_FID1				0x58
> +#define JZ_REG_LCD_CMD1				0x5C
> +
> +#define JZ_LCD_CFG_SLCD				BIT(31)
> +#define JZ_LCD_CFG_PS_DISABLE			BIT(23)
> +#define JZ_LCD_CFG_CLS_DISABLE			BIT(22)
> +#define JZ_LCD_CFG_SPL_DISABLE			BIT(21)
> +#define JZ_LCD_CFG_REV_DISABLE			BIT(20)
> +#define JZ_LCD_CFG_HSYNCM			BIT(19)
> +#define JZ_LCD_CFG_PCLKM			BIT(18)
> +#define JZ_LCD_CFG_INV				BIT(17)
> +#define JZ_LCD_CFG_SYNC_DIR			BIT(16)
> +#define JZ_LCD_CFG_PS_POLARITY			BIT(15)
> +#define JZ_LCD_CFG_CLS_POLARITY			BIT(14)
> +#define JZ_LCD_CFG_SPL_POLARITY			BIT(13)
> +#define JZ_LCD_CFG_REV_POLARITY			BIT(12)
> +#define JZ_LCD_CFG_HSYNC_ACTIVE_LOW		BIT(11)
> +#define JZ_LCD_CFG_PCLK_FALLING_EDGE		BIT(10)
> +#define JZ_LCD_CFG_DE_ACTIVE_LOW		BIT(9)
> +#define JZ_LCD_CFG_VSYNC_ACTIVE_LOW		BIT(8)
> +#define JZ_LCD_CFG_18_BIT			BIT(7)
> +#define JZ_LCD_CFG_PDW				(BIT(5) | BIT(4))
> +
> +#define JZ_LCD_CFG_MODE_GENERIC_16BIT		0
> +#define JZ_LCD_CFG_MODE_GENERIC_18BIT		BIT(7)
> +#define JZ_LCD_CFG_MODE_GENERIC_24BIT		BIT(6)
> +
> +#define JZ_LCD_CFG_MODE_SPECIAL_TFT_1		1
> +#define JZ_LCD_CFG_MODE_SPECIAL_TFT_2		2
> +#define JZ_LCD_CFG_MODE_SPECIAL_TFT_3		3
> +
> +#define JZ_LCD_CFG_MODE_TV_OUT_P		4
> +#define JZ_LCD_CFG_MODE_TV_OUT_I		6
> +
> +#define JZ_LCD_CFG_MODE_SINGLE_COLOR_STN	8
> +#define JZ_LCD_CFG_MODE_SINGLE_MONOCHROME_STN	9
> +#define JZ_LCD_CFG_MODE_DUAL_COLOR_STN		10
> +#define JZ_LCD_CFG_MODE_DUAL_MONOCHROME_STN	11
> +
> +#define JZ_LCD_CFG_MODE_8BIT_SERIAL		12
> +#define JZ_LCD_CFG_MODE_LCM			13
> +
> +#define JZ_LCD_VSYNC_VPS_OFFSET			16
> +#define JZ_LCD_VSYNC_VPE_OFFSET			0
> +
> +#define JZ_LCD_HSYNC_HPS_OFFSET			16
> +#define JZ_LCD_HSYNC_HPE_OFFSET			0
> +
> +#define JZ_LCD_VAT_HT_OFFSET			16
> +#define JZ_LCD_VAT_VT_OFFSET			0
> +
> +#define JZ_LCD_DAH_HDS_OFFSET			16
> +#define JZ_LCD_DAH_HDE_OFFSET			0
> +
> +#define JZ_LCD_DAV_VDS_OFFSET			16
> +#define JZ_LCD_DAV_VDE_OFFSET			0
> +
> +#define JZ_LCD_CTRL_BURST_4			(0x0 << 28)
> +#define JZ_LCD_CTRL_BURST_8			(0x1 << 28)
> +#define JZ_LCD_CTRL_BURST_16			(0x2 << 28)
> +#define JZ_LCD_CTRL_RGB555			BIT(27)
> +#define JZ_LCD_CTRL_OFUP			BIT(26)
> +#define JZ_LCD_CTRL_FRC_GRAYSCALE_16		(0x0 << 24)
> +#define JZ_LCD_CTRL_FRC_GRAYSCALE_4		(0x1 << 24)
> +#define JZ_LCD_CTRL_FRC_GRAYSCALE_2		(0x2 << 24)
> +#define JZ_LCD_CTRL_PDD_MASK			(0xff << 16)
> +#define JZ_LCD_CTRL_EOF_IRQ			BIT(13)
> +#define JZ_LCD_CTRL_SOF_IRQ			BIT(12)
> +#define JZ_LCD_CTRL_OFU_IRQ			BIT(11)
> +#define JZ_LCD_CTRL_IFU0_IRQ			BIT(10)
> +#define JZ_LCD_CTRL_IFU1_IRQ			BIT(9)
> +#define JZ_LCD_CTRL_DD_IRQ			BIT(8)
> +#define JZ_LCD_CTRL_QDD_IRQ			BIT(7)
> +#define JZ_LCD_CTRL_REVERSE_ENDIAN		BIT(6)
> +#define JZ_LCD_CTRL_LSB_FISRT			BIT(5)
> +#define JZ_LCD_CTRL_DISABLE			BIT(4)
> +#define JZ_LCD_CTRL_ENABLE			BIT(3)
> +#define JZ_LCD_CTRL_BPP_1			0x0
> +#define JZ_LCD_CTRL_BPP_2			0x1
> +#define JZ_LCD_CTRL_BPP_4			0x2
> +#define JZ_LCD_CTRL_BPP_8			0x3
> +#define JZ_LCD_CTRL_BPP_15_16			0x4
> +#define JZ_LCD_CTRL_BPP_18_24			0x5
> +#define JZ_LCD_CTRL_BPP_MASK			(JZ_LCD_CTRL_RGB555 | 0x7)
> +
> +#define JZ_LCD_CMD_SOF_IRQ			BIT(31)
> +#define JZ_LCD_CMD_EOF_IRQ			BIT(30)
> +#define JZ_LCD_CMD_ENABLE_PAL			BIT(28)
> +
> +#define JZ_LCD_SYNC_MASK			0x3ff
> +
> +#define JZ_LCD_STATE_EOF_IRQ			BIT(5)
> +#define JZ_LCD_STATE_SOF_IRQ			BIT(4)
> +#define JZ_LCD_STATE_DISABLED			BIT(0)
> +
> +#endif /* DRIVERS_GPU_DRM_INGENIC_INGENIC_DRM_H */
> -- 
> 2.27.0
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH v2 06/10] drm/ingenic: Set DMA descriptor chain address in probe
  2020-06-30 11:44   ` Sam Ravnborg
@ 2020-06-30 11:54     ` Paul Cercueil
  0 siblings, 0 replies; 22+ messages in thread
From: Paul Cercueil @ 2020-06-30 11:54 UTC (permalink / raw)
  To: Sam Ravnborg
  Cc: David Airlie, Daniel Vetter, Rob Herring, devicetree, linux-mips,
	dri-devel, linux-kernel, od

Hi Sam,

Le mar. 30 juin 2020 à 13:44, Sam Ravnborg <sam@ravnborg.org> a écrit 
:
> Hi Paul.
> 
> On Tue, Jun 30, 2020 at 01:52:06AM +0200, Paul Cercueil wrote:
>>  The address of the DMA descriptor never changes. It can therefore 
>> be set
>>  in the probe function.
>> 
>>  Signed-off-by: Paul Cercueil <paul@crapouillou.net>
>>  ---
>> 
>>  Notes:
>>      v2: No change
>> 
>>   drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 5 +++--
>>   1 file changed, 3 insertions(+), 2 deletions(-)
>> 
>>  diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c 
>> b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
>>  index 924c8daf071a..f7b0c5dc8cd8 100644
>>  --- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
>>  +++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
>>  @@ -358,8 +358,6 @@ static void 
>> ingenic_drm_crtc_atomic_flush(struct drm_crtc *crtc,
>>   		ingenic_drm_crtc_update_ctrl(priv, finfo);
>> 
>>   		clk_set_rate(priv->pix_clk, state->adjusted_mode.clock * 1000);
>>  -
>>  -		regmap_write(priv->map, JZ_REG_LCD_DA0, priv->dma_hwdesc->next);
>>   	}
>> 
>>   	if (event) {
>>  @@ -757,6 +755,9 @@ static int ingenic_drm_probe(struct 
>> platform_device *pdev)
>>   		}
>>   	}
>> 
>>  +	/* Set address of our DMA descriptor chain */
>>  +	regmap_write(priv->map, JZ_REG_LCD_DA0, priv->dma_hwdesc_phys);
>>  +
> 
> 
> What is the purpose of this code after the assignment was moved:
> 
> static int ingenic_drm_probe(struct platform_device *pdev)
> {
> ...
> 	priv->dma_hwdesc->next = priv->dma_hwdesc_phys;
> 
> I do not see ->next used anymore.
> Could this assignment be dropped?
> 
> 
> And the following line:
> 	priv->dma_hwdesc->id = 0xdeafbead;
> 
> I can only see ->id be assingned, it is never referenced??
> 
> Maybe this is all related to the structure assumed by the data pointed
> to by JZ_REG_LCD_DA0?

As its name suggests, 'dma_hwdesc' points to a DMA hardware descriptor. 
Setting ->next sets the address of the next descriptor (which is itself 
since we only use one descriptor). The 'id' field will be copied by the 
hardware to a register when the DMA descriptor is loaded, so we can 
know from userspace (debugfs) what DMA descriptors are loaded by 
looking up the IDs.

-Paul

> 	Sam
> 
>>   	ret = drm_dev_register(drm, 0);
>>   	if (ret) {
>>   		dev_err(dev, "Failed to register DRM driver\n");
>>  --
>>  2.27.0
>> 
>>  _______________________________________________
>>  dri-devel mailing list
>>  dri-devel@lists.freedesktop.org
>>  https://lists.freedesktop.org/mailman/listinfo/dri-devel



^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH v2 08/10] drm/ingenic: Add support for OSD mode
  2020-06-29 23:52 ` [PATCH v2 08/10] drm/ingenic: Add support for OSD mode Paul Cercueil
@ 2020-06-30 12:05   ` Sam Ravnborg
  2020-06-30 14:39     ` Paul Cercueil
  0 siblings, 1 reply; 22+ messages in thread
From: Sam Ravnborg @ 2020-06-30 12:05 UTC (permalink / raw)
  To: Paul Cercueil
  Cc: David Airlie, Daniel Vetter, Rob Herring, devicetree, linux-mips,
	dri-devel, linux-kernel, od

Hi Paul.

On Tue, Jun 30, 2020 at 01:52:08AM +0200, Paul Cercueil wrote:
> All Ingenic SoCs starting from the JZ4725B support OSD mode.
> 
> In this mode, two separate planes can be used. They can have different
> positions and sizes, and one can be overlayed on top of the other.
> 
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>

OSD? On screen Display?

Some random comments in the following - from my attempt to follow the
code.

	Sam


> ---
> 
> Notes:
>     v2: Use fallthrough; instead of /* fall-through */
> 
>  drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 271 +++++++++++++++++-----
>  drivers/gpu/drm/ingenic/ingenic-drm.h     |  35 +++
>  2 files changed, 254 insertions(+), 52 deletions(-)
> 
> diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
> index 6590b61cb915..a8573da1d577 100644
> --- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
> +++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
> @@ -43,12 +43,13 @@ struct ingenic_dma_hwdesc {
>  
>  struct jz_soc_info {
>  	bool needs_dev_clk;
> +	bool has_osd;
>  	unsigned int max_width, max_height;
>  };
>  
>  struct ingenic_drm {
>  	struct drm_device drm;
> -	struct drm_plane primary;
> +	struct drm_plane f0, f1;

A small comment about when f0 and f1 is used and how they are the
primary plane would be good here.


>  	struct drm_crtc crtc;
>  	struct drm_encoder encoder;
>  
> @@ -57,8 +58,8 @@ struct ingenic_drm {
>  	struct clk *lcd_clk, *pix_clk;
>  	const struct jz_soc_info *soc_info;
>  
> -	struct ingenic_dma_hwdesc *dma_hwdesc;
> -	dma_addr_t dma_hwdesc_phys;
> +	struct ingenic_dma_hwdesc *dma_hwdesc[2];
> +	dma_addr_t dma_hwdesc_phys[2];
>  
>  	bool panel_is_sharp;
>  };
> @@ -90,7 +91,7 @@ static const struct regmap_config ingenic_drm_regmap_config = {
>  	.val_bits = 32,
>  	.reg_stride = 4,
>  
> -	.max_register = JZ_REG_LCD_CMD1,
> +	.max_register = JZ_REG_LCD_SIZE1,
>  	.writeable_reg = ingenic_drm_writeable_reg,
>  };
>  
> @@ -110,11 +111,6 @@ drm_encoder_get_priv(struct drm_encoder *encoder)
>  	return container_of(encoder, struct ingenic_drm, encoder);
>  }
>  
> -static inline struct ingenic_drm *drm_plane_get_priv(struct drm_plane *plane)
> -{
> -	return container_of(plane, struct ingenic_drm, primary);
> -}
> -
>  static void ingenic_drm_crtc_atomic_enable(struct drm_crtc *crtc,
>  					   struct drm_crtc_state *state)
>  {
> @@ -185,34 +181,17 @@ static void ingenic_drm_crtc_update_timings(struct ingenic_drm *priv,
>  		regmap_write(priv->map, JZ_REG_LCD_SPL, hpe << 16 | (hpe + 1));
>  		regmap_write(priv->map, JZ_REG_LCD_REV, mode->htotal << 16);
>  	}
> -}
> -
> -static void ingenic_drm_crtc_update_ctrl(struct ingenic_drm *priv,
> -					 const struct drm_format_info *finfo)
> -{
> -	unsigned int ctrl = JZ_LCD_CTRL_OFUP | JZ_LCD_CTRL_BURST_16;
> -
> -	switch (finfo->format) {
> -	case DRM_FORMAT_XRGB1555:
> -		ctrl |= JZ_LCD_CTRL_RGB555;
> -		/* fall-through */
> -	case DRM_FORMAT_RGB565:
> -		ctrl |= JZ_LCD_CTRL_BPP_15_16;
> -		break;
> -	case DRM_FORMAT_XRGB8888:
> -		ctrl |= JZ_LCD_CTRL_BPP_18_24;
> -		break;
> -	}
>  
>  	regmap_update_bits(priv->map, JZ_REG_LCD_CTRL,
> -			   JZ_LCD_CTRL_OFUP | JZ_LCD_CTRL_BURST_16 |
> -			   JZ_LCD_CTRL_BPP_MASK, ctrl);
> +			   JZ_LCD_CTRL_OFUP | JZ_LCD_CTRL_BURST_16,
> +			   JZ_LCD_CTRL_OFUP | JZ_LCD_CTRL_BURST_16);
It looks like regmap_update_bits() is no longer the best choice here.

>  }
>  
>  static int ingenic_drm_crtc_atomic_check(struct drm_crtc *crtc,
>  					 struct drm_crtc_state *state)
>  {
>  	struct ingenic_drm *priv = drm_crtc_get_priv(crtc);
> +	struct drm_plane_state *f1_state, *f0_state;
>  	long rate;
>  
>  	if (!drm_atomic_crtc_needs_modeset(state))
> @@ -227,6 +206,15 @@ static int ingenic_drm_crtc_atomic_check(struct drm_crtc *crtc,
>  	if (rate < 0)
>  		return rate;
>  
> +	if (priv->soc_info->has_osd) {
> +		f1_state = drm_atomic_get_plane_state(state->state, &priv->f1);
> +		f0_state = drm_atomic_get_plane_state(state->state, &priv->f0);
> +
> +		/* If all the planes are disabled, we won't get a VBLANK IRQ */
> +		if (!f1_state->fb && !f0_state->fb)
> +			state->no_vblank = true;
> +	}
> +
>  	return 0;
>  }
>  
> @@ -236,14 +224,9 @@ static void ingenic_drm_crtc_atomic_flush(struct drm_crtc *crtc,
>  	struct ingenic_drm *priv = drm_crtc_get_priv(crtc);
>  	struct drm_crtc_state *state = crtc->state;
>  	struct drm_pending_vblank_event *event = state->event;
> -	struct drm_framebuffer *drm_fb = crtc->primary->state->fb;
> -	const struct drm_format_info *finfo;
>  
>  	if (drm_atomic_crtc_needs_modeset(state)) {
> -		finfo = drm_format_info(drm_fb->format->format);
> -
>  		ingenic_drm_crtc_update_timings(priv, &state->mode);
> -		ingenic_drm_crtc_update_ctrl(priv, finfo);
>  
>  		clk_set_rate(priv->pix_clk, state->adjusted_mode.clock * 1000);
>  	}
> @@ -260,12 +243,149 @@ static void ingenic_drm_crtc_atomic_flush(struct drm_crtc *crtc,
>  	}
>  }
>  
> +static int ingenic_drm_plane_atomic_check(struct drm_plane *plane,
> +					  struct drm_plane_state *state)
> +{
> +	struct ingenic_drm *priv = drm_device_get_priv(plane->dev);
> +	struct drm_crtc_state *crtc_state;
> +	struct drm_crtc *crtc = state->crtc ?: plane->state->crtc;
> +	int ret;
> +
> +	if (!crtc)
> +		return 0;
> +
> +	crtc_state = drm_atomic_get_existing_crtc_state(state->state, crtc);
> +	if (WARN_ON(!crtc_state))
> +		return -EINVAL;
> +
> +	ret = drm_atomic_helper_check_plane_state(state, crtc_state,
> +						  DRM_PLANE_HELPER_NO_SCALING,
> +						  DRM_PLANE_HELPER_NO_SCALING,
> +						  priv->soc_info->has_osd,
> +						  true);
> +	if (ret)
> +		return ret;
> +
> +	if (!priv->soc_info->has_osd &&
> +	    (state->src_x != 0 ||
> +	     (state->src_w >> 16) != state->crtc_w ||
> +	     (state->src_h >> 16) != state->crtc_h))
> +		return -EINVAL;
This check could bebefit from a small comment.
I cannot see the purpose of " >> 16" on the src_* fields...


> +
> +	/*
> +	 * Require full modeset if if enabling or disabling a plane, or changing
Too many ifs?

> +	 * its position, size or depth.
> +	 */
> +	if (priv->soc_info->has_osd &&
> +	    (!plane->state->fb || !state->fb ||
> +	     plane->state->crtc_x != state->crtc_x ||
> +	     plane->state->crtc_y != state->crtc_y ||
> +	     plane->state->crtc_w != state->crtc_w ||
> +	     plane->state->crtc_h != state->crtc_h ||
> +	     plane->state->fb->format->format != state->fb->format->format))
> +		crtc_state->mode_changed = true;
> +
> +	return 0;
> +}
> +
> +static void ingenic_drm_plane_enable(struct ingenic_drm *priv,
> +				      struct drm_plane *plane)
> +{
> +	unsigned int en_bit;
> +
> +	if (priv->soc_info->has_osd) {
> +		if (plane->type == DRM_PLANE_TYPE_PRIMARY)
> +			en_bit = JZ_LCD_OSDC_F1EN;
> +		else
> +			en_bit = JZ_LCD_OSDC_F0EN;
> +
> +		regmap_update_bits(priv->map, JZ_REG_LCD_OSDC, en_bit, en_bit);
I think you can use a more direct way to do the assignment.
Like before where the same pattern was used (last two arguments the
same).

> +	}
> +}
> +
> +static void ingenic_drm_plane_atomic_disable(struct drm_plane *plane,
> +					     struct drm_plane_state *old_state)
> +{
> +	struct ingenic_drm *priv = drm_device_get_priv(plane->dev);
> +	unsigned int en_bit;
> +
> +	if (priv->soc_info->has_osd) {
> +		if (plane->type == DRM_PLANE_TYPE_PRIMARY)
> +			en_bit = JZ_LCD_OSDC_F1EN;
> +		else
> +			en_bit = JZ_LCD_OSDC_F0EN;
> +
> +		regmap_update_bits(priv->map, JZ_REG_LCD_OSDC, en_bit, 0);
> +	}
> +}
> +
> +static void ingenic_drm_plane_config(struct ingenic_drm *priv,
> +				     struct drm_plane *plane, u32 fourcc)
> +{
> +	struct drm_plane_state *state = plane->state;
> +	unsigned int xy_reg, size_reg;
> +	unsigned int ctrl = 0;
> +
> +	ingenic_drm_plane_enable(priv, plane);
> +
> +	if (priv->soc_info->has_osd &&
> +	    plane->type == DRM_PLANE_TYPE_PRIMARY) {
> +		switch (fourcc) {
> +		case DRM_FORMAT_XRGB1555:
> +			ctrl |= JZ_LCD_OSDCTRL_RGB555;
> +			fallthrough;
> +		case DRM_FORMAT_RGB565:
> +			ctrl |= JZ_LCD_OSDCTRL_BPP_15_16;
> +			break;
> +		case DRM_FORMAT_XRGB8888:
> +			ctrl |= JZ_LCD_OSDCTRL_BPP_18_24;
> +			break;
> +		}
> +
> +		regmap_update_bits(priv->map, JZ_REG_LCD_OSDCTRL,
> +				   JZ_LCD_OSDCTRL_BPP_MASK, ctrl);
> +	} else {
> +		switch (fourcc) {
> +		case DRM_FORMAT_XRGB1555:
> +			ctrl |= JZ_LCD_CTRL_RGB555;
> +			fallthrough;
> +		case DRM_FORMAT_RGB565:
> +			ctrl |= JZ_LCD_CTRL_BPP_15_16;
> +			break;
> +		case DRM_FORMAT_XRGB8888:
> +			ctrl |= JZ_LCD_CTRL_BPP_18_24;
> +			break;
> +		}
> +
> +		regmap_update_bits(priv->map, JZ_REG_LCD_CTRL,
> +				   JZ_LCD_CTRL_BPP_MASK, ctrl);
> +	}
> +
> +	if (priv->soc_info->has_osd) {
> +		if (plane->type == DRM_PLANE_TYPE_PRIMARY) {
> +			xy_reg = JZ_REG_LCD_XYP1;
> +			size_reg = JZ_REG_LCD_SIZE1;
> +		} else {
> +			xy_reg = JZ_REG_LCD_XYP0;
> +			size_reg = JZ_REG_LCD_SIZE0;
> +		}
> +
> +		regmap_write(priv->map, xy_reg,
> +			     state->crtc_x << JZ_LCD_XYP01_XPOS_LSB |
> +			     state->crtc_y << JZ_LCD_XYP01_YPOS_LSB);
> +		regmap_write(priv->map, size_reg,
> +			     state->crtc_w << JZ_LCD_SIZE01_WIDTH_LSB |
> +			     state->crtc_h << JZ_LCD_SIZE01_HEIGHT_LSB);
> +	}
> +}
> +
>  static void ingenic_drm_plane_atomic_update(struct drm_plane *plane,
>  					    struct drm_plane_state *oldstate)
>  {
> -	struct ingenic_drm *priv = drm_plane_get_priv(plane);
> +	struct ingenic_drm *priv = drm_device_get_priv(plane->dev);
>  	struct drm_plane_state *state = plane->state;
>  	unsigned int width, height, cpp;
> +	unsigned int hwdesc_idx;
>  	dma_addr_t addr;
>  
>  	if (state && state->fb) {
> @@ -274,9 +394,18 @@ static void ingenic_drm_plane_atomic_update(struct drm_plane *plane,
>  		height = state->src_h >> 16;
>  		cpp = state->fb->format->cpp[0];
>  
> -		priv->dma_hwdesc->addr = addr;
> -		priv->dma_hwdesc->cmd = width * height * cpp / 4;
> -		priv->dma_hwdesc->cmd |= JZ_LCD_CMD_EOF_IRQ;
> +		if (!priv->soc_info->has_osd)
> +			hwdesc_idx = 0;
> +		else

> +			hwdesc_idx = plane->type == DRM_PLANE_TYPE_PRIMARY;
This looks ugly.
"plane->type == DRM_PLANE_TYPE_PRIMARY" evaluates to a boolean.
This is then ocnverted to an int used as index to an array later.
Something a bit more explicit would be more readable.


> +
> +		priv->dma_hwdesc[hwdesc_idx]->addr = addr;
> +		priv->dma_hwdesc[hwdesc_idx]->cmd = width * height * cpp / 4;
> +		priv->dma_hwdesc[hwdesc_idx]->cmd |= JZ_LCD_CMD_EOF_IRQ;
> +
> +		if (drm_atomic_crtc_needs_modeset(state->crtc->state))
> +			ingenic_drm_plane_config(priv, plane,
> +						 state->fb->format->format);
>  	}
>  }
>  
> @@ -437,6 +566,8 @@ static const struct drm_crtc_funcs ingenic_drm_crtc_funcs = {
>  
>  static const struct drm_plane_helper_funcs ingenic_drm_plane_helper_funcs = {
>  	.atomic_update		= ingenic_drm_plane_atomic_update,
> +	.atomic_check		= ingenic_drm_plane_atomic_check,
> +	.atomic_disable		= ingenic_drm_plane_atomic_disable,
>  	.prepare_fb		= drm_gem_fb_prepare_fb,
>  };
>  
> @@ -463,8 +594,10 @@ static void ingenic_drm_free_dma_hwdesc(void *d)
>  {
>  	struct ingenic_drm *priv = d;
>  
> -	dma_free_coherent(priv->dev, sizeof(*priv->dma_hwdesc),
> -			  priv->dma_hwdesc, priv->dma_hwdesc_phys);
> +	dma_free_coherent(priv->dev, sizeof(*priv->dma_hwdesc[0]),
> +			  priv->dma_hwdesc[0], priv->dma_hwdesc_phys[0]);
> +	dma_free_coherent(priv->dev, sizeof(*priv->dma_hwdesc[1]),
> +			  priv->dma_hwdesc[1], priv->dma_hwdesc_phys[1]);
>  }
>  
>  static int ingenic_drm_probe(struct platform_device *pdev)
> @@ -549,23 +682,32 @@ static int ingenic_drm_probe(struct platform_device *pdev)
>  		bridge = devm_drm_panel_bridge_add_typed(dev, panel,
>  							 DRM_MODE_CONNECTOR_DPI);
>  
> -	priv->dma_hwdesc = dma_alloc_coherent(dev, sizeof(*priv->dma_hwdesc),
> -					      &priv->dma_hwdesc_phys,
> -					      GFP_KERNEL);
> -	if (!priv->dma_hwdesc)
> +	priv->dma_hwdesc[0] = dma_alloc_coherent(dev, sizeof(*priv->dma_hwdesc[0]),
> +						 &priv->dma_hwdesc_phys[0],
> +						 GFP_KERNEL);
> +	if (!priv->dma_hwdesc[0])
> +		return -ENOMEM;
> +
> +	priv->dma_hwdesc[0]->next = priv->dma_hwdesc_phys[0];
> +	priv->dma_hwdesc[0]->id = 0xdeafbead;
> +
> +	priv->dma_hwdesc[1] = dma_alloc_coherent(dev, sizeof(*priv->dma_hwdesc[1]),
> +						 &priv->dma_hwdesc_phys[1],
> +						 GFP_KERNEL);
> +	if (!priv->dma_hwdesc[1])
>  		return -ENOMEM;
Here you should undo the first allocation??
I think the code could benefit from using dmam_alloc_coherent().

>  
> +	priv->dma_hwdesc[1]->next = priv->dma_hwdesc_phys[1];
> +	priv->dma_hwdesc[1]->id = 0xdeadbabe;
> +
>  	ret = devm_add_action_or_reset(dev, ingenic_drm_free_dma_hwdesc, priv);
>  	if (ret)
>  		return ret;
>  
> -	priv->dma_hwdesc->next = priv->dma_hwdesc_phys;
> -	priv->dma_hwdesc->id = 0xdeafbead;
> -
> -	drm_plane_helper_add(&priv->primary, &ingenic_drm_plane_helper_funcs);
> +	drm_plane_helper_add(&priv->f1, &ingenic_drm_plane_helper_funcs);
>  
> -	ret = drm_universal_plane_init(drm, &priv->primary,
> -				       0, &ingenic_drm_primary_plane_funcs,
> +	ret = drm_universal_plane_init(drm, &priv->f1, 1,
> +				       &ingenic_drm_primary_plane_funcs,
>  				       ingenic_drm_primary_formats,
>  				       ARRAY_SIZE(ingenic_drm_primary_formats),
>  				       NULL, DRM_PLANE_TYPE_PRIMARY, NULL);
> @@ -576,13 +718,30 @@ static int ingenic_drm_probe(struct platform_device *pdev)
>  
>  	drm_crtc_helper_add(&priv->crtc, &ingenic_drm_crtc_helper_funcs);
>  
> -	ret = drm_crtc_init_with_planes(drm, &priv->crtc, &priv->primary,
> +	ret = drm_crtc_init_with_planes(drm, &priv->crtc, &priv->f1,
>  					NULL, &ingenic_drm_crtc_funcs, NULL);
>  	if (ret) {
>  		dev_err(dev, "Failed to init CRTC: %i\n", ret);
>  		return ret;
>  	}
>  
> +	if (soc_info->has_osd) {
> +		drm_plane_helper_add(&priv->f0,
> +				     &ingenic_drm_plane_helper_funcs);
> +
> +		ret = drm_universal_plane_init(drm, &priv->f0, 1,
> +					       &ingenic_drm_primary_plane_funcs,
> +					       ingenic_drm_primary_formats,
> +					       ARRAY_SIZE(ingenic_drm_primary_formats),
> +					       NULL, DRM_PLANE_TYPE_OVERLAY,
> +					       NULL);
> +		if (ret) {
> +			dev_err(dev, "Failed to register overlay plane: %i\n",
> +				ret);
> +			return ret;
> +		}
> +	}
> +
>  	priv->encoder.possible_crtcs = 1;
>  
>  	drm_encoder_helper_add(&priv->encoder,
> @@ -644,7 +803,12 @@ static int ingenic_drm_probe(struct platform_device *pdev)
>  	}
>  
>  	/* Set address of our DMA descriptor chain */
> -	regmap_write(priv->map, JZ_REG_LCD_DA0, priv->dma_hwdesc_phys);
> +	regmap_write(priv->map, JZ_REG_LCD_DA0, priv->dma_hwdesc_phys[0]);
> +	regmap_write(priv->map, JZ_REG_LCD_DA1, priv->dma_hwdesc_phys[1]);
> +
> +	/* Enable OSD if available */
> +	if (soc_info->has_osd)
> +		regmap_write(priv->map, JZ_REG_LCD_OSDC, JZ_LCD_OSDC_OSDEN);
>  
>  	ret = drm_dev_register(drm, 0);
>  	if (ret) {
> @@ -680,18 +844,21 @@ static int ingenic_drm_remove(struct platform_device *pdev)
>  
>  static const struct jz_soc_info jz4740_soc_info = {
>  	.needs_dev_clk = true,
> +	.has_osd = false,
>  	.max_width = 800,
>  	.max_height = 600,
>  };
>  
>  static const struct jz_soc_info jz4725b_soc_info = {
>  	.needs_dev_clk = false,
> +	.has_osd = true,
>  	.max_width = 800,
>  	.max_height = 600,
>  };
>  
>  static const struct jz_soc_info jz4770_soc_info = {
>  	.needs_dev_clk = false,
> +	.has_osd = true,
>  	.max_width = 1280,
>  	.max_height = 720,
>  };
> diff --git a/drivers/gpu/drm/ingenic/ingenic-drm.h b/drivers/gpu/drm/ingenic/ingenic-drm.h
> index cb578cff7bb1..d0b827a9fe83 100644
> --- a/drivers/gpu/drm/ingenic/ingenic-drm.h
> +++ b/drivers/gpu/drm/ingenic/ingenic-drm.h
> @@ -30,6 +30,18 @@
>  #define JZ_REG_LCD_SA1				0x54
>  #define JZ_REG_LCD_FID1				0x58
>  #define JZ_REG_LCD_CMD1				0x5C
> +#define JZ_REG_LCD_OSDC				0x100
> +#define JZ_REG_LCD_OSDCTRL			0x104
> +#define JZ_REG_LCD_OSDS				0x108
> +#define JZ_REG_LCD_BGC				0x10c
> +#define JZ_REG_LCD_KEY0				0x110
> +#define JZ_REG_LCD_KEY1				0x114
> +#define JZ_REG_LCD_ALPHA			0x118
> +#define JZ_REG_LCD_IPUR				0x11c
> +#define JZ_REG_LCD_XYP0				0x120
> +#define JZ_REG_LCD_XYP1				0x124
> +#define JZ_REG_LCD_SIZE0			0x128
> +#define JZ_REG_LCD_SIZE1			0x12c
>  
>  #define JZ_LCD_CFG_SLCD				BIT(31)
>  #define JZ_LCD_CFG_PS_DISABLE			BIT(23)
> @@ -123,4 +135,27 @@
>  #define JZ_LCD_STATE_SOF_IRQ			BIT(4)
>  #define JZ_LCD_STATE_DISABLED			BIT(0)
>  
> +#define JZ_LCD_OSDC_OSDEN			BIT(0)
> +#define JZ_LCD_OSDC_F0EN			BIT(3)
> +#define JZ_LCD_OSDC_F1EN			BIT(4)
> +
> +#define JZ_LCD_OSDCTRL_IPU			BIT(15)
> +#define JZ_LCD_OSDCTRL_RGB555			BIT(4)
> +#define JZ_LCD_OSDCTRL_CHANGE			BIT(3)
> +#define JZ_LCD_OSDCTRL_BPP_15_16		0x4
> +#define JZ_LCD_OSDCTRL_BPP_18_24		0x5
> +#define JZ_LCD_OSDCTRL_BPP_30			0x7
> +#define JZ_LCD_OSDCTRL_BPP_MASK			(JZ_LCD_OSDCTRL_RGB555 | 0x7)
> +
> +#define JZ_LCD_OSDS_READY			BIT(0)
> +
> +#define JZ_LCD_IPUR_IPUREN			BIT(31)
> +#define JZ_LCD_IPUR_IPUR_LSB			0
> +
> +#define JZ_LCD_XYP01_XPOS_LSB			0
> +#define JZ_LCD_XYP01_YPOS_LSB			16
> +
> +#define JZ_LCD_SIZE01_WIDTH_LSB			0
> +#define JZ_LCD_SIZE01_HEIGHT_LSB		16
> +
>  #endif /* DRIVERS_GPU_DRM_INGENIC_INGENIC_DRM_H */
> -- 
> 2.27.0
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH v2 09/10] drm/ingenic: Add support for the IPU
  2020-06-29 23:52 ` [PATCH v2 09/10] drm/ingenic: Add support for the IPU Paul Cercueil
@ 2020-06-30 12:16   ` Sam Ravnborg
  2020-06-30 13:33     ` Paul Cercueil
  0 siblings, 1 reply; 22+ messages in thread
From: Sam Ravnborg @ 2020-06-30 12:16 UTC (permalink / raw)
  To: Paul Cercueil
  Cc: David Airlie, Daniel Vetter, Rob Herring, devicetree, linux-mips,
	dri-devel, linux-kernel, od

Hi Paul.

On Tue, Jun 30, 2020 at 01:52:09AM +0200, Paul Cercueil wrote:
> Add support for the Image Processing Unit (IPU) found in all Ingenic
> SoCs.
> 
> The IPU can upscale and downscale a source frame of arbitrary size
> ranging from 4x4 to 4096x4096 on newer SoCs, with bicubic filtering
> on newer SoCs, bilinear filtering on older SoCs. Nearest-neighbour can
> also be obtained with proper coefficients.
> 
> Starting from the JZ4725B, the IPU supports a mode where its output is
> sent directly to the LCDC, without having to be written to RAM first.
> This makes it possible to use the IPU as a DRM plane on the compatible
> SoCs, and have it convert and scale anything the userspace asks for to
> what's available for the display.
> 
> Regarding pixel formats, older SoCs support packed YUV 4:2:2 and various
> planar YUV formats. Newer SoCs introduced support for RGB.
> 

> Since the IPU is a separate hardware block, to make it work properly the
> Ingenic DRM driver will now register itself as a component master in
> case the IPU driver has been enabled in the config.
I cannot see why this driver needs the component framework to deal with
the IPU. It looks like a left-over from when this was two modules.
While browsing the code the code now has two independent struct
soc_info. It would be simpler with only one - at least if it is the
same logic that is used in both cases.

So open question - can this be simplified more than it is today and
is the use of the component framework mandatory?

	Sam

> 
> When enabled in the config, the CRTC will see the IPU as a second primary
> plane. It cannot be enabled at the same time as the regular primary
> plane. It has the same priority, which means that it will also display
> below the overlay plane.
> 
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
> 
> Notes:
>     v2: - ingenic-ipu is no longer its own module. It will be built
>     	  into the ingenic-drm module.
>     	- If enabled in the config, both the core driver and the IPU
>     	  driver will register as components; otherwise the core
>     	  driver will bypass that and call the ingenic_drm_bind()
>     	  function directly.
>     	- Since both files now build into the same module, the
>     	  symbols previously exported as GPL are not exported anymore,
>     	  since they are only used internally.
>     	- Fix SPDX license header in ingenic-ipu.h
>     	- Avoid using 'for(;;);' loops without trailing statement(s)
> 
>  drivers/gpu/drm/ingenic/Kconfig           |  11 +
>  drivers/gpu/drm/ingenic/Makefile          |   3 +-
>  drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 155 +++-
>  drivers/gpu/drm/ingenic/ingenic-drm.h     |  12 +
>  drivers/gpu/drm/ingenic/ingenic-ipu.c     | 848 ++++++++++++++++++++++
>  drivers/gpu/drm/ingenic/ingenic-ipu.h     | 109 +++
>  6 files changed, 1122 insertions(+), 16 deletions(-)
>  create mode 100644 drivers/gpu/drm/ingenic/ingenic-ipu.c
>  create mode 100644 drivers/gpu/drm/ingenic/ingenic-ipu.h
> 
> diff --git a/drivers/gpu/drm/ingenic/Kconfig b/drivers/gpu/drm/ingenic/Kconfig
> index d82c3d37ec9c..477d5387e43e 100644
> --- a/drivers/gpu/drm/ingenic/Kconfig
> +++ b/drivers/gpu/drm/ingenic/Kconfig
> @@ -14,3 +14,14 @@ config DRM_INGENIC
>  	  Choose this option for DRM support for the Ingenic SoCs.
>  
>  	  If M is selected the module will be called ingenic-drm.
> +
> +if DRM_INGENIC
> +
> +config DRM_INGENIC_IPU
> +	bool "IPU support for Ingenic SoCs"
> +	help
> +	  Choose this option to enable support for the IPU found in Ingenic SoCs.
> +
> +	  The Image Processing Unit (IPU) will appear as a second primary plane.
> +
> +endif
> diff --git a/drivers/gpu/drm/ingenic/Makefile b/drivers/gpu/drm/ingenic/Makefile
> index 9875628dd8bc..d313326bdddb 100644
> --- a/drivers/gpu/drm/ingenic/Makefile
> +++ b/drivers/gpu/drm/ingenic/Makefile
> @@ -1,2 +1,3 @@
>  obj-$(CONFIG_DRM_INGENIC) += ingenic-drm.o
> -ingenic-drm-y += ingenic-drm-drv.o
> +ingenic-drm-y = ingenic-drm-drv.o
> +ingenic-drm-$(CONFIG_DRM_INGENIC_IPU) += ingenic-ipu.o
> diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
> index a8573da1d577..36440acd23de 100644
> --- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
> +++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
> @@ -6,6 +6,7 @@
>  
>  #include "ingenic-drm.h"
>  
> +#include <linux/component.h>
>  #include <linux/clk.h>
>  #include <linux/dma-mapping.h>
>  #include <linux/module.h>
> @@ -49,7 +50,7 @@ struct jz_soc_info {
>  
>  struct ingenic_drm {
>  	struct drm_device drm;
> -	struct drm_plane f0, f1;
> +	struct drm_plane f0, f1, *ipu_plane;
>  	struct drm_crtc crtc;
>  	struct drm_encoder encoder;
>  
> @@ -185,13 +186,16 @@ static void ingenic_drm_crtc_update_timings(struct ingenic_drm *priv,
>  	regmap_update_bits(priv->map, JZ_REG_LCD_CTRL,
>  			   JZ_LCD_CTRL_OFUP | JZ_LCD_CTRL_BURST_16,
>  			   JZ_LCD_CTRL_OFUP | JZ_LCD_CTRL_BURST_16);
> +
> +	regmap_write(priv->map, JZ_REG_LCD_IPUR, JZ_LCD_IPUR_IPUREN |
> +		     (ht * vpe / 3) << JZ_LCD_IPUR_IPUR_LSB);
>  }
>  
>  static int ingenic_drm_crtc_atomic_check(struct drm_crtc *crtc,
>  					 struct drm_crtc_state *state)
>  {
>  	struct ingenic_drm *priv = drm_crtc_get_priv(crtc);
> -	struct drm_plane_state *f1_state, *f0_state;
> +	struct drm_plane_state *f1_state, *f0_state, *ipu_state;
>  	long rate;
>  
>  	if (!drm_atomic_crtc_needs_modeset(state))
> @@ -210,14 +214,40 @@ static int ingenic_drm_crtc_atomic_check(struct drm_crtc *crtc,
>  		f1_state = drm_atomic_get_plane_state(state->state, &priv->f1);
>  		f0_state = drm_atomic_get_plane_state(state->state, &priv->f0);
>  
> +		if (priv->ipu_plane)
> +			ipu_state = drm_atomic_get_plane_state(state->state, priv->ipu_plane);
> +
> +		/* IPU and F1 planes cannot be enabled at the same time. */
> +		if (priv->ipu_plane && f1_state->fb && ipu_state->fb) {
> +			dev_dbg(priv->dev, "Cannot enable both F1 and IPU\n");
> +			return -EINVAL;
> +		}
> +
>  		/* If all the planes are disabled, we won't get a VBLANK IRQ */
> -		if (!f1_state->fb && !f0_state->fb)
> +		if (!f1_state->fb && !f0_state->fb &&
> +		    !(priv->ipu_plane && ipu_state->fb))
>  			state->no_vblank = true;
>  	}
>  
>  	return 0;
>  }
>  
> +static void ingenic_drm_crtc_atomic_begin(struct drm_crtc *crtc,
> +					  struct drm_crtc_state *oldstate)
> +{
> +	struct ingenic_drm *priv = drm_crtc_get_priv(crtc);
> +	u32 ctrl = 0;
> +
> +	if (priv->soc_info->has_osd &&
> +	    drm_atomic_crtc_needs_modeset(crtc->state)) {
> +		if (priv->ipu_plane && priv->ipu_plane->state->fb)
> +			ctrl |= JZ_LCD_OSDCTRL_IPU;
> +
> +		regmap_update_bits(priv->map, JZ_REG_LCD_OSDCTRL,
> +				   JZ_LCD_OSDCTRL_IPU, ctrl);
> +	}
> +}
> +
>  static void ingenic_drm_crtc_atomic_flush(struct drm_crtc *crtc,
>  					  struct drm_crtc_state *oldstate)
>  {
> @@ -303,10 +333,9 @@ static void ingenic_drm_plane_enable(struct ingenic_drm *priv,
>  	}
>  }
>  
> -static void ingenic_drm_plane_atomic_disable(struct drm_plane *plane,
> -					     struct drm_plane_state *old_state)
> +void ingenic_drm_plane_disable(struct device *dev, struct drm_plane *plane)
>  {
> -	struct ingenic_drm *priv = drm_device_get_priv(plane->dev);
> +	struct ingenic_drm *priv = dev_get_drvdata(dev);
>  	unsigned int en_bit;
>  
>  	if (priv->soc_info->has_osd) {
> @@ -319,9 +348,18 @@ static void ingenic_drm_plane_atomic_disable(struct drm_plane *plane,
>  	}
>  }
>  
> -static void ingenic_drm_plane_config(struct ingenic_drm *priv,
> -				     struct drm_plane *plane, u32 fourcc)
> +static void ingenic_drm_plane_atomic_disable(struct drm_plane *plane,
> +					     struct drm_plane_state *old_state)
>  {
> +	struct ingenic_drm *priv = drm_device_get_priv(plane->dev);
> +
> +	ingenic_drm_plane_disable(priv->dev, plane);
> +}
> +
> +void ingenic_drm_plane_config(struct device *dev,
> +			      struct drm_plane *plane, u32 fourcc)
> +{
> +	struct ingenic_drm *priv = dev_get_drvdata(dev);
>  	struct drm_plane_state *state = plane->state;
>  	unsigned int xy_reg, size_reg;
>  	unsigned int ctrl = 0;
> @@ -404,7 +442,7 @@ static void ingenic_drm_plane_atomic_update(struct drm_plane *plane,
>  		priv->dma_hwdesc[hwdesc_idx]->cmd |= JZ_LCD_CMD_EOF_IRQ;
>  
>  		if (drm_atomic_crtc_needs_modeset(state->crtc->state))
> -			ingenic_drm_plane_config(priv, plane,
> +			ingenic_drm_plane_config(priv->dev, plane,
>  						 state->fb->format->format);
>  	}
>  }
> @@ -574,6 +612,7 @@ static const struct drm_plane_helper_funcs ingenic_drm_plane_helper_funcs = {
>  static const struct drm_crtc_helper_funcs ingenic_drm_crtc_helper_funcs = {
>  	.atomic_enable		= ingenic_drm_crtc_atomic_enable,
>  	.atomic_disable		= ingenic_drm_crtc_atomic_disable,
> +	.atomic_begin		= ingenic_drm_crtc_atomic_begin,
>  	.atomic_flush		= ingenic_drm_crtc_atomic_flush,
>  	.atomic_check		= ingenic_drm_crtc_atomic_check,
>  };
> @@ -600,10 +639,17 @@ static void ingenic_drm_free_dma_hwdesc(void *d)
>  			  priv->dma_hwdesc[1], priv->dma_hwdesc_phys[1]);
>  }
>  
> -static int ingenic_drm_probe(struct platform_device *pdev)
> +static void ingenic_drm_unbind_all(void *d)
> +{
> +	struct ingenic_drm *priv = d;
> +
> +	component_unbind_all(priv->dev, &priv->drm);
> +}
> +
> +static int ingenic_drm_bind(struct device *dev)
>  {
> +	struct platform_device *pdev = to_platform_device(dev);
>  	const struct jz_soc_info *soc_info;
> -	struct device *dev = &pdev->dev;
>  	struct ingenic_drm *priv;
>  	struct clk *parent_clk;
>  	struct drm_bridge *bridge;
> @@ -640,6 +686,19 @@ static int ingenic_drm_probe(struct platform_device *pdev)
>  	drm->mode_config.max_height = 4095;
>  	drm->mode_config.funcs = &ingenic_drm_mode_config_funcs;
>  
> +	if (IS_ENABLED(CONFIG_DRM_INGENIC_IPU)) {
> +		ret = component_bind_all(dev, drm);
> +		if (ret) {
> +			if (ret != -EPROBE_DEFER)
> +				dev_err(dev, "Failed to bind components: %i\n", ret);
> +			return ret;
> +		}
> +
> +		ret = devm_add_action_or_reset(dev, ingenic_drm_unbind_all, priv);
> +		if (ret)
> +			return ret;
> +	}
> +
>  	base = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(base)) {
>  		dev_err(dev, "Failed to get memory resource\n");
> @@ -704,6 +763,9 @@ static int ingenic_drm_probe(struct platform_device *pdev)
>  	if (ret)
>  		return ret;
>  
> +	if (soc_info->has_osd)
> +		priv->ipu_plane = drm_plane_from_index(drm, 0);
> +
>  	drm_plane_helper_add(&priv->f1, &ingenic_drm_plane_helper_funcs);
>  
>  	ret = drm_universal_plane_init(drm, &priv->f1, 1,
> @@ -712,7 +774,7 @@ static int ingenic_drm_probe(struct platform_device *pdev)
>  				       ARRAY_SIZE(ingenic_drm_primary_formats),
>  				       NULL, DRM_PLANE_TYPE_PRIMARY, NULL);
>  	if (ret) {
> -		dev_err(dev, "Failed to register primary plane: %i\n", ret);
> +		dev_err(dev, "Failed to register plane: %i\n", ret);
>  		return ret;
>  	}
>  
> @@ -828,9 +890,14 @@ static int ingenic_drm_probe(struct platform_device *pdev)
>  	return ret;
>  }
>  
> -static int ingenic_drm_remove(struct platform_device *pdev)
> +static int compare_of(struct device *dev, void *data)
>  {
> -	struct ingenic_drm *priv = platform_get_drvdata(pdev);
> +	return dev->of_node == data;
> +}
> +
> +static void ingenic_drm_unbind(struct device *dev)
> +{
> +	struct ingenic_drm *priv = dev_get_drvdata(dev);
>  
>  	if (priv->lcd_clk)
>  		clk_disable_unprepare(priv->lcd_clk);
> @@ -838,6 +905,42 @@ static int ingenic_drm_remove(struct platform_device *pdev)
>  
>  	drm_dev_unregister(&priv->drm);
>  	drm_atomic_helper_shutdown(&priv->drm);
> +}
> +
> +static const struct component_master_ops ingenic_master_ops = {
> +	.bind = ingenic_drm_bind,
> +	.unbind = ingenic_drm_unbind,
> +};
> +
> +static int ingenic_drm_probe(struct platform_device *pdev)
> +{
> +	struct device *dev = &pdev->dev;
> +	struct component_match *match = NULL;
> +	struct device_node *np;
> +
> +	if (!IS_ENABLED(CONFIG_DRM_INGENIC_IPU))
> +		return ingenic_drm_bind(dev);
> +
> +	/* IPU is at port address 8 */
> +	np = of_graph_get_remote_node(dev->of_node, 8, 0);
> +	if (!np) {
> +		dev_err(dev, "Unable to get IPU node\n");
> +		return -EINVAL;
> +	}
> +
> +	drm_of_component_match_add(dev, &match, compare_of, np);
> +
> +	return component_master_add_with_match(dev, &ingenic_master_ops, match);
> +}
> +
> +static int ingenic_drm_remove(struct platform_device *pdev)
> +{
> +	struct device *dev = &pdev->dev;
> +
> +	if (!IS_ENABLED(CONFIG_DRM_INGENIC_IPU))
> +		ingenic_drm_unbind(dev);
> +	else
> +		component_master_del(dev, &ingenic_master_ops);
>  
>  	return 0;
>  }
> @@ -879,7 +982,29 @@ static struct platform_driver ingenic_drm_driver = {
>  	.probe = ingenic_drm_probe,
>  	.remove = ingenic_drm_remove,
>  };
> -module_platform_driver(ingenic_drm_driver);
> +
> +static int ingenic_drm_init(void)
> +{
> +	int err;
> +
> +	if (IS_ENABLED(CONFIG_DRM_INGENIC_IPU)) {
> +		err = platform_driver_register(ingenic_ipu_driver_ptr);
> +		if (err)
> +			return err;
> +	}
> +
> +	return platform_driver_register(&ingenic_drm_driver);
> +}
> +module_init(ingenic_drm_init);
> +
> +static void ingenic_drm_exit(void)
> +{
> +	platform_driver_unregister(&ingenic_drm_driver);
> +
> +	if (IS_ENABLED(CONFIG_DRM_INGENIC_IPU))
> +		platform_driver_unregister(ingenic_ipu_driver_ptr);
> +}
> +module_exit(ingenic_drm_exit);
>  
>  MODULE_AUTHOR("Paul Cercueil <paul@crapouillou.net>");
>  MODULE_DESCRIPTION("DRM driver for the Ingenic SoCs\n");
> diff --git a/drivers/gpu/drm/ingenic/ingenic-drm.h b/drivers/gpu/drm/ingenic/ingenic-drm.h
> index d0b827a9fe83..43f7d959cff7 100644
> --- a/drivers/gpu/drm/ingenic/ingenic-drm.h
> +++ b/drivers/gpu/drm/ingenic/ingenic-drm.h
> @@ -8,6 +8,7 @@
>  #define DRIVERS_GPU_DRM_INGENIC_INGENIC_DRM_H
>  
>  #include <linux/bitops.h>
> +#include <linux/types.h>
>  
>  #define JZ_REG_LCD_CFG				0x00
>  #define JZ_REG_LCD_VSYNC			0x04
> @@ -158,4 +159,15 @@
>  #define JZ_LCD_SIZE01_WIDTH_LSB			0
>  #define JZ_LCD_SIZE01_HEIGHT_LSB		16
>  
> +struct device;
> +struct drm_plane;
> +struct drm_plane_state;
> +struct platform_driver;
> +
> +void ingenic_drm_plane_config(struct device *dev,
> +			      struct drm_plane *plane, u32 fourcc);
> +void ingenic_drm_plane_disable(struct device *dev, struct drm_plane *plane);
> +
> +extern struct platform_driver *ingenic_ipu_driver_ptr;
> +
>  #endif /* DRIVERS_GPU_DRM_INGENIC_INGENIC_DRM_H */
> diff --git a/drivers/gpu/drm/ingenic/ingenic-ipu.c b/drivers/gpu/drm/ingenic/ingenic-ipu.c
> new file mode 100644
> index 000000000000..df7eb72df887
> --- /dev/null
> +++ b/drivers/gpu/drm/ingenic/ingenic-ipu.c
> @@ -0,0 +1,848 @@
> +// SPDX-License-Identifier: GPL-2.0
> +//
> +// Ingenic JZ47xx IPU driver
> +//
> +// Copyright (C) 2020, Paul Cercueil <paul@crapouillou.net>
> +
> +#include "ingenic-drm.h"
> +#include "ingenic-ipu.h"
> +
> +#include <linux/clk.h>
> +#include <linux/component.h>
> +#include <linux/gcd.h>
> +#include <linux/interrupt.h>
> +#include <linux/module.h>
> +#include <linux/of.h>
> +#include <linux/of_device.h>
> +#include <linux/regmap.h>
> +#include <linux/time.h>
> +
> +#include <drm/drm_atomic.h>
> +#include <drm/drm_atomic_helper.h>
> +#include <drm/drm_drv.h>
> +#include <drm/drm_fb_cma_helper.h>
> +#include <drm/drm_fourcc.h>
> +#include <drm/drm_gem_framebuffer_helper.h>
> +#include <drm/drm_plane.h>
> +#include <drm/drm_plane_helper.h>
> +#include <drm/drm_property.h>
> +#include <drm/drm_vblank.h>
> +
> +struct ingenic_ipu;
> +
> +struct soc_info {
> +	const u32 *formats;
> +	size_t num_formats;
> +	bool has_bicubic;
> +
> +	void (*set_coefs)(struct ingenic_ipu *ipu, unsigned int reg,
> +			  unsigned int sharpness, bool downscale,
> +			  unsigned int weight, unsigned int offset);
> +};
> +
> +struct ingenic_ipu {
> +	struct drm_plane plane;
> +	struct device *dev, *master;
> +	struct regmap *map;
> +	struct clk *clk;
> +	const struct soc_info *soc_info;
> +
> +	unsigned int numW, numH, denomW, denomH;
> +
> +	struct drm_property *sharpness_prop;
> +	unsigned int sharpness;
> +};
> +
> +/* Signed 15.16 fixed-point math (for bicubic scaling coefficients) */
> +#define I2F(i) ((s32)(i) * 65536)
> +#define F2I(f) ((f) / 65536)
> +#define FMUL(fa, fb) ((s32)(((s64)(fa) * (s64)(fb)) / 65536))
> +#define SHARPNESS_INCR (I2F(-1) / 8)
> +
> +static inline struct ingenic_ipu *plane_to_ingenic_ipu(struct drm_plane *plane)
> +{
> +	return container_of(plane, struct ingenic_ipu, plane);
> +}
> +
> +/*
> + * Apply conventional cubic convolution kernel. Both parameters
> + *  and return value are 15.16 signed fixed-point.
> + *
> + *  @f_a: Sharpness factor, typically in range [-4.0, -0.25].
> + *        A larger magnitude increases perceived sharpness, but going past
> + *        -2.0 might cause ringing artifacts to outweigh any improvement.
> + *        Nice values on a 320x240 LCD are between -0.75 and -2.0.
> + *
> + *  @f_x: Absolute distance in pixels from 'pixel 0' sample position
> + *        along horizontal (or vertical) source axis. Range is [0, +2.0].
> + *
> + *  returns: Weight of this pixel within 4-pixel sample group. Range is
> + *           [-2.0, +2.0]. For moderate (i.e. > -3.0) sharpness factors,
> + *           range is within [-1.0, +1.0].
> + */
> +static inline s32 cubic_conv(s32 f_a, s32 f_x)
> +{
> +	const s32 f_1 = I2F(1);
> +	const s32 f_2 = I2F(2);
> +	const s32 f_3 = I2F(3);
> +	const s32 f_4 = I2F(4);
> +	const s32 f_x2 = FMUL(f_x, f_x);
> +	const s32 f_x3 = FMUL(f_x, f_x2);
> +
> +	if (f_x <= f_1)
> +		return FMUL((f_a + f_2), f_x3) - FMUL((f_a + f_3), f_x2) + f_1;
> +	else if (f_x <= f_2)
> +		return FMUL(f_a, (f_x3 - 5 * f_x2 + 8 * f_x - f_4));
> +	else
> +		return 0;
> +}
> +
> +/*
> + * On entry, "weight" is a coefficient suitable for bilinear mode,
> + *  which is converted to a set of four suitable for bicubic mode.
> + *
> + * "weight 512" means all of pixel 0;
> + * "weight 256" means half of pixel 0 and half of pixel 1;
> + * "weight 0" means all of pixel 1;
> + *
> + * "offset" is increment to next source pixel sample location.
> + */
> +static void jz4760_set_coefs(struct ingenic_ipu *ipu, unsigned int reg,
> +			     unsigned int sharpness, bool downscale,
> +			     unsigned int weight, unsigned int offset)
> +{
> +	u32 val;
> +	s32 w0, w1, w2, w3; /* Pixel weights at X (or Y) offsets -1,0,1,2 */
> +
> +	weight = clamp_val(weight, 0, 512);
> +
> +	if (sharpness < 2) {
> +		/*
> +		 *  When sharpness setting is 0, emulate nearest-neighbor.
> +		 *  When sharpness setting is 1, emulate bilinear.
> +		 */
> +
> +		if (sharpness == 0)
> +			weight = weight >= 256 ? 512 : 0;
> +		w0 = 0;
> +		w1 = weight;
> +		w2 = 512 - weight;
> +		w3 = 0;
> +	} else {
> +		const s32 f_a = SHARPNESS_INCR * sharpness;
> +		const s32 f_h = I2F(1) / 2; /* Round up 0.5 */
> +
> +		/*
> +		 * Note that always rounding towards +infinity here is intended.
> +		 * The resulting coefficients match a round-to-nearest-int
> +		 * double floating-point implementation.
> +		 */
> +
> +		weight = 512 - weight;
> +		w0 = F2I(f_h + 512 * cubic_conv(f_a, I2F(512  + weight) / 512));
> +		w1 = F2I(f_h + 512 * cubic_conv(f_a, I2F(0    + weight) / 512));
> +		w2 = F2I(f_h + 512 * cubic_conv(f_a, I2F(512  - weight) / 512));
> +		w3 = F2I(f_h + 512 * cubic_conv(f_a, I2F(1024 - weight) / 512));
> +		w0 = clamp_val(w0, -1024, 1023);
> +		w1 = clamp_val(w1, -1024, 1023);
> +		w2 = clamp_val(w2, -1024, 1023);
> +		w3 = clamp_val(w3, -1024, 1023);
> +	}
> +
> +	val = ((w1 & JZ4760_IPU_RSZ_COEF_MASK) << JZ4760_IPU_RSZ_COEF31_LSB) |
> +		((w0 & JZ4760_IPU_RSZ_COEF_MASK) << JZ4760_IPU_RSZ_COEF20_LSB);
> +	regmap_write(ipu->map, reg, val);
> +
> +	val = ((w3 & JZ4760_IPU_RSZ_COEF_MASK) << JZ4760_IPU_RSZ_COEF31_LSB) |
> +		((w2 & JZ4760_IPU_RSZ_COEF_MASK) << JZ4760_IPU_RSZ_COEF20_LSB) |
> +		((offset & JZ4760_IPU_RSZ_OFFSET_MASK) << JZ4760_IPU_RSZ_OFFSET_LSB);
> +	regmap_write(ipu->map, reg, val);
> +}
> +
> +static void jz4725b_set_coefs(struct ingenic_ipu *ipu, unsigned int reg,
> +			      unsigned int sharpness, bool downscale,
> +			      unsigned int weight, unsigned int offset)
> +{
> +	u32 val = JZ4725B_IPU_RSZ_LUT_OUT_EN;
> +	unsigned int i;
> +
> +	weight = clamp_val(weight, 0, 512);
> +
> +	if (sharpness == 0)
> +		weight = weight >= 256 ? 512 : 0;
> +
> +	val |= (weight & JZ4725B_IPU_RSZ_LUT_COEF_MASK) << JZ4725B_IPU_RSZ_LUT_COEF_LSB;
> +	if (downscale || !!offset)
> +		val |= JZ4725B_IPU_RSZ_LUT_IN_EN;
> +
> +	regmap_write(ipu->map, reg, val);
> +
> +	if (downscale) {
> +		for (i = 1; i < offset; i++)
> +			regmap_write(ipu->map, reg, JZ4725B_IPU_RSZ_LUT_IN_EN);
> +	}
> +}
> +
> +static void ingenic_ipu_set_downscale_coefs(struct ingenic_ipu *ipu,
> +					    unsigned int reg,
> +					    unsigned int num,
> +					    unsigned int denom)
> +{
> +	unsigned int i, offset, weight, weight_num = denom;
> +
> +	for (i = 0; i < num; i++) {
> +		weight_num = num + (weight_num - num) % (num * 2);
> +		weight = 512 - 512 * (weight_num - num) / (num * 2);
> +		weight_num += denom * 2;
> +		offset = (weight_num - num) / (num * 2);
> +
> +		ipu->soc_info->set_coefs(ipu, reg, ipu->sharpness,
> +					 true, weight, offset);
> +	}
> +}
> +
> +static void ingenic_ipu_set_integer_upscale_coefs(struct ingenic_ipu *ipu,
> +						  unsigned int reg,
> +						  unsigned int num)
> +{
> +	/*
> +	 * Force nearest-neighbor scaling and use simple math when upscaling
> +	 * by an integer ratio. It looks better, and fixes a few problem cases.
> +	 */
> +	unsigned int i;
> +
> +	for (i = 0; i < num; i++)
> +		ipu->soc_info->set_coefs(ipu, reg, 0, false, 512, i == num - 1);
> +}
> +
> +static void ingenic_ipu_set_upscale_coefs(struct ingenic_ipu *ipu,
> +					  unsigned int reg,
> +					  unsigned int num,
> +					  unsigned int denom)
> +{
> +	unsigned int i, offset, weight, weight_num = 0;
> +
> +	for (i = 0; i < num; i++) {
> +		weight = 512 - 512 * weight_num / num;
> +		weight_num += denom;
> +		offset = weight_num >= num;
> +
> +		if (offset)
> +			weight_num -= num;
> +
> +		ipu->soc_info->set_coefs(ipu, reg, ipu->sharpness,
> +					 false, weight, offset);
> +	}
> +}
> +
> +static void ingenic_ipu_set_coefs(struct ingenic_ipu *ipu, unsigned int reg,
> +				  unsigned int num, unsigned int denom)
> +{
> +	/* Begin programming the LUT */
> +	regmap_write(ipu->map, reg, -1);
> +
> +	if (denom > num)
> +		ingenic_ipu_set_downscale_coefs(ipu, reg, num, denom);
> +	else if (denom == 1)
> +		ingenic_ipu_set_integer_upscale_coefs(ipu, reg, num);
> +	else
> +		ingenic_ipu_set_upscale_coefs(ipu, reg, num, denom);
> +}
> +
> +static int reduce_fraction(unsigned int *num, unsigned int *denom)
> +{
> +	unsigned long d = gcd(*num, *denom);
> +
> +	/* The scaling table has only 31 entries */
> +	if (*num > 31 * d)
> +		return -EINVAL;
> +
> +	*num /= d;
> +	*denom /= d;
> +	return 0;
> +}
> +
> +static inline bool scaling_required(struct drm_plane_state *state)
> +{
> +	return (state->src_w >> 16) != state->crtc_w &&
> +		(state->src_h >> 16) != state->crtc_h;
> +}
> +
> +static inline bool osd_changed(struct drm_plane_state *state,
> +			       struct drm_plane_state *oldstate)
> +{
> +	return state->crtc_x != oldstate->crtc_x ||
> +		state->crtc_y != oldstate->crtc_y ||
> +		state->crtc_w != oldstate->crtc_w ||
> +		state->crtc_h != oldstate->crtc_h;
> +}
> +
> +static void ingenic_ipu_plane_atomic_update(struct drm_plane *plane,
> +					    struct drm_plane_state *oldstate)
> +{
> +	struct ingenic_ipu *ipu = plane_to_ingenic_ipu(plane);
> +	struct drm_plane_state *state = plane->state;
> +	const struct drm_format_info *finfo;
> +	u32 ctrl, stride = 0, coef_index = 0, format = 0;
> +	bool needs_modeset, upscaling_w, upscaling_h;
> +	dma_addr_t addr;
> +
> +	if (!state || !state->fb)
> +		return;
> +
> +	finfo = drm_format_info(state->fb->format->format);
> +
> +	/* Reset all the registers if needed */
> +	needs_modeset = drm_atomic_crtc_needs_modeset(state->crtc->state);
> +	if (needs_modeset)
> +		regmap_set_bits(ipu->map, JZ_REG_IPU_CTRL, JZ_IPU_CTRL_RST);
> +
> +	/* Enable the chip */
> +	regmap_set_bits(ipu->map, JZ_REG_IPU_CTRL, JZ_IPU_CTRL_CHIP_EN);
> +
> +	/* Set addresses */
> +	if (finfo->num_planes > 2) {
> +		addr = drm_fb_cma_get_gem_addr(state->fb, state, 2);
> +		regmap_write(ipu->map, JZ_REG_IPU_V_ADDR, addr);
> +	}
> +
> +	if (finfo->num_planes > 1) {
> +		addr = drm_fb_cma_get_gem_addr(state->fb, state, 1);
> +		regmap_write(ipu->map, JZ_REG_IPU_U_ADDR, addr);
> +	}
> +
> +	addr = drm_fb_cma_get_gem_addr(state->fb, state, 0);
> +	regmap_write(ipu->map, JZ_REG_IPU_Y_ADDR, addr);
> +
> +	if (!needs_modeset)
> +		return;
> +
> +	ingenic_drm_plane_config(ipu->master, plane, DRM_FORMAT_XRGB8888);
> +
> +	/* Set the input height/width/strides */
> +	if (finfo->num_planes > 2)
> +		stride = ((state->src_w >> 16) * finfo->cpp[2] / finfo->hsub)
> +			<< JZ_IPU_UV_STRIDE_V_LSB;
> +
> +	if (finfo->num_planes > 1)
> +		stride |= ((state->src_w >> 16) * finfo->cpp[1] / finfo->hsub)
> +			<< JZ_IPU_UV_STRIDE_U_LSB;
> +
> +	regmap_write(ipu->map, JZ_REG_IPU_UV_STRIDE, stride);
> +
> +	stride = ((state->src_w >> 16) * finfo->cpp[0])
> +		<< JZ_IPU_Y_STRIDE_Y_LSB;
> +	regmap_write(ipu->map, JZ_REG_IPU_Y_STRIDE, stride);
> +
> +	regmap_write(ipu->map, JZ_REG_IPU_IN_GS,
> +		     (stride << JZ_IPU_IN_GS_W_LSB) |
> +		     ((state->src_h >> 16) << JZ_IPU_IN_GS_H_LSB));
> +
> +	switch (finfo->format) {
> +	case DRM_FORMAT_XRGB1555:
> +		format = JZ_IPU_D_FMT_IN_FMT_RGB555 |
> +			JZ_IPU_D_FMT_RGB_OUT_OFT_RGB;
> +		break;
> +	case DRM_FORMAT_XBGR1555:
> +		format = JZ_IPU_D_FMT_IN_FMT_RGB555 |
> +			JZ_IPU_D_FMT_RGB_OUT_OFT_BGR;
> +		break;
> +	case DRM_FORMAT_RGB565:
> +		format = JZ_IPU_D_FMT_IN_FMT_RGB565 |
> +			JZ_IPU_D_FMT_RGB_OUT_OFT_RGB;
> +		break;
> +	case DRM_FORMAT_BGR565:
> +		format = JZ_IPU_D_FMT_IN_FMT_RGB565 |
> +			JZ_IPU_D_FMT_RGB_OUT_OFT_BGR;
> +		break;
> +	case DRM_FORMAT_XRGB8888:
> +		format = JZ_IPU_D_FMT_IN_FMT_RGB888 |
> +			JZ_IPU_D_FMT_RGB_OUT_OFT_RGB;
> +		break;
> +	case DRM_FORMAT_XBGR8888:
> +		format = JZ_IPU_D_FMT_IN_FMT_RGB888 |
> +			JZ_IPU_D_FMT_RGB_OUT_OFT_BGR;
> +		break;
> +	case DRM_FORMAT_YUYV:
> +		format = JZ_IPU_D_FMT_IN_FMT_YUV422 |
> +			JZ_IPU_D_FMT_YUV_VY1UY0;
> +		break;
> +	case DRM_FORMAT_YVYU:
> +		format = JZ_IPU_D_FMT_IN_FMT_YUV422 |
> +			JZ_IPU_D_FMT_YUV_UY1VY0;
> +		break;
> +	case DRM_FORMAT_UYVY:
> +		format = JZ_IPU_D_FMT_IN_FMT_YUV422 |
> +			JZ_IPU_D_FMT_YUV_Y1VY0U;
> +		break;
> +	case DRM_FORMAT_VYUY:
> +		format = JZ_IPU_D_FMT_IN_FMT_YUV422 |
> +			JZ_IPU_D_FMT_YUV_Y1UY0V;
> +		break;
> +	case DRM_FORMAT_YUV411:
> +		format = JZ_IPU_D_FMT_IN_FMT_YUV411;
> +		break;
> +	case DRM_FORMAT_YUV420:
> +		format = JZ_IPU_D_FMT_IN_FMT_YUV420;
> +		break;
> +	case DRM_FORMAT_YUV422:
> +		format = JZ_IPU_D_FMT_IN_FMT_YUV422;
> +		break;
> +	case DRM_FORMAT_YUV444:
> +		format = JZ_IPU_D_FMT_IN_FMT_YUV444;
> +		break;
> +	default:
> +		WARN_ONCE(1, "Unsupported format");
> +		break;
> +	}
> +
> +	/* Fix output to RGB888 */
> +	format |= JZ_IPU_D_FMT_OUT_FMT_RGB888;
> +
> +	/* Set pixel format */
> +	regmap_write(ipu->map, JZ_REG_IPU_D_FMT, format);
> +
> +	/* Set the output height/width/stride */
> +	regmap_write(ipu->map, JZ_REG_IPU_OUT_GS,
> +		     ((state->crtc_w * 4) << JZ_IPU_OUT_GS_W_LSB)
> +		     | state->crtc_h << JZ_IPU_OUT_GS_H_LSB);
> +	regmap_write(ipu->map, JZ_REG_IPU_OUT_STRIDE, state->crtc_w * 4);
> +
> +	ctrl = JZ_IPU_CTRL_LCDC_SEL | JZ_IPU_CTRL_FM_IRQ_EN;
> +
> +	if (finfo->num_planes == 1)
> +		ctrl |= JZ_IPU_CTRL_SPKG_SEL;
> +	if (finfo->is_yuv)
> +		ctrl |= JZ_IPU_CTRL_CSC_EN;
> +
> +	regmap_update_bits(ipu->map, JZ_REG_IPU_CTRL,
> +			   JZ_IPU_CTRL_LCDC_SEL | JZ_IPU_CTRL_FM_IRQ_EN |
> +			   JZ_IPU_CTRL_SPKG_SEL | JZ_IPU_CTRL_CSC_EN, ctrl);
> +
> +	if (finfo->is_yuv) {
> +		/*
> +		 * Offsets for Chroma/Luma.
> +		 * y = source Y - LUMA,
> +		 * u = source Cb - CHROMA,
> +		 * v = source Cr - CHROMA
> +		 */
> +		regmap_write(ipu->map, JZ_REG_IPU_CSC_OFFSET,
> +			     128 << JZ_IPU_CSC_OFFSET_CHROMA_LSB |
> +			     0 << JZ_IPU_CSC_OFFSET_LUMA_LSB);
> +
> +		/*
> +		 * YUV422 to RGB conversion table.
> +		 * R = C0 / 0x400 * y + C1 / 0x400 * v
> +		 * G = C0 / 0x400 * y - C2 / 0x400 * u - C3 / 0x400 * v
> +		 * B = C0 / 0x400 * y + C4 / 0x400 * u
> +		 */
> +		regmap_write(ipu->map, JZ_REG_IPU_CSC_C0_COEF, 0x4a8);
> +		regmap_write(ipu->map, JZ_REG_IPU_CSC_C1_COEF, 0x662);
> +		regmap_write(ipu->map, JZ_REG_IPU_CSC_C2_COEF, 0x191);
> +		regmap_write(ipu->map, JZ_REG_IPU_CSC_C3_COEF, 0x341);
> +		regmap_write(ipu->map, JZ_REG_IPU_CSC_C4_COEF, 0x811);
> +	}
> +
> +	ctrl = 0;
> +
> +	/*
> +	 * Must set ZOOM_SEL before programming bicubic LUTs.
> +	 * If the IPU supports bicubic, we enable it unconditionally, since it
> +	 * can do anything bilinear can and more.
> +	 */
> +	if (ipu->soc_info->has_bicubic)
> +		ctrl |= JZ_IPU_CTRL_ZOOM_SEL;
> +
> +	upscaling_w = ipu->numW > ipu->denomW;
> +	if (upscaling_w)
> +		ctrl |= JZ_IPU_CTRL_HSCALE;
> +
> +	if (ipu->numW != 1 || ipu->denomW != 1) {
> +		if (!ipu->soc_info->has_bicubic && !upscaling_w)
> +			coef_index |= (ipu->denomW - 1) << 16;
> +		else
> +			coef_index |= (ipu->numW - 1) << 16;
> +		ctrl |= JZ_IPU_CTRL_HRSZ_EN;
> +	}
> +
> +	upscaling_h = ipu->numH > ipu->denomH;
> +	if (upscaling_h)
> +		ctrl |= JZ_IPU_CTRL_VSCALE;
> +
> +	if (ipu->numH != 1 || ipu->denomH != 1) {
> +		if (!ipu->soc_info->has_bicubic && !upscaling_h)
> +			coef_index |= ipu->denomH - 1;
> +		else
> +			coef_index |= ipu->numH - 1;
> +		ctrl |= JZ_IPU_CTRL_VRSZ_EN;
> +	}
> +
> +	regmap_update_bits(ipu->map, JZ_REG_IPU_CTRL, JZ_IPU_CTRL_ZOOM_SEL |
> +			   JZ_IPU_CTRL_HRSZ_EN | JZ_IPU_CTRL_VRSZ_EN |
> +			   JZ_IPU_CTRL_HSCALE | JZ_IPU_CTRL_VSCALE, ctrl);
> +
> +	/* Set the LUT index register */
> +	regmap_write(ipu->map, JZ_REG_IPU_RSZ_COEF_INDEX, coef_index);
> +
> +	if (ipu->numW != 1 || ipu->denomW != 1)
> +		ingenic_ipu_set_coefs(ipu, JZ_REG_IPU_HRSZ_COEF_LUT,
> +				      ipu->numW, ipu->denomW);
> +
> +	if (ipu->numH != 1 || ipu->denomH != 1)
> +		ingenic_ipu_set_coefs(ipu, JZ_REG_IPU_VRSZ_COEF_LUT,
> +				      ipu->numH, ipu->denomH);
> +
> +	/* Clear STATUS register */
> +	regmap_write(ipu->map, JZ_REG_IPU_STATUS, 0);
> +
> +	/* Start IPU */
> +	regmap_set_bits(ipu->map, JZ_REG_IPU_CTRL, JZ_IPU_CTRL_RUN);
> +
> +	dev_dbg(ipu->dev, "Scaling %ux%u to %ux%u (%u:%u horiz, %u:%u vert)\n",
> +		state->src_w >> 16, state->src_h >> 16,
> +		state->crtc_w, state->crtc_h,
> +		ipu->numW, ipu->denomW, ipu->numH, ipu->denomH);
> +}
> +
> +static int ingenic_ipu_plane_atomic_check(struct drm_plane *plane,
> +					  struct drm_plane_state *state)
> +{
> +	unsigned int numW, denomW, numH, denomH, xres, yres;
> +	struct ingenic_ipu *ipu = plane_to_ingenic_ipu(plane);
> +	struct drm_crtc *crtc = state->crtc ?: plane->state->crtc;
> +	struct drm_crtc_state *crtc_state;
> +
> +	if (!crtc)
> +		return 0;
> +
> +	crtc_state = drm_atomic_get_existing_crtc_state(state->state, crtc);
> +	if (WARN_ON(!crtc_state))
> +		return -EINVAL;
> +
> +	/* Request a full modeset if we are enabling or disabling the IPU. */
> +	if (!plane->state->crtc ^ !state->crtc)
> +		crtc_state->mode_changed = true;
> +
> +	if (!state->crtc ||
> +	    !crtc_state->mode.hdisplay || !crtc_state->mode.vdisplay)
> +		return 0;
> +
> +	/* Plane must be fully visible */
> +	if (state->crtc_x < 0 || state->crtc_y < 0 ||
> +	    state->crtc_x + state->crtc_w > crtc_state->mode.hdisplay ||
> +	    state->crtc_y + state->crtc_h > crtc_state->mode.vdisplay)
> +		return -EINVAL;
> +
> +	/* Minimum size is 4x4 */
> +	if ((state->src_w >> 16) < 4 || (state->src_h >> 16) < 4)
> +		return -EINVAL;
> +
> +	/* Input and output lines must have an even number of pixels. */
> +	if (((state->src_w >> 16) & 1) || (state->crtc_w & 1))
> +		return -EINVAL;
> +
> +	if (!scaling_required(state)) {
> +		if (plane->state && osd_changed(state, plane->state))
> +			crtc_state->mode_changed = true;
> +
> +		ipu->numW = ipu->numH = ipu->denomW = ipu->denomH = 1;
> +		return 0;
> +	}
> +
> +	crtc_state->mode_changed = true;
> +
> +	xres = state->src_w >> 16;
> +	yres = state->src_h >> 16;
> +
> +	/* Adjust the coefficients until we find a valid configuration */
> +	for (denomW = xres, numW = state->crtc_w;
> +	     numW <= crtc_state->mode.hdisplay; numW++)
> +		if (!reduce_fraction(&numW, &denomW))
> +			break;
> +	if (numW > crtc_state->mode.hdisplay)
> +		return -EINVAL;
> +
> +	for (denomH = yres, numH = state->crtc_h;
> +	     numH <= crtc_state->mode.vdisplay; numH++)
> +		if (!reduce_fraction(&numH, &denomH))
> +			break;
> +	if (numH > crtc_state->mode.vdisplay)
> +		return -EINVAL;
> +
> +	ipu->numW = numW;
> +	ipu->numH = numH;
> +	ipu->denomW = denomW;
> +	ipu->denomH = denomH;
> +
> +	return 0;
> +}
> +
> +static void ingenic_ipu_plane_atomic_disable(struct drm_plane *plane,
> +					     struct drm_plane_state *old_state)
> +{
> +	struct ingenic_ipu *ipu = plane_to_ingenic_ipu(plane);
> +
> +	regmap_set_bits(ipu->map, JZ_REG_IPU_CTRL, JZ_IPU_CTRL_STOP);
> +	regmap_clear_bits(ipu->map, JZ_REG_IPU_CTRL, JZ_IPU_CTRL_CHIP_EN);
> +
> +	ingenic_drm_plane_disable(ipu->master, plane);
> +}
> +
> +static const struct drm_plane_helper_funcs ingenic_ipu_plane_helper_funcs = {
> +	.atomic_update		= ingenic_ipu_plane_atomic_update,
> +	.atomic_check		= ingenic_ipu_plane_atomic_check,
> +	.atomic_disable		= ingenic_ipu_plane_atomic_disable,
> +	.prepare_fb		= drm_gem_fb_prepare_fb,
> +};
> +
> +static int
> +ingenic_ipu_plane_atomic_get_property(struct drm_plane *plane,
> +				      const struct drm_plane_state *state,
> +				      struct drm_property *property, u64 *val)
> +{
> +	struct ingenic_ipu *ipu = plane_to_ingenic_ipu(plane);
> +
> +	if (property != ipu->sharpness_prop)
> +		return -EINVAL;
> +
> +	*val = ipu->sharpness;
> +
> +	return 0;
> +}
> +
> +static int
> +ingenic_ipu_plane_atomic_set_property(struct drm_plane *plane,
> +				      struct drm_plane_state *state,
> +				      struct drm_property *property, u64 val)
> +{
> +	struct ingenic_ipu *ipu = plane_to_ingenic_ipu(plane);
> +	struct drm_crtc_state *crtc_state;
> +
> +	if (property != ipu->sharpness_prop)
> +		return -EINVAL;
> +
> +	ipu->sharpness = val;
> +
> +	if (state->crtc) {
> +		crtc_state = drm_atomic_get_existing_crtc_state(state->state, state->crtc);
> +		if (WARN_ON(!crtc_state))
> +			return -EINVAL;
> +
> +		crtc_state->mode_changed = true;
> +	}
> +
> +	return 0;
> +}
> +
> +static const struct drm_plane_funcs ingenic_ipu_plane_funcs = {
> +	.update_plane		= drm_atomic_helper_update_plane,
> +	.disable_plane		= drm_atomic_helper_disable_plane,
> +	.reset			= drm_atomic_helper_plane_reset,
> +	.destroy		= drm_plane_cleanup,
> +
> +	.atomic_duplicate_state	= drm_atomic_helper_plane_duplicate_state,
> +	.atomic_destroy_state	= drm_atomic_helper_plane_destroy_state,
> +
> +	.atomic_get_property	= ingenic_ipu_plane_atomic_get_property,
> +	.atomic_set_property	= ingenic_ipu_plane_atomic_set_property,
> +};
> +
> +static irqreturn_t ingenic_ipu_irq_handler(int irq, void *arg)
> +{
> +	struct drm_plane *plane = drm_plane_from_index(arg, 0);
> +	struct ingenic_ipu *ipu = plane_to_ingenic_ipu(plane);
> +	struct drm_crtc *crtc = drm_crtc_from_index(arg, 0);
> +
> +	regmap_write(ipu->map, JZ_REG_IPU_STATUS, 0);
> +
> +	drm_crtc_handle_vblank(crtc);
> +
> +	return IRQ_HANDLED;
> +}
> +
> +static const struct regmap_config ingenic_ipu_regmap_config = {
> +	.reg_bits = 32,
> +	.val_bits = 32,
> +	.reg_stride = 4,
> +
> +	.max_register = JZ_REG_IPU_OUT_PHY_T_ADDR,
> +};
> +
> +static int ingenic_ipu_bind(struct device *dev, struct device *master, void *d)
> +{
> +	struct platform_device *pdev = to_platform_device(dev);
> +	const struct soc_info *soc_info;
> +	struct drm_device *drm = d;
> +	struct drm_plane *plane;
> +	struct ingenic_ipu *ipu;
> +	void __iomem *base;
> +	unsigned int sharpness_max;
> +	int err, irq;
> +
> +	ipu = devm_kzalloc(dev, sizeof(*ipu), GFP_KERNEL);
> +	if (!ipu)
> +		return -ENOMEM;
> +
> +	soc_info = of_device_get_match_data(dev);
> +	if (!soc_info) {
> +		dev_err(dev, "Missing platform data\n");
> +		return -EINVAL;
> +	}
> +
> +	ipu->dev = dev;
> +	ipu->master = master;
> +	ipu->soc_info = soc_info;
> +
> +	base = devm_platform_ioremap_resource(pdev, 0);
> +	if (IS_ERR(base)) {
> +		dev_err(dev, "Failed to get memory resource\n");
> +		return PTR_ERR(base);
> +	}
> +
> +	ipu->map = devm_regmap_init_mmio(dev, base, &ingenic_ipu_regmap_config);
> +	if (IS_ERR(ipu->map)) {
> +		dev_err(dev, "Failed to create regmap\n");
> +		return PTR_ERR(ipu->map);
> +	}
> +
> +	irq = platform_get_irq(pdev, 0);
> +	if (irq < 0)
> +		return irq;
> +
> +	ipu->clk = devm_clk_get(dev, "ipu");
> +	if (IS_ERR(ipu->clk)) {
> +		dev_err(dev, "Failed to get pixel clock\n");
> +		return PTR_ERR(ipu->clk);
> +	}
> +
> +	err = devm_request_irq(dev, irq, ingenic_ipu_irq_handler, 0,
> +			       drm->driver->name, drm);
> +	if (err) {
> +		dev_err(dev, "Unable to request IRQ\n");
> +		return err;
> +	}
> +
> +	plane = &ipu->plane;
> +	dev_set_drvdata(dev, plane);
> +
> +	drm_plane_helper_add(plane, &ingenic_ipu_plane_helper_funcs);
> +
> +	err = drm_universal_plane_init(drm, plane, 1, &ingenic_ipu_plane_funcs,
> +				       soc_info->formats, soc_info->num_formats,
> +				       NULL, DRM_PLANE_TYPE_PRIMARY, NULL);
> +	if (err) {
> +		dev_err(dev, "Failed to init plane: %i\n", err);
> +		return err;
> +	}
> +
> +	/*
> +	 * Sharpness settings range is [0,32]
> +	 * 0       : nearest-neighbor
> +	 * 1       : bilinear
> +	 * 2 .. 32 : bicubic (translated to sharpness factor -0.25 .. -4.0)
> +	 */
> +	sharpness_max = soc_info->has_bicubic ? 32 : 1;
> +	ipu->sharpness_prop = drm_property_create_range(drm, 0, "sharpness",
> +							0, sharpness_max);
> +	if (!ipu->sharpness_prop) {
> +		dev_err(dev, "Unable to create sharpness property\n");
> +		return -ENOMEM;
> +	}
> +
> +	/* Default sharpness factor: -0.125 * 8 = -1.0 */
> +	ipu->sharpness = soc_info->has_bicubic ? 8 : 1;
> +	drm_object_attach_property(&plane->base, ipu->sharpness_prop,
> +				   ipu->sharpness);
> +
> +	err = clk_prepare_enable(ipu->clk);
> +	if (err) {
> +		dev_err(dev, "Unable to enable clock\n");
> +		return err;
> +	}
> +
> +	return 0;
> +}
> +
> +static void ingenic_ipu_unbind(struct device *dev,
> +			       struct device *master, void *d)
> +{
> +	struct ingenic_ipu *ipu = dev_get_drvdata(dev);
> +
> +	clk_disable_unprepare(ipu->clk);
> +}
> +
> +static const struct component_ops ingenic_ipu_ops = {
> +	.bind = ingenic_ipu_bind,
> +	.unbind = ingenic_ipu_unbind,
> +};
> +
> +static int ingenic_ipu_probe(struct platform_device *pdev)
> +{
> +	return component_add(&pdev->dev, &ingenic_ipu_ops);
> +}
> +
> +static int ingenic_ipu_remove(struct platform_device *pdev)
> +{
> +	component_del(&pdev->dev, &ingenic_ipu_ops);
> +	return 0;
> +}
> +
> +static const u32 jz4725b_ipu_formats[] = {
> +	DRM_FORMAT_YUYV,
> +	DRM_FORMAT_YVYU,
> +	DRM_FORMAT_UYVY,
> +	DRM_FORMAT_VYUY,
> +	DRM_FORMAT_YUV411,
> +	DRM_FORMAT_YUV420,
> +	DRM_FORMAT_YUV422,
> +	DRM_FORMAT_YUV444,
> +};
> +
> +static const struct soc_info jz4725b_soc_info = {
> +	.formats	= jz4725b_ipu_formats,
> +	.num_formats	= ARRAY_SIZE(jz4725b_ipu_formats),
> +	.has_bicubic	= false,
> +	.set_coefs	= jz4725b_set_coefs,
> +};
> +
> +static const u32 jz4760_ipu_formats[] = {
> +	DRM_FORMAT_XRGB1555,
> +	DRM_FORMAT_XBGR1555,
> +	DRM_FORMAT_RGB565,
> +	DRM_FORMAT_BGR565,
> +	DRM_FORMAT_XRGB8888,
> +	DRM_FORMAT_XBGR8888,
> +	DRM_FORMAT_YUYV,
> +	DRM_FORMAT_YVYU,
> +	DRM_FORMAT_UYVY,
> +	DRM_FORMAT_VYUY,
> +	DRM_FORMAT_YUV411,
> +	DRM_FORMAT_YUV420,
> +	DRM_FORMAT_YUV422,
> +	DRM_FORMAT_YUV444,
> +};
> +
> +static const struct soc_info jz4760_soc_info = {
> +	.formats	= jz4760_ipu_formats,
> +	.num_formats	= ARRAY_SIZE(jz4760_ipu_formats),
> +	.has_bicubic	= true,
> +	.set_coefs	= jz4760_set_coefs,
> +};
> +
> +static const struct of_device_id ingenic_ipu_of_match[] = {
> +	{ .compatible = "ingenic,jz4725b-ipu", .data = &jz4725b_soc_info },
> +	{ .compatible = "ingenic,jz4760-ipu", .data = &jz4760_soc_info },
> +	{ /* sentinel */ },
> +};
> +MODULE_DEVICE_TABLE(of, ingenic_ipu_of_match);
> +
> +static struct platform_driver ingenic_ipu_driver = {
> +	.driver = {
> +		.name = "ingenic-ipu",
> +		.of_match_table = ingenic_ipu_of_match,
> +	},
> +	.probe = ingenic_ipu_probe,
> +	.remove = ingenic_ipu_remove,
> +};
> +
> +struct platform_driver *ingenic_ipu_driver_ptr = &ingenic_ipu_driver;
> diff --git a/drivers/gpu/drm/ingenic/ingenic-ipu.h b/drivers/gpu/drm/ingenic/ingenic-ipu.h
> new file mode 100644
> index 000000000000..eab6fab8c7f6
> --- /dev/null
> +++ b/drivers/gpu/drm/ingenic/ingenic-ipu.h
> @@ -0,0 +1,109 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +//
> +// Ingenic JZ47xx IPU - Register definitions and private API
> +//
> +// Copyright (C) 2020, Paul Cercueil <paul@crapouillou.net>
> +
> +#ifndef DRIVERS_GPU_DRM_INGENIC_INGENIC_IPU_H
> +#define DRIVERS_GPU_DRM_INGENIC_INGENIC_IPU_H
> +
> +#include <linux/bitops.h>
> +
> +#define JZ_REG_IPU_CTRL			0x00
> +#define JZ_REG_IPU_STATUS		0x04
> +#define JZ_REG_IPU_D_FMT		0x08
> +#define JZ_REG_IPU_Y_ADDR		0x0c
> +#define JZ_REG_IPU_U_ADDR		0x10
> +#define JZ_REG_IPU_V_ADDR		0x14
> +#define JZ_REG_IPU_IN_GS		0x18
> +#define JZ_REG_IPU_Y_STRIDE		0x1c
> +#define JZ_REG_IPU_UV_STRIDE		0x20
> +#define JZ_REG_IPU_OUT_ADDR		0x24
> +#define JZ_REG_IPU_OUT_GS		0x28
> +#define JZ_REG_IPU_OUT_STRIDE		0x2c
> +#define JZ_REG_IPU_RSZ_COEF_INDEX	0x30
> +#define JZ_REG_IPU_CSC_C0_COEF		0x34
> +#define JZ_REG_IPU_CSC_C1_COEF		0x38
> +#define JZ_REG_IPU_CSC_C2_COEF		0x3c
> +#define JZ_REG_IPU_CSC_C3_COEF		0x40
> +#define JZ_REG_IPU_CSC_C4_COEF		0x44
> +#define JZ_REG_IPU_HRSZ_COEF_LUT	0x48
> +#define JZ_REG_IPU_VRSZ_COEF_LUT	0x4c
> +#define JZ_REG_IPU_CSC_OFFSET		0x50
> +#define JZ_REG_IPU_Y_PHY_T_ADDR		0x54
> +#define JZ_REG_IPU_U_PHY_T_ADDR		0x58
> +#define JZ_REG_IPU_V_PHY_T_ADDR		0x5c
> +#define JZ_REG_IPU_OUT_PHY_T_ADDR	0x60
> +
> +#define JZ_IPU_CTRL_ADDR_SEL		BIT(20)
> +#define JZ_IPU_CTRL_ZOOM_SEL		BIT(18)
> +#define JZ_IPU_CTRL_DFIX_SEL		BIT(17)
> +#define JZ_IPU_CTRL_LCDC_SEL		BIT(11)
> +#define JZ_IPU_CTRL_SPKG_SEL		BIT(10)
> +#define JZ_IPU_CTRL_VSCALE		BIT(9)
> +#define JZ_IPU_CTRL_HSCALE		BIT(8)
> +#define JZ_IPU_CTRL_STOP		BIT(7)
> +#define JZ_IPU_CTRL_RST			BIT(6)
> +#define JZ_IPU_CTRL_FM_IRQ_EN		BIT(5)
> +#define JZ_IPU_CTRL_CSC_EN		BIT(4)
> +#define JZ_IPU_CTRL_VRSZ_EN		BIT(3)
> +#define JZ_IPU_CTRL_HRSZ_EN		BIT(2)
> +#define JZ_IPU_CTRL_RUN			BIT(1)
> +#define JZ_IPU_CTRL_CHIP_EN		BIT(0)
> +
> +#define JZ_IPU_STATUS_OUT_END		BIT(0)
> +
> +#define JZ_IPU_IN_GS_H_LSB		0x0
> +#define JZ_IPU_IN_GS_W_LSB		0x10
> +#define JZ_IPU_OUT_GS_H_LSB		0x0
> +#define JZ_IPU_OUT_GS_W_LSB		0x10
> +
> +#define JZ_IPU_Y_STRIDE_Y_LSB		0
> +#define JZ_IPU_UV_STRIDE_U_LSB		16
> +#define JZ_IPU_UV_STRIDE_V_LSB		0
> +
> +#define JZ_IPU_D_FMT_IN_FMT_LSB		0
> +#define JZ_IPU_D_FMT_IN_FMT_RGB555	(0x0 << JZ_IPU_D_FMT_IN_FMT_LSB)
> +#define JZ_IPU_D_FMT_IN_FMT_YUV420	(0x0 << JZ_IPU_D_FMT_IN_FMT_LSB)
> +#define JZ_IPU_D_FMT_IN_FMT_YUV422	(0x1 << JZ_IPU_D_FMT_IN_FMT_LSB)
> +#define JZ_IPU_D_FMT_IN_FMT_RGB888	(0x2 << JZ_IPU_D_FMT_IN_FMT_LSB)
> +#define JZ_IPU_D_FMT_IN_FMT_YUV444	(0x2 << JZ_IPU_D_FMT_IN_FMT_LSB)
> +#define JZ_IPU_D_FMT_IN_FMT_RGB565	(0x3 << JZ_IPU_D_FMT_IN_FMT_LSB)
> +
> +#define JZ_IPU_D_FMT_YUV_FMT_LSB	2
> +#define JZ_IPU_D_FMT_YUV_Y1UY0V		(0x0 << JZ_IPU_D_FMT_YUV_FMT_LSB)
> +#define JZ_IPU_D_FMT_YUV_Y1VY0U		(0x1 << JZ_IPU_D_FMT_YUV_FMT_LSB)
> +#define JZ_IPU_D_FMT_YUV_UY1VY0		(0x2 << JZ_IPU_D_FMT_YUV_FMT_LSB)
> +#define JZ_IPU_D_FMT_YUV_VY1UY0		(0x3 << JZ_IPU_D_FMT_YUV_FMT_LSB)
> +#define JZ_IPU_D_FMT_IN_FMT_YUV411	(0x3 << JZ_IPU_D_FMT_IN_FMT_LSB)
> +
> +#define JZ_IPU_D_FMT_OUT_FMT_LSB	19
> +#define JZ_IPU_D_FMT_OUT_FMT_RGB555	(0x0 << JZ_IPU_D_FMT_OUT_FMT_LSB)
> +#define JZ_IPU_D_FMT_OUT_FMT_RGB565	(0x1 << JZ_IPU_D_FMT_OUT_FMT_LSB)
> +#define JZ_IPU_D_FMT_OUT_FMT_RGB888	(0x2 << JZ_IPU_D_FMT_OUT_FMT_LSB)
> +#define JZ_IPU_D_FMT_OUT_FMT_YUV422	(0x3 << JZ_IPU_D_FMT_OUT_FMT_LSB)
> +#define JZ_IPU_D_FMT_OUT_FMT_RGBAAA	(0x4 << JZ_IPU_D_FMT_OUT_FMT_LSB)
> +
> +#define JZ_IPU_D_FMT_RGB_OUT_OFT_LSB	22
> +#define JZ_IPU_D_FMT_RGB_OUT_OFT_RGB	(0x0 << JZ_IPU_D_FMT_RGB_OUT_OFT_LSB)
> +#define JZ_IPU_D_FMT_RGB_OUT_OFT_RBG	(0x1 << JZ_IPU_D_FMT_RGB_OUT_OFT_LSB)
> +#define JZ_IPU_D_FMT_RGB_OUT_OFT_GBR	(0x2 << JZ_IPU_D_FMT_RGB_OUT_OFT_LSB)
> +#define JZ_IPU_D_FMT_RGB_OUT_OFT_GRB	(0x3 << JZ_IPU_D_FMT_RGB_OUT_OFT_LSB)
> +#define JZ_IPU_D_FMT_RGB_OUT_OFT_BRG	(0x4 << JZ_IPU_D_FMT_RGB_OUT_OFT_LSB)
> +#define JZ_IPU_D_FMT_RGB_OUT_OFT_BGR	(0x5 << JZ_IPU_D_FMT_RGB_OUT_OFT_LSB)
> +
> +#define JZ4725B_IPU_RSZ_LUT_COEF_LSB	2
> +#define JZ4725B_IPU_RSZ_LUT_COEF_MASK	0x7ff
> +#define JZ4725B_IPU_RSZ_LUT_IN_EN	BIT(1)
> +#define JZ4725B_IPU_RSZ_LUT_OUT_EN	BIT(0)
> +
> +#define JZ4760_IPU_RSZ_COEF20_LSB	6
> +#define JZ4760_IPU_RSZ_COEF31_LSB	17
> +#define JZ4760_IPU_RSZ_COEF_MASK	0x7ff
> +#define JZ4760_IPU_RSZ_OFFSET_LSB	1
> +#define JZ4760_IPU_RSZ_OFFSET_MASK	0x1f
> +
> +#define JZ_IPU_CSC_OFFSET_CHROMA_LSB	16
> +#define JZ_IPU_CSC_OFFSET_LUMA_LSB	16
> +
> +#endif /* DRIVERS_GPU_DRM_INGENIC_INGENIC_IPU_H */
> -- 
> 2.27.0
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH v2 09/10] drm/ingenic: Add support for the IPU
  2020-06-30 12:16   ` Sam Ravnborg
@ 2020-06-30 13:33     ` Paul Cercueil
  0 siblings, 0 replies; 22+ messages in thread
From: Paul Cercueil @ 2020-06-30 13:33 UTC (permalink / raw)
  To: Sam Ravnborg
  Cc: David Airlie, Daniel Vetter, Rob Herring, devicetree, linux-mips,
	dri-devel, linux-kernel, od

Hi Sam,

Le mar. 30 juin 2020 à 14:16, Sam Ravnborg <sam@ravnborg.org> a écrit 
:
> Hi Paul.
> 
> On Tue, Jun 30, 2020 at 01:52:09AM +0200, Paul Cercueil wrote:
>>  Add support for the Image Processing Unit (IPU) found in all Ingenic
>>  SoCs.
>> 
>>  The IPU can upscale and downscale a source frame of arbitrary size
>>  ranging from 4x4 to 4096x4096 on newer SoCs, with bicubic filtering
>>  on newer SoCs, bilinear filtering on older SoCs. Nearest-neighbour 
>> can
>>  also be obtained with proper coefficients.
>> 
>>  Starting from the JZ4725B, the IPU supports a mode where its output 
>> is
>>  sent directly to the LCDC, without having to be written to RAM 
>> first.
>>  This makes it possible to use the IPU as a DRM plane on the 
>> compatible
>>  SoCs, and have it convert and scale anything the userspace asks for 
>> to
>>  what's available for the display.
>> 
>>  Regarding pixel formats, older SoCs support packed YUV 4:2:2 and 
>> various
>>  planar YUV formats. Newer SoCs introduced support for RGB.
>> 
> 
>>  Since the IPU is a separate hardware block, to make it work 
>> properly the
>>  Ingenic DRM driver will now register itself as a component master in
>>  case the IPU driver has been enabled in the config.
> I cannot see why this driver needs the component framework to deal 
> with
> the IPU. It looks like a left-over from when this was two modules.
> While browsing the code the code now has two independent struct
> soc_info. It would be simpler with only one - at least if it is the
> same logic that is used in both cases.
> 
> So open question - can this be simplified more than it is today and
> is the use of the component framework mandatory?
> 
> 	Sam

The IPU IP is separate from the LCD controller. Its registers are in a 
completely different area, it has its own clock, and interrupt line. It 
has its own node in devicetree. As a result, you have one struct device 
for the LCD controller, and one for the IPU.

Where it gets more complicated, is that the IPU driver needs a pointer 
to the drm_device structure in order to register its drm_panel. When 
the ingenic-drm driver calls component_bind_all(), it passes the 
pointer, which allows the IPU plane to be created, which will be 
retrieved by the ingenic-drm driver later on. There would be no way of 
doing that in a clean manner without using the component framework.

Cheers,
-Paul

>> 
>>  When enabled in the config, the CRTC will see the IPU as a second 
>> primary
>>  plane. It cannot be enabled at the same time as the regular primary
>>  plane. It has the same priority, which means that it will also 
>> display
>>  below the overlay plane.
>> 
>>  Signed-off-by: Paul Cercueil <paul@crapouillou.net>
>>  ---
>> 
>>  Notes:
>>      v2: - ingenic-ipu is no longer its own module. It will be built
>>      	  into the ingenic-drm module.
>>      	- If enabled in the config, both the core driver and the IPU
>>      	  driver will register as components; otherwise the core
>>      	  driver will bypass that and call the ingenic_drm_bind()
>>      	  function directly.
>>      	- Since both files now build into the same module, the
>>      	  symbols previously exported as GPL are not exported anymore,
>>      	  since they are only used internally.
>>      	- Fix SPDX license header in ingenic-ipu.h
>>      	- Avoid using 'for(;;);' loops without trailing statement(s)
>> 
>>   drivers/gpu/drm/ingenic/Kconfig           |  11 +
>>   drivers/gpu/drm/ingenic/Makefile          |   3 +-
>>   drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 155 +++-
>>   drivers/gpu/drm/ingenic/ingenic-drm.h     |  12 +
>>   drivers/gpu/drm/ingenic/ingenic-ipu.c     | 848 
>> ++++++++++++++++++++++
>>   drivers/gpu/drm/ingenic/ingenic-ipu.h     | 109 +++
>>   6 files changed, 1122 insertions(+), 16 deletions(-)
>>   create mode 100644 drivers/gpu/drm/ingenic/ingenic-ipu.c
>>   create mode 100644 drivers/gpu/drm/ingenic/ingenic-ipu.h
>> 
>>  diff --git a/drivers/gpu/drm/ingenic/Kconfig 
>> b/drivers/gpu/drm/ingenic/Kconfig
>>  index d82c3d37ec9c..477d5387e43e 100644
>>  --- a/drivers/gpu/drm/ingenic/Kconfig
>>  +++ b/drivers/gpu/drm/ingenic/Kconfig
>>  @@ -14,3 +14,14 @@ config DRM_INGENIC
>>   	  Choose this option for DRM support for the Ingenic SoCs.
>> 
>>   	  If M is selected the module will be called ingenic-drm.
>>  +
>>  +if DRM_INGENIC
>>  +
>>  +config DRM_INGENIC_IPU
>>  +	bool "IPU support for Ingenic SoCs"
>>  +	help
>>  +	  Choose this option to enable support for the IPU found in 
>> Ingenic SoCs.
>>  +
>>  +	  The Image Processing Unit (IPU) will appear as a second primary 
>> plane.
>>  +
>>  +endif
>>  diff --git a/drivers/gpu/drm/ingenic/Makefile 
>> b/drivers/gpu/drm/ingenic/Makefile
>>  index 9875628dd8bc..d313326bdddb 100644
>>  --- a/drivers/gpu/drm/ingenic/Makefile
>>  +++ b/drivers/gpu/drm/ingenic/Makefile
>>  @@ -1,2 +1,3 @@
>>   obj-$(CONFIG_DRM_INGENIC) += ingenic-drm.o
>>  -ingenic-drm-y += ingenic-drm-drv.o
>>  +ingenic-drm-y = ingenic-drm-drv.o
>>  +ingenic-drm-$(CONFIG_DRM_INGENIC_IPU) += ingenic-ipu.o
>>  diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c 
>> b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
>>  index a8573da1d577..36440acd23de 100644
>>  --- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
>>  +++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
>>  @@ -6,6 +6,7 @@
>> 
>>   #include "ingenic-drm.h"
>> 
>>  +#include <linux/component.h>
>>   #include <linux/clk.h>
>>   #include <linux/dma-mapping.h>
>>   #include <linux/module.h>
>>  @@ -49,7 +50,7 @@ struct jz_soc_info {
>> 
>>   struct ingenic_drm {
>>   	struct drm_device drm;
>>  -	struct drm_plane f0, f1;
>>  +	struct drm_plane f0, f1, *ipu_plane;
>>   	struct drm_crtc crtc;
>>   	struct drm_encoder encoder;
>> 
>>  @@ -185,13 +186,16 @@ static void 
>> ingenic_drm_crtc_update_timings(struct ingenic_drm *priv,
>>   	regmap_update_bits(priv->map, JZ_REG_LCD_CTRL,
>>   			   JZ_LCD_CTRL_OFUP | JZ_LCD_CTRL_BURST_16,
>>   			   JZ_LCD_CTRL_OFUP | JZ_LCD_CTRL_BURST_16);
>>  +
>>  +	regmap_write(priv->map, JZ_REG_LCD_IPUR, JZ_LCD_IPUR_IPUREN |
>>  +		     (ht * vpe / 3) << JZ_LCD_IPUR_IPUR_LSB);
>>   }
>> 
>>   static int ingenic_drm_crtc_atomic_check(struct drm_crtc *crtc,
>>   					 struct drm_crtc_state *state)
>>   {
>>   	struct ingenic_drm *priv = drm_crtc_get_priv(crtc);
>>  -	struct drm_plane_state *f1_state, *f0_state;
>>  +	struct drm_plane_state *f1_state, *f0_state, *ipu_state;
>>   	long rate;
>> 
>>   	if (!drm_atomic_crtc_needs_modeset(state))
>>  @@ -210,14 +214,40 @@ static int 
>> ingenic_drm_crtc_atomic_check(struct drm_crtc *crtc,
>>   		f1_state = drm_atomic_get_plane_state(state->state, &priv->f1);
>>   		f0_state = drm_atomic_get_plane_state(state->state, &priv->f0);
>> 
>>  +		if (priv->ipu_plane)
>>  +			ipu_state = drm_atomic_get_plane_state(state->state, 
>> priv->ipu_plane);
>>  +
>>  +		/* IPU and F1 planes cannot be enabled at the same time. */
>>  +		if (priv->ipu_plane && f1_state->fb && ipu_state->fb) {
>>  +			dev_dbg(priv->dev, "Cannot enable both F1 and IPU\n");
>>  +			return -EINVAL;
>>  +		}
>>  +
>>   		/* If all the planes are disabled, we won't get a VBLANK IRQ */
>>  -		if (!f1_state->fb && !f0_state->fb)
>>  +		if (!f1_state->fb && !f0_state->fb &&
>>  +		    !(priv->ipu_plane && ipu_state->fb))
>>   			state->no_vblank = true;
>>   	}
>> 
>>   	return 0;
>>   }
>> 
>>  +static void ingenic_drm_crtc_atomic_begin(struct drm_crtc *crtc,
>>  +					  struct drm_crtc_state *oldstate)
>>  +{
>>  +	struct ingenic_drm *priv = drm_crtc_get_priv(crtc);
>>  +	u32 ctrl = 0;
>>  +
>>  +	if (priv->soc_info->has_osd &&
>>  +	    drm_atomic_crtc_needs_modeset(crtc->state)) {
>>  +		if (priv->ipu_plane && priv->ipu_plane->state->fb)
>>  +			ctrl |= JZ_LCD_OSDCTRL_IPU;
>>  +
>>  +		regmap_update_bits(priv->map, JZ_REG_LCD_OSDCTRL,
>>  +				   JZ_LCD_OSDCTRL_IPU, ctrl);
>>  +	}
>>  +}
>>  +
>>   static void ingenic_drm_crtc_atomic_flush(struct drm_crtc *crtc,
>>   					  struct drm_crtc_state *oldstate)
>>   {
>>  @@ -303,10 +333,9 @@ static void ingenic_drm_plane_enable(struct 
>> ingenic_drm *priv,
>>   	}
>>   }
>> 
>>  -static void ingenic_drm_plane_atomic_disable(struct drm_plane 
>> *plane,
>>  -					     struct drm_plane_state *old_state)
>>  +void ingenic_drm_plane_disable(struct device *dev, struct 
>> drm_plane *plane)
>>   {
>>  -	struct ingenic_drm *priv = drm_device_get_priv(plane->dev);
>>  +	struct ingenic_drm *priv = dev_get_drvdata(dev);
>>   	unsigned int en_bit;
>> 
>>   	if (priv->soc_info->has_osd) {
>>  @@ -319,9 +348,18 @@ static void 
>> ingenic_drm_plane_atomic_disable(struct drm_plane *plane,
>>   	}
>>   }
>> 
>>  -static void ingenic_drm_plane_config(struct ingenic_drm *priv,
>>  -				     struct drm_plane *plane, u32 fourcc)
>>  +static void ingenic_drm_plane_atomic_disable(struct drm_plane 
>> *plane,
>>  +					     struct drm_plane_state *old_state)
>>   {
>>  +	struct ingenic_drm *priv = drm_device_get_priv(plane->dev);
>>  +
>>  +	ingenic_drm_plane_disable(priv->dev, plane);
>>  +}
>>  +
>>  +void ingenic_drm_plane_config(struct device *dev,
>>  +			      struct drm_plane *plane, u32 fourcc)
>>  +{
>>  +	struct ingenic_drm *priv = dev_get_drvdata(dev);
>>   	struct drm_plane_state *state = plane->state;
>>   	unsigned int xy_reg, size_reg;
>>   	unsigned int ctrl = 0;
>>  @@ -404,7 +442,7 @@ static void 
>> ingenic_drm_plane_atomic_update(struct drm_plane *plane,
>>   		priv->dma_hwdesc[hwdesc_idx]->cmd |= JZ_LCD_CMD_EOF_IRQ;
>> 
>>   		if (drm_atomic_crtc_needs_modeset(state->crtc->state))
>>  -			ingenic_drm_plane_config(priv, plane,
>>  +			ingenic_drm_plane_config(priv->dev, plane,
>>   						 state->fb->format->format);
>>   	}
>>   }
>>  @@ -574,6 +612,7 @@ static const struct drm_plane_helper_funcs 
>> ingenic_drm_plane_helper_funcs = {
>>   static const struct drm_crtc_helper_funcs 
>> ingenic_drm_crtc_helper_funcs = {
>>   	.atomic_enable		= ingenic_drm_crtc_atomic_enable,
>>   	.atomic_disable		= ingenic_drm_crtc_atomic_disable,
>>  +	.atomic_begin		= ingenic_drm_crtc_atomic_begin,
>>   	.atomic_flush		= ingenic_drm_crtc_atomic_flush,
>>   	.atomic_check		= ingenic_drm_crtc_atomic_check,
>>   };
>>  @@ -600,10 +639,17 @@ static void ingenic_drm_free_dma_hwdesc(void 
>> *d)
>>   			  priv->dma_hwdesc[1], priv->dma_hwdesc_phys[1]);
>>   }
>> 
>>  -static int ingenic_drm_probe(struct platform_device *pdev)
>>  +static void ingenic_drm_unbind_all(void *d)
>>  +{
>>  +	struct ingenic_drm *priv = d;
>>  +
>>  +	component_unbind_all(priv->dev, &priv->drm);
>>  +}
>>  +
>>  +static int ingenic_drm_bind(struct device *dev)
>>   {
>>  +	struct platform_device *pdev = to_platform_device(dev);
>>   	const struct jz_soc_info *soc_info;
>>  -	struct device *dev = &pdev->dev;
>>   	struct ingenic_drm *priv;
>>   	struct clk *parent_clk;
>>   	struct drm_bridge *bridge;
>>  @@ -640,6 +686,19 @@ static int ingenic_drm_probe(struct 
>> platform_device *pdev)
>>   	drm->mode_config.max_height = 4095;
>>   	drm->mode_config.funcs = &ingenic_drm_mode_config_funcs;
>> 
>>  +	if (IS_ENABLED(CONFIG_DRM_INGENIC_IPU)) {
>>  +		ret = component_bind_all(dev, drm);
>>  +		if (ret) {
>>  +			if (ret != -EPROBE_DEFER)
>>  +				dev_err(dev, "Failed to bind components: %i\n", ret);
>>  +			return ret;
>>  +		}
>>  +
>>  +		ret = devm_add_action_or_reset(dev, ingenic_drm_unbind_all, 
>> priv);
>>  +		if (ret)
>>  +			return ret;
>>  +	}
>>  +
>>   	base = devm_platform_ioremap_resource(pdev, 0);
>>   	if (IS_ERR(base)) {
>>   		dev_err(dev, "Failed to get memory resource\n");
>>  @@ -704,6 +763,9 @@ static int ingenic_drm_probe(struct 
>> platform_device *pdev)
>>   	if (ret)
>>   		return ret;
>> 
>>  +	if (soc_info->has_osd)
>>  +		priv->ipu_plane = drm_plane_from_index(drm, 0);
>>  +
>>   	drm_plane_helper_add(&priv->f1, &ingenic_drm_plane_helper_funcs);
>> 
>>   	ret = drm_universal_plane_init(drm, &priv->f1, 1,
>>  @@ -712,7 +774,7 @@ static int ingenic_drm_probe(struct 
>> platform_device *pdev)
>>   				       ARRAY_SIZE(ingenic_drm_primary_formats),
>>   				       NULL, DRM_PLANE_TYPE_PRIMARY, NULL);
>>   	if (ret) {
>>  -		dev_err(dev, "Failed to register primary plane: %i\n", ret);
>>  +		dev_err(dev, "Failed to register plane: %i\n", ret);
>>   		return ret;
>>   	}
>> 
>>  @@ -828,9 +890,14 @@ static int ingenic_drm_probe(struct 
>> platform_device *pdev)
>>   	return ret;
>>   }
>> 
>>  -static int ingenic_drm_remove(struct platform_device *pdev)
>>  +static int compare_of(struct device *dev, void *data)
>>   {
>>  -	struct ingenic_drm *priv = platform_get_drvdata(pdev);
>>  +	return dev->of_node == data;
>>  +}
>>  +
>>  +static void ingenic_drm_unbind(struct device *dev)
>>  +{
>>  +	struct ingenic_drm *priv = dev_get_drvdata(dev);
>> 
>>   	if (priv->lcd_clk)
>>   		clk_disable_unprepare(priv->lcd_clk);
>>  @@ -838,6 +905,42 @@ static int ingenic_drm_remove(struct 
>> platform_device *pdev)
>> 
>>   	drm_dev_unregister(&priv->drm);
>>   	drm_atomic_helper_shutdown(&priv->drm);
>>  +}
>>  +
>>  +static const struct component_master_ops ingenic_master_ops = {
>>  +	.bind = ingenic_drm_bind,
>>  +	.unbind = ingenic_drm_unbind,
>>  +};
>>  +
>>  +static int ingenic_drm_probe(struct platform_device *pdev)
>>  +{
>>  +	struct device *dev = &pdev->dev;
>>  +	struct component_match *match = NULL;
>>  +	struct device_node *np;
>>  +
>>  +	if (!IS_ENABLED(CONFIG_DRM_INGENIC_IPU))
>>  +		return ingenic_drm_bind(dev);
>>  +
>>  +	/* IPU is at port address 8 */
>>  +	np = of_graph_get_remote_node(dev->of_node, 8, 0);
>>  +	if (!np) {
>>  +		dev_err(dev, "Unable to get IPU node\n");
>>  +		return -EINVAL;
>>  +	}
>>  +
>>  +	drm_of_component_match_add(dev, &match, compare_of, np);
>>  +
>>  +	return component_master_add_with_match(dev, &ingenic_master_ops, 
>> match);
>>  +}
>>  +
>>  +static int ingenic_drm_remove(struct platform_device *pdev)
>>  +{
>>  +	struct device *dev = &pdev->dev;
>>  +
>>  +	if (!IS_ENABLED(CONFIG_DRM_INGENIC_IPU))
>>  +		ingenic_drm_unbind(dev);
>>  +	else
>>  +		component_master_del(dev, &ingenic_master_ops);
>> 
>>   	return 0;
>>   }
>>  @@ -879,7 +982,29 @@ static struct platform_driver 
>> ingenic_drm_driver = {
>>   	.probe = ingenic_drm_probe,
>>   	.remove = ingenic_drm_remove,
>>   };
>>  -module_platform_driver(ingenic_drm_driver);
>>  +
>>  +static int ingenic_drm_init(void)
>>  +{
>>  +	int err;
>>  +
>>  +	if (IS_ENABLED(CONFIG_DRM_INGENIC_IPU)) {
>>  +		err = platform_driver_register(ingenic_ipu_driver_ptr);
>>  +		if (err)
>>  +			return err;
>>  +	}
>>  +
>>  +	return platform_driver_register(&ingenic_drm_driver);
>>  +}
>>  +module_init(ingenic_drm_init);
>>  +
>>  +static void ingenic_drm_exit(void)
>>  +{
>>  +	platform_driver_unregister(&ingenic_drm_driver);
>>  +
>>  +	if (IS_ENABLED(CONFIG_DRM_INGENIC_IPU))
>>  +		platform_driver_unregister(ingenic_ipu_driver_ptr);
>>  +}
>>  +module_exit(ingenic_drm_exit);
>> 
>>   MODULE_AUTHOR("Paul Cercueil <paul@crapouillou.net>");
>>   MODULE_DESCRIPTION("DRM driver for the Ingenic SoCs\n");
>>  diff --git a/drivers/gpu/drm/ingenic/ingenic-drm.h 
>> b/drivers/gpu/drm/ingenic/ingenic-drm.h
>>  index d0b827a9fe83..43f7d959cff7 100644
>>  --- a/drivers/gpu/drm/ingenic/ingenic-drm.h
>>  +++ b/drivers/gpu/drm/ingenic/ingenic-drm.h
>>  @@ -8,6 +8,7 @@
>>   #define DRIVERS_GPU_DRM_INGENIC_INGENIC_DRM_H
>> 
>>   #include <linux/bitops.h>
>>  +#include <linux/types.h>
>> 
>>   #define JZ_REG_LCD_CFG				0x00
>>   #define JZ_REG_LCD_VSYNC			0x04
>>  @@ -158,4 +159,15 @@
>>   #define JZ_LCD_SIZE01_WIDTH_LSB			0
>>   #define JZ_LCD_SIZE01_HEIGHT_LSB		16
>> 
>>  +struct device;
>>  +struct drm_plane;
>>  +struct drm_plane_state;
>>  +struct platform_driver;
>>  +
>>  +void ingenic_drm_plane_config(struct device *dev,
>>  +			      struct drm_plane *plane, u32 fourcc);
>>  +void ingenic_drm_plane_disable(struct device *dev, struct 
>> drm_plane *plane);
>>  +
>>  +extern struct platform_driver *ingenic_ipu_driver_ptr;
>>  +
>>   #endif /* DRIVERS_GPU_DRM_INGENIC_INGENIC_DRM_H */
>>  diff --git a/drivers/gpu/drm/ingenic/ingenic-ipu.c 
>> b/drivers/gpu/drm/ingenic/ingenic-ipu.c
>>  new file mode 100644
>>  index 000000000000..df7eb72df887
>>  --- /dev/null
>>  +++ b/drivers/gpu/drm/ingenic/ingenic-ipu.c
>>  @@ -0,0 +1,848 @@
>>  +// SPDX-License-Identifier: GPL-2.0
>>  +//
>>  +// Ingenic JZ47xx IPU driver
>>  +//
>>  +// Copyright (C) 2020, Paul Cercueil <paul@crapouillou.net>
>>  +
>>  +#include "ingenic-drm.h"
>>  +#include "ingenic-ipu.h"
>>  +
>>  +#include <linux/clk.h>
>>  +#include <linux/component.h>
>>  +#include <linux/gcd.h>
>>  +#include <linux/interrupt.h>
>>  +#include <linux/module.h>
>>  +#include <linux/of.h>
>>  +#include <linux/of_device.h>
>>  +#include <linux/regmap.h>
>>  +#include <linux/time.h>
>>  +
>>  +#include <drm/drm_atomic.h>
>>  +#include <drm/drm_atomic_helper.h>
>>  +#include <drm/drm_drv.h>
>>  +#include <drm/drm_fb_cma_helper.h>
>>  +#include <drm/drm_fourcc.h>
>>  +#include <drm/drm_gem_framebuffer_helper.h>
>>  +#include <drm/drm_plane.h>
>>  +#include <drm/drm_plane_helper.h>
>>  +#include <drm/drm_property.h>
>>  +#include <drm/drm_vblank.h>
>>  +
>>  +struct ingenic_ipu;
>>  +
>>  +struct soc_info {
>>  +	const u32 *formats;
>>  +	size_t num_formats;
>>  +	bool has_bicubic;
>>  +
>>  +	void (*set_coefs)(struct ingenic_ipu *ipu, unsigned int reg,
>>  +			  unsigned int sharpness, bool downscale,
>>  +			  unsigned int weight, unsigned int offset);
>>  +};
>>  +
>>  +struct ingenic_ipu {
>>  +	struct drm_plane plane;
>>  +	struct device *dev, *master;
>>  +	struct regmap *map;
>>  +	struct clk *clk;
>>  +	const struct soc_info *soc_info;
>>  +
>>  +	unsigned int numW, numH, denomW, denomH;
>>  +
>>  +	struct drm_property *sharpness_prop;
>>  +	unsigned int sharpness;
>>  +};
>>  +
>>  +/* Signed 15.16 fixed-point math (for bicubic scaling 
>> coefficients) */
>>  +#define I2F(i) ((s32)(i) * 65536)
>>  +#define F2I(f) ((f) / 65536)
>>  +#define FMUL(fa, fb) ((s32)(((s64)(fa) * (s64)(fb)) / 65536))
>>  +#define SHARPNESS_INCR (I2F(-1) / 8)
>>  +
>>  +static inline struct ingenic_ipu *plane_to_ingenic_ipu(struct 
>> drm_plane *plane)
>>  +{
>>  +	return container_of(plane, struct ingenic_ipu, plane);
>>  +}
>>  +
>>  +/*
>>  + * Apply conventional cubic convolution kernel. Both parameters
>>  + *  and return value are 15.16 signed fixed-point.
>>  + *
>>  + *  @f_a: Sharpness factor, typically in range [-4.0, -0.25].
>>  + *        A larger magnitude increases perceived sharpness, but 
>> going past
>>  + *        -2.0 might cause ringing artifacts to outweigh any 
>> improvement.
>>  + *        Nice values on a 320x240 LCD are between -0.75 and -2.0.
>>  + *
>>  + *  @f_x: Absolute distance in pixels from 'pixel 0' sample 
>> position
>>  + *        along horizontal (or vertical) source axis. Range is [0, 
>> +2.0].
>>  + *
>>  + *  returns: Weight of this pixel within 4-pixel sample group. 
>> Range is
>>  + *           [-2.0, +2.0]. For moderate (i.e. > -3.0) sharpness 
>> factors,
>>  + *           range is within [-1.0, +1.0].
>>  + */
>>  +static inline s32 cubic_conv(s32 f_a, s32 f_x)
>>  +{
>>  +	const s32 f_1 = I2F(1);
>>  +	const s32 f_2 = I2F(2);
>>  +	const s32 f_3 = I2F(3);
>>  +	const s32 f_4 = I2F(4);
>>  +	const s32 f_x2 = FMUL(f_x, f_x);
>>  +	const s32 f_x3 = FMUL(f_x, f_x2);
>>  +
>>  +	if (f_x <= f_1)
>>  +		return FMUL((f_a + f_2), f_x3) - FMUL((f_a + f_3), f_x2) + f_1;
>>  +	else if (f_x <= f_2)
>>  +		return FMUL(f_a, (f_x3 - 5 * f_x2 + 8 * f_x - f_4));
>>  +	else
>>  +		return 0;
>>  +}
>>  +
>>  +/*
>>  + * On entry, "weight" is a coefficient suitable for bilinear mode,
>>  + *  which is converted to a set of four suitable for bicubic mode.
>>  + *
>>  + * "weight 512" means all of pixel 0;
>>  + * "weight 256" means half of pixel 0 and half of pixel 1;
>>  + * "weight 0" means all of pixel 1;
>>  + *
>>  + * "offset" is increment to next source pixel sample location.
>>  + */
>>  +static void jz4760_set_coefs(struct ingenic_ipu *ipu, unsigned int 
>> reg,
>>  +			     unsigned int sharpness, bool downscale,
>>  +			     unsigned int weight, unsigned int offset)
>>  +{
>>  +	u32 val;
>>  +	s32 w0, w1, w2, w3; /* Pixel weights at X (or Y) offsets -1,0,1,2 
>> */
>>  +
>>  +	weight = clamp_val(weight, 0, 512);
>>  +
>>  +	if (sharpness < 2) {
>>  +		/*
>>  +		 *  When sharpness setting is 0, emulate nearest-neighbor.
>>  +		 *  When sharpness setting is 1, emulate bilinear.
>>  +		 */
>>  +
>>  +		if (sharpness == 0)
>>  +			weight = weight >= 256 ? 512 : 0;
>>  +		w0 = 0;
>>  +		w1 = weight;
>>  +		w2 = 512 - weight;
>>  +		w3 = 0;
>>  +	} else {
>>  +		const s32 f_a = SHARPNESS_INCR * sharpness;
>>  +		const s32 f_h = I2F(1) / 2; /* Round up 0.5 */
>>  +
>>  +		/*
>>  +		 * Note that always rounding towards +infinity here is intended.
>>  +		 * The resulting coefficients match a round-to-nearest-int
>>  +		 * double floating-point implementation.
>>  +		 */
>>  +
>>  +		weight = 512 - weight;
>>  +		w0 = F2I(f_h + 512 * cubic_conv(f_a, I2F(512  + weight) / 512));
>>  +		w1 = F2I(f_h + 512 * cubic_conv(f_a, I2F(0    + weight) / 512));
>>  +		w2 = F2I(f_h + 512 * cubic_conv(f_a, I2F(512  - weight) / 512));
>>  +		w3 = F2I(f_h + 512 * cubic_conv(f_a, I2F(1024 - weight) / 512));
>>  +		w0 = clamp_val(w0, -1024, 1023);
>>  +		w1 = clamp_val(w1, -1024, 1023);
>>  +		w2 = clamp_val(w2, -1024, 1023);
>>  +		w3 = clamp_val(w3, -1024, 1023);
>>  +	}
>>  +
>>  +	val = ((w1 & JZ4760_IPU_RSZ_COEF_MASK) << 
>> JZ4760_IPU_RSZ_COEF31_LSB) |
>>  +		((w0 & JZ4760_IPU_RSZ_COEF_MASK) << JZ4760_IPU_RSZ_COEF20_LSB);
>>  +	regmap_write(ipu->map, reg, val);
>>  +
>>  +	val = ((w3 & JZ4760_IPU_RSZ_COEF_MASK) << 
>> JZ4760_IPU_RSZ_COEF31_LSB) |
>>  +		((w2 & JZ4760_IPU_RSZ_COEF_MASK) << JZ4760_IPU_RSZ_COEF20_LSB) |
>>  +		((offset & JZ4760_IPU_RSZ_OFFSET_MASK) << 
>> JZ4760_IPU_RSZ_OFFSET_LSB);
>>  +	regmap_write(ipu->map, reg, val);
>>  +}
>>  +
>>  +static void jz4725b_set_coefs(struct ingenic_ipu *ipu, unsigned 
>> int reg,
>>  +			      unsigned int sharpness, bool downscale,
>>  +			      unsigned int weight, unsigned int offset)
>>  +{
>>  +	u32 val = JZ4725B_IPU_RSZ_LUT_OUT_EN;
>>  +	unsigned int i;
>>  +
>>  +	weight = clamp_val(weight, 0, 512);
>>  +
>>  +	if (sharpness == 0)
>>  +		weight = weight >= 256 ? 512 : 0;
>>  +
>>  +	val |= (weight & JZ4725B_IPU_RSZ_LUT_COEF_MASK) << 
>> JZ4725B_IPU_RSZ_LUT_COEF_LSB;
>>  +	if (downscale || !!offset)
>>  +		val |= JZ4725B_IPU_RSZ_LUT_IN_EN;
>>  +
>>  +	regmap_write(ipu->map, reg, val);
>>  +
>>  +	if (downscale) {
>>  +		for (i = 1; i < offset; i++)
>>  +			regmap_write(ipu->map, reg, JZ4725B_IPU_RSZ_LUT_IN_EN);
>>  +	}
>>  +}
>>  +
>>  +static void ingenic_ipu_set_downscale_coefs(struct ingenic_ipu 
>> *ipu,
>>  +					    unsigned int reg,
>>  +					    unsigned int num,
>>  +					    unsigned int denom)
>>  +{
>>  +	unsigned int i, offset, weight, weight_num = denom;
>>  +
>>  +	for (i = 0; i < num; i++) {
>>  +		weight_num = num + (weight_num - num) % (num * 2);
>>  +		weight = 512 - 512 * (weight_num - num) / (num * 2);
>>  +		weight_num += denom * 2;
>>  +		offset = (weight_num - num) / (num * 2);
>>  +
>>  +		ipu->soc_info->set_coefs(ipu, reg, ipu->sharpness,
>>  +					 true, weight, offset);
>>  +	}
>>  +}
>>  +
>>  +static void ingenic_ipu_set_integer_upscale_coefs(struct 
>> ingenic_ipu *ipu,
>>  +						  unsigned int reg,
>>  +						  unsigned int num)
>>  +{
>>  +	/*
>>  +	 * Force nearest-neighbor scaling and use simple math when 
>> upscaling
>>  +	 * by an integer ratio. It looks better, and fixes a few problem 
>> cases.
>>  +	 */
>>  +	unsigned int i;
>>  +
>>  +	for (i = 0; i < num; i++)
>>  +		ipu->soc_info->set_coefs(ipu, reg, 0, false, 512, i == num - 1);
>>  +}
>>  +
>>  +static void ingenic_ipu_set_upscale_coefs(struct ingenic_ipu *ipu,
>>  +					  unsigned int reg,
>>  +					  unsigned int num,
>>  +					  unsigned int denom)
>>  +{
>>  +	unsigned int i, offset, weight, weight_num = 0;
>>  +
>>  +	for (i = 0; i < num; i++) {
>>  +		weight = 512 - 512 * weight_num / num;
>>  +		weight_num += denom;
>>  +		offset = weight_num >= num;
>>  +
>>  +		if (offset)
>>  +			weight_num -= num;
>>  +
>>  +		ipu->soc_info->set_coefs(ipu, reg, ipu->sharpness,
>>  +					 false, weight, offset);
>>  +	}
>>  +}
>>  +
>>  +static void ingenic_ipu_set_coefs(struct ingenic_ipu *ipu, 
>> unsigned int reg,
>>  +				  unsigned int num, unsigned int denom)
>>  +{
>>  +	/* Begin programming the LUT */
>>  +	regmap_write(ipu->map, reg, -1);
>>  +
>>  +	if (denom > num)
>>  +		ingenic_ipu_set_downscale_coefs(ipu, reg, num, denom);
>>  +	else if (denom == 1)
>>  +		ingenic_ipu_set_integer_upscale_coefs(ipu, reg, num);
>>  +	else
>>  +		ingenic_ipu_set_upscale_coefs(ipu, reg, num, denom);
>>  +}
>>  +
>>  +static int reduce_fraction(unsigned int *num, unsigned int *denom)
>>  +{
>>  +	unsigned long d = gcd(*num, *denom);
>>  +
>>  +	/* The scaling table has only 31 entries */
>>  +	if (*num > 31 * d)
>>  +		return -EINVAL;
>>  +
>>  +	*num /= d;
>>  +	*denom /= d;
>>  +	return 0;
>>  +}
>>  +
>>  +static inline bool scaling_required(struct drm_plane_state *state)
>>  +{
>>  +	return (state->src_w >> 16) != state->crtc_w &&
>>  +		(state->src_h >> 16) != state->crtc_h;
>>  +}
>>  +
>>  +static inline bool osd_changed(struct drm_plane_state *state,
>>  +			       struct drm_plane_state *oldstate)
>>  +{
>>  +	return state->crtc_x != oldstate->crtc_x ||
>>  +		state->crtc_y != oldstate->crtc_y ||
>>  +		state->crtc_w != oldstate->crtc_w ||
>>  +		state->crtc_h != oldstate->crtc_h;
>>  +}
>>  +
>>  +static void ingenic_ipu_plane_atomic_update(struct drm_plane 
>> *plane,
>>  +					    struct drm_plane_state *oldstate)
>>  +{
>>  +	struct ingenic_ipu *ipu = plane_to_ingenic_ipu(plane);
>>  +	struct drm_plane_state *state = plane->state;
>>  +	const struct drm_format_info *finfo;
>>  +	u32 ctrl, stride = 0, coef_index = 0, format = 0;
>>  +	bool needs_modeset, upscaling_w, upscaling_h;
>>  +	dma_addr_t addr;
>>  +
>>  +	if (!state || !state->fb)
>>  +		return;
>>  +
>>  +	finfo = drm_format_info(state->fb->format->format);
>>  +
>>  +	/* Reset all the registers if needed */
>>  +	needs_modeset = drm_atomic_crtc_needs_modeset(state->crtc->state);
>>  +	if (needs_modeset)
>>  +		regmap_set_bits(ipu->map, JZ_REG_IPU_CTRL, JZ_IPU_CTRL_RST);
>>  +
>>  +	/* Enable the chip */
>>  +	regmap_set_bits(ipu->map, JZ_REG_IPU_CTRL, JZ_IPU_CTRL_CHIP_EN);
>>  +
>>  +	/* Set addresses */
>>  +	if (finfo->num_planes > 2) {
>>  +		addr = drm_fb_cma_get_gem_addr(state->fb, state, 2);
>>  +		regmap_write(ipu->map, JZ_REG_IPU_V_ADDR, addr);
>>  +	}
>>  +
>>  +	if (finfo->num_planes > 1) {
>>  +		addr = drm_fb_cma_get_gem_addr(state->fb, state, 1);
>>  +		regmap_write(ipu->map, JZ_REG_IPU_U_ADDR, addr);
>>  +	}
>>  +
>>  +	addr = drm_fb_cma_get_gem_addr(state->fb, state, 0);
>>  +	regmap_write(ipu->map, JZ_REG_IPU_Y_ADDR, addr);
>>  +
>>  +	if (!needs_modeset)
>>  +		return;
>>  +
>>  +	ingenic_drm_plane_config(ipu->master, plane, DRM_FORMAT_XRGB8888);
>>  +
>>  +	/* Set the input height/width/strides */
>>  +	if (finfo->num_planes > 2)
>>  +		stride = ((state->src_w >> 16) * finfo->cpp[2] / finfo->hsub)
>>  +			<< JZ_IPU_UV_STRIDE_V_LSB;
>>  +
>>  +	if (finfo->num_planes > 1)
>>  +		stride |= ((state->src_w >> 16) * finfo->cpp[1] / finfo->hsub)
>>  +			<< JZ_IPU_UV_STRIDE_U_LSB;
>>  +
>>  +	regmap_write(ipu->map, JZ_REG_IPU_UV_STRIDE, stride);
>>  +
>>  +	stride = ((state->src_w >> 16) * finfo->cpp[0])
>>  +		<< JZ_IPU_Y_STRIDE_Y_LSB;
>>  +	regmap_write(ipu->map, JZ_REG_IPU_Y_STRIDE, stride);
>>  +
>>  +	regmap_write(ipu->map, JZ_REG_IPU_IN_GS,
>>  +		     (stride << JZ_IPU_IN_GS_W_LSB) |
>>  +		     ((state->src_h >> 16) << JZ_IPU_IN_GS_H_LSB));
>>  +
>>  +	switch (finfo->format) {
>>  +	case DRM_FORMAT_XRGB1555:
>>  +		format = JZ_IPU_D_FMT_IN_FMT_RGB555 |
>>  +			JZ_IPU_D_FMT_RGB_OUT_OFT_RGB;
>>  +		break;
>>  +	case DRM_FORMAT_XBGR1555:
>>  +		format = JZ_IPU_D_FMT_IN_FMT_RGB555 |
>>  +			JZ_IPU_D_FMT_RGB_OUT_OFT_BGR;
>>  +		break;
>>  +	case DRM_FORMAT_RGB565:
>>  +		format = JZ_IPU_D_FMT_IN_FMT_RGB565 |
>>  +			JZ_IPU_D_FMT_RGB_OUT_OFT_RGB;
>>  +		break;
>>  +	case DRM_FORMAT_BGR565:
>>  +		format = JZ_IPU_D_FMT_IN_FMT_RGB565 |
>>  +			JZ_IPU_D_FMT_RGB_OUT_OFT_BGR;
>>  +		break;
>>  +	case DRM_FORMAT_XRGB8888:
>>  +		format = JZ_IPU_D_FMT_IN_FMT_RGB888 |
>>  +			JZ_IPU_D_FMT_RGB_OUT_OFT_RGB;
>>  +		break;
>>  +	case DRM_FORMAT_XBGR8888:
>>  +		format = JZ_IPU_D_FMT_IN_FMT_RGB888 |
>>  +			JZ_IPU_D_FMT_RGB_OUT_OFT_BGR;
>>  +		break;
>>  +	case DRM_FORMAT_YUYV:
>>  +		format = JZ_IPU_D_FMT_IN_FMT_YUV422 |
>>  +			JZ_IPU_D_FMT_YUV_VY1UY0;
>>  +		break;
>>  +	case DRM_FORMAT_YVYU:
>>  +		format = JZ_IPU_D_FMT_IN_FMT_YUV422 |
>>  +			JZ_IPU_D_FMT_YUV_UY1VY0;
>>  +		break;
>>  +	case DRM_FORMAT_UYVY:
>>  +		format = JZ_IPU_D_FMT_IN_FMT_YUV422 |
>>  +			JZ_IPU_D_FMT_YUV_Y1VY0U;
>>  +		break;
>>  +	case DRM_FORMAT_VYUY:
>>  +		format = JZ_IPU_D_FMT_IN_FMT_YUV422 |
>>  +			JZ_IPU_D_FMT_YUV_Y1UY0V;
>>  +		break;
>>  +	case DRM_FORMAT_YUV411:
>>  +		format = JZ_IPU_D_FMT_IN_FMT_YUV411;
>>  +		break;
>>  +	case DRM_FORMAT_YUV420:
>>  +		format = JZ_IPU_D_FMT_IN_FMT_YUV420;
>>  +		break;
>>  +	case DRM_FORMAT_YUV422:
>>  +		format = JZ_IPU_D_FMT_IN_FMT_YUV422;
>>  +		break;
>>  +	case DRM_FORMAT_YUV444:
>>  +		format = JZ_IPU_D_FMT_IN_FMT_YUV444;
>>  +		break;
>>  +	default:
>>  +		WARN_ONCE(1, "Unsupported format");
>>  +		break;
>>  +	}
>>  +
>>  +	/* Fix output to RGB888 */
>>  +	format |= JZ_IPU_D_FMT_OUT_FMT_RGB888;
>>  +
>>  +	/* Set pixel format */
>>  +	regmap_write(ipu->map, JZ_REG_IPU_D_FMT, format);
>>  +
>>  +	/* Set the output height/width/stride */
>>  +	regmap_write(ipu->map, JZ_REG_IPU_OUT_GS,
>>  +		     ((state->crtc_w * 4) << JZ_IPU_OUT_GS_W_LSB)
>>  +		     | state->crtc_h << JZ_IPU_OUT_GS_H_LSB);
>>  +	regmap_write(ipu->map, JZ_REG_IPU_OUT_STRIDE, state->crtc_w * 4);
>>  +
>>  +	ctrl = JZ_IPU_CTRL_LCDC_SEL | JZ_IPU_CTRL_FM_IRQ_EN;
>>  +
>>  +	if (finfo->num_planes == 1)
>>  +		ctrl |= JZ_IPU_CTRL_SPKG_SEL;
>>  +	if (finfo->is_yuv)
>>  +		ctrl |= JZ_IPU_CTRL_CSC_EN;
>>  +
>>  +	regmap_update_bits(ipu->map, JZ_REG_IPU_CTRL,
>>  +			   JZ_IPU_CTRL_LCDC_SEL | JZ_IPU_CTRL_FM_IRQ_EN |
>>  +			   JZ_IPU_CTRL_SPKG_SEL | JZ_IPU_CTRL_CSC_EN, ctrl);
>>  +
>>  +	if (finfo->is_yuv) {
>>  +		/*
>>  +		 * Offsets for Chroma/Luma.
>>  +		 * y = source Y - LUMA,
>>  +		 * u = source Cb - CHROMA,
>>  +		 * v = source Cr - CHROMA
>>  +		 */
>>  +		regmap_write(ipu->map, JZ_REG_IPU_CSC_OFFSET,
>>  +			     128 << JZ_IPU_CSC_OFFSET_CHROMA_LSB |
>>  +			     0 << JZ_IPU_CSC_OFFSET_LUMA_LSB);
>>  +
>>  +		/*
>>  +		 * YUV422 to RGB conversion table.
>>  +		 * R = C0 / 0x400 * y + C1 / 0x400 * v
>>  +		 * G = C0 / 0x400 * y - C2 / 0x400 * u - C3 / 0x400 * v
>>  +		 * B = C0 / 0x400 * y + C4 / 0x400 * u
>>  +		 */
>>  +		regmap_write(ipu->map, JZ_REG_IPU_CSC_C0_COEF, 0x4a8);
>>  +		regmap_write(ipu->map, JZ_REG_IPU_CSC_C1_COEF, 0x662);
>>  +		regmap_write(ipu->map, JZ_REG_IPU_CSC_C2_COEF, 0x191);
>>  +		regmap_write(ipu->map, JZ_REG_IPU_CSC_C3_COEF, 0x341);
>>  +		regmap_write(ipu->map, JZ_REG_IPU_CSC_C4_COEF, 0x811);
>>  +	}
>>  +
>>  +	ctrl = 0;
>>  +
>>  +	/*
>>  +	 * Must set ZOOM_SEL before programming bicubic LUTs.
>>  +	 * If the IPU supports bicubic, we enable it unconditionally, 
>> since it
>>  +	 * can do anything bilinear can and more.
>>  +	 */
>>  +	if (ipu->soc_info->has_bicubic)
>>  +		ctrl |= JZ_IPU_CTRL_ZOOM_SEL;
>>  +
>>  +	upscaling_w = ipu->numW > ipu->denomW;
>>  +	if (upscaling_w)
>>  +		ctrl |= JZ_IPU_CTRL_HSCALE;
>>  +
>>  +	if (ipu->numW != 1 || ipu->denomW != 1) {
>>  +		if (!ipu->soc_info->has_bicubic && !upscaling_w)
>>  +			coef_index |= (ipu->denomW - 1) << 16;
>>  +		else
>>  +			coef_index |= (ipu->numW - 1) << 16;
>>  +		ctrl |= JZ_IPU_CTRL_HRSZ_EN;
>>  +	}
>>  +
>>  +	upscaling_h = ipu->numH > ipu->denomH;
>>  +	if (upscaling_h)
>>  +		ctrl |= JZ_IPU_CTRL_VSCALE;
>>  +
>>  +	if (ipu->numH != 1 || ipu->denomH != 1) {
>>  +		if (!ipu->soc_info->has_bicubic && !upscaling_h)
>>  +			coef_index |= ipu->denomH - 1;
>>  +		else
>>  +			coef_index |= ipu->numH - 1;
>>  +		ctrl |= JZ_IPU_CTRL_VRSZ_EN;
>>  +	}
>>  +
>>  +	regmap_update_bits(ipu->map, JZ_REG_IPU_CTRL, 
>> JZ_IPU_CTRL_ZOOM_SEL |
>>  +			   JZ_IPU_CTRL_HRSZ_EN | JZ_IPU_CTRL_VRSZ_EN |
>>  +			   JZ_IPU_CTRL_HSCALE | JZ_IPU_CTRL_VSCALE, ctrl);
>>  +
>>  +	/* Set the LUT index register */
>>  +	regmap_write(ipu->map, JZ_REG_IPU_RSZ_COEF_INDEX, coef_index);
>>  +
>>  +	if (ipu->numW != 1 || ipu->denomW != 1)
>>  +		ingenic_ipu_set_coefs(ipu, JZ_REG_IPU_HRSZ_COEF_LUT,
>>  +				      ipu->numW, ipu->denomW);
>>  +
>>  +	if (ipu->numH != 1 || ipu->denomH != 1)
>>  +		ingenic_ipu_set_coefs(ipu, JZ_REG_IPU_VRSZ_COEF_LUT,
>>  +				      ipu->numH, ipu->denomH);
>>  +
>>  +	/* Clear STATUS register */
>>  +	regmap_write(ipu->map, JZ_REG_IPU_STATUS, 0);
>>  +
>>  +	/* Start IPU */
>>  +	regmap_set_bits(ipu->map, JZ_REG_IPU_CTRL, JZ_IPU_CTRL_RUN);
>>  +
>>  +	dev_dbg(ipu->dev, "Scaling %ux%u to %ux%u (%u:%u horiz, %u:%u 
>> vert)\n",
>>  +		state->src_w >> 16, state->src_h >> 16,
>>  +		state->crtc_w, state->crtc_h,
>>  +		ipu->numW, ipu->denomW, ipu->numH, ipu->denomH);
>>  +}
>>  +
>>  +static int ingenic_ipu_plane_atomic_check(struct drm_plane *plane,
>>  +					  struct drm_plane_state *state)
>>  +{
>>  +	unsigned int numW, denomW, numH, denomH, xres, yres;
>>  +	struct ingenic_ipu *ipu = plane_to_ingenic_ipu(plane);
>>  +	struct drm_crtc *crtc = state->crtc ?: plane->state->crtc;
>>  +	struct drm_crtc_state *crtc_state;
>>  +
>>  +	if (!crtc)
>>  +		return 0;
>>  +
>>  +	crtc_state = drm_atomic_get_existing_crtc_state(state->state, 
>> crtc);
>>  +	if (WARN_ON(!crtc_state))
>>  +		return -EINVAL;
>>  +
>>  +	/* Request a full modeset if we are enabling or disabling the 
>> IPU. */
>>  +	if (!plane->state->crtc ^ !state->crtc)
>>  +		crtc_state->mode_changed = true;
>>  +
>>  +	if (!state->crtc ||
>>  +	    !crtc_state->mode.hdisplay || !crtc_state->mode.vdisplay)
>>  +		return 0;
>>  +
>>  +	/* Plane must be fully visible */
>>  +	if (state->crtc_x < 0 || state->crtc_y < 0 ||
>>  +	    state->crtc_x + state->crtc_w > crtc_state->mode.hdisplay ||
>>  +	    state->crtc_y + state->crtc_h > crtc_state->mode.vdisplay)
>>  +		return -EINVAL;
>>  +
>>  +	/* Minimum size is 4x4 */
>>  +	if ((state->src_w >> 16) < 4 || (state->src_h >> 16) < 4)
>>  +		return -EINVAL;
>>  +
>>  +	/* Input and output lines must have an even number of pixels. */
>>  +	if (((state->src_w >> 16) & 1) || (state->crtc_w & 1))
>>  +		return -EINVAL;
>>  +
>>  +	if (!scaling_required(state)) {
>>  +		if (plane->state && osd_changed(state, plane->state))
>>  +			crtc_state->mode_changed = true;
>>  +
>>  +		ipu->numW = ipu->numH = ipu->denomW = ipu->denomH = 1;
>>  +		return 0;
>>  +	}
>>  +
>>  +	crtc_state->mode_changed = true;
>>  +
>>  +	xres = state->src_w >> 16;
>>  +	yres = state->src_h >> 16;
>>  +
>>  +	/* Adjust the coefficients until we find a valid configuration */
>>  +	for (denomW = xres, numW = state->crtc_w;
>>  +	     numW <= crtc_state->mode.hdisplay; numW++)
>>  +		if (!reduce_fraction(&numW, &denomW))
>>  +			break;
>>  +	if (numW > crtc_state->mode.hdisplay)
>>  +		return -EINVAL;
>>  +
>>  +	for (denomH = yres, numH = state->crtc_h;
>>  +	     numH <= crtc_state->mode.vdisplay; numH++)
>>  +		if (!reduce_fraction(&numH, &denomH))
>>  +			break;
>>  +	if (numH > crtc_state->mode.vdisplay)
>>  +		return -EINVAL;
>>  +
>>  +	ipu->numW = numW;
>>  +	ipu->numH = numH;
>>  +	ipu->denomW = denomW;
>>  +	ipu->denomH = denomH;
>>  +
>>  +	return 0;
>>  +}
>>  +
>>  +static void ingenic_ipu_plane_atomic_disable(struct drm_plane 
>> *plane,
>>  +					     struct drm_plane_state *old_state)
>>  +{
>>  +	struct ingenic_ipu *ipu = plane_to_ingenic_ipu(plane);
>>  +
>>  +	regmap_set_bits(ipu->map, JZ_REG_IPU_CTRL, JZ_IPU_CTRL_STOP);
>>  +	regmap_clear_bits(ipu->map, JZ_REG_IPU_CTRL, JZ_IPU_CTRL_CHIP_EN);
>>  +
>>  +	ingenic_drm_plane_disable(ipu->master, plane);
>>  +}
>>  +
>>  +static const struct drm_plane_helper_funcs 
>> ingenic_ipu_plane_helper_funcs = {
>>  +	.atomic_update		= ingenic_ipu_plane_atomic_update,
>>  +	.atomic_check		= ingenic_ipu_plane_atomic_check,
>>  +	.atomic_disable		= ingenic_ipu_plane_atomic_disable,
>>  +	.prepare_fb		= drm_gem_fb_prepare_fb,
>>  +};
>>  +
>>  +static int
>>  +ingenic_ipu_plane_atomic_get_property(struct drm_plane *plane,
>>  +				      const struct drm_plane_state *state,
>>  +				      struct drm_property *property, u64 *val)
>>  +{
>>  +	struct ingenic_ipu *ipu = plane_to_ingenic_ipu(plane);
>>  +
>>  +	if (property != ipu->sharpness_prop)
>>  +		return -EINVAL;
>>  +
>>  +	*val = ipu->sharpness;
>>  +
>>  +	return 0;
>>  +}
>>  +
>>  +static int
>>  +ingenic_ipu_plane_atomic_set_property(struct drm_plane *plane,
>>  +				      struct drm_plane_state *state,
>>  +				      struct drm_property *property, u64 val)
>>  +{
>>  +	struct ingenic_ipu *ipu = plane_to_ingenic_ipu(plane);
>>  +	struct drm_crtc_state *crtc_state;
>>  +
>>  +	if (property != ipu->sharpness_prop)
>>  +		return -EINVAL;
>>  +
>>  +	ipu->sharpness = val;
>>  +
>>  +	if (state->crtc) {
>>  +		crtc_state = drm_atomic_get_existing_crtc_state(state->state, 
>> state->crtc);
>>  +		if (WARN_ON(!crtc_state))
>>  +			return -EINVAL;
>>  +
>>  +		crtc_state->mode_changed = true;
>>  +	}
>>  +
>>  +	return 0;
>>  +}
>>  +
>>  +static const struct drm_plane_funcs ingenic_ipu_plane_funcs = {
>>  +	.update_plane		= drm_atomic_helper_update_plane,
>>  +	.disable_plane		= drm_atomic_helper_disable_plane,
>>  +	.reset			= drm_atomic_helper_plane_reset,
>>  +	.destroy		= drm_plane_cleanup,
>>  +
>>  +	.atomic_duplicate_state	= drm_atomic_helper_plane_duplicate_state,
>>  +	.atomic_destroy_state	= drm_atomic_helper_plane_destroy_state,
>>  +
>>  +	.atomic_get_property	= ingenic_ipu_plane_atomic_get_property,
>>  +	.atomic_set_property	= ingenic_ipu_plane_atomic_set_property,
>>  +};
>>  +
>>  +static irqreturn_t ingenic_ipu_irq_handler(int irq, void *arg)
>>  +{
>>  +	struct drm_plane *plane = drm_plane_from_index(arg, 0);
>>  +	struct ingenic_ipu *ipu = plane_to_ingenic_ipu(plane);
>>  +	struct drm_crtc *crtc = drm_crtc_from_index(arg, 0);
>>  +
>>  +	regmap_write(ipu->map, JZ_REG_IPU_STATUS, 0);
>>  +
>>  +	drm_crtc_handle_vblank(crtc);
>>  +
>>  +	return IRQ_HANDLED;
>>  +}
>>  +
>>  +static const struct regmap_config ingenic_ipu_regmap_config = {
>>  +	.reg_bits = 32,
>>  +	.val_bits = 32,
>>  +	.reg_stride = 4,
>>  +
>>  +	.max_register = JZ_REG_IPU_OUT_PHY_T_ADDR,
>>  +};
>>  +
>>  +static int ingenic_ipu_bind(struct device *dev, struct device 
>> *master, void *d)
>>  +{
>>  +	struct platform_device *pdev = to_platform_device(dev);
>>  +	const struct soc_info *soc_info;
>>  +	struct drm_device *drm = d;
>>  +	struct drm_plane *plane;
>>  +	struct ingenic_ipu *ipu;
>>  +	void __iomem *base;
>>  +	unsigned int sharpness_max;
>>  +	int err, irq;
>>  +
>>  +	ipu = devm_kzalloc(dev, sizeof(*ipu), GFP_KERNEL);
>>  +	if (!ipu)
>>  +		return -ENOMEM;
>>  +
>>  +	soc_info = of_device_get_match_data(dev);
>>  +	if (!soc_info) {
>>  +		dev_err(dev, "Missing platform data\n");
>>  +		return -EINVAL;
>>  +	}
>>  +
>>  +	ipu->dev = dev;
>>  +	ipu->master = master;
>>  +	ipu->soc_info = soc_info;
>>  +
>>  +	base = devm_platform_ioremap_resource(pdev, 0);
>>  +	if (IS_ERR(base)) {
>>  +		dev_err(dev, "Failed to get memory resource\n");
>>  +		return PTR_ERR(base);
>>  +	}
>>  +
>>  +	ipu->map = devm_regmap_init_mmio(dev, base, 
>> &ingenic_ipu_regmap_config);
>>  +	if (IS_ERR(ipu->map)) {
>>  +		dev_err(dev, "Failed to create regmap\n");
>>  +		return PTR_ERR(ipu->map);
>>  +	}
>>  +
>>  +	irq = platform_get_irq(pdev, 0);
>>  +	if (irq < 0)
>>  +		return irq;
>>  +
>>  +	ipu->clk = devm_clk_get(dev, "ipu");
>>  +	if (IS_ERR(ipu->clk)) {
>>  +		dev_err(dev, "Failed to get pixel clock\n");
>>  +		return PTR_ERR(ipu->clk);
>>  +	}
>>  +
>>  +	err = devm_request_irq(dev, irq, ingenic_ipu_irq_handler, 0,
>>  +			       drm->driver->name, drm);
>>  +	if (err) {
>>  +		dev_err(dev, "Unable to request IRQ\n");
>>  +		return err;
>>  +	}
>>  +
>>  +	plane = &ipu->plane;
>>  +	dev_set_drvdata(dev, plane);
>>  +
>>  +	drm_plane_helper_add(plane, &ingenic_ipu_plane_helper_funcs);
>>  +
>>  +	err = drm_universal_plane_init(drm, plane, 1, 
>> &ingenic_ipu_plane_funcs,
>>  +				       soc_info->formats, soc_info->num_formats,
>>  +				       NULL, DRM_PLANE_TYPE_PRIMARY, NULL);
>>  +	if (err) {
>>  +		dev_err(dev, "Failed to init plane: %i\n", err);
>>  +		return err;
>>  +	}
>>  +
>>  +	/*
>>  +	 * Sharpness settings range is [0,32]
>>  +	 * 0       : nearest-neighbor
>>  +	 * 1       : bilinear
>>  +	 * 2 .. 32 : bicubic (translated to sharpness factor -0.25 .. 
>> -4.0)
>>  +	 */
>>  +	sharpness_max = soc_info->has_bicubic ? 32 : 1;
>>  +	ipu->sharpness_prop = drm_property_create_range(drm, 0, 
>> "sharpness",
>>  +							0, sharpness_max);
>>  +	if (!ipu->sharpness_prop) {
>>  +		dev_err(dev, "Unable to create sharpness property\n");
>>  +		return -ENOMEM;
>>  +	}
>>  +
>>  +	/* Default sharpness factor: -0.125 * 8 = -1.0 */
>>  +	ipu->sharpness = soc_info->has_bicubic ? 8 : 1;
>>  +	drm_object_attach_property(&plane->base, ipu->sharpness_prop,
>>  +				   ipu->sharpness);
>>  +
>>  +	err = clk_prepare_enable(ipu->clk);
>>  +	if (err) {
>>  +		dev_err(dev, "Unable to enable clock\n");
>>  +		return err;
>>  +	}
>>  +
>>  +	return 0;
>>  +}
>>  +
>>  +static void ingenic_ipu_unbind(struct device *dev,
>>  +			       struct device *master, void *d)
>>  +{
>>  +	struct ingenic_ipu *ipu = dev_get_drvdata(dev);
>>  +
>>  +	clk_disable_unprepare(ipu->clk);
>>  +}
>>  +
>>  +static const struct component_ops ingenic_ipu_ops = {
>>  +	.bind = ingenic_ipu_bind,
>>  +	.unbind = ingenic_ipu_unbind,
>>  +};
>>  +
>>  +static int ingenic_ipu_probe(struct platform_device *pdev)
>>  +{
>>  +	return component_add(&pdev->dev, &ingenic_ipu_ops);
>>  +}
>>  +
>>  +static int ingenic_ipu_remove(struct platform_device *pdev)
>>  +{
>>  +	component_del(&pdev->dev, &ingenic_ipu_ops);
>>  +	return 0;
>>  +}
>>  +
>>  +static const u32 jz4725b_ipu_formats[] = {
>>  +	DRM_FORMAT_YUYV,
>>  +	DRM_FORMAT_YVYU,
>>  +	DRM_FORMAT_UYVY,
>>  +	DRM_FORMAT_VYUY,
>>  +	DRM_FORMAT_YUV411,
>>  +	DRM_FORMAT_YUV420,
>>  +	DRM_FORMAT_YUV422,
>>  +	DRM_FORMAT_YUV444,
>>  +};
>>  +
>>  +static const struct soc_info jz4725b_soc_info = {
>>  +	.formats	= jz4725b_ipu_formats,
>>  +	.num_formats	= ARRAY_SIZE(jz4725b_ipu_formats),
>>  +	.has_bicubic	= false,
>>  +	.set_coefs	= jz4725b_set_coefs,
>>  +};
>>  +
>>  +static const u32 jz4760_ipu_formats[] = {
>>  +	DRM_FORMAT_XRGB1555,
>>  +	DRM_FORMAT_XBGR1555,
>>  +	DRM_FORMAT_RGB565,
>>  +	DRM_FORMAT_BGR565,
>>  +	DRM_FORMAT_XRGB8888,
>>  +	DRM_FORMAT_XBGR8888,
>>  +	DRM_FORMAT_YUYV,
>>  +	DRM_FORMAT_YVYU,
>>  +	DRM_FORMAT_UYVY,
>>  +	DRM_FORMAT_VYUY,
>>  +	DRM_FORMAT_YUV411,
>>  +	DRM_FORMAT_YUV420,
>>  +	DRM_FORMAT_YUV422,
>>  +	DRM_FORMAT_YUV444,
>>  +};
>>  +
>>  +static const struct soc_info jz4760_soc_info = {
>>  +	.formats	= jz4760_ipu_formats,
>>  +	.num_formats	= ARRAY_SIZE(jz4760_ipu_formats),
>>  +	.has_bicubic	= true,
>>  +	.set_coefs	= jz4760_set_coefs,
>>  +};
>>  +
>>  +static const struct of_device_id ingenic_ipu_of_match[] = {
>>  +	{ .compatible = "ingenic,jz4725b-ipu", .data = &jz4725b_soc_info 
>> },
>>  +	{ .compatible = "ingenic,jz4760-ipu", .data = &jz4760_soc_info },
>>  +	{ /* sentinel */ },
>>  +};
>>  +MODULE_DEVICE_TABLE(of, ingenic_ipu_of_match);
>>  +
>>  +static struct platform_driver ingenic_ipu_driver = {
>>  +	.driver = {
>>  +		.name = "ingenic-ipu",
>>  +		.of_match_table = ingenic_ipu_of_match,
>>  +	},
>>  +	.probe = ingenic_ipu_probe,
>>  +	.remove = ingenic_ipu_remove,
>>  +};
>>  +
>>  +struct platform_driver *ingenic_ipu_driver_ptr = 
>> &ingenic_ipu_driver;
>>  diff --git a/drivers/gpu/drm/ingenic/ingenic-ipu.h 
>> b/drivers/gpu/drm/ingenic/ingenic-ipu.h
>>  new file mode 100644
>>  index 000000000000..eab6fab8c7f6
>>  --- /dev/null
>>  +++ b/drivers/gpu/drm/ingenic/ingenic-ipu.h
>>  @@ -0,0 +1,109 @@
>>  +/* SPDX-License-Identifier: GPL-2.0 */
>>  +//
>>  +// Ingenic JZ47xx IPU - Register definitions and private API
>>  +//
>>  +// Copyright (C) 2020, Paul Cercueil <paul@crapouillou.net>
>>  +
>>  +#ifndef DRIVERS_GPU_DRM_INGENIC_INGENIC_IPU_H
>>  +#define DRIVERS_GPU_DRM_INGENIC_INGENIC_IPU_H
>>  +
>>  +#include <linux/bitops.h>
>>  +
>>  +#define JZ_REG_IPU_CTRL			0x00
>>  +#define JZ_REG_IPU_STATUS		0x04
>>  +#define JZ_REG_IPU_D_FMT		0x08
>>  +#define JZ_REG_IPU_Y_ADDR		0x0c
>>  +#define JZ_REG_IPU_U_ADDR		0x10
>>  +#define JZ_REG_IPU_V_ADDR		0x14
>>  +#define JZ_REG_IPU_IN_GS		0x18
>>  +#define JZ_REG_IPU_Y_STRIDE		0x1c
>>  +#define JZ_REG_IPU_UV_STRIDE		0x20
>>  +#define JZ_REG_IPU_OUT_ADDR		0x24
>>  +#define JZ_REG_IPU_OUT_GS		0x28
>>  +#define JZ_REG_IPU_OUT_STRIDE		0x2c
>>  +#define JZ_REG_IPU_RSZ_COEF_INDEX	0x30
>>  +#define JZ_REG_IPU_CSC_C0_COEF		0x34
>>  +#define JZ_REG_IPU_CSC_C1_COEF		0x38
>>  +#define JZ_REG_IPU_CSC_C2_COEF		0x3c
>>  +#define JZ_REG_IPU_CSC_C3_COEF		0x40
>>  +#define JZ_REG_IPU_CSC_C4_COEF		0x44
>>  +#define JZ_REG_IPU_HRSZ_COEF_LUT	0x48
>>  +#define JZ_REG_IPU_VRSZ_COEF_LUT	0x4c
>>  +#define JZ_REG_IPU_CSC_OFFSET		0x50
>>  +#define JZ_REG_IPU_Y_PHY_T_ADDR		0x54
>>  +#define JZ_REG_IPU_U_PHY_T_ADDR		0x58
>>  +#define JZ_REG_IPU_V_PHY_T_ADDR		0x5c
>>  +#define JZ_REG_IPU_OUT_PHY_T_ADDR	0x60
>>  +
>>  +#define JZ_IPU_CTRL_ADDR_SEL		BIT(20)
>>  +#define JZ_IPU_CTRL_ZOOM_SEL		BIT(18)
>>  +#define JZ_IPU_CTRL_DFIX_SEL		BIT(17)
>>  +#define JZ_IPU_CTRL_LCDC_SEL		BIT(11)
>>  +#define JZ_IPU_CTRL_SPKG_SEL		BIT(10)
>>  +#define JZ_IPU_CTRL_VSCALE		BIT(9)
>>  +#define JZ_IPU_CTRL_HSCALE		BIT(8)
>>  +#define JZ_IPU_CTRL_STOP		BIT(7)
>>  +#define JZ_IPU_CTRL_RST			BIT(6)
>>  +#define JZ_IPU_CTRL_FM_IRQ_EN		BIT(5)
>>  +#define JZ_IPU_CTRL_CSC_EN		BIT(4)
>>  +#define JZ_IPU_CTRL_VRSZ_EN		BIT(3)
>>  +#define JZ_IPU_CTRL_HRSZ_EN		BIT(2)
>>  +#define JZ_IPU_CTRL_RUN			BIT(1)
>>  +#define JZ_IPU_CTRL_CHIP_EN		BIT(0)
>>  +
>>  +#define JZ_IPU_STATUS_OUT_END		BIT(0)
>>  +
>>  +#define JZ_IPU_IN_GS_H_LSB		0x0
>>  +#define JZ_IPU_IN_GS_W_LSB		0x10
>>  +#define JZ_IPU_OUT_GS_H_LSB		0x0
>>  +#define JZ_IPU_OUT_GS_W_LSB		0x10
>>  +
>>  +#define JZ_IPU_Y_STRIDE_Y_LSB		0
>>  +#define JZ_IPU_UV_STRIDE_U_LSB		16
>>  +#define JZ_IPU_UV_STRIDE_V_LSB		0
>>  +
>>  +#define JZ_IPU_D_FMT_IN_FMT_LSB		0
>>  +#define JZ_IPU_D_FMT_IN_FMT_RGB555	(0x0 << JZ_IPU_D_FMT_IN_FMT_LSB)
>>  +#define JZ_IPU_D_FMT_IN_FMT_YUV420	(0x0 << JZ_IPU_D_FMT_IN_FMT_LSB)
>>  +#define JZ_IPU_D_FMT_IN_FMT_YUV422	(0x1 << JZ_IPU_D_FMT_IN_FMT_LSB)
>>  +#define JZ_IPU_D_FMT_IN_FMT_RGB888	(0x2 << JZ_IPU_D_FMT_IN_FMT_LSB)
>>  +#define JZ_IPU_D_FMT_IN_FMT_YUV444	(0x2 << JZ_IPU_D_FMT_IN_FMT_LSB)
>>  +#define JZ_IPU_D_FMT_IN_FMT_RGB565	(0x3 << JZ_IPU_D_FMT_IN_FMT_LSB)
>>  +
>>  +#define JZ_IPU_D_FMT_YUV_FMT_LSB	2
>>  +#define JZ_IPU_D_FMT_YUV_Y1UY0V		(0x0 << JZ_IPU_D_FMT_YUV_FMT_LSB)
>>  +#define JZ_IPU_D_FMT_YUV_Y1VY0U		(0x1 << JZ_IPU_D_FMT_YUV_FMT_LSB)
>>  +#define JZ_IPU_D_FMT_YUV_UY1VY0		(0x2 << JZ_IPU_D_FMT_YUV_FMT_LSB)
>>  +#define JZ_IPU_D_FMT_YUV_VY1UY0		(0x3 << JZ_IPU_D_FMT_YUV_FMT_LSB)
>>  +#define JZ_IPU_D_FMT_IN_FMT_YUV411	(0x3 << JZ_IPU_D_FMT_IN_FMT_LSB)
>>  +
>>  +#define JZ_IPU_D_FMT_OUT_FMT_LSB	19
>>  +#define JZ_IPU_D_FMT_OUT_FMT_RGB555	(0x0 << 
>> JZ_IPU_D_FMT_OUT_FMT_LSB)
>>  +#define JZ_IPU_D_FMT_OUT_FMT_RGB565	(0x1 << 
>> JZ_IPU_D_FMT_OUT_FMT_LSB)
>>  +#define JZ_IPU_D_FMT_OUT_FMT_RGB888	(0x2 << 
>> JZ_IPU_D_FMT_OUT_FMT_LSB)
>>  +#define JZ_IPU_D_FMT_OUT_FMT_YUV422	(0x3 << 
>> JZ_IPU_D_FMT_OUT_FMT_LSB)
>>  +#define JZ_IPU_D_FMT_OUT_FMT_RGBAAA	(0x4 << 
>> JZ_IPU_D_FMT_OUT_FMT_LSB)
>>  +
>>  +#define JZ_IPU_D_FMT_RGB_OUT_OFT_LSB	22
>>  +#define JZ_IPU_D_FMT_RGB_OUT_OFT_RGB	(0x0 << 
>> JZ_IPU_D_FMT_RGB_OUT_OFT_LSB)
>>  +#define JZ_IPU_D_FMT_RGB_OUT_OFT_RBG	(0x1 << 
>> JZ_IPU_D_FMT_RGB_OUT_OFT_LSB)
>>  +#define JZ_IPU_D_FMT_RGB_OUT_OFT_GBR	(0x2 << 
>> JZ_IPU_D_FMT_RGB_OUT_OFT_LSB)
>>  +#define JZ_IPU_D_FMT_RGB_OUT_OFT_GRB	(0x3 << 
>> JZ_IPU_D_FMT_RGB_OUT_OFT_LSB)
>>  +#define JZ_IPU_D_FMT_RGB_OUT_OFT_BRG	(0x4 << 
>> JZ_IPU_D_FMT_RGB_OUT_OFT_LSB)
>>  +#define JZ_IPU_D_FMT_RGB_OUT_OFT_BGR	(0x5 << 
>> JZ_IPU_D_FMT_RGB_OUT_OFT_LSB)
>>  +
>>  +#define JZ4725B_IPU_RSZ_LUT_COEF_LSB	2
>>  +#define JZ4725B_IPU_RSZ_LUT_COEF_MASK	0x7ff
>>  +#define JZ4725B_IPU_RSZ_LUT_IN_EN	BIT(1)
>>  +#define JZ4725B_IPU_RSZ_LUT_OUT_EN	BIT(0)
>>  +
>>  +#define JZ4760_IPU_RSZ_COEF20_LSB	6
>>  +#define JZ4760_IPU_RSZ_COEF31_LSB	17
>>  +#define JZ4760_IPU_RSZ_COEF_MASK	0x7ff
>>  +#define JZ4760_IPU_RSZ_OFFSET_LSB	1
>>  +#define JZ4760_IPU_RSZ_OFFSET_MASK	0x1f
>>  +
>>  +#define JZ_IPU_CSC_OFFSET_CHROMA_LSB	16
>>  +#define JZ_IPU_CSC_OFFSET_LUMA_LSB	16
>>  +
>>  +#endif /* DRIVERS_GPU_DRM_INGENIC_INGENIC_IPU_H */
>>  --
>>  2.27.0
>> 
>>  _______________________________________________
>>  dri-devel mailing list
>>  dri-devel@lists.freedesktop.org
>>  https://lists.freedesktop.org/mailman/listinfo/dri-devel



^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH v2 08/10] drm/ingenic: Add support for OSD mode
  2020-06-30 12:05   ` Sam Ravnborg
@ 2020-06-30 14:39     ` Paul Cercueil
  0 siblings, 0 replies; 22+ messages in thread
From: Paul Cercueil @ 2020-06-30 14:39 UTC (permalink / raw)
  To: Sam Ravnborg
  Cc: David Airlie, Daniel Vetter, Rob Herring, devicetree, linux-mips,
	dri-devel, linux-kernel, od

Hi Sam,

Le mar. 30 juin 2020 à 14:05, Sam Ravnborg <sam@ravnborg.org> a écrit 
:
> Hi Paul.
> 
> On Tue, Jun 30, 2020 at 01:52:08AM +0200, Paul Cercueil wrote:
>>  All Ingenic SoCs starting from the JZ4725B support OSD mode.
>> 
>>  In this mode, two separate planes can be used. They can have 
>> different
>>  positions and sizes, and one can be overlayed on top of the other.
>> 
>>  Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> 
> OSD? On screen Display?

Yes... That's how it's called in the programming manual.

I believe it's because this mode adds the possibility to create OSDs 
with the overlay plane.

> Some random comments in the following - from my attempt to follow the
> code.
> 
> 	Sam
> 
> 
>>  ---
>> 
>>  Notes:
>>      v2: Use fallthrough; instead of /* fall-through */
>> 
>>   drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 271 
>> +++++++++++++++++-----
>>   drivers/gpu/drm/ingenic/ingenic-drm.h     |  35 +++
>>   2 files changed, 254 insertions(+), 52 deletions(-)
>> 
>>  diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c 
>> b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
>>  index 6590b61cb915..a8573da1d577 100644
>>  --- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
>>  +++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
>>  @@ -43,12 +43,13 @@ struct ingenic_dma_hwdesc {
>> 
>>   struct jz_soc_info {
>>   	bool needs_dev_clk;
>>  +	bool has_osd;
>>   	unsigned int max_width, max_height;
>>   };
>> 
>>   struct ingenic_drm {
>>   	struct drm_device drm;
>>  -	struct drm_plane primary;
>>  +	struct drm_plane f0, f1;
> 
> A small comment about when f0 and f1 is used and how they are the
> primary plane would be good here.

Right.

> 
>>   	struct drm_crtc crtc;
>>   	struct drm_encoder encoder;
>> 
>>  @@ -57,8 +58,8 @@ struct ingenic_drm {
>>   	struct clk *lcd_clk, *pix_clk;
>>   	const struct jz_soc_info *soc_info;
>> 
>>  -	struct ingenic_dma_hwdesc *dma_hwdesc;
>>  -	dma_addr_t dma_hwdesc_phys;
>>  +	struct ingenic_dma_hwdesc *dma_hwdesc[2];
>>  +	dma_addr_t dma_hwdesc_phys[2];
>> 
>>   	bool panel_is_sharp;
>>   };
>>  @@ -90,7 +91,7 @@ static const struct regmap_config 
>> ingenic_drm_regmap_config = {
>>   	.val_bits = 32,
>>   	.reg_stride = 4,
>> 
>>  -	.max_register = JZ_REG_LCD_CMD1,
>>  +	.max_register = JZ_REG_LCD_SIZE1,
>>   	.writeable_reg = ingenic_drm_writeable_reg,
>>   };
>> 
>>  @@ -110,11 +111,6 @@ drm_encoder_get_priv(struct drm_encoder 
>> *encoder)
>>   	return container_of(encoder, struct ingenic_drm, encoder);
>>   }
>> 
>>  -static inline struct ingenic_drm *drm_plane_get_priv(struct 
>> drm_plane *plane)
>>  -{
>>  -	return container_of(plane, struct ingenic_drm, primary);
>>  -}
>>  -
>>   static void ingenic_drm_crtc_atomic_enable(struct drm_crtc *crtc,
>>   					   struct drm_crtc_state *state)
>>   {
>>  @@ -185,34 +181,17 @@ static void 
>> ingenic_drm_crtc_update_timings(struct ingenic_drm *priv,
>>   		regmap_write(priv->map, JZ_REG_LCD_SPL, hpe << 16 | (hpe + 1));
>>   		regmap_write(priv->map, JZ_REG_LCD_REV, mode->htotal << 16);
>>   	}
>>  -}
>>  -
>>  -static void ingenic_drm_crtc_update_ctrl(struct ingenic_drm *priv,
>>  -					 const struct drm_format_info *finfo)
>>  -{
>>  -	unsigned int ctrl = JZ_LCD_CTRL_OFUP | JZ_LCD_CTRL_BURST_16;
>>  -
>>  -	switch (finfo->format) {
>>  -	case DRM_FORMAT_XRGB1555:
>>  -		ctrl |= JZ_LCD_CTRL_RGB555;
>>  -		/* fall-through */
>>  -	case DRM_FORMAT_RGB565:
>>  -		ctrl |= JZ_LCD_CTRL_BPP_15_16;
>>  -		break;
>>  -	case DRM_FORMAT_XRGB8888:
>>  -		ctrl |= JZ_LCD_CTRL_BPP_18_24;
>>  -		break;
>>  -	}
>> 
>>   	regmap_update_bits(priv->map, JZ_REG_LCD_CTRL,
>>  -			   JZ_LCD_CTRL_OFUP | JZ_LCD_CTRL_BURST_16 |
>>  -			   JZ_LCD_CTRL_BPP_MASK, ctrl);
>>  +			   JZ_LCD_CTRL_OFUP | JZ_LCD_CTRL_BURST_16,
>>  +			   JZ_LCD_CTRL_OFUP | JZ_LCD_CTRL_BURST_16);
> It looks like regmap_update_bits() is no longer the best choice here.

I see that regmap_set_bits() appeared in 5.8, I'll just use that.

>>   }
>> 
>>   static int ingenic_drm_crtc_atomic_check(struct drm_crtc *crtc,
>>   					 struct drm_crtc_state *state)
>>   {
>>   	struct ingenic_drm *priv = drm_crtc_get_priv(crtc);
>>  +	struct drm_plane_state *f1_state, *f0_state;
>>   	long rate;
>> 
>>   	if (!drm_atomic_crtc_needs_modeset(state))
>>  @@ -227,6 +206,15 @@ static int 
>> ingenic_drm_crtc_atomic_check(struct drm_crtc *crtc,
>>   	if (rate < 0)
>>   		return rate;
>> 
>>  +	if (priv->soc_info->has_osd) {
>>  +		f1_state = drm_atomic_get_plane_state(state->state, &priv->f1);
>>  +		f0_state = drm_atomic_get_plane_state(state->state, &priv->f0);
>>  +
>>  +		/* If all the planes are disabled, we won't get a VBLANK IRQ */
>>  +		if (!f1_state->fb && !f0_state->fb)
>>  +			state->no_vblank = true;
>>  +	}
>>  +
>>   	return 0;
>>   }
>> 
>>  @@ -236,14 +224,9 @@ static void 
>> ingenic_drm_crtc_atomic_flush(struct drm_crtc *crtc,
>>   	struct ingenic_drm *priv = drm_crtc_get_priv(crtc);
>>   	struct drm_crtc_state *state = crtc->state;
>>   	struct drm_pending_vblank_event *event = state->event;
>>  -	struct drm_framebuffer *drm_fb = crtc->primary->state->fb;
>>  -	const struct drm_format_info *finfo;
>> 
>>   	if (drm_atomic_crtc_needs_modeset(state)) {
>>  -		finfo = drm_format_info(drm_fb->format->format);
>>  -
>>   		ingenic_drm_crtc_update_timings(priv, &state->mode);
>>  -		ingenic_drm_crtc_update_ctrl(priv, finfo);
>> 
>>   		clk_set_rate(priv->pix_clk, state->adjusted_mode.clock * 1000);
>>   	}
>>  @@ -260,12 +243,149 @@ static void 
>> ingenic_drm_crtc_atomic_flush(struct drm_crtc *crtc,
>>   	}
>>   }
>> 
>>  +static int ingenic_drm_plane_atomic_check(struct drm_plane *plane,
>>  +					  struct drm_plane_state *state)
>>  +{
>>  +	struct ingenic_drm *priv = drm_device_get_priv(plane->dev);
>>  +	struct drm_crtc_state *crtc_state;
>>  +	struct drm_crtc *crtc = state->crtc ?: plane->state->crtc;
>>  +	int ret;
>>  +
>>  +	if (!crtc)
>>  +		return 0;
>>  +
>>  +	crtc_state = drm_atomic_get_existing_crtc_state(state->state, 
>> crtc);
>>  +	if (WARN_ON(!crtc_state))
>>  +		return -EINVAL;
>>  +
>>  +	ret = drm_atomic_helper_check_plane_state(state, crtc_state,
>>  +						  DRM_PLANE_HELPER_NO_SCALING,
>>  +						  DRM_PLANE_HELPER_NO_SCALING,
>>  +						  priv->soc_info->has_osd,
>>  +						  true);
>>  +	if (ret)
>>  +		return ret;
>>  +
>>  +	if (!priv->soc_info->has_osd &&
>>  +	    (state->src_x != 0 ||
>>  +	     (state->src_w >> 16) != state->crtc_w ||
>>  +	     (state->src_h >> 16) != state->crtc_h))
>>  +		return -EINVAL;
> This check could bebefit from a small comment.
> I cannot see the purpose of " >> 16" on the src_* fields...

I can add a comment, yes.

The src_* fields of a drm_plane are in 16.16 fixed-point format, hence 
the >>16. I didn't invent that here.

>>  +
>>  +	/*
>>  +	 * Require full modeset if if enabling or disabling a plane, or 
>> changing
> Too many ifs?
> 
>>  +	 * its position, size or depth.
>>  +	 */
>>  +	if (priv->soc_info->has_osd &&
>>  +	    (!plane->state->fb || !state->fb ||
>>  +	     plane->state->crtc_x != state->crtc_x ||
>>  +	     plane->state->crtc_y != state->crtc_y ||
>>  +	     plane->state->crtc_w != state->crtc_w ||
>>  +	     plane->state->crtc_h != state->crtc_h ||
>>  +	     plane->state->fb->format->format != 
>> state->fb->format->format))
>>  +		crtc_state->mode_changed = true;
>>  +
>>  +	return 0;
>>  +}
>>  +
>>  +static void ingenic_drm_plane_enable(struct ingenic_drm *priv,
>>  +				      struct drm_plane *plane)
>>  +{
>>  +	unsigned int en_bit;
>>  +
>>  +	if (priv->soc_info->has_osd) {
>>  +		if (plane->type == DRM_PLANE_TYPE_PRIMARY)
>>  +			en_bit = JZ_LCD_OSDC_F1EN;
>>  +		else
>>  +			en_bit = JZ_LCD_OSDC_F0EN;
>>  +
>>  +		regmap_update_bits(priv->map, JZ_REG_LCD_OSDC, en_bit, en_bit);
> I think you can use a more direct way to do the assignment.
> Like before where the same pattern was used (last two arguments the
> same).
> 
>>  +	}
>>  +}
>>  +
>>  +static void ingenic_drm_plane_atomic_disable(struct drm_plane 
>> *plane,
>>  +					     struct drm_plane_state *old_state)
>>  +{
>>  +	struct ingenic_drm *priv = drm_device_get_priv(plane->dev);
>>  +	unsigned int en_bit;
>>  +
>>  +	if (priv->soc_info->has_osd) {
>>  +		if (plane->type == DRM_PLANE_TYPE_PRIMARY)
>>  +			en_bit = JZ_LCD_OSDC_F1EN;
>>  +		else
>>  +			en_bit = JZ_LCD_OSDC_F0EN;
>>  +
>>  +		regmap_update_bits(priv->map, JZ_REG_LCD_OSDC, en_bit, 0);
>>  +	}
>>  +}
>>  +
>>  +static void ingenic_drm_plane_config(struct ingenic_drm *priv,
>>  +				     struct drm_plane *plane, u32 fourcc)
>>  +{
>>  +	struct drm_plane_state *state = plane->state;
>>  +	unsigned int xy_reg, size_reg;
>>  +	unsigned int ctrl = 0;
>>  +
>>  +	ingenic_drm_plane_enable(priv, plane);
>>  +
>>  +	if (priv->soc_info->has_osd &&
>>  +	    plane->type == DRM_PLANE_TYPE_PRIMARY) {
>>  +		switch (fourcc) {
>>  +		case DRM_FORMAT_XRGB1555:
>>  +			ctrl |= JZ_LCD_OSDCTRL_RGB555;
>>  +			fallthrough;
>>  +		case DRM_FORMAT_RGB565:
>>  +			ctrl |= JZ_LCD_OSDCTRL_BPP_15_16;
>>  +			break;
>>  +		case DRM_FORMAT_XRGB8888:
>>  +			ctrl |= JZ_LCD_OSDCTRL_BPP_18_24;
>>  +			break;
>>  +		}
>>  +
>>  +		regmap_update_bits(priv->map, JZ_REG_LCD_OSDCTRL,
>>  +				   JZ_LCD_OSDCTRL_BPP_MASK, ctrl);
>>  +	} else {
>>  +		switch (fourcc) {
>>  +		case DRM_FORMAT_XRGB1555:
>>  +			ctrl |= JZ_LCD_CTRL_RGB555;
>>  +			fallthrough;
>>  +		case DRM_FORMAT_RGB565:
>>  +			ctrl |= JZ_LCD_CTRL_BPP_15_16;
>>  +			break;
>>  +		case DRM_FORMAT_XRGB8888:
>>  +			ctrl |= JZ_LCD_CTRL_BPP_18_24;
>>  +			break;
>>  +		}
>>  +
>>  +		regmap_update_bits(priv->map, JZ_REG_LCD_CTRL,
>>  +				   JZ_LCD_CTRL_BPP_MASK, ctrl);
>>  +	}
>>  +
>>  +	if (priv->soc_info->has_osd) {
>>  +		if (plane->type == DRM_PLANE_TYPE_PRIMARY) {
>>  +			xy_reg = JZ_REG_LCD_XYP1;
>>  +			size_reg = JZ_REG_LCD_SIZE1;
>>  +		} else {
>>  +			xy_reg = JZ_REG_LCD_XYP0;
>>  +			size_reg = JZ_REG_LCD_SIZE0;
>>  +		}
>>  +
>>  +		regmap_write(priv->map, xy_reg,
>>  +			     state->crtc_x << JZ_LCD_XYP01_XPOS_LSB |
>>  +			     state->crtc_y << JZ_LCD_XYP01_YPOS_LSB);
>>  +		regmap_write(priv->map, size_reg,
>>  +			     state->crtc_w << JZ_LCD_SIZE01_WIDTH_LSB |
>>  +			     state->crtc_h << JZ_LCD_SIZE01_HEIGHT_LSB);
>>  +	}
>>  +}
>>  +
>>   static void ingenic_drm_plane_atomic_update(struct drm_plane 
>> *plane,
>>   					    struct drm_plane_state *oldstate)
>>   {
>>  -	struct ingenic_drm *priv = drm_plane_get_priv(plane);
>>  +	struct ingenic_drm *priv = drm_device_get_priv(plane->dev);
>>   	struct drm_plane_state *state = plane->state;
>>   	unsigned int width, height, cpp;
>>  +	unsigned int hwdesc_idx;
>>   	dma_addr_t addr;
>> 
>>   	if (state && state->fb) {
>>  @@ -274,9 +394,18 @@ static void 
>> ingenic_drm_plane_atomic_update(struct drm_plane *plane,
>>   		height = state->src_h >> 16;
>>   		cpp = state->fb->format->cpp[0];
>> 
>>  -		priv->dma_hwdesc->addr = addr;
>>  -		priv->dma_hwdesc->cmd = width * height * cpp / 4;
>>  -		priv->dma_hwdesc->cmd |= JZ_LCD_CMD_EOF_IRQ;
>>  +		if (!priv->soc_info->has_osd)
>>  +			hwdesc_idx = 0;
>>  +		else
> 
>>  +			hwdesc_idx = plane->type == DRM_PLANE_TYPE_PRIMARY;
> This looks ugly.
> "plane->type == DRM_PLANE_TYPE_PRIMARY" evaluates to a boolean.
> This is then ocnverted to an int used as index to an array later.
> Something a bit more explicit would be more readable.

I'll come up with something better.

>>  +
>>  +		priv->dma_hwdesc[hwdesc_idx]->addr = addr;
>>  +		priv->dma_hwdesc[hwdesc_idx]->cmd = width * height * cpp / 4;
>>  +		priv->dma_hwdesc[hwdesc_idx]->cmd |= JZ_LCD_CMD_EOF_IRQ;
>>  +
>>  +		if (drm_atomic_crtc_needs_modeset(state->crtc->state))
>>  +			ingenic_drm_plane_config(priv, plane,
>>  +						 state->fb->format->format);
>>   	}
>>   }
>> 
>>  @@ -437,6 +566,8 @@ static const struct drm_crtc_funcs 
>> ingenic_drm_crtc_funcs = {
>> 
>>   static const struct drm_plane_helper_funcs 
>> ingenic_drm_plane_helper_funcs = {
>>   	.atomic_update		= ingenic_drm_plane_atomic_update,
>>  +	.atomic_check		= ingenic_drm_plane_atomic_check,
>>  +	.atomic_disable		= ingenic_drm_plane_atomic_disable,
>>   	.prepare_fb		= drm_gem_fb_prepare_fb,
>>   };
>> 
>>  @@ -463,8 +594,10 @@ static void ingenic_drm_free_dma_hwdesc(void 
>> *d)
>>   {
>>   	struct ingenic_drm *priv = d;
>> 
>>  -	dma_free_coherent(priv->dev, sizeof(*priv->dma_hwdesc),
>>  -			  priv->dma_hwdesc, priv->dma_hwdesc_phys);
>>  +	dma_free_coherent(priv->dev, sizeof(*priv->dma_hwdesc[0]),
>>  +			  priv->dma_hwdesc[0], priv->dma_hwdesc_phys[0]);
>>  +	dma_free_coherent(priv->dev, sizeof(*priv->dma_hwdesc[1]),
>>  +			  priv->dma_hwdesc[1], priv->dma_hwdesc_phys[1]);
>>   }
>> 
>>   static int ingenic_drm_probe(struct platform_device *pdev)
>>  @@ -549,23 +682,32 @@ static int ingenic_drm_probe(struct 
>> platform_device *pdev)
>>   		bridge = devm_drm_panel_bridge_add_typed(dev, panel,
>>   							 DRM_MODE_CONNECTOR_DPI);
>> 
>>  -	priv->dma_hwdesc = dma_alloc_coherent(dev, 
>> sizeof(*priv->dma_hwdesc),
>>  -					      &priv->dma_hwdesc_phys,
>>  -					      GFP_KERNEL);
>>  -	if (!priv->dma_hwdesc)
>>  +	priv->dma_hwdesc[0] = dma_alloc_coherent(dev, 
>> sizeof(*priv->dma_hwdesc[0]),
>>  +						 &priv->dma_hwdesc_phys[0],
>>  +						 GFP_KERNEL);
>>  +	if (!priv->dma_hwdesc[0])
>>  +		return -ENOMEM;
>>  +
>>  +	priv->dma_hwdesc[0]->next = priv->dma_hwdesc_phys[0];
>>  +	priv->dma_hwdesc[0]->id = 0xdeafbead;
>>  +
>>  +	priv->dma_hwdesc[1] = dma_alloc_coherent(dev, 
>> sizeof(*priv->dma_hwdesc[1]),
>>  +						 &priv->dma_hwdesc_phys[1],
>>  +						 GFP_KERNEL);
>>  +	if (!priv->dma_hwdesc[1])
>>   		return -ENOMEM;
> Here you should undo the first allocation??
> I think the code could benefit from using dmam_alloc_coherent().

Right, good catch.

Thanks for the review!

Cheers,
-Paul

> 
>> 
>>  +	priv->dma_hwdesc[1]->next = priv->dma_hwdesc_phys[1];
>>  +	priv->dma_hwdesc[1]->id = 0xdeadbabe;
>>  +
>>   	ret = devm_add_action_or_reset(dev, ingenic_drm_free_dma_hwdesc, 
>> priv);
>>   	if (ret)
>>   		return ret;
>> 
>>  -	priv->dma_hwdesc->next = priv->dma_hwdesc_phys;
>>  -	priv->dma_hwdesc->id = 0xdeafbead;
>>  -
>>  -	drm_plane_helper_add(&priv->primary, 
>> &ingenic_drm_plane_helper_funcs);
>>  +	drm_plane_helper_add(&priv->f1, &ingenic_drm_plane_helper_funcs);
>> 
>>  -	ret = drm_universal_plane_init(drm, &priv->primary,
>>  -				       0, &ingenic_drm_primary_plane_funcs,
>>  +	ret = drm_universal_plane_init(drm, &priv->f1, 1,
>>  +				       &ingenic_drm_primary_plane_funcs,
>>   				       ingenic_drm_primary_formats,
>>   				       ARRAY_SIZE(ingenic_drm_primary_formats),
>>   				       NULL, DRM_PLANE_TYPE_PRIMARY, NULL);
>>  @@ -576,13 +718,30 @@ static int ingenic_drm_probe(struct 
>> platform_device *pdev)
>> 
>>   	drm_crtc_helper_add(&priv->crtc, &ingenic_drm_crtc_helper_funcs);
>> 
>>  -	ret = drm_crtc_init_with_planes(drm, &priv->crtc, &priv->primary,
>>  +	ret = drm_crtc_init_with_planes(drm, &priv->crtc, &priv->f1,
>>   					NULL, &ingenic_drm_crtc_funcs, NULL);
>>   	if (ret) {
>>   		dev_err(dev, "Failed to init CRTC: %i\n", ret);
>>   		return ret;
>>   	}
>> 
>>  +	if (soc_info->has_osd) {
>>  +		drm_plane_helper_add(&priv->f0,
>>  +				     &ingenic_drm_plane_helper_funcs);
>>  +
>>  +		ret = drm_universal_plane_init(drm, &priv->f0, 1,
>>  +					       &ingenic_drm_primary_plane_funcs,
>>  +					       ingenic_drm_primary_formats,
>>  +					       ARRAY_SIZE(ingenic_drm_primary_formats),
>>  +					       NULL, DRM_PLANE_TYPE_OVERLAY,
>>  +					       NULL);
>>  +		if (ret) {
>>  +			dev_err(dev, "Failed to register overlay plane: %i\n",
>>  +				ret);
>>  +			return ret;
>>  +		}
>>  +	}
>>  +
>>   	priv->encoder.possible_crtcs = 1;
>> 
>>   	drm_encoder_helper_add(&priv->encoder,
>>  @@ -644,7 +803,12 @@ static int ingenic_drm_probe(struct 
>> platform_device *pdev)
>>   	}
>> 
>>   	/* Set address of our DMA descriptor chain */
>>  -	regmap_write(priv->map, JZ_REG_LCD_DA0, priv->dma_hwdesc_phys);
>>  +	regmap_write(priv->map, JZ_REG_LCD_DA0, priv->dma_hwdesc_phys[0]);
>>  +	regmap_write(priv->map, JZ_REG_LCD_DA1, priv->dma_hwdesc_phys[1]);
>>  +
>>  +	/* Enable OSD if available */
>>  +	if (soc_info->has_osd)
>>  +		regmap_write(priv->map, JZ_REG_LCD_OSDC, JZ_LCD_OSDC_OSDEN);
>> 
>>   	ret = drm_dev_register(drm, 0);
>>   	if (ret) {
>>  @@ -680,18 +844,21 @@ static int ingenic_drm_remove(struct 
>> platform_device *pdev)
>> 
>>   static const struct jz_soc_info jz4740_soc_info = {
>>   	.needs_dev_clk = true,
>>  +	.has_osd = false,
>>   	.max_width = 800,
>>   	.max_height = 600,
>>   };
>> 
>>   static const struct jz_soc_info jz4725b_soc_info = {
>>   	.needs_dev_clk = false,
>>  +	.has_osd = true,
>>   	.max_width = 800,
>>   	.max_height = 600,
>>   };
>> 
>>   static const struct jz_soc_info jz4770_soc_info = {
>>   	.needs_dev_clk = false,
>>  +	.has_osd = true,
>>   	.max_width = 1280,
>>   	.max_height = 720,
>>   };
>>  diff --git a/drivers/gpu/drm/ingenic/ingenic-drm.h 
>> b/drivers/gpu/drm/ingenic/ingenic-drm.h
>>  index cb578cff7bb1..d0b827a9fe83 100644
>>  --- a/drivers/gpu/drm/ingenic/ingenic-drm.h
>>  +++ b/drivers/gpu/drm/ingenic/ingenic-drm.h
>>  @@ -30,6 +30,18 @@
>>   #define JZ_REG_LCD_SA1				0x54
>>   #define JZ_REG_LCD_FID1				0x58
>>   #define JZ_REG_LCD_CMD1				0x5C
>>  +#define JZ_REG_LCD_OSDC				0x100
>>  +#define JZ_REG_LCD_OSDCTRL			0x104
>>  +#define JZ_REG_LCD_OSDS				0x108
>>  +#define JZ_REG_LCD_BGC				0x10c
>>  +#define JZ_REG_LCD_KEY0				0x110
>>  +#define JZ_REG_LCD_KEY1				0x114
>>  +#define JZ_REG_LCD_ALPHA			0x118
>>  +#define JZ_REG_LCD_IPUR				0x11c
>>  +#define JZ_REG_LCD_XYP0				0x120
>>  +#define JZ_REG_LCD_XYP1				0x124
>>  +#define JZ_REG_LCD_SIZE0			0x128
>>  +#define JZ_REG_LCD_SIZE1			0x12c
>> 
>>   #define JZ_LCD_CFG_SLCD				BIT(31)
>>   #define JZ_LCD_CFG_PS_DISABLE			BIT(23)
>>  @@ -123,4 +135,27 @@
>>   #define JZ_LCD_STATE_SOF_IRQ			BIT(4)
>>   #define JZ_LCD_STATE_DISABLED			BIT(0)
>> 
>>  +#define JZ_LCD_OSDC_OSDEN			BIT(0)
>>  +#define JZ_LCD_OSDC_F0EN			BIT(3)
>>  +#define JZ_LCD_OSDC_F1EN			BIT(4)
>>  +
>>  +#define JZ_LCD_OSDCTRL_IPU			BIT(15)
>>  +#define JZ_LCD_OSDCTRL_RGB555			BIT(4)
>>  +#define JZ_LCD_OSDCTRL_CHANGE			BIT(3)
>>  +#define JZ_LCD_OSDCTRL_BPP_15_16		0x4
>>  +#define JZ_LCD_OSDCTRL_BPP_18_24		0x5
>>  +#define JZ_LCD_OSDCTRL_BPP_30			0x7
>>  +#define JZ_LCD_OSDCTRL_BPP_MASK			(JZ_LCD_OSDCTRL_RGB555 | 0x7)
>>  +
>>  +#define JZ_LCD_OSDS_READY			BIT(0)
>>  +
>>  +#define JZ_LCD_IPUR_IPUREN			BIT(31)
>>  +#define JZ_LCD_IPUR_IPUR_LSB			0
>>  +
>>  +#define JZ_LCD_XYP01_XPOS_LSB			0
>>  +#define JZ_LCD_XYP01_YPOS_LSB			16
>>  +
>>  +#define JZ_LCD_SIZE01_WIDTH_LSB			0
>>  +#define JZ_LCD_SIZE01_HEIGHT_LSB		16
>>  +
>>   #endif /* DRIVERS_GPU_DRM_INGENIC_INGENIC_DRM_H */
>>  --
>>  2.27.0
>> 
>>  _______________________________________________
>>  dri-devel mailing list
>>  dri-devel@lists.freedesktop.org
>>  https://lists.freedesktop.org/mailman/listinfo/dri-devel



^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH v2 02/10] dt-bindings: display: Add ingenic,ipu.yaml
  2020-06-29 23:52 ` [PATCH v2 02/10] dt-bindings: display: Add ingenic,ipu.yaml Paul Cercueil
  2020-06-30 10:08   ` Sam Ravnborg
@ 2020-07-14  2:38   ` Rob Herring
  1 sibling, 0 replies; 22+ messages in thread
From: Rob Herring @ 2020-07-14  2:38 UTC (permalink / raw)
  To: Paul Cercueil
  Cc: Daniel Vetter, dri-devel, David Airlie, linux-mips, Rob Herring,
	linux-kernel, devicetree, od

On Tue, 30 Jun 2020 01:52:02 +0200, Paul Cercueil wrote:
> Add documentation of the Device Tree bindings for the Image Processing
> Unit (IPU) found in most Ingenic SoCs.
> 
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
> 
> Notes:
>     v2: Add missing 'const' in items list
> 
>  .../bindings/display/ingenic,ipu.yaml         | 65 +++++++++++++++++++
>  1 file changed, 65 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/ingenic,ipu.yaml
> 

Reviewed-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 22+ messages in thread

end of thread, back to index

Thread overview: 22+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-29 23:52 [PATCH v2 01/10] dt-bindings: display: Convert ingenic,lcd.txt to YAML Paul Cercueil
2020-06-29 23:52 ` [PATCH v2 02/10] dt-bindings: display: Add ingenic,ipu.yaml Paul Cercueil
2020-06-30 10:08   ` Sam Ravnborg
2020-07-14  2:38   ` Rob Herring
2020-06-29 23:52 ` [PATCH v2 03/10] drm/ingenic: Rename ingenic-drm.c to ingenic-drm-drv.c Paul Cercueil
2020-06-30 10:09   ` Sam Ravnborg
2020-06-29 23:52 ` [PATCH v2 04/10] drm/ingenic: Add missing CR in debug strings Paul Cercueil
2020-06-30 10:10   ` Sam Ravnborg
2020-06-29 23:52 ` [PATCH v2 05/10] drm/ingenic: Fix incorrect assumption about plane->index Paul Cercueil
2020-06-30 11:35   ` Sam Ravnborg
2020-06-29 23:52 ` [PATCH v2 06/10] drm/ingenic: Set DMA descriptor chain address in probe Paul Cercueil
2020-06-30 11:44   ` Sam Ravnborg
2020-06-30 11:54     ` Paul Cercueil
2020-06-29 23:52 ` [PATCH v2 07/10] drm/ingenic: Move register definitions to ingenic-drm.h Paul Cercueil
2020-06-30 11:46   ` Sam Ravnborg
2020-06-29 23:52 ` [PATCH v2 08/10] drm/ingenic: Add support for OSD mode Paul Cercueil
2020-06-30 12:05   ` Sam Ravnborg
2020-06-30 14:39     ` Paul Cercueil
2020-06-29 23:52 ` [PATCH v2 09/10] drm/ingenic: Add support for the IPU Paul Cercueil
2020-06-30 12:16   ` Sam Ravnborg
2020-06-30 13:33     ` Paul Cercueil
2020-06-29 23:52 ` [PATCH v2 10/10] drm/ingenic: Support multiple panels/bridges Paul Cercueil

Linux-MIPS Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-mips/0 linux-mips/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mips linux-mips/ https://lore.kernel.org/linux-mips \
		linux-mips@vger.kernel.org
	public-inbox-index linux-mips

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-mips


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git