From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Rafał Miłecki" <zajec5@gmail.com>,
linux-mips@vger.kernel.org,
"Vikas Gupta" <vikas.gupta@broadcom.com>
Cc: op-tee@lists.trustedfirmware.org
Subject: Re: [PATCH v1] firmware: tee_bnxt: Use UUID API for exporting the UUID
Date: Mon, 12 Oct 2020 20:24:14 +0300 [thread overview]
Message-ID: <20201012172414.GJ4077@smile.fi.intel.com> (raw)
In-Reply-To: <20200618105648.GP2428291@smile.fi.intel.com>
On Thu, Jun 18, 2020 at 01:56:48PM +0300, Andy Shevchenko wrote:
> On Wed, Apr 22, 2020 at 04:00:21PM +0300, Andy Shevchenko wrote:
> > There is export_uuid() function which exports uuid_t to the u8 array.
> > Use it instead of open coding variant.
> >
> > This allows to hide the uuid_t internals.
>
> Any comment on this?
Guys, who is going to pick this up?
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> > drivers/firmware/broadcom/tee_bnxt_fw.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/firmware/broadcom/tee_bnxt_fw.c b/drivers/firmware/broadcom/tee_bnxt_fw.c
> > index ed10da5313e86..4cf0c2576037d 100644
> > --- a/drivers/firmware/broadcom/tee_bnxt_fw.c
> > +++ b/drivers/firmware/broadcom/tee_bnxt_fw.c
> > @@ -197,7 +197,7 @@ static int tee_bnxt_fw_probe(struct device *dev)
> > return -ENODEV;
> >
> > /* Open session with Bnxt load Trusted App */
> > - memcpy(sess_arg.uuid, bnxt_device->id.uuid.b, TEE_IOCTL_UUID_LEN);
> > + export_uuid(sess_arg.uuid, &bnxt_device->id.uuid);
> > sess_arg.clnt_login = TEE_IOCTL_LOGIN_PUBLIC;
> > sess_arg.num_params = 0;
> >
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2020-10-12 17:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 13:00 [PATCH v1] firmware: tee_bnxt: Use UUID API for exporting the UUID Andy Shevchenko
2020-06-18 10:56 ` Andy Shevchenko
2020-10-12 17:24 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201012172414.GJ4077@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linux-mips@vger.kernel.org \
--cc=op-tee@lists.trustedfirmware.org \
--cc=vikas.gupta@broadcom.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).