From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 022BCC433E7 for ; Mon, 12 Oct 2020 18:26:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9ADF22072C for ; Mon, 12 Oct 2020 18:26:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="E8lSY0wI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729603AbgJLS0g (ORCPT ); Mon, 12 Oct 2020 14:26:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726636AbgJLS0g (ORCPT ); Mon, 12 Oct 2020 14:26:36 -0400 Received: from mail-ot1-x341.google.com (mail-ot1-x341.google.com [IPv6:2607:f8b0:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1CC5EC0613D0; Mon, 12 Oct 2020 11:26:36 -0700 (PDT) Received: by mail-ot1-x341.google.com with SMTP id m11so16650903otk.13; Mon, 12 Oct 2020 11:26:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=CPoNtINkiZ+7KuJY1WByRUBiNHJzT75R36q7xH6eWUw=; b=E8lSY0wI4diAL2HRosgbWh0rGrIHSK/AK1QiuMdegq/L90Sy4+QEAOvdrs9138vaxv zQyzsr5CrQfOXa/krbPPVGkLRIScl0BoXLSMxsO8nH+6Bw92PDYnwvLDDSRrH+woHKk8 IEhaJL04XBMXe6iFbG/zSMqegtrkB5EhYgrUkgy2PkT+1hph/MOsFfy9IJgCQNafYzG7 RLI9qqH2/pbN3Kb1zgfw3Ov9htJs6mtU63MothRJjXLlptCtZMflMHg7etxnrXPGr6Nt /62qorhKq9ubOa5se+0fYj1Fz5HSShoSnH20aAHEJ754b099x7eYok3q9X6EHdO4myCe YjXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=CPoNtINkiZ+7KuJY1WByRUBiNHJzT75R36q7xH6eWUw=; b=BlVpNnbryQgrrQigPJaOKekVr5mlTqU9+LJwRYUxFb443ZF/93EV5bdE+pvMMveSPY UDeP+yVC6YLz6yYRhBGUfrrylc6Kwg2Dnp2pAOIY37IQX1Lt46NiGvHrCCkrkJ8c1HgW wIgUjb9ygViJ3u4ftRBGG5D7ba/58CCA4NdPBN/wQqvXhHwIx952xAQaOUCImpAscxlR QEt5fvf6dxUdovp1GtcL6HCNF0tDIXGl1lIRYe/wGKVjH3i3f4htBAwh1YjH+yDaejtS CM5VPnLFwB+OL7zkPdA2WJMFzf2DzqVTNyWjK6leMhtrAeVA/lU+/odfwoTXIvvdWhQg IuzA== X-Gm-Message-State: AOAM532LgKHX7bTPAlMPmEf0dzybF44w7YL7EUlnHv3tb9gcv2fLo6og lkfiXDHdkf4e95Wo4eUIqdA= X-Google-Smtp-Source: ABdhPJys+v4WYfCKgs37iJSnXFMBvay3R5Xctbhyvx+DCBuNCzwiYewoW4MY1hbgYoWmnEOZJ7hw2Q== X-Received: by 2002:a05:6830:22f1:: with SMTP id t17mr18234327otc.239.1602527195490; Mon, 12 Oct 2020 11:26:35 -0700 (PDT) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id u22sm10612987oor.13.2020.10.12.11.26.34 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 12 Oct 2020 11:26:34 -0700 (PDT) Sender: Guenter Roeck Date: Mon, 12 Oct 2020 11:26:33 -0700 From: Guenter Roeck To: Paul Cercueil Cc: Thomas Bogendoerfer , "Maciej W . Rozycki" , Paul Burton , Zhou Yanjie , od@zcrc.me, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org Subject: Re: [PATCH v3 11/15] MIPS: generic: Add support for Ingenic SoCs Message-ID: <20201012182633.GA117683@roeck-us.net> References: <20200906192935.107086-1-paul@crapouillou.net> <20200906192935.107086-12-paul@crapouillou.net> <20201012143319.GA24291@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Mon, Oct 12, 2020 at 04:59:01PM +0200, Paul Cercueil wrote: > Hi Guenter, > > Le lun. 12 oct. 2020 à 7:33, Guenter Roeck a écrit : > > On Sun, Sep 06, 2020 at 09:29:31PM +0200, Paul Cercueil wrote: > > > Add support for Ingenic SoCs in arch/mips/generic/. > > > > > > The Kconfig changes are here to ensure that it is possible to > > > compile > > > either a generic kernel that supports Ingenic SoCs, or a > > > Ingenic-only > > > kernel, both using the same code base, to avoid duplicated code. > > > > > > Signed-off-by: Paul Cercueil > > > > This patch results in the following build error (mips:allmodconfig). > > > > In file included from : > > arch/mips/mm/init.c: In function 'mem_init': > > include/linux/compiler_types.h:319:38: error: call to > > '__compiletime_assert_331' > > declared with attribute error: BUILD_BUG_ON failed: > > IS_ENABLED(CONFIG_32BIT) && (_PFN_SHIFT > PAGE_SHIFT) > > > > Bisect log attached. > > This doesn't seem to be something that was added with this patch. This > COMPILE_BUG_ON() has been here for quite some time... I'm not sure why it > triggers now. > Reverting the offending patch from next-20201009 fixes the problem (after fixing a context conflict). > The mips:allmodconfig works here as long as I switch to CPU_LITTLE_ENDIAN > (no big-endian compiler). But I'm at a different HEAD, and I can't find > commit d67bc7812221606e1886620a357b13f906814af7 anywhere, in which repo is > that found? > d67bc7812221606e1886620a357b13f906814af7 is the tip of next-20201009. The key difference is that the code in linux-next sets CONFIG_CPU_SUPPORTS_HUGEPAGES=y and enables CONFIG_MIPS_HUGE_TLB_SUPPORT. This was not previously the case, and was added/enabled with your patch. As result, _CACHE_SHIFT and with it _PFN_SHIFT is one larger than in mainline, which seems sufficient to trigger the problem. Underlying change is that CONFIG_MACH_INGENIC was not set with mips:allmodconfig prior to your patch, but it is now set. Guenter > Cheers, > -Paul > > > --- > > # bad: [d67bc7812221606e1886620a357b13f906814af7] Add linux-next > > specific files for 20201009 > > # good: [549738f15da0e5a00275977623be199fbbf7df50] Linux 5.9-rc8 > > git bisect start 'HEAD' 'v5.9-rc8' > > # bad: [b71be15b496cc71a3434a198fc1a1b9e08af6c57] Merge remote-tracking > > branch 'bpf-next/master' into master > > git bisect bad b71be15b496cc71a3434a198fc1a1b9e08af6c57 > > # bad: [6be11f939f380ef14bc94242cb0262197ce2a054] Merge remote-tracking > > branch 'i2c/i2c/for-next' into master > > git bisect bad 6be11f939f380ef14bc94242cb0262197ce2a054 > > # good: [c03a115d8ad8a87b6d275c3c91c13bc111217bf6] Merge remote-tracking > > branch 'samsung-krzk/for-next' into master > > git bisect good c03a115d8ad8a87b6d275c3c91c13bc111217bf6 > > # bad: [bdd0ef71b0d7d6a8f1d59af57dc73d19ddc26ad0] Merge remote-tracking > > branch 'f2fs/dev' into master > > git bisect bad bdd0ef71b0d7d6a8f1d59af57dc73d19ddc26ad0 > > # bad: [0c4bd40a7ccd06122c1942f525b714abcd9efe36] Merge remote-tracking > > branch 'powerpc/next' into master > > git bisect bad 0c4bd40a7ccd06122c1942f525b714abcd9efe36 > > # bad: [744d2c114d58c11fd76d572021d7ef3c55a1a225] Merge remote-tracking > > branch 'nds32/next' into master > > git bisect bad 744d2c114d58c11fd76d572021d7ef3c55a1a225 > > # good: [1e9f9330cea616f9f2baf8144f049e4b405715dd] Merge remote-tracking > > branch 'csky/linux-next' into master > > git bisect good 1e9f9330cea616f9f2baf8144f049e4b405715dd > > # bad: [b350041e6f23a71f63f1eee6d939c846838e7e25] MIPS: alchemy: remove > > unused ALCHEMY_GPIOINT_AU1000 > > git bisect bad b350041e6f23a71f63f1eee6d939c846838e7e25 > > # good: [43df4eb2fc9511e09c66252c3fec4f8933a77c73] MIPS: Replace > > SIBYTE_1956_WAR by CONFIG_SB1_PASS_2_WORKAROUNDS > > git bisect good 43df4eb2fc9511e09c66252c3fec4f8933a77c73 > > # good: [13a0ea28e8c698cc0d600fdeed8da3e4d478b97e] MIPS: generic: Init > > command line with fw_init_cmdline() > > git bisect good 13a0ea28e8c698cc0d600fdeed8da3e4d478b97e > > # bad: [d41afc398fbc9dfb8c40b951e97a7f0283346c6a] MAINTAINERS: Update > > paths to Ingenic platform code > > git bisect bad d41afc398fbc9dfb8c40b951e97a7f0283346c6a > > # bad: [f0f4a753079c636d5d43a102edbde0dad1e7de51] MIPS: generic: Add > > support for Ingenic SoCs > > git bisect bad f0f4a753079c636d5d43a102edbde0dad1e7de51 > > # good: [c3e2ee657418f4f2bff1269c0550f8135ed0c927] MIPS: generic: Add > > support for zboot > > git bisect good c3e2ee657418f4f2bff1269c0550f8135ed0c927 > > # good: [02bd530f888c6d6ba4995c3afcd10f87c136f173] MIPS: generic: > > Increase NR_IRQS to 256 > > git bisect good 02bd530f888c6d6ba4995c3afcd10f87c136f173 > > # first bad commit: [f0f4a753079c636d5d43a102edbde0dad1e7de51] MIPS: > > generic: Add support for Ingenic SoCs > >