Linux-MIPS Archive on lore.kernel.org
 help / color / Atom feed
* Re: [PATCH] MIPS: ingenic: Remove CPU_SUPPORTS_HUGEPAGES
@ 2020-10-12 19:37 Guenter Roeck
  0 siblings, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2020-10-12 19:37 UTC (permalink / raw)
  To: Paul Cercueil
  Cc: Thomas Bogendoerfer, Maciej W . Rozycki, Paul Burton,
	Zhou Yanjie, od, linux-kernel, linux-mips

On Mon, Oct 12, 2020 at 09:27:39PM +0200, Paul Cercueil wrote:
> While it is true that Ingenic SoCs support huge pages, we cannot use
> them yet as PTEs don't have any single bit that is free. Right now,
> having that symbol only causes build errors, so remove it until the
> situation with PTEs is resolved.
> 
> Fixes: f0f4a753079c ("MIPS: generic: Add support for Ingenic SoCs")
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Tested-by: Guenter Roeck <linux@roeck-us.net>

> ---
>  arch/mips/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index f52fa211a4cf..29bad5bd3e70 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -103,7 +103,6 @@ config MACH_INGENIC
>  	select SYS_SUPPORTS_32BIT_KERNEL
>  	select SYS_SUPPORTS_LITTLE_ENDIAN
>  	select SYS_SUPPORTS_ZBOOT
> -	select CPU_SUPPORTS_HUGEPAGES
>  	select DMA_NONCOHERENT
>  	select IRQ_MIPS_CPU
>  	select PINCTRL
> -- 
> 2.28.0
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] MIPS: ingenic: Remove CPU_SUPPORTS_HUGEPAGES
  2020-10-12 19:27 ` [PATCH] MIPS: ingenic: Remove CPU_SUPPORTS_HUGEPAGES Paul Cercueil
@ 2020-10-13  9:31   ` Thomas Bogendoerfer
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Bogendoerfer @ 2020-10-13  9:31 UTC (permalink / raw)
  To: Paul Cercueil
  Cc: Guenter Roeck, Maciej W . Rozycki, Paul Burton, Zhou Yanjie, od,
	linux-kernel, linux-mips

On Mon, Oct 12, 2020 at 09:27:39PM +0200, Paul Cercueil wrote:
> While it is true that Ingenic SoCs support huge pages, we cannot use
> them yet as PTEs don't have any single bit that is free. Right now,
> having that symbol only causes build errors, so remove it until the
> situation with PTEs is resolved.
> 
> Fixes: f0f4a753079c ("MIPS: generic: Add support for Ingenic SoCs")
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
>  arch/mips/Kconfig | 1 -
>  1 file changed, 1 deletion(-)

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] MIPS: ingenic: Remove CPU_SUPPORTS_HUGEPAGES
  2020-10-12 14:33 [PATCH v3 11/15] MIPS: generic: Add support for Ingenic SoCs Guenter Roeck
@ 2020-10-12 19:27 ` Paul Cercueil
  2020-10-13  9:31   ` Thomas Bogendoerfer
  0 siblings, 1 reply; 3+ messages in thread
From: Paul Cercueil @ 2020-10-12 19:27 UTC (permalink / raw)
  To: Guenter Roeck
  Cc: Thomas Bogendoerfer, Maciej W . Rozycki, Paul Burton,
	Zhou Yanjie, od, linux-kernel, linux-mips, Paul Cercueil

While it is true that Ingenic SoCs support huge pages, we cannot use
them yet as PTEs don't have any single bit that is free. Right now,
having that symbol only causes build errors, so remove it until the
situation with PTEs is resolved.

Fixes: f0f4a753079c ("MIPS: generic: Add support for Ingenic SoCs")
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
 arch/mips/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index f52fa211a4cf..29bad5bd3e70 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -103,7 +103,6 @@ config MACH_INGENIC
 	select SYS_SUPPORTS_32BIT_KERNEL
 	select SYS_SUPPORTS_LITTLE_ENDIAN
 	select SYS_SUPPORTS_ZBOOT
-	select CPU_SUPPORTS_HUGEPAGES
 	select DMA_NONCOHERENT
 	select IRQ_MIPS_CPU
 	select PINCTRL
-- 
2.28.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-12 19:37 [PATCH] MIPS: ingenic: Remove CPU_SUPPORTS_HUGEPAGES Guenter Roeck
  -- strict thread matches above, loose matches on Subject: below --
2020-10-12 14:33 [PATCH v3 11/15] MIPS: generic: Add support for Ingenic SoCs Guenter Roeck
2020-10-12 19:27 ` [PATCH] MIPS: ingenic: Remove CPU_SUPPORTS_HUGEPAGES Paul Cercueil
2020-10-13  9:31   ` Thomas Bogendoerfer

Linux-MIPS Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-mips/0 linux-mips/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mips linux-mips/ https://lore.kernel.org/linux-mips \
		linux-mips@vger.kernel.org
	public-inbox-index linux-mips

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-mips


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git