From: Serge Semin <fancer.lancer@gmail.com>
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] MIPS: DEC: Restore bootmem reservation for firmware working memory area
Date: Wed, 14 Oct 2020 21:01:14 +0300 [thread overview]
Message-ID: <20201014180114.fnz5ewt2tzkgxin4@mobilestation> (raw)
In-Reply-To: <alpine.LFD.2.21.2010141123010.866917@eddie.linux-mips.org>
Hello Maciej,
On Wed, Oct 14, 2020 at 12:10:09PM +0100, Maciej W. Rozycki wrote:
> Fix a crash on DEC platforms starting with:
>
...
> @@ -146,6 +150,9 @@ void __init plat_mem_setup(void)
>
> ioport_resource.start = ~0UL;
> ioport_resource.end = 0UL;
> +
> + /* Stay away from the firmware working memory area for now. */
> + memblock_reserve(PHYS_OFFSET, __pa_symbol(&_text));
Shouldn't that be:
+ memblock_reserve(PHYS_OFFSET, __pa_symbol(&_text) - PHYS_OFFSET);
instead?
-Sergey
> }
>
> /*
>
next prev parent reply other threads:[~2020-10-14 18:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 11:10 [PATCH] MIPS: DEC: Restore bootmem reservation for firmware working memory area Maciej W. Rozycki
2020-10-14 18:01 ` Serge Semin [this message]
2020-10-14 20:53 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201014180114.fnz5ewt2tzkgxin4@mobilestation \
--to=fancer.lancer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=macro@linux-mips.org \
--cc=stable@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).