From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43A9CC433E7 for ; Wed, 14 Oct 2020 21:23:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D5685221FF for ; Wed, 14 Oct 2020 21:23:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730612AbgJNVXK (ORCPT ); Wed, 14 Oct 2020 17:23:10 -0400 Received: from mail.baikalelectronics.com ([87.245.175.226]:50576 "EHLO mail.baikalelectronics.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727403AbgJNVXK (ORCPT ); Wed, 14 Oct 2020 17:23:10 -0400 Received: from localhost (unknown [127.0.0.1]) by mail.baikalelectronics.ru (Postfix) with ESMTP id 12B99803073C; Wed, 14 Oct 2020 21:23:06 +0000 (UTC) X-Virus-Scanned: amavisd-new at baikalelectronics.ru Received: from mail.baikalelectronics.ru ([127.0.0.1]) by localhost (mail.baikalelectronics.ru [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id inYRWRerfTBc; Thu, 15 Oct 2020 00:23:05 +0300 (MSK) Date: Thu, 15 Oct 2020 00:22:59 +0300 From: Serge Semin To: Rob Herring CC: Serge Semin , Felipe Balbi , Mathias Nyman , Greg Kroah-Hartman , Jason Cooper , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Kukjin Kim , Krzysztof Kozlowski , Santosh Shilimkar , Shawn Guo , Li Yang , =?utf-8?Q?Beno=C3=AEt?= Cousson , Tony Lindgren , Patrice Chotard , Maxime Ripard , Chen-Yu Tsai , Wei Xu , Andy Gross , Bjorn Andersson , Alexey Malahov , Pavel Parkhomenko , Manu Gautam , Roger Quadros , Lad Prabhakar , Yoshihiro Shimoda , Neil Armstrong , Kevin Hilman , linux-arm-kernel , arcml , "open list:MIPS" , linuxppc-dev , Linux USB List , , "linux-kernel@vger.kernel.org" , linux-samsung-soc , linux-omap , linux-arm-msm Subject: Re: [PATCH 20/20] arch: dts: Fix DWC USB3 DT nodes name Message-ID: <20201014212259.ltckcgz2yrola7za@mobilestation> References: <20201014101402.18271-1-Sergey.Semin@baikalelectronics.ru> <20201014101402.18271-21-Sergey.Semin@baikalelectronics.ru> <878sc8lx0e.fsf@kernel.org> <20201014143720.yny3jco5pkb7dr4b@mobilestation> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: MAIL.baikal.int (192.168.51.25) To mail (192.168.51.25) Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Wed, Oct 14, 2020 at 01:35:16PM -0500, Rob Herring wrote: > On Wed, Oct 14, 2020 at 9:37 AM Serge Semin > wrote: > > > > On Wed, Oct 14, 2020 at 05:09:37PM +0300, Felipe Balbi wrote: > > > > > > Hi Serge, > > > > > > Serge Semin writes: > > > > In accordance with the DWC USB3 bindings the corresponding node name is > > > > suppose to comply with Generic USB HCD DT schema, which requires the USB > > > > > > > > DWC3 is not a simple HDC, though. > > > > Yeah, strictly speaking it is equipped with a lot of vendor-specific stuff, > > which are tuned by the DWC USB3 driver in the kernel. But after that the > > controller is registered as xhci-hcd device so it's serviced by the xHCI driver, > > which then registers the HCD device so the corresponding DT node is supposed > > to be compatible with the next bindings: usb/usb-hcd.yaml, usb/usb-xhci.yaml > > and usb/snps,dwc3,yaml. I've created the later one so to validate the denoted > > compatibility. > > > > > > > > > nodes to have the name acceptable by the regexp: "^usb(@.*)?" . But a lot > > > > of the DWC USB3-compatible nodes defined in the ARM/ARM64 DTS files have > > > > name as "^dwc3@.*" or "^usb[1-3]@.*" or even "^dwusb@.*", which will cause > > > > the dtbs_check procedure failure. Let's fix the nodes naming to be > > > > compatible with the DWC USB3 DT schema to make dtbs_check happy. > > > > > > > > Note we don't change the DWC USB3-compatible nodes names of > > > > arch/arm64/boot/dts/apm/{apm-storm.dtsi,apm-shadowcat.dtsi} since the > > > > in-source comment says that the nodes name need to be preserved as > > > > "^dwusb@.*" for some backward compatibility. > > > > > > > > interesting, compatibility with what? Some debugfs files, perhaps? :-) > > > > Don't really know.) In my experience the worst type of such compatibility is > > connected with some bootloader magic, which may add/remove/modify properties > > to nodes with pre-defined names. > > I seriously doubt anyone is using the APM machines with DT (even ACPI > is somewhat doubtful). I say change them. Or remove the dts files and > see what happens. Either way it can always be reverted. Ok. I'll change them in v3. -Sergey > > Rob