From: Alexander Lobakin <alobakin@pm.me>
To: Nathan Chancellor <natechancellor@gmail.com>
Cc: Alexander Lobakin <alobakin@pm.me>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Kees Cook <keescook@chromium.org>, Ingo Molnar <mingo@kernel.org>,
Fangrui Song <maskray@google.com>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Ralf Baechle <ralf@linux-mips.org>,
Alex Smith <alex.smith@imgtec.com>,
Markos Chandras <markos.chandras@imgtec.com>,
linux-mips@vger.kernel.org, stable@vger.kernel.org,
linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com
Subject: Re: [PATCH mips-next 0/4] MIPS: vmlinux.lds.S sections fix & cleanup
Date: Wed, 06 Jan 2021 20:14:22 +0000 [thread overview]
Message-ID: <20210106201400.32416-1-alobakin@pm.me> (raw)
In-Reply-To: <20210104121729.46981-1-alobakin@pm.me>
From: Nathan Chancellor <natechancellor@gmail.com>
Date: Mon, 4 Jan 2021 17:09:36 -0700
> On Mon, Jan 04, 2021 at 12:18:10PM +0000, Alexander Lobakin wrote:
>> This series hunts the problems discovered after manual enabling of
>> ARCH_WANT_LD_ORPHAN_WARN, notably the missing PAGE_ALIGNED_DATA()
>> section affecting VDSO placement (marked for stable).
>>
>> Compile and runtime tested on MIPS32R2 CPS board with no issues.
>>
>> Alexander Lobakin (4):
>> MIPS: vmlinux.lds.S: add missing PAGE_ALIGNED_DATA() section
>> MIPS: vmlinux.lds.S: add ".rel.dyn" to DISCARDS
>> MIPS: vmlinux.lds.S: add ".gnu.attributes" to DISCARDS
>> MIPS: select ARCH_WANT_LD_ORPHAN_WARN
>>
>> arch/mips/Kconfig | 1 +
>> arch/mips/kernel/vmlinux.lds.S | 5 ++++-
>> 2 files changed, 5 insertions(+), 1 deletion(-)
>>
>> --
>> 2.30.0
>>
>
> Glad to see ARCH_WANT_LD_ORPHAN_WARN catching on :)
>
> I took this for a spin with clang with malta_kvm_guest_defconfig and I
> only see one section unaccounted for:
>
> $ make -skj"$(nproc)" ARCH=mips CROSS_COMPILE=mipsel-linux-gnu- LLVM=1 O=out/mips distclean malta_kvm_guest_defconfig all
> ...
> ld.lld: warning: <internal>:(.got) is being placed in '.got'
> ld.lld: warning: <internal>:(.got) is being placed in '.got'
> ld.lld: warning: <internal>:(.got) is being placed in '.got'
>
> Looks like most architectures place it in .got (ia64, nios2, powerpc)
> or .text (arm64).
Addressed in v2, thanks!
> Cheers,
> Nathan
Al
prev parent reply other threads:[~2021-01-06 20:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-04 12:18 [PATCH mips-next 0/4] MIPS: vmlinux.lds.S sections fix & cleanup Alexander Lobakin
2021-01-04 12:20 ` [PATCH mips-next 1/4] MIPS: vmlinux.lds.S: add missing PAGE_ALIGNED_DATA() section Alexander Lobakin
2021-01-04 12:20 ` [PATCH mips-next 2/4] MIPS: vmlinux.lds.S: add ".rel.dyn" to DISCARDS Alexander Lobakin
2021-01-05 7:39 ` Fāng-ruì Sòng
2021-01-05 8:59 ` Jiaxun Yang
2021-01-04 12:20 ` [PATCH mips-next 3/4] MIPS: vmlinux.lds.S: add ".gnu.attributes" " Alexander Lobakin
2021-01-04 12:20 ` [PATCH mips-next 4/4] MIPS: select ARCH_WANT_LD_ORPHAN_WARN Alexander Lobakin
2021-01-05 0:09 ` [PATCH mips-next 0/4] MIPS: vmlinux.lds.S sections fix & cleanup Nathan Chancellor
2021-01-06 20:14 ` Alexander Lobakin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210106201400.32416-1-alobakin@pm.me \
--to=alobakin@pm.me \
--cc=alex.smith@imgtec.com \
--cc=clang-built-linux@googlegroups.com \
--cc=jiaxun.yang@flygoat.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=markos.chandras@imgtec.com \
--cc=maskray@google.com \
--cc=mingo@kernel.org \
--cc=natechancellor@gmail.com \
--cc=ralf@linux-mips.org \
--cc=stable@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).