From: Lauri Kasanen <cand@gmx.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: linux-mips@vger.kernel.org, tsbogend@alpha.franken.de,
perex@perex.cz, tiwai@suse.com
Subject: Re: [PATCH 5/6 v2] sound: Add n64 driver
Date: Sat, 9 Jan 2021 09:23:03 +0200 [thread overview]
Message-ID: <20210109092303.b9a2a2f678a5d1b19b7f27f3@gmx.com> (raw)
In-Reply-To: <s5hsg7byezb.wl-tiwai@suse.de>
Hi,
On Fri, 08 Jan 2021 10:06:48 +0100
Takashi Iwai <tiwai@suse.de> wrote:
> > +static const struct snd_pcm_hardware n64audio_pcm_hw = {
> > + .info = (SNDRV_PCM_INFO_MMAP |
> > + SNDRV_PCM_INFO_MMAP_VALID |
> > + SNDRV_PCM_INFO_INTERLEAVED |
> > + SNDRV_PCM_INFO_BLOCK_TRANSFER),
> > + .formats = SNDRV_PCM_FMTBIT_S16_BE,
> > + .rates = SNDRV_PCM_RATE_8000_48000,
> > + .rate_min = 8000,
> > + .rate_max = 48000,
> > + .channels_min = 2,
> > + .channels_max = 2,
> > + .buffer_bytes_max = 32768,
> > + .period_bytes_min = 1024,
> > + .period_bytes_max = 32768,
> > + .periods_min = 1,
>
> periods_min=1 makes little sense for this driver.
I have some questions about this.
When I had periods_min = 128, OSS apps were broken. I mean simple ones,
open /dev/dsp, ioctl the format/rate/stereo, write data. They got an IO
error errno IIRC, and no clarifying error in dmesg.
I tried following the error with printks, several levels deep. I gave
up when it got to the constraint resolving function, and there was no
good way to print and track which constraint failed, why, and who set
the constraint.
Only through blind guessing did I stumble upon periods_min.
- why did it break OSS apps?
- how does the OSS layer interact with periods? I didn't find any "set
period" ioctl
- why was there no clarifying error in dmesg? Just an errno that means
a million things makes it impossible for the userspace app writer to
know why it's not working
- Lauri
next prev parent reply other threads:[~2021-01-09 7:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 8:35 [PATCH 5/6 v2] sound: Add n64 driver Lauri Kasanen
2021-01-08 9:06 ` Takashi Iwai
2021-01-08 10:13 ` Lauri Kasanen
2021-01-09 7:23 ` Lauri Kasanen [this message]
2021-01-09 8:16 ` Takashi Iwai
2021-01-09 17:46 ` Lauri Kasanen
2021-01-09 18:17 ` Takashi Iwai
2021-01-09 20:54 ` Takashi Iwai
2021-01-10 7:15 ` Lauri Kasanen
2021-01-10 10:24 ` Takashi Iwai
2021-01-10 17:03 ` Lauri Kasanen
2021-01-10 17:22 ` Takashi Iwai
2021-01-10 17:41 ` Lauri Kasanen
2021-01-11 8:05 ` Takashi Iwai
2021-01-11 9:43 ` Lauri Kasanen
2021-01-11 10:11 ` Takashi Iwai
2021-01-11 12:02 ` Lauri Kasanen
2021-01-11 15:25 ` Takashi Iwai
2021-01-11 15:51 ` Lauri Kasanen
2021-01-13 11:57 ` Lauri Kasanen
2021-01-13 12:04 ` Takashi Iwai
2021-01-13 12:14 ` Lauri Kasanen
2021-01-13 12:38 ` Takashi Iwai
2021-01-13 12:49 ` Lauri Kasanen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210109092303.b9a2a2f678a5d1b19b7f27f3@gmx.com \
--to=cand@gmx.com \
--cc=linux-mips@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).