From: Christoph Hellwig <hch@lst.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Christoph Hellwig <hch@lst.de>,
Andrew Morton <akpm@linux-foundation.org>,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
Russell King <linux@armlinux.org.uk>, Guo Ren <guoren@kernel.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Nick Hu <nickhu@andestech.com>, Greentime Hu <green.hu@gmail.com>,
Vincent Chen <deanbo422@gmail.com>, Helge Deller <deller@gmx.de>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>, Geoff Levand <geoff@infradead.org>,
Paul Cercueil <paul@crapouillou.net>,
Ulf Hansson <ulf.hansson@linaro.org>, Alex Shi <alexs@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-csky@vger.kernel.org,
"open list:BROADCOM NVRAM DRIVER" <linux-mips@vger.kernel.org>,
linux-parisc@vger.kernel.org,
Linux-sh list <linux-sh@vger.kernel.org>,
linux-mmc@vger.kernel.org,
linux-scsi <linux-scsi@vger.kernel.org>,
Linux-MM <linux-mm@kvack.org>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>
Subject: Re: flush_kernel_dcache_page fixes and removal
Date: Tue, 13 Jul 2021 07:46:06 +0200 [thread overview]
Message-ID: <20210713054606.GA6036@lst.de> (raw)
In-Reply-To: <CAHk-=whd0GaAH7gHuEiuKjOeD6JGKY1q5ydG1TCKjVBFNBUEJA@mail.gmail.com>
On Mon, Jul 12, 2021 at 12:24:11PM -0700, Linus Torvalds wrote:
> I think architectures that have virtual caches might want to think
> about this patch a bit more, but on the whole I can't argue against
> the "it's badly documented and misused".
>
> No sane architecture will care, since dcache will be coherent (there
> are more issues on the I$ side, but that's a different issue)
Yeah. Once the arch maintainers look it it it might be worth to check
if there is optimization potential for pages that are not in highmem
and not in the page cache, as most architectures should be able to
just do nothing in that case.
Either way, I think getting patches 1-4 into 5.14 as bug fixes would
be useful, 6 is a trivial cleanup and 5 is something we can chew on
for a bit.
next prev parent reply other threads:[~2021-07-13 5:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-12 6:09 flush_kernel_dcache_page fixes and removal Christoph Hellwig
2021-07-12 6:09 ` [PATCH 1/6] mmc: JZ4740: remove the flush_kernel_dcache_page call in jz4740_mmc_read_data Christoph Hellwig
2021-07-19 8:15 ` Paul Cercueil
2021-08-04 11:12 ` Ulf Hansson
2021-07-12 6:09 ` [PATCH 2/6] mmc: mmc_spi: replace flush_kernel_dcache_page with flush_dcache_page Christoph Hellwig
2021-08-04 11:12 ` Ulf Hansson
2021-07-12 6:09 ` [PATCH 3/6] ps3disk: " Christoph Hellwig
2021-07-19 3:07 ` Geoff Levand
2021-07-12 6:09 ` [PATCH 4/6] scatterlist: " Christoph Hellwig
2021-07-12 6:09 ` [PATCH 5/6] aacraid: remove an unused include Christoph Hellwig
2021-07-19 1:50 ` Martin K. Petersen
2021-07-12 6:09 ` [PATCH 6/6] mm: remove flush_kernel_dcache_page Christoph Hellwig
2021-07-12 23:56 ` Ira Weiny
2021-07-12 19:24 ` flush_kernel_dcache_page fixes and removal Linus Torvalds
2021-07-13 5:46 ` Christoph Hellwig [this message]
2021-07-13 8:46 ` Russell King (Oracle)
2021-07-13 9:11 ` Christoph Hellwig
2021-07-19 5:38 ` Herbert Xu
2021-07-19 15:42 ` Russell King (Oracle)
2021-07-14 3:13 ` Guo Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210713054606.GA6036@lst.de \
--to=hch@lst.de \
--cc=James.Bottomley@hansenpartnership.com \
--cc=akpm@linux-foundation.org \
--cc=alexs@kernel.org \
--cc=dalias@libc.org \
--cc=deanbo422@gmail.com \
--cc=deller@gmx.de \
--cc=geoff@infradead.org \
--cc=green.hu@gmail.com \
--cc=guoren@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=nickhu@andestech.com \
--cc=paul@crapouillou.net \
--cc=torvalds@linux-foundation.org \
--cc=tsbogend@alpha.franken.de \
--cc=ulf.hansson@linaro.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).