From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B65AC63798 for ; Thu, 22 Jul 2021 12:49:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 12FEE6136D for ; Thu, 22 Jul 2021 12:49:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231927AbhGVMIZ (ORCPT ); Thu, 22 Jul 2021 08:08:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:60728 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231838AbhGVMIS (ORCPT ); Thu, 22 Jul 2021 08:08:18 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6B77A61285; Thu, 22 Jul 2021 12:48:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626958132; bh=PX46ntR2F8mhtnTnqk6z0maUFKW3hKlsYGyDxWq8nt8=; h=From:To:Cc:Subject:Date:From; b=uI8fZsAnCujH8W7YiEBRgCAjHShI6gE1mvUR0l57R+InmBX0WanZ/uw9vRAOln3Z8 nGIW49oPfs3Z0oGoceXArCb+pcxtHVC7BDgIPVu7ZQgOSXVYcpE0fh0cemOAHYvVRq FKI2JY1Q7ji5J3em2CfLjWBtEWHTWOWxHMmXXgWyndwrPSlVntSikFKkr25MPmfWRd v73iMcJt52+PkD+rdPNKZ3PKisAXpGa6fQ8OZroEymMb7Gi2et/DUC63IcI09aav3H 3ECp+pAFmA7kucS8vsrWJ92J66Z8gjShxT5O7vJdnqnBEe0ThenTNBxBPkUxQ1dKDS brNKF2Qpg7HWw== From: Arnd Bergmann To: linux-arch@vger.kernel.org Cc: Arnd Bergmann , "James E.J. Bottomley" , Al Viro , Anton Ivanov , Brian Cain , Chris Zankel , Christian Borntraeger , Christoph Hellwig , Guo Ren , Heiko Carstens , Helge Deller , Jeff Dike , Linus Walleij , Max Filippov , Michal Simek , Richard Weinberger , Thomas Bogendoerfer , Vasily Gorbik , Vineet Gupta , Yoshinori Sato , linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-s390@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, uclinux-h8-devel@lists.sourceforge.jp Subject: [PATCH v3 0/6] asm-generic: strncpy_from_user/strnlen_user cleanup Date: Thu, 22 Jul 2021 14:48:05 +0200 Message-Id: <20210722124814.778059-1-arnd@kernel.org> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org From: Arnd Bergmann I had run into some regressions for the previous version of this series, the new version is based on v5.14-rc2 instead. These two functions appear to be unnecessarily different between architectures, and the asm-generic version is a bit questionable, even for NOMMU architectures. Clean this up to just use the generic library version for anything that uses the generic version today. I've expanded on the patch descriptions a little, as suggested by Christoph Hellwig, but I suspect a more detailed review would uncover additional problems with the custom versions that are getting removed. I ended up adding patches for csky and microblaze as they had the same implementation that I removed elsewhere, these are now gone as well. If I hear no objections from architecture maintainers or new build regressions, I'll queue these up in the asm-generic tree for 5.15. Arnd Link: https://lore.kernel.org/linux-arch/20210515101803.924427-1-arnd@kernel.org/ Arnd Bergmann (9): asm-generic/uaccess.h: remove __strncpy_from_user/__strnlen_user h8300: remove stale strncpy_from_user hexagon: use generic strncpy/strnlen from_user arc: use generic strncpy/strnlen from_user csky: use generic strncpy/strnlen from_user microblaze: use generic strncpy/strnlen from_user asm-generic: uaccess: remove inline strncpy_from_user/strnlen_user asm-generic: remove extra strn{cpy_from,len}_user declarations asm-generic: reverse GENERIC_{STRNCPY_FROM,STRNLEN}_USER symbols arch/alpha/Kconfig | 2 - arch/arc/include/asm/uaccess.h | 72 ------------- arch/arc/mm/extable.c | 12 --- arch/arm/Kconfig | 2 - arch/arm64/Kconfig | 2 - arch/csky/include/asm/uaccess.h | 6 -- arch/csky/lib/usercopy.c | 102 ------------------ arch/h8300/kernel/h8300_ksyms.c | 2 - arch/h8300/lib/Makefile | 2 +- arch/h8300/lib/strncpy.S | 35 ------ arch/hexagon/include/asm/uaccess.h | 31 ------ arch/hexagon/kernel/hexagon_ksyms.c | 1 - arch/hexagon/mm/Makefile | 2 +- arch/hexagon/mm/strnlen_user.S | 126 ---------------------- arch/ia64/Kconfig | 2 + arch/m68k/Kconfig | 2 - arch/microblaze/include/asm/uaccess.h | 19 +--- arch/microblaze/kernel/microblaze_ksyms.c | 3 - arch/microblaze/lib/uaccess_old.S | 90 ---------------- arch/mips/Kconfig | 2 + arch/nds32/Kconfig | 2 - arch/nios2/Kconfig | 2 - arch/openrisc/Kconfig | 2 - arch/parisc/Kconfig | 2 +- arch/powerpc/Kconfig | 2 - arch/riscv/Kconfig | 2 - arch/s390/Kconfig | 2 + arch/sh/Kconfig | 2 - arch/sparc/Kconfig | 2 - arch/um/Kconfig | 2 + arch/um/include/asm/uaccess.h | 5 +- arch/um/kernel/skas/uaccess.c | 14 ++- arch/x86/Kconfig | 2 - arch/xtensa/Kconfig | 3 +- arch/xtensa/include/asm/uaccess.h | 3 +- include/asm-generic/uaccess.h | 52 ++------- lib/Kconfig | 10 +- 37 files changed, 43 insertions(+), 581 deletions(-) delete mode 100644 arch/h8300/lib/strncpy.S delete mode 100644 arch/hexagon/mm/strnlen_user.S -- 2.29.2 Cc: "James E.J. Bottomley" Cc: Al Viro Cc: Anton Ivanov Cc: Brian Cain Cc: Chris Zankel Cc: Christian Borntraeger Cc: Christoph Hellwig Cc: Guo Ren Cc: Heiko Carstens Cc: Helge Deller Cc: Jeff Dike Cc: Linus Walleij Cc: Max Filippov Cc: Michal Simek Cc: Richard Weinberger Cc: Thomas Bogendoerfer Cc: Vasily Gorbik Cc: Vineet Gupta Cc: Yoshinori Sato Cc: linux-arch@vger.kernel.org Cc: linux-csky@vger.kernel.org Cc: linux-hexagon@vger.kernel.org Cc: linux-ia64@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: linux-mips@vger.kernel.org Cc: linux-parisc@vger.kernel.org Cc: linux-s390@vger.kernel.org Cc: linux-snps-arc@lists.infradead.org Cc: linux-um@lists.infradead.org Cc: linux-xtensa@linux-xtensa.org Cc: uclinux-h8-devel@lists.sourceforge.jp