linux-mips.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [RFC PATCH v2] locking/atomic: arch/mips: Fix atomic{_64,}_sub_if_positive
@ 2021-07-29  9:31 Rui Wang
  2021-08-05  9:16 ` Thomas Bogendoerfer
  0 siblings, 1 reply; 2+ messages in thread
From: Rui Wang @ 2021-07-29  9:31 UTC (permalink / raw)
  To: Thomas Bogendoerfer, Peter Zijlstra
  Cc: Will Deacon, Boqun Feng, linux-kernel, linux-mips, Rui Wang, Rui Wang

This looks like a typo and that caused atomic64 test failed.

Signed-off-by: Rui Wang <wangrui@loongson.cn>
---
 arch/mips/include/asm/atomic.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/include/asm/atomic.h b/arch/mips/include/asm/atomic.h
index 95e1f7f3597f..a0b9e7c1e4fc 100644
--- a/arch/mips/include/asm/atomic.h
+++ b/arch/mips/include/asm/atomic.h
@@ -206,7 +206,7 @@ ATOMIC_OPS(atomic64, xor, s64, ^=, xor, lld, scd)
  * The function returns the old value of @v minus @i.
  */
 #define ATOMIC_SIP_OP(pfx, type, op, ll, sc)				\
-static __inline__ int arch_##pfx##_sub_if_positive(type i, pfx##_t * v)	\
+static __inline__ type arch_##pfx##_sub_if_positive(type i, pfx##_t * v)	\
 {									\
 	type temp, result;						\
 									\
-- 
2.32.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [RFC PATCH v2] locking/atomic: arch/mips: Fix atomic{_64,}_sub_if_positive
  2021-07-29  9:31 [RFC PATCH v2] locking/atomic: arch/mips: Fix atomic{_64,}_sub_if_positive Rui Wang
@ 2021-08-05  9:16 ` Thomas Bogendoerfer
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Bogendoerfer @ 2021-08-05  9:16 UTC (permalink / raw)
  To: Rui Wang
  Cc: Peter Zijlstra, Will Deacon, Boqun Feng, linux-kernel,
	linux-mips, Rui Wang

On Thu, Jul 29, 2021 at 05:31:52PM +0800, Rui Wang wrote:
> This looks like a typo and that caused atomic64 test failed.
> 
> Signed-off-by: Rui Wang <wangrui@loongson.cn>
> ---
>  arch/mips/include/asm/atomic.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

applied to mips-next with slightly edited subject.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-08-05  9:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-29  9:31 [RFC PATCH v2] locking/atomic: arch/mips: Fix atomic{_64,}_sub_if_positive Rui Wang
2021-08-05  9:16 ` Thomas Bogendoerfer

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox