From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 485A9C432BE for ; Thu, 29 Jul 2021 14:33:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3577C60EBB for ; Thu, 29 Jul 2021 14:33:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237424AbhG2Od5 (ORCPT ); Thu, 29 Jul 2021 10:33:57 -0400 Received: from elvis.franken.de ([193.175.24.41]:33299 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237573AbhG2Od4 (ORCPT ); Thu, 29 Jul 2021 10:33:56 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1m976b-0004ov-00; Thu, 29 Jul 2021 16:33:49 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 3E8D5C257B; Thu, 29 Jul 2021 16:33:07 +0200 (CEST) Date: Thu, 29 Jul 2021 16:33:07 +0200 From: Thomas Bogendoerfer To: hev Cc: Rui Wang , Peter Zijlstra , Will Deacon , Boqun Feng , linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org Subject: Re: [RFC PATCH] locking/atomic: arch/mips: Fix atomic{_64,}_sub_if_positive Message-ID: <20210729143307.GA13231@alpha.franken.de> References: <20210729082549.144559-1-wangrui@loongson.cn> <20210729095342.GB8286@alpha.franken.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Thu, Jul 29, 2021 at 08:31:11PM +0800, hev wrote: > Hi, Thomas, > > On Thu, Jul 29, 2021 at 5:53 PM Thomas Bogendoerfer > wrote: > > > > On Thu, Jul 29, 2021 at 04:25:49PM +0800, Rui Wang wrote: > > > This looks like a typo and that caused atomic64 test failed. > > > > > > Signed-off-by: Rui Wang > > > Signed-off-by: hev > > > --- > > > arch/mips/include/asm/atomic.h | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/arch/mips/include/asm/atomic.h b/arch/mips/include/asm/atomic.h > > > index 95e1f7f3597f..a0b9e7c1e4fc 100644 > > > --- a/arch/mips/include/asm/atomic.h > > > +++ b/arch/mips/include/asm/atomic.h > > > @@ -206,7 +206,7 @@ ATOMIC_OPS(atomic64, xor, s64, ^=, xor, lld, scd) > > > * The function returns the old value of @v minus @i. > > > */ > > > #define ATOMIC_SIP_OP(pfx, type, op, ll, sc) \ > > > -static __inline__ int arch_##pfx##_sub_if_positive(type i, pfx##_t * v) \ > > > +static __inline__ type arch_##pfx##_sub_if_positive(type i, pfx##_t * v) \ > > > { \ > > > type temp, result; \ > > > \ > > > > sub_if_postive looks unused to me. Could you send a patch removing it > > instead ? riscv also has a sub_if_positive implementation, which looks > > unused. > I found atomic{_64,}_dec_if_postive is based on sub_if_postive, and > used in many places: > > kernel/kmod.c: if (atomic_dec_if_positive(&kmod_concurrent_max) < 0) { > kernel/kmod.c: > atomic_dec_if_positive(&kmod_concurrent_max) >= 0, > kernel/module.c: ret = atomic_dec_if_positive(&module->refcnt); > ... > drivers/net/ethernet/mellanox/mlx5/core/eswitch.c: > atomic64_dec_if_positive(&esw->user_count); > drivers/net/netdevsim/fib.c: atomic64_dec_if_positive(&entry->num); > drivers/net/netdevsim/fib.c: atomic64_dec_if_positive(&entry->num); > > Are you sure to remove it? in that case, let's keep it. There is a fallback for atomic_dec_if_positive, that's why I didn't notice where it is used. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]