From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Yinbo Zhu <zhuyinbo@loongson.cn>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
WANG Xuerui <kernel@xen0n.name>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Juxin Gao <gaojuxin@loongson.cn>, Bibo Mao <maobibo@loongson.cn>,
Yanteng Si <siyanteng@loongson.cn>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, loongarch@lists.linux.dev,
linux-mips@vger.kernel.org, Arnaud Patard <apatard@mandriva.com>,
Huacai Chen <chenhuacai@kernel.org>,
lvjianmin <lvjianmin@loongson.cn>,
zhanghongchen <zhanghongchen@loongson.cn>,
Liu Peibao <liupeibao@loongson.cn>
Subject: Re: [PATCH v2 1/2] gpio: loongson: add dts/acpi gpio support
Date: Tue, 15 Nov 2022 11:20:50 +0100 [thread overview]
Message-ID: <20221115102050.GA3167@alpha.franken.de> (raw)
In-Reply-To: <8b24e3df-8c22-bd09-cfc1-b27e39a05c25@loongson.cn>
On Tue, Nov 15, 2022 at 05:53:26PM +0800, Yinbo Zhu wrote:
> > > +/* ============== Data structrues =============== */
> > > +
> > > +/* gpio data */
> > > +struct platform_gpio_data {
> > > + u32 gpio_conf;
> > > + u32 gpio_out;
> > > + u32 gpio_in;
> > > + u32 support_irq;
> > > + char *label;
> > > + int gpio_base;
> > > + int ngpio;
> > > +};
> >
> > No idea why you would need to duplicate it like this either. And why
> > put it in arch/.
> because loongson platform include mips and loongarch, and the gpio device
> data was defined in arch/ in leagcy loongson gpio driver. so the
> latest loongson gpio drvier add platform_gpio_data in same dir.
put the struct into a new file in include/linux/platform_data and
use that.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
next prev parent reply other threads:[~2022-11-15 10:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-14 9:53 [PATCH v2 1/2] gpio: loongson: add dts/acpi gpio support Yinbo Zhu
2022-11-14 9:53 ` [PATCH v2 2/2] dt-bindings: gpio: add loongson series gpio Yinbo Zhu
2022-11-18 12:40 ` Krzysztof Kozlowski
2022-11-15 9:05 ` [PATCH v2 1/2] gpio: loongson: add dts/acpi gpio support Bartosz Golaszewski
2022-11-15 9:53 ` Yinbo Zhu
2022-11-15 10:17 ` WANG Xuerui
2022-11-15 13:07 ` Yinbo Zhu
2022-11-15 13:35 ` Bartosz Golaszewski
2022-11-16 3:31 ` Yinbo Zhu
2022-11-15 10:20 ` Thomas Bogendoerfer [this message]
2022-11-16 3:34 ` Yinbo Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221115102050.GA3167@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=apatard@mandriva.com \
--cc=brgl@bgdev.pl \
--cc=chenhuacai@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gaojuxin@loongson.cn \
--cc=jiaxun.yang@flygoat.com \
--cc=kernel@xen0n.name \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=liupeibao@loongson.cn \
--cc=loongarch@lists.linux.dev \
--cc=lvjianmin@loongson.cn \
--cc=maobibo@loongson.cn \
--cc=robh+dt@kernel.org \
--cc=siyanteng@loongson.cn \
--cc=zhanghongchen@loongson.cn \
--cc=zhuyinbo@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).