From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7E59C47089 for ; Mon, 28 Nov 2022 14:42:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231728AbiK1Ol6 (ORCPT ); Mon, 28 Nov 2022 09:41:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232608AbiK1Olp (ORCPT ); Mon, 28 Nov 2022 09:41:45 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2ABEA205F0 for ; Mon, 28 Nov 2022 06:41:44 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ozfKF-0006du-3k; Mon, 28 Nov 2022 15:41:39 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1ozfKD-000qTJ-LY; Mon, 28 Nov 2022 15:41:38 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1ozfKD-000xkl-Bb; Mon, 28 Nov 2022 15:41:37 +0100 Date: Mon, 28 Nov 2022 15:41:37 +0100 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Paul Cercueil Cc: Thierry Reding , od@opendingux.net, linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org Subject: Re: [PATCH 3/5] pwm: jz4740: Force dependency on Device Tree Message-ID: <20221128144137.aavwwb3oxz5hw4ae@pengutronix.de> References: <20221024205213.327001-1-paul@crapouillou.net> <20221024205213.327001-4-paul@crapouillou.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="mgihohoq2ffxir4a" Content-Disposition: inline In-Reply-To: <20221024205213.327001-4-paul@crapouillou.net> X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mips@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org --mgihohoq2ffxir4a Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 24, 2022 at 09:52:11PM +0100, Paul Cercueil wrote: > Ingenic SoCs all require CONFIG_OF, so there is no case where we want to > use this driver without CONFIG_OF. >=20 > Signed-off-by: Paul Cercueil > --- > drivers/pwm/Kconfig | 2 +- > drivers/pwm/pwm-jz4740.c | 10 ++++------ > 2 files changed, 5 insertions(+), 7 deletions(-) >=20 > diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig > index 60d13a949bc5..1fe420a45f91 100644 > --- a/drivers/pwm/Kconfig > +++ b/drivers/pwm/Kconfig > @@ -283,7 +283,7 @@ config PWM_IQS620A > config PWM_JZ4740 > tristate "Ingenic JZ47xx PWM support" > depends on MIPS || COMPILE_TEST > - depends on COMMON_CLK > + depends on COMMON_CLK && OF I think you don't even need to enforce OF here. For the compile-test case having OF=3Dn should work fine. Anyhow: Acked-by: Uwe Kleine-K=F6nig Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --mgihohoq2ffxir4a Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmOEyJ4ACgkQwfwUeK3K 7AlxPwf9Gz4JXf2XTZRSbBnXuGgyQt+OyfBEMbRTI/dWN6wERc/buzwXNno15Ue+ wxpdN6FcKgZaAyxJHVm+lLQkzGiVoU79BgZKiwtUjl9k4iPNqzhnd55k3e65JEy9 NMDRIzIEjmfJ1A9mTYRcnRMT5EnQvg/UCIAqBRENb6tskL5Bk8YdC2jQld1B7Se4 DZ1hBSK5Jg5ij7vjDH2Z8mCuMfejS98pTfr9yfMwQKrezKx1JONK/D727v+wBNWW fdYFdHyOShfcVQNiBiDyGoYDP0aAZmTBlMMwDZEsgH8ELX39QIqdjNONBTJ6Sv+H lt/skHCvuJW8lZnqYW9wLtjkt1id8w== =j7d3 -----END PGP SIGNATURE----- --mgihohoq2ffxir4a--