From: "H. Nikolaus Schaller" <hns@goldelico.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: "Paul Cercueil" <paul@crapouillou.net>,
"Paul Boddie" <paul@boddie.org.uk>,
"Alex Smith" <alex.smith@imgtec.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Ralf Baechle" <ralf@linux-mips.org>,
"Paul Burton" <paulburton@kernel.org>,
"James Hogan" <jhogan@kernel.org>,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>,
"David S. Miller" <davem@davemloft.net>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Andi Kleen" <ak@linux.intel.com>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
"Petr Štetiar" <ynezz@true.cz>,
"Richard Fontana" <rfontana@redhat.com>,
"Allison Randal" <allison@lohutok.net>,
"Stephen Boyd" <swboyd@chromium.org>,
devicetree@vger.kernel.org, linux-mips@vger.kernel.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-i2c@vger.kernel.org, netdev@vger.kernel.org,
linux-gpio@vger.kernel.org, letux-kernel@openphoenux.org,
kernel@pyra-handheld.com
Subject: Re: i2c: jz4780: silence log flood on txabrt
Date: Wed, 12 Feb 2020 15:46:19 +0100 [thread overview]
Message-ID: <213C52CC-E5DC-4641-BE68-3D5C4FEA1FB5@goldelico.com> (raw)
In-Reply-To: <20200212094628.GB1143@ninjato>
Hi,
> Am 12.02.2020 um 10:46 schrieb Wolfram Sang <wsa@the-dreams.de>:
>
>
> The printout for txabrt is way too talkative. Reduce it to the minimum,
> the rest can be gained by I2C core debugging and datasheet information.
> Also, make it a debug printout, it won't help the regular user.
>
> Reported-by: H. Nikolaus Schaller <hns@goldelico.com>
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> ---
>
> Sorry, normally I don't do counter patches. Yet, this time I realized
> that it would be faster to actually do what I envisioned than to
> describe it in words. I hope you don't feel offended.
No problem. I had thought a little about that myself, but did not
dare to solve more than my problem...
> This driver has
> way too many dev_err anyhow, so this may be a start.
>
> Obviously, I can't test, does it work for you?
Yes,it works.
Do you want to push your patch yourself, or should I add it to my
patch series and resubmit in a v2?
BR and thanks,
Nikolaus
>
> drivers/i2c/busses/i2c-jz4780.c | 36 ++-------------------------------
> 1 file changed, 2 insertions(+), 34 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-jz4780.c b/drivers/i2c/busses/i2c-jz4780.c
> index 16a67a64284a..b426fc956938 100644
> --- a/drivers/i2c/busses/i2c-jz4780.c
> +++ b/drivers/i2c/busses/i2c-jz4780.c
> @@ -78,25 +78,6 @@
>
> #define X1000_I2C_DC_STOP BIT(9)
>
> -static const char * const jz4780_i2c_abrt_src[] = {
> - "ABRT_7B_ADDR_NOACK",
> - "ABRT_10ADDR1_NOACK",
> - "ABRT_10ADDR2_NOACK",
> - "ABRT_XDATA_NOACK",
> - "ABRT_GCALL_NOACK",
> - "ABRT_GCALL_READ",
> - "ABRT_HS_ACKD",
> - "SBYTE_ACKDET",
> - "ABRT_HS_NORSTRT",
> - "SBYTE_NORSTRT",
> - "ABRT_10B_RD_NORSTRT",
> - "ABRT_MASTER_DIS",
> - "ARB_LOST",
> - "SLVFLUSH_TXFIFO",
> - "SLV_ARBLOST",
> - "SLVRD_INTX",
> -};
> -
> #define JZ4780_I2C_INTST_IGC BIT(11)
> #define JZ4780_I2C_INTST_ISTT BIT(10)
> #define JZ4780_I2C_INTST_ISTP BIT(9)
> @@ -576,21 +557,8 @@ static irqreturn_t jz4780_i2c_irq(int irqno, void *dev_id)
>
> static void jz4780_i2c_txabrt(struct jz4780_i2c *i2c, int src)
> {
> - int i;
> -
> - dev_err(&i2c->adap.dev, "txabrt: 0x%08x\n", src);
> - dev_err(&i2c->adap.dev, "device addr=%x\n",
> - jz4780_i2c_readw(i2c, JZ4780_I2C_TAR));
> - dev_err(&i2c->adap.dev, "send cmd count:%d %d\n",
> - i2c->cmd, i2c->cmd_buf[i2c->cmd]);
> - dev_err(&i2c->adap.dev, "receive data count:%d %d\n",
> - i2c->cmd, i2c->data_buf[i2c->cmd]);
> -
> - for (i = 0; i < 16; i++) {
> - if (src & BIT(i))
> - dev_dbg(&i2c->adap.dev, "I2C TXABRT[%d]=%s\n",
> - i, jz4780_i2c_abrt_src[i]);
> - }
> + dev_dbg(&i2c->adap.dev, "txabrt: 0x%08x, cmd: %d, send: %d, recv: %d\n",
> + src, i2c->cmd, i2c->cmd_buf[i2c->cmd], i2c->data_buf[i2c->cmd]);
> }
>
> static inline int jz4780_i2c_xfer_read(struct jz4780_i2c *i2c,
> --
> 2.20.1
>
next prev parent reply other threads:[~2020-02-12 14:46 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 21:41 [PATCH 00/14] MIPS: Fixes and improvements for CI20 board (JZ4780) H. Nikolaus Schaller
2020-02-11 21:41 ` [PATCH 01/14] i2c: jz4780: suppress txabrt reports for i2cdetect H. Nikolaus Schaller
2020-02-12 9:46 ` i2c: jz4780: silence log flood on txabrt Wolfram Sang
2020-02-12 14:46 ` H. Nikolaus Schaller [this message]
2020-02-12 14:53 ` Wolfram Sang
2020-02-12 14:59 ` H. Nikolaus Schaller
2020-02-13 9:10 ` Wolfram Sang
2020-02-11 21:41 ` [PATCH 02/14] drm: ingenic-drm: add MODULE_DEVICE_TABLE H. Nikolaus Schaller
2020-02-11 21:41 ` [PATCH 03/14] net: davicom: dm9000: allow to pass MAC address through mac_addr module parameter H. Nikolaus Schaller
2020-02-11 22:25 ` Andrew Lunn
2020-02-12 8:07 ` Geert Uytterhoeven
2020-02-12 8:13 ` H. Nikolaus Schaller
2020-02-11 21:41 ` [PATCH 04/14] MIPS: DTS: jz4780: fix #includes for irq.h and gpio.h H. Nikolaus Schaller
2020-02-11 21:41 ` [PATCH 05/14] MIPS: CI20: defconfig: configure for supporting modules H. Nikolaus Schaller
2020-02-11 21:41 ` [PATCH 06/14] MIPS: CI20: defconfig: compile leds-gpio driver into the kernel and configure for LED triggers H. Nikolaus Schaller
2020-02-11 21:41 ` [PATCH 07/14] MIPS: DTS: CI20: fix PMU definitions for ACT8600 H. Nikolaus Schaller
2020-02-11 21:48 ` [Letux-kernel] " Andreas Kemnade
2020-02-11 21:41 ` [PATCH 08/14] MIPS: CI20: defconfig: configure CONFIG_REGULATOR_ACT8865 for PMU H. Nikolaus Schaller
2020-02-11 21:41 ` [PATCH 09/14] MIPS: DTS: CI20: give eth0_power a defined voltage H. Nikolaus Schaller
2020-02-11 21:41 ` [PATCH 10/14] MIPS: DTS: CI20: add DT node for IR sensor H. Nikolaus Schaller
2020-02-11 21:41 ` [PATCH 11/14] MIPS: CI20: defconfig: compile gpio-ir driver H. Nikolaus Schaller
2020-02-11 21:41 ` [PATCH 12/14] MIPS: DTS: CI20: add DT node for SW1 as Enter button H. Nikolaus Schaller
2020-02-11 21:41 ` [PATCH 13/14] MIPS: CI20: defconfig: configure for CONFIG_KEYBOARD_GPIO=m H. Nikolaus Schaller
2020-02-11 21:41 ` [PATCH 14/14] MIPS: DTS: CI20: fix interrupt for pcf8563 RTC H. Nikolaus Schaller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=213C52CC-E5DC-4641-BE68-3D5C4FEA1FB5@goldelico.com \
--to=hns@goldelico.com \
--cc=airlied@linux.ie \
--cc=ak@linux.intel.com \
--cc=alex.smith@imgtec.com \
--cc=allison@lohutok.net \
--cc=daniel@ffwll.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert+renesas@glider.be \
--cc=jhogan@kernel.org \
--cc=kernel@pyra-handheld.com \
--cc=krzk@kernel.org \
--cc=letux-kernel@openphoenux.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=miquel.raynal@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=paul@boddie.org.uk \
--cc=paul@crapouillou.net \
--cc=paulburton@kernel.org \
--cc=ralf@linux-mips.org \
--cc=rfontana@redhat.com \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
--cc=wsa@the-dreams.de \
--cc=ynezz@true.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).